Recent::show() - Code Metrics - Inspection of "[WIP] refactor html_* functions into Ui class memb..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#3198)

unknown

created 2020-07-11 00:44 UTC

Recent::show() F

↳ Parent: Recent

Complexity

Conditions	27
Paths	> 20000

Size

Total Lines

223

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	27
nc	276864
nop	2
dl	0
loc	223
rs	0
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace dokuwiki\Ui;

use dokuwiki\ChangeLog\MediaChangeLog;
use dokuwiki\Extension\Event;
use dokuwiki\Form\Form;

/**
 * DokuWiki Recent Insterface
 *
 * @package dokuwiki\Ui
 */
class Recent extends Ui
{
    /**
     * Display recent changes
     *
     * @author Andreas Gohr <[email protected]>
     * @author Matthias Grimm <[email protected]>
     * @author Ben Coburn <[email protected]>
     * @author Kate Arzamastseva <[email protected]>
     *
     * @triggers HTML_RECENTFORM_OUTPUT
     * @param int $first skip the first n changelog lines
     * @param string $show_changes
     * @return void
     */
    public function show($first = 0, $show_changes = 'both')
    {
        global $conf;
        global $lang;
        global $ID;

        /* we need to get one additionally log entry to be able to
         * decide if this is the last page or is there another one.
         * This is the cheapest solution to get this information.
         */
        $flags = 0;
        if ($show_changes == 'mediafiles' && $conf['mediarevisions']) {
            $flags = RECENTS_MEDIA_CHANGES;
        } elseif ($show_changes == 'pages') {
            $flags = 0;
        } elseif ($conf['mediarevisions']) {
            $show_changes = 'both';
            $flags = RECENTS_MEDIA_PAGES_MIXED;
        }

        $recents = getRecents($first, $conf['recent'] + 1, getNS($ID), $flags);

        if (count($recents) == 0 && $first != 0) {
            $first = 0;
            $recents = getRecents($first, $conf['recent'] + 1, getNS($ID), $flags);

        }

        $hasNext = false;
        if (count($recents) > $conf['recent']) {
            $hasNext = true;
            array_pop($recents); // remove extra log entry
        }

        // print intro
        print p_locale_xhtml('recent');

        if (getNS($ID) != '') {
            print '<div class="level1"><p>'
                . sprintf($lang['recent_global'], getNS($ID), wl('', 'do=recent'))
                .'</p></div>';
        }

        // create the form
        $form = new Form(['id' => 'dw__recent', 'method' => 'GET', 'action'=>wl($ID)]);
        $form->addClass('changes');
        $form->addTagOpen('div')->addClass('no');
        $form->setHiddenField('sectok', null);
        $form->setHiddenField('do', 'recent');
        $form->setHiddenField('id', $ID);

        // show dropdown selector, whether include not only recent pages but also recent media files?
        if ($conf['mediarevisions']) {
            $form->addTagOpen('div')->addClass('changeType');
            $options = array(
                            'pages'      => $lang['pages_changes'],
                            'mediafiles' => $lang['media_changes'],
                            'both'       => $lang['both_changes'],
            );
            $form->addDropdown('show_changes', $options, $lang['changes_type'])
                ->val($show_changes)->addClass('quickselect');
            $form->addButton('do[recent]', $lang['btn_apply'])->attr('type','submit');
            $form->addTagClose('div');
        }

        // start listing
        $form->addTagOpen('ul');

        foreach ($recents as $recent) {
            $date = dformat($recent['date']);
            $class = ($recent['type'] === DOKU_CHANGE_TYPE_MINOR_EDIT) ? 'minor': '';

            $form->addTagOpen('li')->addClass($class);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $form->addTagOpen('div')->addClass('li');

            if (!empty($recent['media'])) {
                $form->addHTML(media_printicon($recent['id']));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            } else {
                $form->addTag('img')->attrs([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                        'src' => DOKU_BASE .'lib/images/fileicons/file.png',
                        'alt' => $recent['id']
                ])->addClass('icon');
            }

            $form->addTagOpen('span')->addClass('date');
            $form->addHTML($date);
            $form->addTagClose('span');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

            $diff = false;
            $href = '';

            if (!empty($recent['media'])) {
                $changelog = new MediaChangeLog($recent['id']);
                $revs = $changelog->getRevisions(0, 1);
                $diff = (count($revs) && file_exists(mediaFN($recent['id'])));
                if ($diff) {
                    $href = media_managerURL(
                        array(
                            'tab_details' => 'history',
                            'mediado' => 'diff',
                            'image' => $recent['id'],
                            'ns' => getNS($recent['id'])
                        ), '&'
                    );
                }
            } else {
                $href = wl($recent['id'], "do=diff", false, '&');
            }

            if (!empty($recent['media']) && !$diff) {
                $form->addTag('img')->attrs([
                        'src'    => DOKU_BASE .'lib/images/blank.gif',
                        'width'  => 15,
                        'height' => 11,
                        'alt' => '',
                ]);
            } else {
                $form->addTagOpen('a')->attr('href', $href)->addClass('diff_link');
                $form->addTag('img')->attrs([
                        'src'    => DOKU_BASE .'lib/images/diff.png',
                        'width'  => 15,
                        'height' => 11,
                        'title'  => $lang['diff'],
                        'alt'    => $lang['diff'],
                ]);
                $form->addTagClose('a');
            }

            if (!empty($recent['media'])) {
                $href = media_managerURL(
                    array(
                        'tab_details' => 'history',
                        'image' => $recent['id'],
                        'ns' => getNS($recent['id'])
                    ), '&'
                );
            } else {
                $href = wl($recent['id'], "do=revisions", false, '&');
            }
            $form->addTagOpen('a')->attr('href', $href)->addClass('revisions_link');
            $form->addTag('img')->attrs([
                    'src'    => DOKU_BASE .'lib/images/history.png',
                    'width'  => 12,
                    'height' => 14,
                    'title'  => $lang['btn_revs'],
                    'alt'    => $lang['btn_revs']
            ]);
            $form->addTagClose('a');

            if (!empty($recent['media'])) {
                $href = media_managerURL(
                    array(
                        'tab_details' => 'view',
                        'image' => $recent['id'],
                        'ns' => getNS($recent['id'])
                    ), '&'
                );
                $class = file_exists(mediaFN($recent['id'])) ? 'wikilink1' : 'wikilink2';
                $form->addTagOpen('a')->attr('href', $href)->addClass($class);
                $form->addHTML($recent['id']);
                $form->addTagClose('a');
            } else {
                $form->addHTML(html_wikilink(':'. $recent['id'], useHeading('navigation') ? null : $recent['id']));
            }
            $form->addTagOpen('span')->addClass('sum');
            $form->addHTML(' – '. hsc($recent['sum']));
            $form->addTagClose('span');

            $form->addTagOPen('span')->addClass('user');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            if ($recent['user']) {
                $form->addHTML('<bdi>'. editorinfo($recent['user']) .'</bdi>');
                if (auth_ismanager()) {
                    $form->addHTML(' <bdo dir="ltr">('. $recent['ip'] .')</bdo>');
                }
            } else {
                $form->addHTML('<bdo dir="ltr">'. $recent['ip'] .'</bdo>');
            }
            $form->addTagClose('span');

            html_sizechange($recent['sizechange'], $form);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            $form->addTagClose('div');

            $form->addTagClose('li');

        }

        $form->addTagClose('ul');

        // provide navigation for pagenated cecent list (of pages and/or media files)
        $form->addTagOpen('div')->addClass('pagenav');
        $last = $first + $conf['recent'];
        if ($first > 0) {
            $first = $conf['recent'] -1;
            if ($first < 0) $first = 0;
            $form->addTagOpen('div')->addClass('pagenav-prev');
            $form->addTagOpen('button')->attrs([
                    'type'      => 'submit',
                    'name'      => 'first['. $first .']',
                    'accesskey' => 'n',
                    'title'     => $lang['btn_newer'] .' [N]',
            ])->addClass('button show');
            $form->addHTML($lang['btn_newer']);
            $form->addTagClose('button');
            $form->addTagClose('div');
        }
        if ($hasNext) {
            $form->addTagOpen('div')->addClass('pagenav-next');
            $form->addTagOpen('button')->attrs([
                    'type'      => 'submit',
                    'name'      => 'first['. $last .']',
                    'accesskey' => 'p',
                    'title'     => $lang['btn_older'] .' [P]',
            ])->addClass('button show');
            $form->addHTML($lang['btn_older']);
            $form->addTagClose('button');
            $form->addTagClose('div');
        }
        $form->addTagClose('div');

        $form->addTagClose('div'); // close div class=no

        // emit HTML_CRECENTFORM_OUTPUT event, print the form
        Event::createAndTrigger('HTML_RECENTFORM_OUTPUT', $form, 'html_form_output', false);

        print DOKU_LF;
    }

}


Pull Request — master (#3198)

Recent::show() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace dokuwiki\Ui;
4
5			use dokuwiki\ChangeLog\MediaChangeLog;
6			use dokuwiki\Extension\Event;
7			use dokuwiki\Form\Form;
8
9			/**
10			* DokuWiki Recent Insterface
11			*
12			* @package dokuwiki\Ui
13			*/
14			class Recent extends Ui
15			{
16			/**
17			* Display recent changes
18			*
19			* @author Andreas Gohr <[email protected]>
20			* @author Matthias Grimm <[email protected]>
21			* @author Ben Coburn <[email protected]>
22			* @author Kate Arzamastseva <[email protected]>
23			*
24			* @triggers HTML_RECENTFORM_OUTPUT
25			* @param int $first skip the first n changelog lines
26			* @param string $show_changes
27			* @return void
28			*/
29			public function show($first = 0, $show_changes = 'both')
30			{
31			global $conf;
32			global $lang;
33			global $ID;
34
35			/* we need to get one additionally log entry to be able to
36			* decide if this is the last page or is there another one.
37			* This is the cheapest solution to get this information.
38			*/
39			$flags = 0;
40			if ($show_changes == 'mediafiles' && $conf['mediarevisions']) {
41			$flags = RECENTS_MEDIA_CHANGES;
42			} elseif ($show_changes == 'pages') {
43			$flags = 0;
44			} elseif ($conf['mediarevisions']) {
45			$show_changes = 'both';
46			$flags = RECENTS_MEDIA_PAGES_MIXED;
47			}
48
49			$recents = getRecents($first, $conf['recent'] + 1, getNS($ID), $flags);
			0 ignored issues – show Security Bug introduced 2016-01-22 20:26 UTC by Report Bug Copy Issue Report It seems like `getNS($ID)` targeting `getNS()` can also be of type `false`; however, `getRecents()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
50			if (count($recents) == 0 && $first != 0) {
51			$first = 0;
52			$recents = getRecents($first, $conf['recent'] + 1, getNS($ID), $flags);
			0 ignored issues – show Security Bug introduced 2016-01-22 20:26 UTC by Report Bug Copy Issue Report It seems like `getNS($ID)` targeting `getNS()` can also be of type `false`; however, `getRecents()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
53			}
54
55			$hasNext = false;
56			if (count($recents) > $conf['recent']) {
57			$hasNext = true;
58			array_pop($recents); // remove extra log entry
59			}
60
61			// print intro
62			print p_locale_xhtml('recent');
63
64			if (getNS($ID) != '') {
65			print '<div class="level1"><p>'
66			. sprintf($lang['recent_global'], getNS($ID), wl('', 'do=recent'))
67			.'</p></div>';
68			}
69
70			// create the form
71			$form = new Form(['id' => 'dw__recent', 'method' => 'GET', 'action'=>wl($ID)]);
72			$form->addClass('changes');
73			$form->addTagOpen('div')->addClass('no');
74			$form->setHiddenField('sectok', null);
75			$form->setHiddenField('do', 'recent');
76			$form->setHiddenField('id', $ID);
77
78			// show dropdown selector, whether include not only recent pages but also recent media files?
79			if ($conf['mediarevisions']) {
80			$form->addTagOpen('div')->addClass('changeType');
81			$options = array(
82			'pages' => $lang['pages_changes'],
83			'mediafiles' => $lang['media_changes'],
84			'both' => $lang['both_changes'],
85			);
86			$form->addDropdown('show_changes', $options, $lang['changes_type'])
87			->val($show_changes)->addClass('quickselect');
88			$form->addButton('do[recent]', $lang['btn_apply'])->attr('type','submit');
89			$form->addTagClose('div');
90			}
91
92			// start listing
93			$form->addTagOpen('ul');
94
95			foreach ($recents as $recent) {
96			$date = dformat($recent['date']);
97			$class = ($recent['type'] === DOKU_CHANGE_TYPE_MINOR_EDIT) ? 'minor': '';
98
99			$form->addTagOpen('li')->addClass($class);
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report The method `addTagOpen` does only exist in `dokuwiki\Form\Form`, but not in `Doku_Form`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
100			$form->addTagOpen('div')->addClass('li');
101
102			if (!empty($recent['media'])) {
103			$form->addHTML(media_printicon($recent['id']));
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report The method `addHTML` does only exist in `dokuwiki\Form\Form`, but not in `Doku_Form`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
104			} else {
105			$form->addTag('img')->attrs([
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report The method `addTag` does only exist in `dokuwiki\Form\Form`, but not in `Doku_Form`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
106			'src' => DOKU_BASE .'lib/images/fileicons/file.png',
107			'alt' => $recent['id']
108			])->addClass('icon');
109			}
110
111			$form->addTagOpen('span')->addClass('date');
112			$form->addHTML($date);
113			$form->addTagClose('span');
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report The method `addTagClose` does only exist in `dokuwiki\Form\Form`, but not in `Doku_Form`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
114
115			$diff = false;
116			$href = '';
117
118			if (!empty($recent['media'])) {
119			$changelog = new MediaChangeLog($recent['id']);
120			$revs = $changelog->getRevisions(0, 1);
121			$diff = (count($revs) && file_exists(mediaFN($recent['id'])));
122			if ($diff) {
123			$href = media_managerURL(
124			array(
125			'tab_details' => 'history',
126			'mediado' => 'diff',
127			'image' => $recent['id'],
128			'ns' => getNS($recent['id'])
129			), '&'
130			);
131			}
132			} else {
133			$href = wl($recent['id'], "do=diff", false, '&');
134			}
135
136			if (!empty($recent['media']) && !$diff) {
137			$form->addTag('img')->attrs([
138			'src' => DOKU_BASE .'lib/images/blank.gif',
139			'width' => 15,
140			'height' => 11,
141			'alt' => '',
142			]);
143			} else {
144			$form->addTagOpen('a')->attr('href', $href)->addClass('diff_link');
145			$form->addTag('img')->attrs([
146			'src' => DOKU_BASE .'lib/images/diff.png',
147			'width' => 15,
148			'height' => 11,
149			'title' => $lang['diff'],
150			'alt' => $lang['diff'],
151			]);
152			$form->addTagClose('a');
153			}
154
155			if (!empty($recent['media'])) {
156			$href = media_managerURL(
157			array(
158			'tab_details' => 'history',
159			'image' => $recent['id'],
160			'ns' => getNS($recent['id'])
161			), '&'
162			);
163			} else {
164			$href = wl($recent['id'], "do=revisions", false, '&');
165			}
166			$form->addTagOpen('a')->attr('href', $href)->addClass('revisions_link');
167			$form->addTag('img')->attrs([
168			'src' => DOKU_BASE .'lib/images/history.png',
169			'width' => 12,
170			'height' => 14,
171			'title' => $lang['btn_revs'],
172			'alt' => $lang['btn_revs']
173			]);
174			$form->addTagClose('a');
175
176			if (!empty($recent['media'])) {
177			$href = media_managerURL(
178			array(
179			'tab_details' => 'view',
180			'image' => $recent['id'],
181			'ns' => getNS($recent['id'])
182			), '&'
183			);
184			$class = file_exists(mediaFN($recent['id'])) ? 'wikilink1' : 'wikilink2';
185			$form->addTagOpen('a')->attr('href', $href)->addClass($class);
186			$form->addHTML($recent['id']);
187			$form->addTagClose('a');
188			} else {
189			$form->addHTML(html_wikilink(':'. $recent['id'], useHeading('navigation') ? null : $recent['id']));
190			}
191			$form->addTagOpen('span')->addClass('sum');
192			$form->addHTML(' – '. hsc($recent['sum']));
193			$form->addTagClose('span');
194
195			$form->addTagOPen('span')->addClass('user');
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report The method `addTagOPen` does only exist in `dokuwiki\Form\Form`, but not in `Doku_Form`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
196			if ($recent['user']) {
197			$form->addHTML('<bdi>'. editorinfo($recent['user']) .'</bdi>');
198			if (auth_ismanager()) {
199			$form->addHTML(' <bdo dir="ltr">('. $recent['ip'] .')</bdo>');
200			}
201			} else {
202			$form->addHTML('<bdo dir="ltr">'. $recent['ip'] .'</bdo>');
203			}
204			$form->addTagClose('span');
205
206			html_sizechange($recent['sizechange'], $form);
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report It seems like `$form` defined by `new \dokuwiki\Form\Form(..., 'action' => wl($ID)))` on line `71` can also be of type `object<dokuwiki\Form\Form>`; however, `html_sizechange()` does only seem to accept `object<Form>\|object<Doku_Form>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
207
208			$form->addTagClose('div');
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report The method `addTagClose()` does not seem to exist on `object<Doku_Form>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
209			$form->addTagClose('li');
			0 ignored issues – show Bug introduced 2020-07-11 00:47 UTC by Report Bug Copy Issue Report The method `addTagClose()` does not seem to exist on `object<Doku_Form>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
210			}
211
212			$form->addTagClose('ul');
213
214			// provide navigation for pagenated cecent list (of pages and/or media files)
215			$form->addTagOpen('div')->addClass('pagenav');
216			$last = $first + $conf['recent'];
217			if ($first > 0) {
218			$first = $conf['recent'] -1;
219			if ($first < 0) $first = 0;
220			$form->addTagOpen('div')->addClass('pagenav-prev');
221			$form->addTagOpen('button')->attrs([
222			'type' => 'submit',
223			'name' => 'first['. $first .']',
224			'accesskey' => 'n',
225			'title' => $lang['btn_newer'] .' [N]',
226			])->addClass('button show');
227			$form->addHTML($lang['btn_newer']);
228			$form->addTagClose('button');
229			$form->addTagClose('div');
230			}
231			if ($hasNext) {
232			$form->addTagOpen('div')->addClass('pagenav-next');
233			$form->addTagOpen('button')->attrs([
234			'type' => 'submit',
235			'name' => 'first['. $last .']',
236			'accesskey' => 'p',
237			'title' => $lang['btn_older'] .' [P]',
238			])->addClass('button show');
239			$form->addHTML($lang['btn_older']);
240			$form->addTagClose('button');
241			$form->addTagClose('div');
242			}
243			$form->addTagClose('div');
244
245			$form->addTagClose('div'); // close div class=no
246
247			// emit HTML_CRECENTFORM_OUTPUT event, print the form
248			Event::createAndTrigger('HTML_RECENTFORM_OUTPUT', $form, 'html_form_output', false);
249
250			print DOKU_LF;
251			}
252
253			}
254

splitbrain / dokuwiki

Pull Request — master (#3198)

Recent::show() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like