$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.
Let’s take a look at an example:
foreach($collectionas$item){$myArray['foo']=$item->getFoo();if($item->hasBar()){$myArray['bar']=$item->getBar();}// do something with $myArray}
As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.
This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray=array() either outside or inside the foreach loop.
Loading history...
84
$data['hasAccess'] = false;
85
86
$event = new Doku_Event('ADMINPLUGIN_ACCESS_CHECK', $data);
87
if($event->advise_before()) {
88
if ($this->forAdminOnly()) {
89
$data['hasAccess'] = $INFO['isadmin'];
90
} else {
91
$data['hasAccess'] = $INFO['ismanager'];
92
}
93
}
94
$event->advise_after();
95
96
return $data['hasAccess'];
97
}
98
99
/**
100
* Return true for access only by admins (config:superuser) or false if managers are allowed as well
101
*
102
* @return bool
103
*/
104
public function forAdminOnly() {
105
return true;
106
}
107
108
/**
109
* Return array with ToC items. Items can be created with the html_mktocitem()
splitbrain /
dokuwiki
Andreas Gohr
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.