FeedParser

Complexity

Total Complexity

2

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	feed_url()	0	3	1
A	__construct()	0	5	1

<?php
/**
 * Class used to parse RSS and ATOM feeds
 *
 * @author Andreas Gohr <andi@splitbrain.org>
 */

if(!defined('DOKU_INC')) die('meh.');

/**
 * We override some methods of the original SimplePie class here
 */
class FeedParser extends SimplePie {

    /**
     * Constructor. Set some defaults
     */
    function __construct(){

It is generally recommended to explicitly declare the visibility for methods.

        parent::__construct();
        $this->enable_cache(false);
        $this->set_file_class('FeedParser_File');
    }

    /**
     * Backward compatibility for older plugins
     */
    function feed_url($url){

It is generally recommended to explicitly declare the visibility for methods.

        $this->set_feed_url($url);
    }
}

/**
 * Fetch an URL using our own HTTPClient
 *
 * Replaces SimplePie's own class
 */
class FeedParser_File extends SimplePie_File {
    var $http;
    var $useragent;
    var $success = true;
    var $headers = array();
    var $body;
    var $error;

    /**
     * Inititializes the HTTPClient
     *
     * We ignore all given parameters - they are set in DokuHTTPClient
     */
    function __construct($url, $timeout=10, $redirects=5,

It is generally recommended to explicitly declare the visibility for methods.

                         $headers=null, $useragent=null, $force_fsockopen=false) {
        $this->http    = new DokuHTTPClient();
        $this->success = $this->http->sendRequest($url);

        $this->headers = $this->http->resp_headers;

The property resp_headers cannot be accessed from this context as it is declared private in class HTTPClient.

        $this->body    = $this->http->resp_body;

The property resp_body cannot be accessed from this context as it is declared private in class HTTPClient.

        $this->error   = $this->http->error;

The property error cannot be accessed from this context as it is declared private in class HTTPClient.

        $this->method  = SIMPLEPIE_FILE_SOURCE_REMOTE | SIMPLEPIE_FILE_SOURCE_FSOCKOPEN;

        return $this->success;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    function headers(){

It is generally recommended to explicitly declare the visibility for methods.

        return $this->headers;
    }

    function body(){

It is generally recommended to explicitly declare the visibility for methods.

        return $this->body;
    }

    function close(){

It is generally recommended to explicitly declare the visibility for methods.

        return true;
    }

}