splitbrain /
dokuwiki
| Conditions | 12 |
| Paths | 12 |
| Total Lines | 54 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 21 | public function process() |
||
| 22 | { |
||
| 23 | |||
| 24 | $quoteDepth = 1; |
||
| 25 | |||
| 26 | foreach ($this->calls as $call) { |
||
| 27 | switch ($call[0]) { |
||
| 28 | |||
| 29 | /** @noinspection PhpMissingBreakStatementInspection */ |
||
| 30 | case 'quote_start': |
||
| 31 | $this->quoteCalls[] = array('quote_open',array(),$call[2]); |
||
| 32 | // fallthrough |
||
| 33 | case 'quote_newline': |
||
| 34 | $quoteLength = $this->getDepth($call[1][0]); |
||
| 35 | |||
| 36 | if ($quoteLength > $quoteDepth) { |
||
| 37 | $quoteDiff = $quoteLength - $quoteDepth; |
||
| 38 | for ($i = 1; $i <= $quoteDiff; $i++) { |
||
| 39 | $this->quoteCalls[] = array('quote_open',array(),$call[2]); |
||
| 40 | } |
||
| 41 | } elseif ($quoteLength < $quoteDepth) { |
||
| 42 | $quoteDiff = $quoteDepth - $quoteLength; |
||
| 43 | for ($i = 1; $i <= $quoteDiff; $i++) { |
||
| 44 | $this->quoteCalls[] = array('quote_close',array(),$call[2]); |
||
| 45 | } |
||
| 46 | } else { |
||
| 47 | if ($call[0] != 'quote_start') $this->quoteCalls[] = array('linebreak',array(),$call[2]); |
||
| 48 | } |
||
| 49 | |||
| 50 | $quoteDepth = $quoteLength; |
||
| 51 | |||
| 52 | break; |
||
| 53 | |||
| 54 | case 'quote_end': |
||
| 55 | if ($quoteDepth > 1) { |
||
| 56 | $quoteDiff = $quoteDepth - 1; |
||
| 57 | for ($i = 1; $i <= $quoteDiff; $i++) { |
||
| 58 | $this->quoteCalls[] = array('quote_close',array(),$call[2]); |
||
| 59 | } |
||
| 60 | } |
||
| 61 | |||
| 62 | $this->quoteCalls[] = array('quote_close',array(),$call[2]); |
||
| 63 | |||
| 64 | $this->callWriter->writeCalls($this->quoteCalls); |
||
| 65 | break; |
||
| 66 | |||
| 67 | default: |
||
| 68 | $this->quoteCalls[] = $call; |
||
| 69 | break; |
||
| 70 | } |
||
| 71 | } |
||
| 72 | |||
| 73 | return $this->callWriter; |
||
| 74 | } |
||
| 75 | |||
| 87 |
