The expression $args of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
Loading history...
67
$startdir = dirname(wikiFN($args[0] . ':xxx'));
68
} else {
69
$startdir = dirname(wikiFN('xxx'));
70
}
71
72
$this->skip = $options->getOpt('skip');
73
$this->sort = $options->getOpt('sort');
74
75
$this->info("searching $startdir");
76
77
foreach($this->get_pages($startdir) as $page) {
78
$this->internal_links($page);
79
}
80
ksort($this->result);
81
foreach($this->result as $main => $subs) {
82
if($this->skip) {
83
print "$main\n";
84
} else {
85
$subs = array_unique($subs);
86
sort($subs);
87
foreach($subs as $sub) {
88
printf("%-40s %s\n", $main, $sub);
89
}
90
}
91
}
92
}
93
94
/**
95
* Determine directions of the search loop
96
*
97
* @param string $entry
98
* @param string $basepath
99
* @return int
100
*/
101
protected function dir_filter($entry, $basepath) {
102
if($entry == '.' || $entry == '..') {
103
return WantedPagesCLI::DIR_CONTINUE;
104
}
105
if(is_dir($basepath . '/' . $entry)) {
106
if(strpos($entry, '_') === 0) {
107
return WantedPagesCLI::DIR_CONTINUE;
108
}
109
return WantedPagesCLI::DIR_NS;
110
}
111
if(preg_match('/\.txt$/', $entry)) {
112
return WantedPagesCLI::DIR_PAGE;
113
}
114
return WantedPagesCLI::DIR_CONTINUE;
115
}
116
117
/**
118
* Collects recursively the pages in a namespace
119
*
120
* @param string $dir
121
* @return array
122
* @throws DokuCLI_Exception
123
*/
124
protected function get_pages($dir) {
125
static $trunclen = null;
126
if(!$trunclen) {
127
global $conf;
128
$trunclen = strlen($conf['datadir'] . ':');
129
}
130
131
if(!is_dir($dir)) {
132
throw new DokuCLI_Exception("Unable to read directory $dir");
splitbrain /
dokuwiki
Andreas Gohr
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.