Issues in Show.php - New Issues - Inspection of "allow actions to be initialized without an action..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — actionrefactor ( 6e4bf0 )

by Andreas

created 2017-03-31 10:54 UTC

All Issues
New 39

inc/Action/Show.php (1 issue)

Labels

Best Practice 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Created by IntelliJ IDEA.
 * User: andi
 * Date: 2/10/17
 * Time: 4:32 PM
 */

namespace dokuwiki\Action;

/**
 * Class Show
 *
 * The default action of showing a page
 *
 * @package dokuwiki\Action
 */
class Show extends AbstractAction {

    /** @inheritdoc */
    function minimumPermission() {

        return AUTH_READ;
    }

    /** @inheritdoc */
    public function tplContent() {
        html_show();
    }

}


1			<?php
2			/**
3			* Created by IntelliJ IDEA.
4			* User: andi
5			* Date: 2/10/17
6			* Time: 4:32 PM
7			*/
8
9			namespace dokuwiki\Action;
10
11			/**
12			* Class Show
13			*
14			* The default action of showing a page
15			*
16			* @package dokuwiki\Action
17			*/
18			class Show extends AbstractAction {
19
20			/** @inheritdoc */
21			function minimumPermission() {
			0 ignored issues – show Best Practice introduced 2017-03-31 10:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
22			return AUTH_READ;
23			}
24
25			/** @inheritdoc */
26			public function tplContent() {
27			html_show();
28			}
29
30			}
31

splitbrain / dokuwiki

Push — actionrefactor ( 6e4bf0 )

inc/Action/Show.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like