Issues in Revisions.php - New Issues - Inspection of "allow actions to be initialized without an action..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — actionrefactor ( 6e4bf0 )

by Andreas

created 2017-03-31 10:54 UTC

All Issues
New 39

inc/Action/Revisions.php (1 issue)

Labels

Best Practice 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace dokuwiki\Action;

/**
 * Class Revisions
 *
 * Show the list of old revisions of the current page
 *
 * @package dokuwiki\Action
 */
class Revisions extends AbstractAction {

    /** @inheritdoc */
    function minimumPermission() {

        return AUTH_READ;
    }

    /** @inheritdoc */
    public function tplContent() {
        global $INPUT;
        html_revisions($INPUT->int('first'));
    }
}


1			<?php
2
3			namespace dokuwiki\Action;
4
5			/**
6			* Class Revisions
7			*
8			* Show the list of old revisions of the current page
9			*
10			* @package dokuwiki\Action
11			*/
12			class Revisions extends AbstractAction {
13
14			/** @inheritdoc */
15			function minimumPermission() {
			0 ignored issues – show Best Practice introduced 2017-03-31 10:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
16			return AUTH_READ;
17			}
18
19			/** @inheritdoc */
20			public function tplContent() {
21			global $INPUT;
22			html_revisions($INPUT->int('first'));
23			}
24			}
25

splitbrain / dokuwiki

Push — actionrefactor ( 6e4bf0 )

inc/Action/Revisions.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like