Issues in Check.php - New Issues - Inspection of "allow actions to be initialized without an action..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — actionrefactor ( 6e4bf0 )

by Andreas

created 2017-03-31 10:54 UTC

All Issues
New 39

inc/Action/Check.php (1 issue)

Labels

Best Practice 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace dokuwiki\Action;

use dokuwiki\Action\Exception\ActionAbort;

/**
 * Class Check
 *
 * Adds some debugging info before aborting to show
 *
 * @package dokuwiki\Action
 */
class Check extends AbstractAction {

    /** @inheritdoc */
    function minimumPermission() {

        return AUTH_READ;
    }

    public function preProcess() {
        check();
        throw new ActionAbort();
    }

}


1			<?php
2
3			namespace dokuwiki\Action;
4
5			use dokuwiki\Action\Exception\ActionAbort;
6
7			/**
8			* Class Check
9			*
10			* Adds some debugging info before aborting to show
11			*
12			* @package dokuwiki\Action
13			*/
14			class Check extends AbstractAction {
15
16			/** @inheritdoc */
17			function minimumPermission() {
			0 ignored issues – show Best Practice introduced 2017-03-31 10:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
18			return AUTH_READ;
19			}
20
21			public function preProcess() {
22			check();
23			throw new ActionAbort();
24			}
25
26			}
27

splitbrain / dokuwiki

Push — actionrefactor ( 6e4bf0 )

inc/Action/Check.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like