Login::minimumPermission() - Code Metrics - Inspection of "allow actions to be initialized without an action..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — actionrefactor ( 6e4bf0 )

by Andreas

created 2017-03-31 10:54 UTC

Login::minimumPermission() A

↳ Parent: Login

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace dokuwiki\Action;

use dokuwiki\Action\Exception\ActionException;

/**
 * Class Login
 *
 * The login form. Actual logins are handled in inc/auth.php
 *
 * @package dokuwiki\Action
 */
class Login extends AbstractAclAction {

    /** @inheritdoc */
    function minimumPermission() {

        return AUTH_NONE;
    }

    /** @inheritdoc */
    public function checkPermissions() {
        global $INPUT;
        parent::checkPermissions();
        if($INPUT->server->has('REMOTE_USER')) {
            // nothing to do
            throw new ActionException();
        }
        // FIXME auth login capabilities
    }

    /** @inheritdoc */
    public function tplContent() {
        html_login();
    }

}


1			<?php
2
3			namespace dokuwiki\Action;
4
5			use dokuwiki\Action\Exception\ActionException;
6
7			/**
8			* Class Login
9			*
10			* The login form. Actual logins are handled in inc/auth.php
11			*
12			* @package dokuwiki\Action
13			*/
14			class Login extends AbstractAclAction {
15
16			/** @inheritdoc */
17			function minimumPermission() {
			0 ignored issues – show Best Practice introduced 2017-03-31 10:58 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
18			return AUTH_NONE;
19			}
20
21			/** @inheritdoc */
22			public function checkPermissions() {
23			global $INPUT;
24			parent::checkPermissions();
25			if($INPUT->server->has('REMOTE_USER')) {
26			// nothing to do
27			throw new ActionException();
28			}
29			// FIXME auth login capabilities
30			}
31
32			/** @inheritdoc */
33			public function tplContent() {
34			html_login();
35			}
36
37			}
38

splitbrain / dokuwiki

Push — actionrefactor ( 6e4bf0 )

Login::minimumPermission() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like