Diff::tplContent() - Code Metrics - Inspection of "allow actions to be initialized without an action..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — actionrefactor ( 6e4bf0 )

by Andreas

created 2017-03-31 10:54 UTC

Diff::tplContent() A

↳ Parent: Diff

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	3
rs	10
c	1
b	1
f	0

<?php

namespace dokuwiki\Action;

/**
 * Class Diff
 *
 * Show the differences between two revisions
 *
 * @package dokuwiki\Action
 */
class Diff extends AbstractAction {

    /** @inheritdoc */
    function minimumPermission() {

        return AUTH_READ;
    }

    /** @inheritdoc */
    public function preProcess() {
        global $INPUT;

        // store the selected diff type in cookie
        $difftype = $INPUT->str('difftype');
        if(!empty($difftype)) {
            set_doku_pref('difftype', $difftype);
        }
    }

    /** @inheritdoc */
    public function tplContent() {
        html_diff();
    }

}


1			<?php
2
3			namespace dokuwiki\Action;
4
5			/**
6			* Class Diff
7			*
8			* Show the differences between two revisions
9			*
10			* @package dokuwiki\Action
11			*/
12			class Diff extends AbstractAction {
13
14			/** @inheritdoc */
15			function minimumPermission() {
			0 ignored issues – show Best Practice introduced 2017-03-31 10:58 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
16			return AUTH_READ;
17			}
18
19			/** @inheritdoc */
20			public function preProcess() {
21			global $INPUT;
22
23			// store the selected diff type in cookie
24			$difftype = $INPUT->str('difftype');
25			if(!empty($difftype)) {
26			set_doku_pref('difftype', $difftype);
27			}
28			}
29
30			/** @inheritdoc */
31			public function tplContent() {
32			html_diff();
33			}
34
35			}
36

splitbrain / dokuwiki

Push — actionrefactor ( 6e4bf0 )

Diff::tplContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like