Issues in DisplayRow.php - New Issues - Inspection of "Merge branch 'master' into phpunit8" - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — phpunit8 ( 01c53a...dfe72b )

by Andreas

created 2021-02-16 21:55 UTC

inc/Ui/Media/DisplayRow.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace dokuwiki\Ui\Media;

use dokuwiki\Utf8\PhpString;

/**
 * Display a MediaFile in the Media Popup
 */
class DisplayRow extends DisplayTile
{
    /** @inheritDoc */
    public function show()
    {
        global $lang;
        // FIXME Zebra classes have been dropped and need to be readded via CSS

        $id = $this->mediaFile->getId();
        $class = 'select mediafile mf_' . $this->mediaFile->getIcoClass();
        $info = trim($this->formatDimensions('') . ' ' . $this->formatDate() . ' ' . $this->formatFileSize());
        $jump = $this->scrollIntoView ? 'id="scroll__here"' : '';

        echo '<div title="' . $id . '" ' . $jump . '>';
        echo '<a id="h_:' . $id . '" class="' . $class . '">' .
            $this->formatDisplayName() .
            '</a> ';
        echo '<span class="info">(' . $info . ')</span>' . NL;

        // view button
        $link = ml($id, '', true);
        echo ' <a href="' . $link . '" target="_blank"><img src="' . DOKU_BASE . 'lib/images/magnifier.png" ' .
            'alt="' . $lang['mediaview'] . '" title="' . $lang['mediaview'] . '" class="btn" /></a>';

        // mediamanager button
        $link = wl('', array('do' => 'media', 'image' => $id, 'ns' => getNS($id)));
        echo ' <a href="' . $link . '" target="_blank"><img src="' . DOKU_BASE . 'lib/images/mediamanager.png" ' .
            'alt="' . $lang['btn_media'] . '" title="' . $lang['btn_media'] . '" class="btn" /></a>';

        // delete button
        if ($this->mediaFile->isWritable() && $this->mediaFile->userPermission() >= AUTH_DELETE) {
            $link = DOKU_BASE . 'lib/exe/mediamanager.php?delete=' . rawurlencode($id) .
                '&amp;sectok=' . getSecurityToken();
            echo ' <a href="' . $link . '" class="btn_media_delete" title="' . $id . '">' .
                '<img src="' . DOKU_BASE . 'lib/images/trash.png" alt="' . $lang['btn_delete'] . '" ' .
                'title="' . $lang['btn_delete'] . '" class="btn" /></a>';
        }

        echo '<div class="example" id="ex_' . str_replace(':', '_', $id) . '">';
        echo $lang['mediausage'] . ' <code>{{:' . $id . '}}</code>';
        echo '</div>';
        if ($this->mediaFile->getWidth()) $this->showDetails();
        echo '<div class="clearer"></div>' . NL;
        echo '</div>' . NL;

    }

    /**
     * Show Thumbnail and EXIF data
     */
    protected function showDetails()
    {
        $id = $this->mediaFile->getId();

        echo '<div class="detail">';
        echo '<div class="thumb">';
        echo '<a id="d_:' . $id . '" class="select">';
        echo $this->getPreviewHtml(120, 120);
        echo '</a>';
        echo '</div>';

        // read EXIF/IPTC data
        $t = $this->mediaFile->getMeta()->getField(array('IPTC.Headline', 'xmp.dc:title'));
        $d = $this->mediaFile->getMeta()->getField(array(
            'IPTC.Caption',
            'EXIF.UserComment',
            'EXIF.TIFFImageDescription',
            'EXIF.TIFFUserComment',
        ));
        if (PhpString::strlen($d) > 250) $d = PhpString::substr($d, 0, 250) . '...';
        $k = $this->mediaFile->getMeta()->getField(array('IPTC.Keywords', 'IPTC.Category', 'xmp.dc:subject'));

        // print EXIF/IPTC data
        if ($t || $d || $k) {
            echo '<p>';
            if ($t) echo '<strong>' . hsc($t) . '</strong><br />';
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            if ($d) echo hsc($d) . '<br />';
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            if ($t) echo '<em>' . hsc($k) . '</em>';
            echo '</p>';
        }
        echo '</div>';
    }

}


1			<?php
2
3			namespace dokuwiki\Ui\Media;
4
5			use dokuwiki\Utf8\PhpString;
6
7			/**
8			* Display a MediaFile in the Media Popup
9			*/
10			class DisplayRow extends DisplayTile
11			{
12			/** @inheritDoc */
13			public function show()
14			{
15			global $lang;
16			// FIXME Zebra classes have been dropped and need to be readded via CSS
17
18			$id = $this->mediaFile->getId();
19			$class = 'select mediafile mf_' . $this->mediaFile->getIcoClass();
20			$info = trim($this->formatDimensions('') . ' ' . $this->formatDate() . ' ' . $this->formatFileSize());
21			$jump = $this->scrollIntoView ? 'id="scroll__here"' : '';
22
23			echo '<div title="' . $id . '" ' . $jump . '>';
24			echo '<a id="h_:' . $id . '" class="' . $class . '">' .
25			$this->formatDisplayName() .
26			'</a> ';
27			echo '<span class="info">(' . $info . ')</span>' . NL;
28
29			// view button
30			$link = ml($id, '', true);
31			echo ' <a href="' . $link . '" target="_blank"><img src="' . DOKU_BASE . 'lib/images/magnifier.png" ' .
32			'alt="' . $lang['mediaview'] . '" title="' . $lang['mediaview'] . '" class="btn" /></a>';
33
34			// mediamanager button
35			$link = wl('', array('do' => 'media', 'image' => $id, 'ns' => getNS($id)));
36			echo ' <a href="' . $link . '" target="_blank"><img src="' . DOKU_BASE . 'lib/images/mediamanager.png" ' .
37			'alt="' . $lang['btn_media'] . '" title="' . $lang['btn_media'] . '" class="btn" /></a>';
38
39			// delete button
40			if ($this->mediaFile->isWritable() && $this->mediaFile->userPermission() >= AUTH_DELETE) {
41			$link = DOKU_BASE . 'lib/exe/mediamanager.php?delete=' . rawurlencode($id) .
42			'&sectok=' . getSecurityToken();
43			echo ' <a href="' . $link . '" class="btn_media_delete" title="' . $id . '">' .
44			'<img src="' . DOKU_BASE . 'lib/images/trash.png" alt="' . $lang['btn_delete'] . '" ' .
45			'title="' . $lang['btn_delete'] . '" class="btn" /></a>';
46			}
47
48			echo '<div class="example" id="ex_' . str_replace(':', '_', $id) . '">';
49			echo $lang['mediausage'] . ' <code>{{:' . $id . '}}</code>';
50			echo '</div>';
51			if ($this->mediaFile->getWidth()) $this->showDetails();
52			echo '<div class="clearer"></div>' . NL;
53			echo '</div>' . NL;
54
55			}
56
57			/**
58			* Show Thumbnail and EXIF data
59			*/
60			protected function showDetails()
61			{
62			$id = $this->mediaFile->getId();
63
64			echo '<div class="detail">';
65			echo '<div class="thumb">';
66			echo '<a id="d_:' . $id . '" class="select">';
67			echo $this->getPreviewHtml(120, 120);
68			echo '</a>';
69			echo '</div>';
70
71			// read EXIF/IPTC data
72			$t = $this->mediaFile->getMeta()->getField(array('IPTC.Headline', 'xmp.dc:title'));
73			$d = $this->mediaFile->getMeta()->getField(array(
74			'IPTC.Caption',
75			'EXIF.UserComment',
76			'EXIF.TIFFImageDescription',
77			'EXIF.TIFFUserComment',
78			));
79			if (PhpString::strlen($d) > 250) $d = PhpString::substr($d, 0, 250) . '...';
80			$k = $this->mediaFile->getMeta()->getField(array('IPTC.Keywords', 'IPTC.Category', 'xmp.dc:subject'));
81
82			// print EXIF/IPTC data
83			if ($t \|\| $d \|\| $k) {
84			echo '<p>';
85			if ($t) echo '<strong>' . hsc($t) . '</strong><br />';
			0 ignored issues – show Bug introduced 2021-01-05 19:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$t` defined by `$this->mediaFile->getMet...line', 'xmp.dc:title'))` on line `72` can also be of type `array<string,?>`; however, `hsc()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
86			if ($d) echo hsc($d) . '<br />';
			0 ignored issues – show Bug introduced 2021-01-05 19:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$d` defined by `$this->mediaFile->getMet...EXIF.TIFFUserComment'))` on line `73` can also be of type `array<string,?>`; however, `hsc()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
87			if ($t) echo '<em>' . hsc($k) . '</em>';
88			echo '</p>';
89			}
90			echo '</div>';
91			}
92
93			}
94

splitbrain / dokuwiki

Push — phpunit8 ( 01c53a...dfe72b )

inc/Ui/Media/DisplayRow.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like