$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.
Let’s take a look at an example:
foreach($collectionas$item){$myArray['foo']=$item->getFoo();if($item->hasBar()){$myArray['bar']=$item->getBar();}// do something with $myArray}
As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.
This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray=array() either outside or inside the foreach loop.
Loading history...
84
85
$event = new Doku_Event('ADMINPLUGIN_ACCESS_CHECK', $data);
86
if($event->advise_before()) {
87
if ($this->forAdminOnly()) {
88
$data['hasAccess'] = $INFO['isadmin'];
89
} else {
90
$data['hasAccess'] = $INFO['ismanager'];
91
}
92
}
93
$event->advise_after();
94
95
return $data['hasAccess'];
96
}
97
98
/**
99
* Return true for access only by admins (config:superuser) or false if managers are allowed as well
100
*
101
* @return bool
102
*/
103
public function forAdminOnly() {
104
return true;
105
}
106
107
/**
108
* Return array with ToC items. Items can be created with the html_mktocitem()
splitbrain /
dokuwiki
Andreas Gohr
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.