Manifest::jsonToArray() - Code Metrics - Inspection of "feat: provide web app manifest (dynamically geneat..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — manifest ( 5e0255 )

by Michael

created 2018-01-24 13:25 UTC

Manifest::jsonToArray() C

↳ Parent: Manifest

Complexity

Conditions	13
Paths	12

Size

Total Lines	50
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
eloc	41
nc	12
nop	1
dl	0
loc	50
rs	5.3808
c	0
b	0
f	0

How to fix Complexity

<?php

if (!defined('DOKU_INC')) {
    define('DOKU_INC', __DIR__ . '/../../');
}
require_once(DOKU_INC . 'inc/init.php');

class Manifest {
    public function run() {
        $manifest = retrieveConfig('manifest', [$this, 'jsonToArray']);

        global $conf;

        if (empty($manifest['name'])) {
            $manifest['name'] = $conf['title'];
        }

        if (empty($manifest['short_name'])) {
            $manifest['short_name'] = $conf['title'];
        }

        if (empty($manifest['description'])) {
            $manifest['description'] = $conf['tagline'];
        }

        if (empty($manifest['start_url'])) {
            $manifest['start_url'] = DOKU_REL;
        }

        if (empty($manifest['icons'])) {
            $manifest['icons'] = [];
            $look = [
                ':wiki:logo.png',
                ':logo.png',
                'images/logo.png',
                ':wiki:apple-touch-icon.png',
                ':apple-touch-icon.png',
                'images/apple-touch-icon.png',
                ':wiki:favicon.svg',
                ':favicon.svg',
                'images/favicon.svg',
                ':wiki:favicon.ico',
                ':favicon.ico',
                'images/favicon.ico',
                ':wiki:logo',
            ];

            $abs = true;
            foreach($look as $img) {
                if($img[0] === ':') {
                    $file    = mediaFN($img);
                    $ismedia = true;
                } else {
                    $file    = tpl_incdir().$img;
                    $ismedia = false;
                }

                if (file_exists($file)) {
                    $imginfo = getimagesize($file);
                    if($ismedia) {
                        $url = ml($img, '', true, '', $abs);
                    } else {
                        $url = tpl_basedir().$img;
                        if($abs) $url = DOKU_URL.substr($url, strlen(DOKU_REL));
                    }
                    $manifest['icons'][] = [
                        'src' => $url,
                        'sizes' => $imginfo[0] . 'x' . $imginfo[1],
                        'type' => $imginfo['mime'],
                    ];
                };
            }
        }

        trigger_event('MANIFEST_SEND', $manifest);

        header('Content-Type: application/manifest+json');
        echo json_encode($manifest);
    }

    public function jsonToArray($file)
    {
        $json = file_get_contents($file);

        $conf = json_decode($json, true);

        $jsonError = json_last_error();
        if (!is_array($conf) && $jsonError !== JSON_ERROR_NONE) {

            switch ($jsonError) {
                case JSON_ERROR_DEPTH:
                    $jsonErrorText = 'The maximum stack depth has been exceeded';
                    break;
                case JSON_ERROR_STATE_MISMATCH:
                    $jsonErrorText = 'Invalid or malformed JSON';
                    break;
                case JSON_ERROR_CTRL_CHAR:
                    $jsonErrorText = 'Control character error, possibly incorrectly encoded';
                    break;
                case JSON_ERROR_SYNTAX:
                    $jsonErrorText = 'Syntax error';
                    break;
                case JSON_ERROR_UTF8:
                    $jsonErrorText = 'Malformed UTF-8 characters, possibly incorrectly encoded';
                    break;
                case JSON_ERROR_RECURSION:
                    $jsonErrorText = 'One or more recursive references in the value to be encoded';
                    break;
                case JSON_ERROR_INF_OR_NAN:
                    $jsonErrorText = 'One or more NAN or INF values in the value to be encoded';
                    break;
                case JSON_ERROR_UNSUPPORTED_TYPE:
                    $jsonErrorText = 'A value of a type that cannot be encoded was given';
                    break;
                case JSON_ERROR_INVALID_PROPERTY_NAME:
                    $jsonErrorText = 'A property name that cannot be encoded was given';
                    break;
                case JSON_ERROR_UTF16:
                    $jsonErrorText = 'Malformed UTF-16 characters, possibly incorrectly encoded';
                    break;
                default:
                    $jsonErrorText = 'Unknown Error Code';
            }

            trigger_error('JSON decoding error "' . $jsonErrorText . '" for file ' . $file, E_USER_WARNING);
            return [];
        }

        return $conf;
    }
}

$manifest = new Manifest();
$manifest->run();


1			<?php
2
3			if (!defined('DOKU_INC')) {
4			define('DOKU_INC', __DIR__ . '/../../');
5			}
6			require_once(DOKU_INC . 'inc/init.php');
7
8			class Manifest {
9			public function run() {
10			$manifest = retrieveConfig('manifest', [$this, 'jsonToArray']);
11
12			global $conf;
13
14			if (empty($manifest['name'])) {
15			$manifest['name'] = $conf['title'];
16			}
17
18			if (empty($manifest['short_name'])) {
19			$manifest['short_name'] = $conf['title'];
20			}
21
22			if (empty($manifest['description'])) {
23			$manifest['description'] = $conf['tagline'];
24			}
25
26			if (empty($manifest['start_url'])) {
27			$manifest['start_url'] = DOKU_REL;
28			}
29
30			if (empty($manifest['icons'])) {
31			$manifest['icons'] = [];
32			$look = [
33			':wiki:logo.png',
34			':logo.png',
35			'images/logo.png',
36			':wiki:apple-touch-icon.png',
37			':apple-touch-icon.png',
38			'images/apple-touch-icon.png',
39			':wiki:favicon.svg',
40			':favicon.svg',
41			'images/favicon.svg',
42			':wiki:favicon.ico',
43			':favicon.ico',
44			'images/favicon.ico',
45			':wiki:logo',
46			];
47
48			$abs = true;
49			foreach($look as $img) {
50			if($img[0] === ':') {
51			$file = mediaFN($img);
52			$ismedia = true;
53			} else {
54			$file = tpl_incdir().$img;
55			$ismedia = false;
56			}
57
58			if (file_exists($file)) {
59			$imginfo = getimagesize($file);
60			if($ismedia) {
61			$url = ml($img, '', true, '', $abs);
62			} else {
63			$url = tpl_basedir().$img;
64			if($abs) $url = DOKU_URL.substr($url, strlen(DOKU_REL));
65			}
66			$manifest['icons'][] = [
67			'src' => $url,
68			'sizes' => $imginfo[0] . 'x' . $imginfo[1],
69			'type' => $imginfo['mime'],
70			];
71			};
72			}
73			}
74
75			trigger_event('MANIFEST_SEND', $manifest);
76
77			header('Content-Type: application/manifest+json');
78			echo json_encode($manifest);
79			}
80
81			public function jsonToArray($file)
82			{
83			$json = file_get_contents($file);
84
85			$conf = json_decode($json, true);
86
87			$jsonError = json_last_error();
88			if (!is_array($conf) && $jsonError !== JSON_ERROR_NONE) {
89
90			switch ($jsonError) {
91			case JSON_ERROR_DEPTH:
92			$jsonErrorText = 'The maximum stack depth has been exceeded';
93			break;
94			case JSON_ERROR_STATE_MISMATCH:
95			$jsonErrorText = 'Invalid or malformed JSON';
96			break;
97			case JSON_ERROR_CTRL_CHAR:
98			$jsonErrorText = 'Control character error, possibly incorrectly encoded';
99			break;
100			case JSON_ERROR_SYNTAX:
101			$jsonErrorText = 'Syntax error';
102			break;
103			case JSON_ERROR_UTF8:
104			$jsonErrorText = 'Malformed UTF-8 characters, possibly incorrectly encoded';
105			break;
106			case JSON_ERROR_RECURSION:
107			$jsonErrorText = 'One or more recursive references in the value to be encoded';
108			break;
109			case JSON_ERROR_INF_OR_NAN:
110			$jsonErrorText = 'One or more NAN or INF values in the value to be encoded';
111			break;
112			case JSON_ERROR_UNSUPPORTED_TYPE:
113			$jsonErrorText = 'A value of a type that cannot be encoded was given';
114			break;
115			case JSON_ERROR_INVALID_PROPERTY_NAME:
116			$jsonErrorText = 'A property name that cannot be encoded was given';
117			break;
118			case JSON_ERROR_UTF16:
119			$jsonErrorText = 'Malformed UTF-16 characters, possibly incorrectly encoded';
120			break;
121			default:
122			$jsonErrorText = 'Unknown Error Code';
123			}
124
125			trigger_error('JSON decoding error "' . $jsonErrorText . '" for file ' . $file, E_USER_WARNING);
126			return [];
127			}
128
129			return $conf;
130			}
131			}
132
133			$manifest = new Manifest();
134			$manifest->run();
135

splitbrain / dokuwiki

Push — manifest ( 5e0255 )

Manifest::jsonToArray() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like