action_plugin_popularity - Code Metrics - Inspection of "PSR-2 for popularity plugin" - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — psr2 ( 1cdd00...29fc53 )

by Andreas

created 2018-05-08 17:50 UTC

action_plugin_popularity A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	0
loc	59
rs	10
c	0
b	0
f	0
wmc	7
lcom	1
cbo	4

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	register()	4	1
B	autosubmit()	23	4
A	isTooEarlyToSubmit()	5	1

<?php
/**
 * Popularity Feedback Plugin
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 */

class action_plugin_popularity extends Dokuwiki_Action_Plugin
{

    /**
     * @var helper_plugin_popularity
     */
    protected $helper;

    public function __construct()
    {
        $this->helper = $this->loadHelper('popularity', false);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /** @inheritdoc */
    public function register(Doku_Event_Handler $controller)
    {
        $controller->register_hook('INDEXER_TASKS_RUN', 'AFTER', $this, 'autosubmit', array());
    }

    /**
     * Event handler
     *
     * @param Doku_Event $event
     * @param $param
     */
    public function autosubmit(Doku_Event &$event, $param)

    {
        //Do we have to send the data now
        if (!$this->helper->isAutosubmitEnabled() || $this->isTooEarlyToSubmit()) {
            return;
        }

        //Actually send it
        $status = $this->helper->sendData($this->helper->gatherAsString());

        if ($status !== '') {
            //If an error occured, log it
            io_saveFile($this->helper->autosubmitErrorFile, $status);
        } else {
            //If the data has been sent successfully, previous log of errors are useless
            @unlink($this->helper->autosubmitErrorFile);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            //Update the last time we sent data
            touch($this->helper->autosubmitFile);
        }

        $event->stopPropagation();
        $event->preventDefault();
    }

    /**
     * Check if it's time to send autosubmit data
     * (we should have check if autosubmit is enabled first)
     */
    protected function isTooEarlyToSubmit()
    {
        $lastSubmit = $this->helper->lastSentTime();
        return $lastSubmit + 24*60*60*30 > time();
    }
}


1			<?php
2			/**
3			* Popularity Feedback Plugin
4			*
5			* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6			*/
7
8			class action_plugin_popularity extends Dokuwiki_Action_Plugin
9			{
10
11			/**
12			* @var helper_plugin_popularity
13			*/
14			protected $helper;
15
16			public function __construct()
17			{
18			$this->helper = $this->loadHelper('popularity', false);
			0 ignored issues – show Documentation Bug introduced 2017-11-10 16:53 UTC by Report Bug Copy Issue Report It seems like `$this->loadHelper('popularity', false)` can also be of type `object<DokuWiki_PluginInterface>`. However, the property `$helper` is declared as type `object<helper_plugin_popularity>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
19			}
20
21			/** @inheritdoc */
22			public function register(Doku_Event_Handler $controller)
23			{
24			$controller->register_hook('INDEXER_TASKS_RUN', 'AFTER', $this, 'autosubmit', array());
25			}
26
27			/**
28			* Event handler
29			*
30			* @param Doku_Event $event
31			* @param $param
32			*/
33			public function autosubmit(Doku_Event &$event, $param)
			0 ignored issues – show Unused Code introduced 2018-04-27 19:09 UTC by Report Bug Copy Issue Report The parameter `$param` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
34			{
35			//Do we have to send the data now
36			if (!$this->helper->isAutosubmitEnabled() \|\| $this->isTooEarlyToSubmit()) {
37			return;
38			}
39
40			//Actually send it
41			$status = $this->helper->sendData($this->helper->gatherAsString());
42
43			if ($status !== '') {
44			//If an error occured, log it
45			io_saveFile($this->helper->autosubmitErrorFile, $status);
46			} else {
47			//If the data has been sent successfully, previous log of errors are useless
48			@unlink($this->helper->autosubmitErrorFile);
			1 ignored issue – show Security Best Practice introduced 2015-11-25 07:06 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
49			//Update the last time we sent data
50			touch($this->helper->autosubmitFile);
51			}
52
53			$event->stopPropagation();
54			$event->preventDefault();
55			}
56
57			/**
58			* Check if it's time to send autosubmit data
59			* (we should have check if autosubmit is enabled first)
60			*/
61			protected function isTooEarlyToSubmit()
62			{
63			$lastSubmit = $this->helper->lastSentTime();
64			return $lastSubmit + 246060*30 > time();
65			}
66			}
67

splitbrain / dokuwiki

Push — psr2 ( 1cdd00...29fc53 )

action_plugin_popularity A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like