It seems like $options->getOpt('skip') can also be of type string or array<integer,string>. However, the property $skip is declared as type boolean. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
It seems like $options->getOpt('sort') can also be of type boolean or array<integer,string>. However, the property $sort is declared as type string. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
Loading history...
74
75
$this->info("searching $startdir");
76
77
foreach($this->get_pages($startdir) as $page) {
78
$this->internal_links($page);
79
}
80
ksort($this->result);
81
foreach($this->result as $main => $subs) {
82
if($this->skip) {
83
print "$main\n";
84
} else {
85
$subs = array_unique($subs);
86
sort($subs);
87
foreach($subs as $sub) {
88
printf("%-40s %s\n", $main, $sub);
89
}
90
}
91
}
92
}
93
94
/**
95
* Determine directions of the search loop
96
*
97
* @param string $entry
98
* @param string $basepath
99
* @return int
100
*/
101
protected function dir_filter($entry, $basepath) {
102
if($entry == '.' || $entry == '..') {
103
return WantedPagesCLI::DIR_CONTINUE;
104
}
105
if(is_dir($basepath . '/' . $entry)) {
106
if(strpos($entry, '_') === 0) {
107
return WantedPagesCLI::DIR_CONTINUE;
108
}
109
return WantedPagesCLI::DIR_NS;
110
}
111
if(preg_match('/\.txt$/', $entry)) {
112
return WantedPagesCLI::DIR_PAGE;
113
}
114
return WantedPagesCLI::DIR_CONTINUE;
115
}
116
117
/**
118
* Collects recursively the pages in a namespace
119
*
120
* @param string $dir
121
* @return array
122
* @throws DokuCLI_Exception
123
*/
124
protected function get_pages($dir) {
125
static $trunclen = null;
126
if(!$trunclen) {
127
global $conf;
128
$trunclen = strlen($conf['datadir'] . ':');
129
}
130
131
if(!is_dir($dir)) {
132
throw new DokuCLI_Exception("Unable to read directory $dir");
splitbrain /
dokuwiki
Andreas Gohr
Loading history...
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.