SettingNumeric::update() - Code Metrics - Inspection of "Merge pull request #2382 from splitbrain/psr2-conf..." - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — psr2 ( 8eb28c...c68e26 )

by Andreas

created 2018-06-15 08:27 UTC

SettingNumeric::update() B

↳ Parent: SettingNumeric

Complexity

Conditions	8
Paths	3

Size

Total Lines	15
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	12
nc	3
nop	1
dl	0
loc	15
rs	7.7777
c	0
b	0
f	0

<?php

namespace dokuwiki\plugin\config\core\Setting;

/**
 * Class setting_numeric
 */
class SettingNumeric extends SettingString {
    // This allows for many PHP syntax errors...
    // var $_pattern = '/^[-+\/*0-9 ]*$/';
    // much more restrictive, but should eliminate syntax errors.
    protected $pattern = '/^[-+]? *[0-9]+ *(?:[-+*] *[0-9]+ *)*$/';
    protected $min = null;
    protected $max = null;

    /** @inheritdoc */
    public function update($input) {
        $local = $this->local;
        $valid = parent::update($input);
        if($valid && !(is_null($this->min) && is_null($this->max))) {
            $numeric_local = (int) eval('return ' . $this->local . ';');
            if((!is_null($this->min) && $numeric_local < $this->min) ||
                (!is_null($this->max) && $numeric_local > $this->max)) {
                $this->error = true;
                $this->input = $input;
                $this->local = $local;
                $valid = false;
            }
        }
        return $valid;
    }

    /** @inheritdoc */
    public function out($var, $fmt = 'php') {
        if($fmt != 'php') return '';

        $local = $this->local === '' ? "''" : $this->local;
        $out = '$' . $var . "['" . $this->getArrayKey() . "'] = " . $local . ";\n";

        return $out;
    }
}


1			<?php
2
3			namespace dokuwiki\plugin\config\core\Setting;
4
5			/**
6			* Class setting_numeric
7			*/
8			class SettingNumeric extends SettingString {
9			// This allows for many PHP syntax errors...
10			// var $_pattern = '/^[-+\/0-9 ]$/';
11			// much more restrictive, but should eliminate syntax errors.
12			protected $pattern = '/^[-+]? [0-9]+ (?:[-+] [0-9]+ )$/';
13			protected $min = null;
14			protected $max = null;
15
16			/** @inheritdoc */
17			public function update($input) {
18			$local = $this->local;
19			$valid = parent::update($input);
20			if($valid && !(is_null($this->min) && is_null($this->max))) {
21			$numeric_local = (int) eval('return ' . $this->local . ';');
22			if((!is_null($this->min) && $numeric_local < $this->min) \|\|
23			(!is_null($this->max) && $numeric_local > $this->max)) {
24			$this->error = true;
25			$this->input = $input;
26			$this->local = $local;
27			$valid = false;
28			}
29			}
30			return $valid;
31			}
32
33			/** @inheritdoc */
34			public function out($var, $fmt = 'php') {
35			if($fmt != 'php') return '';
36
37			$local = $this->local === '' ? "''" : $this->local;
38			$out = '$' . $var . "['" . $this->getArrayKey() . "'] = " . $local . ";\n";
39
40			return $out;
41			}
42			}
43

splitbrain / dokuwiki

Push — psr2 ( 8eb28c...c68e26 )

SettingNumeric::update() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like