Issues in index.php - Failed Issues - Inspection of "Hotfix release 2018-04-22a "Greebo"" - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — stable ( d0fffb...879d2b )

unknown

created 2018-05-03 06:37 UTC

lib/tpl/index.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file reads the style.ini of the used template and displays the
 * replacements defined in it. Color replacements will be displayed
 * visually. This should help with adjusting and using the styles
 * specified in the style.ini
 *
 * @author Andreas Gohr <[email protected]>
 * @author Anika Henke <[email protected]>
 */
if(!defined('DOKU_INC')) define('DOKU_INC',dirname(__FILE__).'/../../');
if(!defined('NOSESSION')) define('NOSESSION',1);
require_once(DOKU_INC.'inc/init.php');
?>
<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
    <title>Template Replacements</title>
    <style type="text/css">
        body {
            background-color: #fff;
            color: #000;
        }
        caption {
            font-weight: bold;
        }
        td {
            margin: 0;
            padding: 0.5em 2em;
            font-family: monospace;
            font-size: 120%;
            border: 1px solid #fff;
        }
        tr:hover td {
            border: 1px solid #ccc;
        }
        .color {
            padding: 0.25em 1em;
            border: 1px #000 solid;
        }
    </style>
</head>
<body>
<?php
// get merged style.ini
define('SIMPLE_TEST', true); // hack to prevent css output and headers
require_once(DOKU_INC.'lib/exe/css.php');
$styleUtils = new \dokuwiki\StyleUtils();
$ini = $styleUtils->cssStyleini($conf['template']);

if ($ini) {

    echo '<table>';
    echo "<caption>".hsc($conf['template'])."'s style.ini</caption>";
    foreach($ini['replacements'] as $key => $val){
        echo '<tr>';
        echo '<td>'.hsc($key).'</td>';
        echo '<td>'.hsc($val).'</td>';
        echo '<td>';
        if(preg_match('/^#[0-f]{3,6}$/i',$val)){
            echo '<div class="color" style="background-color:'.$val.';">&#160;</div>';
        }
        echo '</td>';
        echo '</tr>';
    }
    echo '</table>';
} else {
    echo "<p>Non-existent or invalid template or style.ini: <strong>".hsc($conf['template'])."</strong></p>";
}
?>
</body>
</html>


1			<?php
2			/**
3			* This file reads the style.ini of the used template and displays the
4			* replacements defined in it. Color replacements will be displayed
5			* visually. This should help with adjusting and using the styles
6			* specified in the style.ini
7			*
8			* @author Andreas Gohr <[email protected]>
9			* @author Anika Henke <[email protected]>
10			*/
11			if(!defined('DOKU_INC')) define('DOKU_INC',dirname(__FILE__).'/../../');
12			if(!defined('NOSESSION')) define('NOSESSION',1);
13			require_once(DOKU_INC.'inc/init.php');
14			?>
15			<!DOCTYPE html>
16			<html lang="en" dir="ltr">
17			<head>
18			<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
19			<title>Template Replacements</title>
20			<style type="text/css">
21			body {
22			background-color: #fff;
23			color: #000;
24			}
25			caption {
26			font-weight: bold;
27			}
28			td {
29			margin: 0;
30			padding: 0.5em 2em;
31			font-family: monospace;
32			font-size: 120%;
33			border: 1px solid #fff;
34			}
35			tr:hover td {
36			border: 1px solid #ccc;
37			}
38			.color {
39			padding: 0.25em 1em;
40			border: 1px #000 solid;
41			}
42			</style>
43			</head>
44			<body>
45			<?php
46			// get merged style.ini
47			define('SIMPLE_TEST', true); // hack to prevent css output and headers
48			require_once(DOKU_INC.'lib/exe/css.php');
49			$styleUtils = new \dokuwiki\StyleUtils();
50			$ini = $styleUtils->cssStyleini($conf['template']);
51
52			if ($ini) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-25 07:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$ini` of type `array<string,array>` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
53			echo '<table>';
54			echo "<caption>".hsc($conf['template'])."'s style.ini</caption>";
55			foreach($ini['replacements'] as $key => $val){
56			echo '<tr>';
57			echo '<td>'.hsc($key).'</td>';
58			echo '<td>'.hsc($val).'</td>';
59			echo '<td>';
60			if(preg_match('/^#[0-f]{3,6}$/i',$val)){
61			echo '<div class="color" style="background-color:'.$val.';"> </div>';
62			}
63			echo '</td>';
64			echo '</tr>';
65			}
66			echo '</table>';
67			} else {
68			echo "<p>Non-existent or invalid template or style.ini: <strong>".hsc($conf['template'])."</strong></p>";
69			}
70			?>
71			</body>
72			</html>
73

splitbrain / dokuwiki

Push — stable ( d0fffb...879d2b )

lib/tpl/index.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like