ChangeLog::retrieveRevisionsAround() - Code Metrics - Inspection of "some small fixes for PSR2" - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — psr2 ( 9ddafc...b78f68 )

by Andreas

created 2018-06-15 09:52 UTC

ChangeLog::retrieveRevisionsAround() C

↳ Parent: Project

Complexity

Conditions	14
Paths	37

Size

Total Lines	62
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	14
eloc	38
nc	37
nop	2
dl	0
loc	62
rs	6.1699
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * Changelog handling functions
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Andreas Gohr <[email protected]>
 */

// Constants for known core changelog line types.
// Use these in place of string literals for more readable code.
define('DOKU_CHANGE_TYPE_CREATE',       'C');
define('DOKU_CHANGE_TYPE_EDIT',         'E');
define('DOKU_CHANGE_TYPE_MINOR_EDIT',   'e');
define('DOKU_CHANGE_TYPE_DELETE',       'D');
define('DOKU_CHANGE_TYPE_REVERT',       'R');

/**
 * parses a changelog line into it's components
 *
 * @author Ben Coburn <[email protected]>
 *
 * @param string $line changelog line
 * @return array|bool parsed line or false
 */
function parseChangelogLine($line) {
    $line = rtrim($line, "\n");
    $tmp = explode("\t", $line);
    if ($tmp!==false && count($tmp)>1) {
        $info = array();
        $info['date']  = (int)$tmp[0]; // unix timestamp
        $info['ip']    = $tmp[1]; // IPv4 address (127.0.0.1)
        $info['type']  = $tmp[2]; // log line type
        $info['id']    = $tmp[3]; // page id
        $info['user']  = $tmp[4]; // user name
        $info['sum']   = $tmp[5]; // edit summary (or action reason)
        $info['extra'] = $tmp[6]; // extra data (varies by line type)
        if(isset($tmp[7]) && $tmp[7] !== '') { //last item has line-end||
            $info['sizechange'] = (int) $tmp[7];
        } else {
            $info['sizechange'] = null;
        }
        return $info;
    } else {
        return false;
    }
}

/**
 * Add's an entry to the changelog and saves the metadata for the page
 *
 * @param int    $date      Timestamp of the change
 * @param String $id        Name of the affected page
 * @param String $type      Type of the change see DOKU_CHANGE_TYPE_*
 * @param String $summary   Summary of the change
 * @param mixed  $extra     In case of a revert the revision (timestmp) of the reverted page
 * @param array  $flags     Additional flags in a key value array.
 *                             Available flags:
 *                             - ExternalEdit - mark as an external edit.
 * @param null|int $sizechange Change of filesize
 *
 * @author Andreas Gohr <[email protected]>
 * @author Esther Brunner <[email protected]>
 * @author Ben Coburn <[email protected]>
 */
function addLogEntry($date, $id, $type=DOKU_CHANGE_TYPE_EDIT, $summary='', $extra='', $flags=null, $sizechange = null){
    global $conf, $INFO;
    /** @var Input $INPUT */
    global $INPUT;

    // check for special flags as keys
    if (!is_array($flags)) { $flags = array(); }
    $flagExternalEdit = isset($flags['ExternalEdit']);

    $id = cleanid($id);
    $file = wikiFN($id);
    $created = @filectime($file);
    $minor = ($type===DOKU_CHANGE_TYPE_MINOR_EDIT);
    $wasRemoved = ($type===DOKU_CHANGE_TYPE_DELETE);

    if(!$date) $date = time(); //use current time if none supplied
    $remote = (!$flagExternalEdit)?clientIP(true):'127.0.0.1';
    $user   = (!$flagExternalEdit)?$INPUT->server->str('REMOTE_USER'):'';
    if($sizechange === null) {
        $sizechange = '';
    } else {
        $sizechange = (int) $sizechange;
    }

    $strip = array("\t", "\n");
    $logline = array(
        'date'       => $date,
        'ip'         => $remote,
        'type'       => str_replace($strip, '', $type),
        'id'         => $id,
        'user'       => $user,
        'sum'        => utf8_substr(str_replace($strip, '', $summary), 0, 255),
        'extra'      => str_replace($strip, '', $extra),
        'sizechange' => $sizechange
    );

    $wasCreated = ($type===DOKU_CHANGE_TYPE_CREATE);
    $wasReverted = ($type===DOKU_CHANGE_TYPE_REVERT);
    // update metadata
    if (!$wasRemoved) {
        $oldmeta = p_read_metadata($id);
        $meta    = array();
        if ($wasCreated && empty($oldmeta['persistent']['date']['created'])){
            // newly created
            $meta['date']['created'] = $created;
            if ($user){
                $meta['creator'] = $INFO['userinfo']['name'];
                $meta['user']    = $user;
            }
        } elseif (($wasCreated || $wasReverted) && !empty($oldmeta['persistent']['date']['created'])) {
            // re-created / restored
            $meta['date']['created']  = $oldmeta['persistent']['date']['created'];
            $meta['date']['modified'] = $created; // use the files ctime here
            $meta['creator'] = $oldmeta['persistent']['creator'];
            if ($user) $meta['contributor'][$user] = $INFO['userinfo']['name'];
        } elseif (!$minor) {   // non-minor modification
            $meta['date']['modified'] = $date;
            if ($user) $meta['contributor'][$user] = $INFO['userinfo']['name'];
        }
        $meta['last_change'] = $logline;
        p_set_metadata($id, $meta);
    }

    // add changelog lines
    $logline = implode("\t", $logline)."\n";
    io_saveFile(metaFN($id,'.changes'),$logline,true); //page changelog
    io_saveFile($conf['changelog'],$logline,true); //global changelog cache
}

/**
 * Add's an entry to the media changelog
 *
 * @author Michael Hamann <[email protected]>
 * @author Andreas Gohr <[email protected]>
 * @author Esther Brunner <[email protected]>
 * @author Ben Coburn <[email protected]>
 *
 * @param int    $date      Timestamp of the change
 * @param String $id        Name of the affected page
 * @param String $type      Type of the change see DOKU_CHANGE_TYPE_*
 * @param String $summary   Summary of the change
 * @param mixed  $extra     In case of a revert the revision (timestmp) of the reverted page
 * @param array  $flags     Additional flags in a key value array.
 *                             Available flags:
 *                             - (none, so far)
 * @param null|int $sizechange Change of filesize
 */
function addMediaLogEntry(
    $date,
    $id,
    $type=DOKU_CHANGE_TYPE_EDIT,
    $summary='',
    $extra='',
    $flags=null,

    $sizechange = null)
{
    global $conf;
    /** @var Input $INPUT */
    global $INPUT;

    $id = cleanid($id);

    if(!$date) $date = time(); //use current time if none supplied
    $remote = clientIP(true);
    $user   = $INPUT->server->str('REMOTE_USER');
    if($sizechange === null) {
        $sizechange = '';
    } else {
        $sizechange = (int) $sizechange;
    }

    $strip = array("\t", "\n");
    $logline = array(
        'date'       => $date,
        'ip'         => $remote,
        'type'       => str_replace($strip, '', $type),
        'id'         => $id,
        'user'       => $user,
        'sum'        => utf8_substr(str_replace($strip, '', $summary), 0, 255),
        'extra'      => str_replace($strip, '', $extra),
        'sizechange' => $sizechange
    );

    // add changelog lines
    $logline = implode("\t", $logline)."\n";
    io_saveFile($conf['media_changelog'],$logline,true); //global media changelog cache
    io_saveFile(mediaMetaFN($id,'.changes'),$logline,true); //media file's changelog
}

/**
 * returns an array of recently changed files using the
 * changelog
 *
 * The following constants can be used to control which changes are
 * included. Add them together as needed.
 *
 * RECENTS_SKIP_DELETED   - don't include deleted pages
 * RECENTS_SKIP_MINORS    - don't include minor changes
 * RECENTS_SKIP_SUBSPACES - don't include subspaces
 * RECENTS_MEDIA_CHANGES  - return media changes instead of page changes
 * RECENTS_MEDIA_PAGES_MIXED  - return both media changes and page changes
 *
 * @param int    $first   number of first entry returned (for paginating
 * @param int    $num     return $num entries
 * @param string $ns      restrict to given namespace
 * @param int    $flags   see above
 * @return array recently changed files
 *
 * @author Ben Coburn <[email protected]>
 * @author Kate Arzamastseva <[email protected]>
 */
function getRecents($first,$num,$ns='',$flags=0){
    global $conf;
    $recent = array();
    $count  = 0;

    if(!$num)
        return $recent;

    // read all recent changes. (kept short)
    if ($flags & RECENTS_MEDIA_CHANGES) {
        $lines = @file($conf['media_changelog']);
    } else {
        $lines = @file($conf['changelog']);
    }
    $lines_position = count($lines)-1;
    $media_lines_position = 0;
    $media_lines = array();

    if ($flags & RECENTS_MEDIA_PAGES_MIXED) {
        $media_lines = @file($conf['media_changelog']);
        $media_lines_position = count($media_lines)-1;
    }

    $seen = array(); // caches seen lines, _handleRecent() skips them

    // handle lines
    while ($lines_position >= 0 || (($flags & RECENTS_MEDIA_PAGES_MIXED) && $media_lines_position >=0)) {
        if (empty($rec) && $lines_position >= 0) {
            $rec = _handleRecent(@$lines[$lines_position], $ns, $flags, $seen);
            if (!$rec) {
                $lines_position --;
                continue;
            }
        }
        if (($flags & RECENTS_MEDIA_PAGES_MIXED) && empty($media_rec) && $media_lines_position >= 0) {
            $media_rec = _handleRecent(
                @$media_lines[$media_lines_position],
                $ns,
                $flags | RECENTS_MEDIA_CHANGES,
                $seen
            );
            if (!$media_rec) {
                $media_lines_position --;
                continue;
            }
        }
        if (($flags & RECENTS_MEDIA_PAGES_MIXED) && @$media_rec['date'] >= @$rec['date']) {
            $media_lines_position--;
            $x = $media_rec;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $x['media'] = true;
            $media_rec = false;
        } else {
            $lines_position--;
            $x = $rec;
            if ($flags & RECENTS_MEDIA_CHANGES) $x['media'] = true;
            $rec = false;
        }
        if(--$first >= 0) continue; // skip first entries
        $recent[] = $x;
        $count++;
        // break when we have enough entries
        if($count >= $num){ break; }
    }
    return $recent;
}

/**
 * returns an array of files changed since a given time using the
 * changelog
 *
 * The following constants can be used to control which changes are
 * included. Add them together as needed.
 *
 * RECENTS_SKIP_DELETED   - don't include deleted pages
 * RECENTS_SKIP_MINORS    - don't include minor changes
 * RECENTS_SKIP_SUBSPACES - don't include subspaces
 * RECENTS_MEDIA_CHANGES  - return media changes instead of page changes
 *
 * @param int    $from    date of the oldest entry to return
 * @param int    $to      date of the newest entry to return (for pagination, optional)
 * @param string $ns      restrict to given namespace (optional)
 * @param int    $flags   see above (optional)
 * @return array of files
 *
 * @author Michael Hamann <[email protected]>
 * @author Ben Coburn <[email protected]>
 */
function getRecentsSince($from,$to=null,$ns='',$flags=0){
    global $conf;
    $recent = array();

    if($to && $to < $from)
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
        return $recent;

    // read all recent changes. (kept short)
    if ($flags & RECENTS_MEDIA_CHANGES) {
        $lines = @file($conf['media_changelog']);
    } else {
        $lines = @file($conf['changelog']);
    }
    if(!$lines) return $recent;

    // we start searching at the end of the list
    $lines = array_reverse($lines);

    // handle lines
    $seen = array(); // caches seen lines, _handleRecent() skips them

    foreach($lines as $line){
        $rec = _handleRecent($line, $ns, $flags, $seen);
        if($rec !== false) {
            if ($rec['date'] >= $from) {
                if (!$to || $rec['date'] <= $to) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                    $recent[] = $rec;
                }
            } else {
                break;
            }
        }
    }

    return array_reverse($recent);
}

/**
 * Internal function used by getRecents
 *
 * don't call directly
 *
 * @see getRecents()
 * @author Andreas Gohr <[email protected]>
 * @author Ben Coburn <[email protected]>
 *
 * @param string $line   changelog line
 * @param string $ns     restrict to given namespace
 * @param int    $flags  flags to control which changes are included
 * @param array  $seen   listing of seen pages
 * @return array|bool    false or array with info about a change
 */
function _handleRecent($line,$ns,$flags,&$seen){
    if(empty($line)) return false;   //skip empty lines

    // split the line into parts
    $recent = parseChangelogLine($line);
    if ($recent===false) { return false; }

    // skip seen ones
    if(isset($seen[$recent['id']])) return false;

    // skip minors
    if($recent['type']===DOKU_CHANGE_TYPE_MINOR_EDIT && ($flags & RECENTS_SKIP_MINORS)) return false;

    // remember in seen to skip additional sights
    $seen[$recent['id']] = 1;

    // check if it's a hidden page
    if(isHiddenPage($recent['id'])) return false;

    // filter namespace
    if (($ns) && (strpos($recent['id'],$ns.':') !== 0)) return false;

    // exclude subnamespaces
    if (($flags & RECENTS_SKIP_SUBSPACES) && (getNS($recent['id']) != $ns)) return false;

    // check ACL
    if ($flags & RECENTS_MEDIA_CHANGES) {
        $recent['perms'] = auth_quickaclcheck(getNS($recent['id']).':*');
    } else {
        $recent['perms'] = auth_quickaclcheck($recent['id']);
    }
    if ($recent['perms'] < AUTH_READ) return false;

    // check existance
    if($flags & RECENTS_SKIP_DELETED){
        $fn = (($flags & RECENTS_MEDIA_CHANGES) ? mediaFN($recent['id']) : wikiFN($recent['id']));
        if(!file_exists($fn)) return false;
    }

    return $recent;
}


1			<?php
2			/**
3			* Changelog handling functions
4			*
5			* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6			* @author Andreas Gohr <[email protected]>
7			*/
8
9			// Constants for known core changelog line types.
10			// Use these in place of string literals for more readable code.
11			define('DOKU_CHANGE_TYPE_CREATE', 'C');
12			define('DOKU_CHANGE_TYPE_EDIT', 'E');
13			define('DOKU_CHANGE_TYPE_MINOR_EDIT', 'e');
14			define('DOKU_CHANGE_TYPE_DELETE', 'D');
15			define('DOKU_CHANGE_TYPE_REVERT', 'R');
16
17			/**
18			* parses a changelog line into it's components
19			*
20			* @author Ben Coburn <[email protected]>
21			*
22			* @param string $line changelog line
23			* @return array\|bool parsed line or false
24			*/
25			function parseChangelogLine($line) {
26			$line = rtrim($line, "\n");
27			$tmp = explode("\t", $line);
28			if ($tmp!==false && count($tmp)>1) {
29			$info = array();
30			$info['date'] = (int)$tmp[0]; // unix timestamp
31			$info['ip'] = $tmp[1]; // IPv4 address (127.0.0.1)
32			$info['type'] = $tmp[2]; // log line type
33			$info['id'] = $tmp[3]; // page id
34			$info['user'] = $tmp[4]; // user name
35			$info['sum'] = $tmp[5]; // edit summary (or action reason)
36			$info['extra'] = $tmp[6]; // extra data (varies by line type)
37			if(isset($tmp[7]) && $tmp[7] !== '') { //last item has line-end\|\|
38			$info['sizechange'] = (int) $tmp[7];
39			} else {
40			$info['sizechange'] = null;
41			}
42			return $info;
43			} else {
44			return false;
45			}
46			}
47
48			/**
49			* Add's an entry to the changelog and saves the metadata for the page
50			*
51			* @param int $date Timestamp of the change
52			* @param String $id Name of the affected page
53			* @param String $type Type of the change see DOKU_CHANGE_TYPE_*
54			* @param String $summary Summary of the change
55			* @param mixed $extra In case of a revert the revision (timestmp) of the reverted page
56			* @param array $flags Additional flags in a key value array.
57			* Available flags:
58			* - ExternalEdit - mark as an external edit.
59			* @param null\|int $sizechange Change of filesize
60			*
61			* @author Andreas Gohr <[email protected]>
62			* @author Esther Brunner <[email protected]>
63			* @author Ben Coburn <[email protected]>
64			*/
65			function addLogEntry($date, $id, $type=DOKU_CHANGE_TYPE_EDIT, $summary='', $extra='', $flags=null, $sizechange = null){
66			global $conf, $INFO;
67			/** @var Input $INPUT */
68			global $INPUT;
69
70			// check for special flags as keys
71			if (!is_array($flags)) { $flags = array(); }
72			$flagExternalEdit = isset($flags['ExternalEdit']);
73
74			$id = cleanid($id);
75			$file = wikiFN($id);
76			$created = @filectime($file);
77			$minor = ($type===DOKU_CHANGE_TYPE_MINOR_EDIT);
78			$wasRemoved = ($type===DOKU_CHANGE_TYPE_DELETE);
79
80			if(!$date) $date = time(); //use current time if none supplied
81			$remote = (!$flagExternalEdit)?clientIP(true):'127.0.0.1';
82			$user = (!$flagExternalEdit)?$INPUT->server->str('REMOTE_USER'):'';
83			if($sizechange === null) {
84			$sizechange = '';
85			} else {
86			$sizechange = (int) $sizechange;
87			}
88
89			$strip = array("\t", "\n");
90			$logline = array(
91			'date' => $date,
92			'ip' => $remote,
93			'type' => str_replace($strip, '', $type),
94			'id' => $id,
95			'user' => $user,
96			'sum' => utf8_substr(str_replace($strip, '', $summary), 0, 255),
97			'extra' => str_replace($strip, '', $extra),
98			'sizechange' => $sizechange
99			);
100
101			$wasCreated = ($type===DOKU_CHANGE_TYPE_CREATE);
102			$wasReverted = ($type===DOKU_CHANGE_TYPE_REVERT);
103			// update metadata
104			if (!$wasRemoved) {
105			$oldmeta = p_read_metadata($id);
106			$meta = array();
107			if ($wasCreated && empty($oldmeta['persistent']['date']['created'])){
108			// newly created
109			$meta['date']['created'] = $created;
110			if ($user){
111			$meta['creator'] = $INFO['userinfo']['name'];
112			$meta['user'] = $user;
113			}
114			} elseif (($wasCreated \|\| $wasReverted) && !empty($oldmeta['persistent']['date']['created'])) {
115			// re-created / restored
116			$meta['date']['created'] = $oldmeta['persistent']['date']['created'];
117			$meta['date']['modified'] = $created; // use the files ctime here
118			$meta['creator'] = $oldmeta['persistent']['creator'];
119			if ($user) $meta['contributor'][$user] = $INFO['userinfo']['name'];
120			} elseif (!$minor) { // non-minor modification
121			$meta['date']['modified'] = $date;
122			if ($user) $meta['contributor'][$user] = $INFO['userinfo']['name'];
123			}
124			$meta['last_change'] = $logline;
125			p_set_metadata($id, $meta);
126			}
127
128			// add changelog lines
129			$logline = implode("\t", $logline)."\n";
130			io_saveFile(metaFN($id,'.changes'),$logline,true); //page changelog
131			io_saveFile($conf['changelog'],$logline,true); //global changelog cache
132			}
133
134			/**
135			* Add's an entry to the media changelog
136			*
137			* @author Michael Hamann <[email protected]>
138			* @author Andreas Gohr <[email protected]>
139			* @author Esther Brunner <[email protected]>
140			* @author Ben Coburn <[email protected]>
141			*
142			* @param int $date Timestamp of the change
143			* @param String $id Name of the affected page
144			* @param String $type Type of the change see DOKU_CHANGE_TYPE_*
145			* @param String $summary Summary of the change
146			* @param mixed $extra In case of a revert the revision (timestmp) of the reverted page
147			* @param array $flags Additional flags in a key value array.
148			* Available flags:
149			* - (none, so far)
150			* @param null\|int $sizechange Change of filesize
151			*/
152			function addMediaLogEntry(
153			$date,
154			$id,
155			$type=DOKU_CHANGE_TYPE_EDIT,
156			$summary='',
157			$extra='',
158			$flags=null,
			0 ignored issues – show Unused Code introduced 2018-04-27 17:13 UTC by Report Bug Copy Issue Report The parameter `$flags` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
159			$sizechange = null)
160			{
161			global $conf;
162			/** @var Input $INPUT */
163			global $INPUT;
164
165			$id = cleanid($id);
166
167			if(!$date) $date = time(); //use current time if none supplied
168			$remote = clientIP(true);
169			$user = $INPUT->server->str('REMOTE_USER');
170			if($sizechange === null) {
171			$sizechange = '';
172			} else {
173			$sizechange = (int) $sizechange;
174			}
175
176			$strip = array("\t", "\n");
177			$logline = array(
178			'date' => $date,
179			'ip' => $remote,
180			'type' => str_replace($strip, '', $type),
181			'id' => $id,
182			'user' => $user,
183			'sum' => utf8_substr(str_replace($strip, '', $summary), 0, 255),
184			'extra' => str_replace($strip, '', $extra),
185			'sizechange' => $sizechange
186			);
187
188			// add changelog lines
189			$logline = implode("\t", $logline)."\n";
190			io_saveFile($conf['media_changelog'],$logline,true); //global media changelog cache
191			io_saveFile(mediaMetaFN($id,'.changes'),$logline,true); //media file's changelog
192			}
193
194			/**
195			* returns an array of recently changed files using the
196			* changelog
197			*
198			* The following constants can be used to control which changes are
199			* included. Add them together as needed.
200			*
201			* RECENTS_SKIP_DELETED - don't include deleted pages
202			* RECENTS_SKIP_MINORS - don't include minor changes
203			* RECENTS_SKIP_SUBSPACES - don't include subspaces
204			* RECENTS_MEDIA_CHANGES - return media changes instead of page changes
205			* RECENTS_MEDIA_PAGES_MIXED - return both media changes and page changes
206			*
207			* @param int $first number of first entry returned (for paginating
208			* @param int $num return $num entries
209			* @param string $ns restrict to given namespace
210			* @param int $flags see above
211			* @return array recently changed files
212			*
213			* @author Ben Coburn <[email protected]>
214			* @author Kate Arzamastseva <[email protected]>
215			*/
216			function getRecents($first,$num,$ns='',$flags=0){
217			global $conf;
218			$recent = array();
219			$count = 0;
220
221			if(!$num)
222			return $recent;
223
224			// read all recent changes. (kept short)
225			if ($flags & RECENTS_MEDIA_CHANGES) {
226			$lines = @file($conf['media_changelog']);
227			} else {
228			$lines = @file($conf['changelog']);
229			}
230			$lines_position = count($lines)-1;
231			$media_lines_position = 0;
232			$media_lines = array();
233
234			if ($flags & RECENTS_MEDIA_PAGES_MIXED) {
235			$media_lines = @file($conf['media_changelog']);
236			$media_lines_position = count($media_lines)-1;
237			}
238
239			$seen = array(); // caches seen lines, _handleRecent() skips them
240
241			// handle lines
242			while ($lines_position >= 0 \|\| (($flags & RECENTS_MEDIA_PAGES_MIXED) && $media_lines_position >=0)) {
243			if (empty($rec) && $lines_position >= 0) {
244			$rec = _handleRecent(@$lines[$lines_position], $ns, $flags, $seen);
245			if (!$rec) {
246			$lines_position --;
247			continue;
248			}
249			}
250			if (($flags & RECENTS_MEDIA_PAGES_MIXED) && empty($media_rec) && $media_lines_position >= 0) {
251			$media_rec = _handleRecent(
252			@$media_lines[$media_lines_position],
253			$ns,
254			$flags \| RECENTS_MEDIA_CHANGES,
255			$seen
256			);
257			if (!$media_rec) {
258			$media_lines_position --;
259			continue;
260			}
261			}
262			if (($flags & RECENTS_MEDIA_PAGES_MIXED) && @$media_rec['date'] >= @$rec['date']) {
263			$media_lines_position--;
264			$x = $media_rec;
			0 ignored issues – show Bug introduced 2015-11-25 07:06 UTC by Report Bug Copy Issue Report The variable `$media_rec` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
265			$x['media'] = true;
266			$media_rec = false;
267			} else {
268			$lines_position--;
269			$x = $rec;
270			if ($flags & RECENTS_MEDIA_CHANGES) $x['media'] = true;
271			$rec = false;
272			}
273			if(--$first >= 0) continue; // skip first entries
274			$recent[] = $x;
275			$count++;
276			// break when we have enough entries
277			if($count >= $num){ break; }
278			}
279			return $recent;
280			}
281
282			/**
283			* returns an array of files changed since a given time using the
284			* changelog
285			*
286			* The following constants can be used to control which changes are
287			* included. Add them together as needed.
288			*
289			* RECENTS_SKIP_DELETED - don't include deleted pages
290			* RECENTS_SKIP_MINORS - don't include minor changes
291			* RECENTS_SKIP_SUBSPACES - don't include subspaces
292			* RECENTS_MEDIA_CHANGES - return media changes instead of page changes
293			*
294			* @param int $from date of the oldest entry to return
295			* @param int $to date of the newest entry to return (for pagination, optional)
296			* @param string $ns restrict to given namespace (optional)
297			* @param int $flags see above (optional)
298			* @return array of files
299			*
300			* @author Michael Hamann <[email protected]>
301			* @author Ben Coburn <[email protected]>
302			*/
303			function getRecentsSince($from,$to=null,$ns='',$flags=0){
304			global $conf;
305			$recent = array();
306
307			if($to && $to < $from)
			0 ignored issues – show Bug Best Practice introduced 2015-11-25 07:06 UTC by Report Bug Copy Issue Report The expression `$to` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
308			return $recent;
309
310			// read all recent changes. (kept short)
311			if ($flags & RECENTS_MEDIA_CHANGES) {
312			$lines = @file($conf['media_changelog']);
313			} else {
314			$lines = @file($conf['changelog']);
315			}
316			if(!$lines) return $recent;
317
318			// we start searching at the end of the list
319			$lines = array_reverse($lines);
320
321			// handle lines
322			$seen = array(); // caches seen lines, _handleRecent() skips them
323
324			foreach($lines as $line){
325			$rec = _handleRecent($line, $ns, $flags, $seen);
326			if($rec !== false) {
327			if ($rec['date'] >= $from) {
328			if (!$to \|\| $rec['date'] <= $to) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-25 07:06 UTC by Report Bug Copy Issue Report The expression `$to` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be zero. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
329			$recent[] = $rec;
330			}
331			} else {
332			break;
333			}
334			}
335			}
336
337			return array_reverse($recent);
338			}
339
340			/**
341			* Internal function used by getRecents
342			*
343			* don't call directly
344			*
345			* @see getRecents()
346			* @author Andreas Gohr <[email protected]>
347			* @author Ben Coburn <[email protected]>
348			*
349			* @param string $line changelog line
350			* @param string $ns restrict to given namespace
351			* @param int $flags flags to control which changes are included
352			* @param array $seen listing of seen pages
353			* @return array\|bool false or array with info about a change
354			*/
355			function _handleRecent($line,$ns,$flags,&$seen){
356			if(empty($line)) return false; //skip empty lines
357
358			// split the line into parts
359			$recent = parseChangelogLine($line);
360			if ($recent===false) { return false; }
361
362			// skip seen ones
363			if(isset($seen[$recent['id']])) return false;
364
365			// skip minors
366			if($recent['type']===DOKU_CHANGE_TYPE_MINOR_EDIT && ($flags & RECENTS_SKIP_MINORS)) return false;
367
368			// remember in seen to skip additional sights
369			$seen[$recent['id']] = 1;
370
371			// check if it's a hidden page
372			if(isHiddenPage($recent['id'])) return false;
373
374			// filter namespace
375			if (($ns) && (strpos($recent['id'],$ns.':') !== 0)) return false;
376
377			// exclude subnamespaces
378			if (($flags & RECENTS_SKIP_SUBSPACES) && (getNS($recent['id']) != $ns)) return false;
379
380			// check ACL
381			if ($flags & RECENTS_MEDIA_CHANGES) {
382			$recent['perms'] = auth_quickaclcheck(getNS($recent['id']).':*');
383			} else {
384			$recent['perms'] = auth_quickaclcheck($recent['id']);
385			}
386			if ($recent['perms'] < AUTH_READ) return false;
387
388			// check existance
389			if($flags & RECENTS_SKIP_DELETED){
390			$fn = (($flags & RECENTS_MEDIA_CHANGES) ? mediaFN($recent['id']) : wikiFN($recent['id']));
391			if(!file_exists($fn)) return false;
392			}
393
394			return $recent;
395			}
396

splitbrain / dokuwiki

Push — psr2 ( 9ddafc...b78f68 )

ChangeLog::retrieveRevisionsAround() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like