DeprecationProxy::getInterface() - Code Metrics - Inspection of "Optimize container" - spiral/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1221)

by Aleksei

created 2025-03-25 22:16 UTC

DeprecationProxy::getInterface() A

↳ Parent: DeprecationProxy

Complexity

Conditions	2
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
dl	0
loc	12
ccs	9
cts	9
cp	1
rs	10
c	1
b	0
f	0
cc	2
nc	1
nop	0
crap	2

<?php

declare(strict_types=1);

namespace Spiral\Core\Config;

/**
 * @internal
 */
final class DeprecationProxy extends Proxy
{
    /**
     * @param class-string $interface

     */
    public function __construct(
        string $interface,
        bool $singleton = false,
        private readonly string|\BackedEnum|null $scope = null,
        private readonly ?string $version = null,
        private readonly ?string $message = null,
    ) {
        if (($scope === null || $version === null) && $message === null) {
            throw new \InvalidArgumentException('Scope and version or custom message must be provided.');
        }

        parent::__construct($interface, $singleton);
    }

    /**
     * @return class-string

     * @internal
     */
    public function getReturnClass(): string
    {
        $message = $this->message ?? \sprintf(
            'Using `%s` outside of the `%s` scope is deprecated and will be impossible in version %s.',
            $this->interface,
            $this->scope instanceof \BackedEnum ? $this->scope->value : $this->scope,

            $this->version,
        );

        @\trigger_error($message, \E_USER_DEPRECATED);

        return parent::getReturnClass();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Spiral\Core\Config;
6
7		/**
8		* @internal
9		*/
10		final class DeprecationProxy extends Proxy
11		{
12		/**
13		* @param class-string $interface
		0 ignored issues – show Documentation Bug introduced 2024-02-15 14:44 UTC by Report Bug Copy Issue Report The doc comment `class-string` at position `0` could not be parsed: Unknown type name 'class-string' at position 0 in class-string. Loading history...
14		*/
15	365	public function __construct(
16		string $interface,
17		bool $singleton = false,
18		private readonly string\|\BackedEnum\|null $scope = null,
19		private readonly ?string $version = null,
20		private readonly ?string $message = null,
21		) {
22	365	if (($scope === null \|\| $version === null) && $message === null) {
23	3	throw new \InvalidArgumentException('Scope and version or custom message must be provided.');
24		}
25
26	362	parent::__construct($interface, $singleton);
27		}
28
29		/**
30		* @return class-string
		0 ignored issues – show Documentation Bug introduced 2024-02-15 14:44 UTC by Report Bug Copy Issue Report The doc comment `class-string` at position `0` could not be parsed: Unknown type name 'class-string' at position 0 in class-string. Loading history...
31		* @internal
32		*/
33	4	public function getReturnClass(): string
34		{
35	4	$message = $this->message ?? \sprintf(
36	4	'Using `%s` outside of the `%s` scope is deprecated and will be impossible in version %s.',
37	4	$this->interface,
38	4	$this->scope instanceof \BackedEnum ? $this->scope->value : $this->scope,
		0 ignored issues – show Bug introduced 2024-04-30 18:11 UTC by Report Bug Copy Issue Report Accessing `value` on the interface `BackedEnum` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
39	4	$this->version,
40	4	);
41
42	4	@\trigger_error($message, \E_USER_DEPRECATED);
43
44	4	return parent::getReturnClass();
45		}
46		}
47

spiral / framework

Pull Request — master (#1221)

DeprecationProxy::getInterface() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like