Passed
Pull Request — master (#384)
by
unknown
04:42
created
src/Scaffolder/tests/Command/AbstractCommandTest.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,11 +24,11 @@
 block discarded – undo
24 24
      */
25 25
     protected function deleteDeclaration(string $class): void
26 26
     {
27
-        if (class_exists($class)) {
28
-            try {
27
+        if (class_exists($class)){
28
+            try{
29 29
                 $reflection = new ReflectionClass($class);
30 30
                 $this->files()->delete($reflection->getFileName());
31
-            } catch (Throwable $exception) {
31
+            }catch (Throwable $exception){
32 32
             }
33 33
         }
34 34
     }
Please login to merge, or discard this patch.
Braces   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,11 +24,15 @@
 block discarded – undo
24 24
      */
25 25
     protected function deleteDeclaration(string $class): void
26 26
     {
27
-        if (class_exists($class)) {
28
-            try {
27
+        if (class_exists($class))
28
+        {
29
+            try
30
+            {
29 31
                 $reflection = new ReflectionClass($class);
30 32
                 $this->files()->delete($reflection->getFileName());
31
-            } catch (Throwable $exception) {
33
+            }
34
+            catch (Throwable $exception)
35
+            {
32 36
             }
33 37
         }
34 38
     }
Please login to merge, or discard this patch.
src/Scaffolder/tests/App/TestApp.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -61,18 +61,18 @@
 block discarded – undo
61 61
      */
62 62
     protected function mapDirectories(array $directories): array
63 63
     {
64
-        if (!isset($directories['root'])) {
64
+        if (!isset($directories['root'])){
65 65
             throw new Boot\Exception\BootException('Missing required directory `root`.');
66 66
         }
67 67
 
68
-        if (!isset($directories['app'])) {
69
-            $directories['app'] = $directories['root'] . '/';
68
+        if (!isset($directories['app'])){
69
+            $directories['app'] = $directories['root'].'/';
70 70
         }
71 71
 
72 72
         return array_merge([
73
-            'vendor'  => $directories['root'] . '/vendor/',
74
-            'runtime' => $directories['root'] . '/runtime/',
75
-            'config'  => $directories['app'] . '/config/'
73
+            'vendor'  => $directories['root'].'/vendor/',
74
+            'runtime' => $directories['root'].'/runtime/',
75
+            'config'  => $directories['app'].'/config/'
76 76
         ], $directories);
77 77
     }
78 78
 }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,11 +61,13 @@
 block discarded – undo
61 61
      */
62 62
     protected function mapDirectories(array $directories): array
63 63
     {
64
-        if (!isset($directories['root'])) {
64
+        if (!isset($directories['root']))
65
+        {
65 66
             throw new Boot\Exception\BootException('Missing required directory `root`.');
66 67
         }
67 68
 
68
-        if (!isset($directories['app'])) {
69
+        if (!isset($directories['app']))
70
+        {
69 71
             $directories['app'] = $directories['root'] . '/';
70 72
         }
71 73
 
Please login to merge, or discard this patch.
src/Scaffolder/tests/App/config/migration.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 declare(strict_types=1);
15 15
 
16 16
 return [
17
-    'directory' => directory('app') . 'migrations/',
17
+    'directory' => directory('app').'migrations/',
18 18
     'database'  => 'runtime',
19 19
     'table'     => 'migrations',
20 20
     'safe'      => env('SPIRAL_ENV') === 'develop'
Please login to merge, or discard this patch.
src/Scaffolder/tests/App/config/database.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
     'connections' => [
34 34
         'runtime' => [
35 35
             'driver'     => SQLiteDriver::class,
36
-            'connection' => 'sqlite:' . directory('runtime') . 'runtime.db',
36
+            'connection' => 'sqlite:'.directory('runtime').'runtime.db',
37 37
             'profiling'  => env('DEBUG', false),
38 38
             'username'   => 'sqlite',
39 39
             'password'   => '',
Please login to merge, or discard this patch.
src/Scaffolder/tests/EntityPHP74Test.php 3 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@  discard block
 block discarded – undo
26 26
     public function testFromEntity(): void
27 27
     {
28 28
         $line = __LINE__;
29
-        $className = __NAMESPACE__ . "\\App\\Request\\Sample{$line}Request";
29
+        $className = __NAMESPACE__."\\App\\Request\\Sample{$line}Request";
30 30
         $output = $this->console()->run('create:filter', [
31
-            'name'     => 'sample' . $line,
31
+            'name'     => 'sample'.$line,
32 32
             '--entity' => SourceEntity74::class
33 33
         ]);
34 34
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 
40 40
         $reflection = new ReflectionClass($className);
41 41
 
42
-        try {
42
+        try{
43 43
             $schema = $reflection->getConstant('SCHEMA');
44 44
             $this->assertSame('data:typedBool', $schema['typedBool']);
45 45
             $this->assertSame('data:noTypeString', $schema['noTypeString']);
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
             $this->assertSame(['notEmpty', 'string'], $validates['obj']);
54 54
             $this->assertSame(['notEmpty', 'integer'], $validates['intFromPhpDoc']);
55 55
             $this->assertSame(['notEmpty', 'float'], $validates['noTypeWithFloatDefault']);
56
-        } finally {
56
+        }finally{
57 57
             $this->deleteDeclaration($className);
58 58
         }
59 59
     }
Please login to merge, or discard this patch.
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,7 +39,8 @@  discard block
 block discarded – undo
39 39
 
40 40
         $reflection = new ReflectionClass($className);
41 41
 
42
-        try {
42
+        try
43
+        {
43 44
             $schema = $reflection->getConstant('SCHEMA');
44 45
             $this->assertSame('data:typedBool', $schema['typedBool']);
45 46
             $this->assertSame('data:noTypeString', $schema['noTypeString']);
@@ -53,7 +54,9 @@  discard block
 block discarded – undo
53 54
             $this->assertSame(['notEmpty', 'string'], $validates['obj']);
54 55
             $this->assertSame(['notEmpty', 'integer'], $validates['intFromPhpDoc']);
55 56
             $this->assertSame(['notEmpty', 'float'], $validates['noTypeWithFloatDefault']);
56
-        } finally {
57
+        }
58
+        finally
59
+        {
57 60
             $this->deleteDeclaration($className);
58 61
         }
59 62
     }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     public function testFromEntity(): void
27 27
     {
28 28
         $line = __LINE__;
29
-        $className = __NAMESPACE__ . "\\App\\Request\\Sample{$line}Request";
29
+        $className = __NAMESPACE__ . "\\App\\Request\\Sample{$line}request";
30 30
         $output = $this->console()->run('create:filter', [
31 31
             'name'     => 'sample' . $line,
32 32
             '--entity' => SourceEntity74::class
Please login to merge, or discard this patch.
src/Annotations/src/AnnotationLocator.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -63,9 +63,9 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public function findClasses(string $annotation): iterable
65 65
     {
66
-        foreach ($this->getTargets() as $target) {
66
+        foreach ($this->getTargets() as $target){
67 67
             $found = $this->reader->getClassAnnotation($target, $annotation);
68
-            if ($found !== null) {
68
+            if ($found !== null){
69 69
                 yield new AnnotatedClass($target, $found);
70 70
             }
71 71
         }
@@ -79,10 +79,10 @@  discard block
 block discarded – undo
79 79
      */
80 80
     public function findMethods(string $annotation): iterable
81 81
     {
82
-        foreach ($this->getTargets() as $target) {
83
-            foreach ($target->getMethods() as $method) {
82
+        foreach ($this->getTargets() as $target){
83
+            foreach ($target->getMethods() as $method){
84 84
                 $found = $this->reader->getMethodAnnotation($method, $annotation);
85
-                if ($found !== null) {
85
+                if ($found !== null){
86 86
                     yield new AnnotatedMethod($method, $found);
87 87
                 }
88 88
             }
@@ -97,10 +97,10 @@  discard block
 block discarded – undo
97 97
      */
98 98
     public function findProperties(string $annotation): iterable
99 99
     {
100
-        foreach ($this->getTargets() as $target) {
101
-            foreach ($target->getProperties() as $property) {
100
+        foreach ($this->getTargets() as $target){
101
+            foreach ($target->getProperties() as $property){
102 102
                 $found = $this->reader->getPropertyAnnotation($property, $annotation);
103
-                if ($found !== null) {
103
+                if ($found !== null){
104 104
                     yield new AnnotatedProperty($property, $found);
105 105
                 }
106 106
             }
@@ -112,12 +112,12 @@  discard block
 block discarded – undo
112 112
      */
113 113
     private function getTargets(): iterable
114 114
     {
115
-        if ($this->targets === []) {
115
+        if ($this->targets === []){
116 116
             yield from $this->classLocator->getClasses();
117 117
             return;
118 118
         }
119 119
 
120
-        foreach ($this->targets as $target) {
120
+        foreach ($this->targets as $target){
121 121
             yield from $this->classLocator->getClasses($target);
122 122
         }
123 123
     }
Please login to merge, or discard this patch.
Braces   +20 added lines, -10 removed lines patch added patch discarded remove patch
@@ -63,9 +63,11 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public function findClasses(string $annotation): iterable
65 65
     {
66
-        foreach ($this->getTargets() as $target) {
66
+        foreach ($this->getTargets() as $target)
67
+        {
67 68
             $found = $this->reader->getClassAnnotation($target, $annotation);
68
-            if ($found !== null) {
69
+            if ($found !== null)
70
+            {
69 71
                 yield new AnnotatedClass($target, $found);
70 72
             }
71 73
         }
@@ -79,10 +81,13 @@  discard block
 block discarded – undo
79 81
      */
80 82
     public function findMethods(string $annotation): iterable
81 83
     {
82
-        foreach ($this->getTargets() as $target) {
83
-            foreach ($target->getMethods() as $method) {
84
+        foreach ($this->getTargets() as $target)
85
+        {
86
+            foreach ($target->getMethods() as $method)
87
+            {
84 88
                 $found = $this->reader->getMethodAnnotation($method, $annotation);
85
-                if ($found !== null) {
89
+                if ($found !== null)
90
+                {
86 91
                     yield new AnnotatedMethod($method, $found);
87 92
                 }
88 93
             }
@@ -97,10 +102,13 @@  discard block
 block discarded – undo
97 102
      */
98 103
     public function findProperties(string $annotation): iterable
99 104
     {
100
-        foreach ($this->getTargets() as $target) {
101
-            foreach ($target->getProperties() as $property) {
105
+        foreach ($this->getTargets() as $target)
106
+        {
107
+            foreach ($target->getProperties() as $property)
108
+            {
102 109
                 $found = $this->reader->getPropertyAnnotation($property, $annotation);
103
-                if ($found !== null) {
110
+                if ($found !== null)
111
+                {
104 112
                     yield new AnnotatedProperty($property, $found);
105 113
                 }
106 114
             }
@@ -112,12 +120,14 @@  discard block
 block discarded – undo
112 120
      */
113 121
     private function getTargets(): iterable
114 122
     {
115
-        if ($this->targets === []) {
123
+        if ($this->targets === [])
124
+        {
116 125
             yield from $this->classLocator->getClasses();
117 126
             return;
118 127
         }
119 128
 
120
-        foreach ($this->targets as $target) {
129
+        foreach ($this->targets as $target)
130
+        {
121 131
             yield from $this->classLocator->getClasses($target);
122 132
         }
123 133
     }
Please login to merge, or discard this patch.
src/Annotations/tests/LocatorTest.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -23,12 +23,12 @@  discard block
 block discarded – undo
23 23
 {
24 24
     public function testLocateClasses()
25 25
     {
26
-        $classes = $this->getLocator(__DIR__ . '/Fixtures')->findClasses(Value::class);
26
+        $classes = $this->getLocator(__DIR__.'/Fixtures')->findClasses(Value::class);
27 27
         $classes = iterator_to_array($classes);
28 28
 
29 29
         $this->assertCount(1, $classes);
30 30
 
31
-        foreach ($classes as $class) {
31
+        foreach ($classes as $class){
32 32
             $this->assertSame(TestClass::class, $class->getClass()->getName());
33 33
             $this->assertSame('abc', $class->getAnnotation()->value);
34 34
         }
@@ -36,12 +36,12 @@  discard block
 block discarded – undo
36 36
 
37 37
     public function testLocateProperties()
38 38
     {
39
-        $props = $this->getLocator(__DIR__ . '/Fixtures')->findProperties(Another::class);
39
+        $props = $this->getLocator(__DIR__.'/Fixtures')->findProperties(Another::class);
40 40
         $props = iterator_to_array($props);
41 41
 
42 42
         $this->assertCount(1, $props);
43 43
 
44
-        foreach ($props as $prop) {
44
+        foreach ($props as $prop){
45 45
             $this->assertSame(TestClass::class, $prop->getClass()->getName());
46 46
             $this->assertSame('name', $prop->getProperty()->getName());
47 47
             $this->assertSame('123', $prop->getAnnotation()->id);
@@ -50,12 +50,12 @@  discard block
 block discarded – undo
50 50
 
51 51
     public function testLocateMethods()
52 52
     {
53
-        $methods = $this->getLocator(__DIR__ . '/Fixtures')->findMethods(Route::class);
53
+        $methods = $this->getLocator(__DIR__.'/Fixtures')->findMethods(Route::class);
54 54
         $methods = iterator_to_array($methods);
55 55
 
56 56
         $this->assertCount(1, $methods);
57 57
 
58
-        foreach ($methods as $m) {
58
+        foreach ($methods as $m){
59 59
             $this->assertSame(TestClass::class, $m->getClass()->getName());
60 60
             $this->assertSame('testMethod', $m->getMethod()->getName());
61 61
             $this->assertSame('/', $m->getAnnotation()->path);
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,7 +28,8 @@  discard block
 block discarded – undo
28 28
 
29 29
         $this->assertCount(1, $classes);
30 30
 
31
-        foreach ($classes as $class) {
31
+        foreach ($classes as $class)
32
+        {
32 33
             $this->assertSame(TestClass::class, $class->getClass()->getName());
33 34
             $this->assertSame('abc', $class->getAnnotation()->value);
34 35
         }
@@ -41,7 +42,8 @@  discard block
 block discarded – undo
41 42
 
42 43
         $this->assertCount(1, $props);
43 44
 
44
-        foreach ($props as $prop) {
45
+        foreach ($props as $prop)
46
+        {
45 47
             $this->assertSame(TestClass::class, $prop->getClass()->getName());
46 48
             $this->assertSame('name', $prop->getProperty()->getName());
47 49
             $this->assertSame('123', $prop->getAnnotation()->id);
@@ -55,7 +57,8 @@  discard block
 block discarded – undo
55 57
 
56 58
         $this->assertCount(1, $methods);
57 59
 
58
-        foreach ($methods as $m) {
60
+        foreach ($methods as $m)
61
+        {
59 62
             $this->assertSame(TestClass::class, $m->getClass()->getName());
60 63
             $this->assertSame('testMethod', $m->getMethod()->getName());
61 64
             $this->assertSame('/', $m->getAnnotation()->path);
Please login to merge, or discard this patch.
src/DataGrid/src/Input/ArrayInput.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,14 +38,14 @@  discard block
 block discarded – undo
38 38
         $input = clone $this;
39 39
 
40 40
         $namespace = trim($namespace);
41
-        if ($namespace === '') {
41
+        if ($namespace === ''){
42 42
             return $input;
43 43
         }
44 44
 
45 45
         $input->data = [];
46 46
 
47 47
         $data = $this->getValue($namespace, []);
48
-        if (is_array($data)) {
48
+        if (is_array($data)){
49 49
             $input->data = $data;
50 50
         }
51 51
 
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
      */
58 58
     public function getValue(string $option, $default = null)
59 59
     {
60
-        if (!$this->hasValue($option)) {
60
+        if (!$this->hasValue($option)){
61 61
             return $default;
62 62
         }
63 63
 
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,14 +38,16 @@  discard block
 block discarded – undo
38 38
         $input = clone $this;
39 39
 
40 40
         $namespace = trim($namespace);
41
-        if ($namespace === '') {
41
+        if ($namespace === '')
42
+        {
42 43
             return $input;
43 44
         }
44 45
 
45 46
         $input->data = [];
46 47
 
47 48
         $data = $this->getValue($namespace, []);
48
-        if (is_array($data)) {
49
+        if (is_array($data))
50
+        {
49 51
             $input->data = $data;
50 52
         }
51 53
 
@@ -57,7 +59,8 @@  discard block
 block discarded – undo
57 59
      */
58 60
     public function getValue(string $option, $default = null)
59 61
     {
60
-        if (!$this->hasValue($option)) {
62
+        if (!$this->hasValue($option))
63
+        {
61 64
             return $default;
62 65
         }
63 66
 
Please login to merge, or discard this patch.
src/DataGrid/src/GridSchema.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function addFilter(string $name, FilterInterface $filter): void
42 42
     {
43
-        if ($this->hasFilter($name)) {
43
+        if ($this->hasFilter($name)){
44 44
             throw new SchemaException("Filter `$name` is already defined");
45 45
         }
46 46
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function getFilter(string $name): FilterInterface
67 67
     {
68
-        if (!$this->hasFilter($name)) {
68
+        if (!$this->hasFilter($name)){
69 69
             throw new SchemaException("No such filter `$name`");
70 70
         }
71 71
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
      */
90 90
     public function addSorter(string $name, SorterInterface $sorter): void
91 91
     {
92
-        if ($this->hasSorter($name)) {
92
+        if ($this->hasSorter($name)){
93 93
             throw new SchemaException("Sorter `$name` is already defined");
94 94
         }
95 95
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function getSorter(string $name): SorterInterface
116 116
     {
117
-        if (!$this->hasSorter($name)) {
117
+        if (!$this->hasSorter($name)){
118 118
             throw new SchemaException("No such sorter `$name`");
119 119
         }
120 120
 
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,8 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function addFilter(string $name, FilterInterface $filter): void
42 42
     {
43
-        if ($this->hasFilter($name)) {
43
+        if ($this->hasFilter($name))
44
+        {
44 45
             throw new SchemaException("Filter `$name` is already defined");
45 46
         }
46 47
 
@@ -65,7 +66,8 @@  discard block
 block discarded – undo
65 66
      */
66 67
     public function getFilter(string $name): FilterInterface
67 68
     {
68
-        if (!$this->hasFilter($name)) {
69
+        if (!$this->hasFilter($name))
70
+        {
69 71
             throw new SchemaException("No such filter `$name`");
70 72
         }
71 73
 
@@ -89,7 +91,8 @@  discard block
 block discarded – undo
89 91
      */
90 92
     public function addSorter(string $name, SorterInterface $sorter): void
91 93
     {
92
-        if ($this->hasSorter($name)) {
94
+        if ($this->hasSorter($name))
95
+        {
93 96
             throw new SchemaException("Sorter `$name` is already defined");
94 97
         }
95 98
 
@@ -114,7 +117,8 @@  discard block
 block discarded – undo
114 117
      */
115 118
     public function getSorter(string $name): SorterInterface
116 119
     {
117
-        if (!$this->hasSorter($name)) {
120
+        if (!$this->hasSorter($name))
121
+        {
118 122
             throw new SchemaException("No such sorter `$name`");
119 123
         }
120 124
 
Please login to merge, or discard this patch.