Passed
Pull Request — master (#357)
by Valentin
06:06 queued 01:39
created
src/Translator/tests/ManagerTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
         $cache->shouldReceive('setLocales')->andReturn(null);
32 32
 
33 33
         $manager = new CatalogueManager(new CatalogueLoader(new TranslatorConfig([
34
-                'directory' => __DIR__ . '/fixtures/locales/',
34
+                'directory' => __DIR__.'/fixtures/locales/',
35 35
                 'loaders'   => [
36 36
                     'php' => PhpFileLoader::class,
37 37
                     'po'  => PoFileLoader::class,
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         $cache->shouldNotReceive('setLocales')->andReturn(null);
50 50
 
51 51
         $manager = new CatalogueManager(new CatalogueLoader(new TranslatorConfig([
52
-                'directory' => __DIR__ . '/fixtures/locales/',
52
+                'directory' => __DIR__.'/fixtures/locales/',
53 53
                 'loaders'   => [
54 54
                     'php' => PhpFileLoader::class,
55 55
                     'po'  => PoFileLoader::class,
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         $cache->shouldReceive('getLocales')->andReturn(['en', 'ru']);
67 67
 
68 68
         $manager = new CatalogueManager(new CatalogueLoader(new TranslatorConfig([
69
-                'directory' => __DIR__ . '/fixtures/locales/',
69
+                'directory' => __DIR__.'/fixtures/locales/',
70 70
                 'loaders'   => [
71 71
                     'php' => PhpFileLoader::class,
72 72
                     'po'  => PoFileLoader::class,
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
         ]);
130 130
 
131 131
         $manager = new CatalogueManager(new CatalogueLoader(new TranslatorConfig([
132
-                'directory' => __DIR__ . '/fixtures/locales/',
132
+                'directory' => __DIR__.'/fixtures/locales/',
133 133
                 'loaders'   => [
134 134
                     'php' => PhpFileLoader::class,
135 135
                     'po'  => PoFileLoader::class,
Please login to merge, or discard this patch.
src/Validation/src/Validator.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $value = $this->data[$field] ?? $default;
77 77
 
78
-        if (is_object($value) && method_exists($value, 'getValue')) {
78
+        if (is_object($value) && method_exists($value, 'getValue')){
79 79
             return $value->getValue();
80 80
         }
81 81
 
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      */
88 88
     public function hasValue(string $field): bool
89 89
     {
90
-        if (is_array($this->data)) {
90
+        if (is_array($this->data)){
91 91
             return array_key_exists($field, $this->data);
92 92
         }
93 93
 
@@ -151,30 +151,30 @@  discard block
 block discarded – undo
151 151
      */
152 152
     protected function validate(): void
153 153
     {
154
-        if ($this->errors !== []) {
154
+        if ($this->errors !== []){
155 155
             // already validated
156 156
             return;
157 157
         }
158 158
 
159 159
         $this->errors = [];
160 160
 
161
-        foreach ($this->rules as $field => $rules) {
161
+        foreach ($this->rules as $field => $rules){
162 162
             $hasValue = $this->hasValue($field);
163 163
             $value = $this->getValue($field);
164 164
 
165
-            foreach ($this->provider->getRules($rules) as $rule) {
166
-                if (!$hasValue && $rule->ignoreEmpty($value) && !$rule->hasConditions()) {
165
+            foreach ($this->provider->getRules($rules) as $rule){
166
+                if (!$hasValue && $rule->ignoreEmpty($value) && !$rule->hasConditions()){
167 167
                     continue;
168 168
                 }
169 169
 
170
-                foreach ($rule->getConditions() as $condition) {
171
-                    if (!$condition->isMet($this, $field, $value)) {
170
+                foreach ($rule->getConditions() as $condition){
171
+                    if (!$condition->isMet($this, $field, $value)){
172 172
                         // condition is not met, skipping validation
173 173
                         continue 2;
174 174
                     }
175 175
                 }
176 176
 
177
-                if (!$rule->validate($this, $field, $value)) {
177
+                if (!$rule->validate($this, $field, $value)){
178 178
                     // got error, jump to next field
179 179
                     $this->errors[$field] = $rule->getMessage($field, $value);
180 180
                     break;
Please login to merge, or discard this patch.
Braces   +18 added lines, -9 removed lines patch added patch discarded remove patch
@@ -75,7 +75,8 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $value = $this->data[$field] ?? $default;
77 77
 
78
-        if (is_object($value) && method_exists($value, 'getValue')) {
78
+        if (is_object($value) && method_exists($value, 'getValue'))
79
+        {
79 80
             return $value->getValue();
80 81
         }
81 82
 
@@ -87,7 +88,8 @@  discard block
 block discarded – undo
87 88
      */
88 89
     public function hasValue(string $field): bool
89 90
     {
90
-        if (is_array($this->data)) {
91
+        if (is_array($this->data))
92
+        {
91 93
             return array_key_exists($field, $this->data);
92 94
         }
93 95
 
@@ -151,30 +153,37 @@  discard block
 block discarded – undo
151 153
      */
152 154
     protected function validate(): void
153 155
     {
154
-        if ($this->errors !== []) {
156
+        if ($this->errors !== [])
157
+        {
155 158
             // already validated
156 159
             return;
157 160
         }
158 161
 
159 162
         $this->errors = [];
160 163
 
161
-        foreach ($this->rules as $field => $rules) {
164
+        foreach ($this->rules as $field => $rules)
165
+        {
162 166
             $hasValue = $this->hasValue($field);
163 167
             $value = $this->getValue($field);
164 168
 
165
-            foreach ($this->provider->getRules($rules) as $rule) {
166
-                if (!$hasValue && $rule->ignoreEmpty($value) && !$rule->hasConditions()) {
169
+            foreach ($this->provider->getRules($rules) as $rule)
170
+            {
171
+                if (!$hasValue && $rule->ignoreEmpty($value) && !$rule->hasConditions())
172
+                {
167 173
                     continue;
168 174
                 }
169 175
 
170
-                foreach ($rule->getConditions() as $condition) {
171
-                    if (!$condition->isMet($this, $field, $value)) {
176
+                foreach ($rule->getConditions() as $condition)
177
+                {
178
+                    if (!$condition->isMet($this, $field, $value))
179
+                    {
172 180
                         // condition is not met, skipping validation
173 181
                         continue 2;
174 182
                     }
175 183
                 }
176 184
 
177
-                if (!$rule->validate($this, $field, $value)) {
185
+                if (!$rule->validate($this, $field, $value))
186
+                {
178 187
                     // got error, jump to next field
179 188
                     $this->errors[$field] = $rule->getMessage($field, $value);
180 189
                     break;
Please login to merge, or discard this patch.
src/Validation/src/CallableRule.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
      */
74 74
     public function getMessage(string $field, $value): string
75 75
     {
76
-        if (!empty($this->message)) {
76
+        if (!empty($this->message)){
77 77
             return Translator::interpolate(
78 78
                 $this->message,
79 79
                 array_merge([$value, $field], $this->args)
@@ -81,13 +81,13 @@  discard block
 block discarded – undo
81 81
         }
82 82
 
83 83
         $name = $this->check;
84
-        if (is_array($name) && isset($name[0], $name[1])) {
84
+        if (is_array($name) && isset($name[0], $name[1])){
85 85
             $name = sprintf(
86 86
                 '%s::%s',
87 87
                 is_object($name[0]) ? get_class($name[0]) : $name,
88 88
                 $name[1]
89 89
             );
90
-        } elseif (!is_string($name)) {
90
+        } elseif (!is_string($name)){
91 91
             $name = '~user-defined~';
92 92
         }
93 93
 
Please login to merge, or discard this patch.
Braces   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -73,7 +73,8 @@  discard block
 block discarded – undo
73 73
      */
74 74
     public function getMessage(string $field, $value): string
75 75
     {
76
-        if (!empty($this->message)) {
76
+        if (!empty($this->message))
77
+        {
77 78
             return Translator::interpolate(
78 79
                 $this->message,
79 80
                 array_merge([$value, $field], $this->args)
@@ -81,13 +82,16 @@  discard block
 block discarded – undo
81 82
         }
82 83
 
83 84
         $name = $this->check;
84
-        if (is_array($name) && isset($name[0], $name[1])) {
85
+        if (is_array($name) && isset($name[0], $name[1]))
86
+        {
85 87
             $name = sprintf(
86 88
                 '%s::%s',
87 89
                 is_object($name[0]) ? get_class($name[0]) : $name,
88 90
                 $name[1]
89 91
             );
90
-        } elseif (!is_string($name)) {
92
+        }
93
+        elseif (!is_string($name))
94
+        {
91 95
             $name = '~user-defined~';
92 96
         }
93 97
 
Please login to merge, or discard this patch.
src/Validation/src/AbstractRule.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,11 +40,11 @@
 block discarded – undo
40 40
      */
41 41
     public function getConditions(): \Generator
42 42
     {
43
-        if (empty($this->conditions)) {
43
+        if (empty($this->conditions)){
44 44
             return;
45 45
         }
46 46
 
47
-        foreach ($this->conditions as $condition) {
47
+        foreach ($this->conditions as $condition){
48 48
             yield $condition->withOptions($this->conditions->offsetGet($condition));
49 49
         }
50 50
     }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,11 +40,13 @@
 block discarded – undo
40 40
      */
41 41
     public function getConditions(): \Generator
42 42
     {
43
-        if (empty($this->conditions)) {
43
+        if (empty($this->conditions))
44
+        {
44 45
             return;
45 46
         }
46 47
 
47
-        foreach ($this->conditions as $condition) {
48
+        foreach ($this->conditions as $condition)
49
+        {
48 50
             yield $condition->withOptions($this->conditions->offsetGet($condition));
49 51
         }
50 52
     }
Please login to merge, or discard this patch.
src/Validation/src/ValidationProvider.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         ValidatorConfig $config,
42 42
         ParserInterface $parser = null,
43 43
         FactoryInterface $factory = null
44
-    ) {
44
+    ){
45 45
         $this->config = $config;
46 46
         $this->parser = $parser ?? new RuleParser();
47 47
         $this->factory = $factory ?? new Container();
@@ -78,14 +78,14 @@  discard block
 block discarded – undo
78 78
      */
79 79
     public function getRules($rules): \Generator
80 80
     {
81
-        foreach ($this->parser->split($rules) as $id => $rule) {
82
-            if (empty($id) || $rule instanceof \Closure) {
81
+        foreach ($this->parser->split($rules) as $id => $rule){
82
+            if (empty($id) || $rule instanceof \Closure){
83 83
                 yield new CallableRule($rule);
84 84
                 continue;
85 85
             }
86 86
 
87 87
             // fetch from cache
88
-            if (isset($this->rules[$id])) {
88
+            if (isset($this->rules[$id])){
89 89
                 yield $this->rules[$id];
90 90
                 continue;
91 91
             }
@@ -126,17 +126,17 @@  discard block
 block discarded – undo
126 126
         $args = $this->parser->parseArgs($rule);
127 127
         $message = $this->parser->parseMessage($rule);
128 128
 
129
-        if (!is_array($check)) {
129
+        if (!is_array($check)){
130 130
             return new CallableRule($check, $args, $message);
131 131
         }
132 132
 
133
-        if (is_string($check[0]) && $this->config->hasChecker($check[0])) {
133
+        if (is_string($check[0]) && $this->config->hasChecker($check[0])){
134 134
             $check[0] = $this->config->getChecker($check[0])->resolve($this->factory);
135 135
 
136 136
             return new CheckerRule($check[0], $check[1], $args, $message);
137 137
         }
138 138
 
139
-        if (!is_object($check[0])) {
139
+        if (!is_object($check[0])){
140 140
             $check[0] = (new Autowire($check[0]))->resolve($this->factory);
141 141
         }
142 142
 
@@ -151,17 +151,17 @@  discard block
 block discarded – undo
151 151
      */
152 152
     protected function makeConditions(array $conditions): ?\SplObjectStorage
153 153
     {
154
-        if (empty($conditions)) {
154
+        if (empty($conditions)){
155 155
             return null;
156 156
         }
157 157
 
158 158
         $storage = new \SplObjectStorage();
159
-        foreach ($conditions as $condition => $options) {
159
+        foreach ($conditions as $condition => $options){
160 160
             $condition = $this->config->resolveAlias($condition);
161 161
 
162
-            if ($this->config->hasCondition($condition)) {
162
+            if ($this->config->hasCondition($condition)){
163 163
                 $autowire = $this->config->getCondition($condition);
164
-            } else {
164
+            }else{
165 165
                 $autowire = new Autowire($condition);
166 166
             }
167 167
 
Please login to merge, or discard this patch.
Braces   +21 added lines, -10 removed lines patch added patch discarded remove patch
@@ -78,14 +78,17 @@  discard block
 block discarded – undo
78 78
      */
79 79
     public function getRules($rules): \Generator
80 80
     {
81
-        foreach ($this->parser->split($rules) as $id => $rule) {
82
-            if (empty($id) || $rule instanceof \Closure) {
81
+        foreach ($this->parser->split($rules) as $id => $rule)
82
+        {
83
+            if (empty($id) || $rule instanceof \Closure)
84
+            {
83 85
                 yield new CallableRule($rule);
84 86
                 continue;
85 87
             }
86 88
 
87 89
             // fetch from cache
88
-            if (isset($this->rules[$id])) {
90
+            if (isset($this->rules[$id]))
91
+            {
89 92
                 yield $this->rules[$id];
90 93
                 continue;
91 94
             }
@@ -126,17 +129,20 @@  discard block
 block discarded – undo
126 129
         $args = $this->parser->parseArgs($rule);
127 130
         $message = $this->parser->parseMessage($rule);
128 131
 
129
-        if (!is_array($check)) {
132
+        if (!is_array($check))
133
+        {
130 134
             return new CallableRule($check, $args, $message);
131 135
         }
132 136
 
133
-        if (is_string($check[0]) && $this->config->hasChecker($check[0])) {
137
+        if (is_string($check[0]) && $this->config->hasChecker($check[0]))
138
+        {
134 139
             $check[0] = $this->config->getChecker($check[0])->resolve($this->factory);
135 140
 
136 141
             return new CheckerRule($check[0], $check[1], $args, $message);
137 142
         }
138 143
 
139
-        if (!is_object($check[0])) {
144
+        if (!is_object($check[0]))
145
+        {
140 146
             $check[0] = (new Autowire($check[0]))->resolve($this->factory);
141 147
         }
142 148
 
@@ -151,17 +157,22 @@  discard block
 block discarded – undo
151 157
      */
152 158
     protected function makeConditions(array $conditions): ?\SplObjectStorage
153 159
     {
154
-        if (empty($conditions)) {
160
+        if (empty($conditions))
161
+        {
155 162
             return null;
156 163
         }
157 164
 
158 165
         $storage = new \SplObjectStorage();
159
-        foreach ($conditions as $condition => $options) {
166
+        foreach ($conditions as $condition => $options)
167
+        {
160 168
             $condition = $this->config->resolveAlias($condition);
161 169
 
162
-            if ($this->config->hasCondition($condition)) {
170
+            if ($this->config->hasCondition($condition))
171
+            {
163 172
                 $autowire = $this->config->getCondition($condition);
164
-            } else {
173
+            }
174
+            else
175
+            {
165 176
                 $autowire = new Autowire($condition);
166 177
             }
167 178
 
Please login to merge, or discard this patch.
src/Validation/src/Checker/TypeChecker.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,11 +69,11 @@
 block discarded – undo
69 69
      */
70 70
     public function datetime($value): bool
71 71
     {
72
-        if (!is_scalar($value)) {
72
+        if (!is_scalar($value)){
73 73
             return false;
74 74
         }
75 75
 
76
-        if (is_numeric($value)) {
76
+        if (is_numeric($value)){
77 77
             return true;
78 78
         }
79 79
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,11 +69,13 @@
 block discarded – undo
69 69
      */
70 70
     public function datetime($value): bool
71 71
     {
72
-        if (!is_scalar($value)) {
72
+        if (!is_scalar($value))
73
+        {
73 74
             return false;
74 75
         }
75 76
 
76
-        if (is_numeric($value)) {
77
+        if (is_numeric($value))
78
+        {
77 79
             return true;
78 80
         }
79 81
 
Please login to merge, or discard this patch.
src/Validation/src/Checker/FileChecker.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
      */
79 79
     public function size($file, int $size): bool
80 80
     {
81
-        if (empty($filename = $this->resolveFilename($file))) {
81
+        if (empty($filename = $this->resolveFilename($file))){
82 82
             return false;
83 83
         }
84 84
 
@@ -96,11 +96,11 @@  discard block
 block discarded – undo
96 96
      */
97 97
     public function extension($file, $extensions): bool
98 98
     {
99
-        if (!is_array($extensions)) {
99
+        if (!is_array($extensions)){
100 100
             $extensions = array_slice(func_get_args(), 1);
101 101
         }
102 102
 
103
-        if ($file instanceof UploadedFileInterface) {
103
+        if ($file instanceof UploadedFileInterface){
104 104
             return in_array(
105 105
                 $this->files->extension($file->getClientFilename()),
106 106
                 $extensions,
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -78,7 +78,8 @@  discard block
 block discarded – undo
78 78
      */
79 79
     public function size($file, int $size): bool
80 80
     {
81
-        if (empty($filename = $this->resolveFilename($file))) {
81
+        if (empty($filename = $this->resolveFilename($file)))
82
+        {
82 83
             return false;
83 84
         }
84 85
 
@@ -96,11 +97,13 @@  discard block
 block discarded – undo
96 97
      */
97 98
     public function extension($file, $extensions): bool
98 99
     {
99
-        if (!is_array($extensions)) {
100
+        if (!is_array($extensions))
101
+        {
100 102
             $extensions = array_slice(func_get_args(), 1);
101 103
         }
102 104
 
103
-        if ($file instanceof UploadedFileInterface) {
105
+        if ($file instanceof UploadedFileInterface)
106
+        {
104 107
             return in_array(
105 108
                 $this->files->extension($file->getClientFilename()),
106 109
                 $extensions,
Please login to merge, or discard this patch.
src/Validation/src/Checker/ImageChecker.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -90,15 +90,15 @@  discard block
 block discarded – undo
90 90
     public function type($file, $types): bool
91 91
     {
92 92
         $image = $this->imageData($file);
93
-        if ($image === false) {
93
+        if ($image === false){
94 94
             return false;
95 95
         }
96 96
 
97
-        if (!is_array($types)) {
97
+        if (!is_array($types)){
98 98
             $types = array_slice(func_get_args(), 1);
99 99
         }
100 100
 
101
-        if (!isset(self::IMAGE_TYPES[$image[self::IMAGE_TYPE]])) {
101
+        if (!isset(self::IMAGE_TYPES[$image[self::IMAGE_TYPE]])){
102 102
             return false;
103 103
         }
104 104
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
      */
127 127
     public function smaller($file, int $width, int $height): bool
128 128
     {
129
-        if (empty($image = $this->imageData($file))) {
129
+        if (empty($image = $this->imageData($file))){
130 130
             return false;
131 131
         }
132 132
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
      */
145 145
     public function bigger($file, int $width, int $height = null): bool
146 146
     {
147
-        if (empty($image = $this->imageData($file))) {
147
+        if (empty($image = $this->imageData($file))){
148 148
             return false;
149 149
         }
150 150
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
     protected function imageData($file)
163 163
     {
164 164
         $filename = $this->resolveFilename($file);
165
-        if (empty($filename)) {
165
+        if (empty($filename)){
166 166
             return false;
167 167
         }
168 168
 
Please login to merge, or discard this patch.
Braces   +12 added lines, -6 removed lines patch added patch discarded remove patch
@@ -90,15 +90,18 @@  discard block
 block discarded – undo
90 90
     public function type($file, $types): bool
91 91
     {
92 92
         $image = $this->imageData($file);
93
-        if ($image === false) {
93
+        if ($image === false)
94
+        {
94 95
             return false;
95 96
         }
96 97
 
97
-        if (!is_array($types)) {
98
+        if (!is_array($types))
99
+        {
98 100
             $types = array_slice(func_get_args(), 1);
99 101
         }
100 102
 
101
-        if (!isset(self::IMAGE_TYPES[$image[self::IMAGE_TYPE]])) {
103
+        if (!isset(self::IMAGE_TYPES[$image[self::IMAGE_TYPE]]))
104
+        {
102 105
             return false;
103 106
         }
104 107
 
@@ -126,7 +129,8 @@  discard block
 block discarded – undo
126 129
      */
127 130
     public function smaller($file, int $width, int $height): bool
128 131
     {
129
-        if (empty($image = $this->imageData($file))) {
132
+        if (empty($image = $this->imageData($file)))
133
+        {
130 134
             return false;
131 135
         }
132 136
 
@@ -144,7 +148,8 @@  discard block
 block discarded – undo
144 148
      */
145 149
     public function bigger($file, int $width, int $height = null): bool
146 150
     {
147
-        if (empty($image = $this->imageData($file))) {
151
+        if (empty($image = $this->imageData($file)))
152
+        {
148 153
             return false;
149 154
         }
150 155
 
@@ -162,7 +167,8 @@  discard block
 block discarded – undo
162 167
     protected function imageData($file)
163 168
     {
164 169
         $filename = $this->resolveFilename($file);
165
-        if (empty($filename)) {
170
+        if (empty($filename))
171
+        {
166 172
             return false;
167 173
         }
168 174
 
Please login to merge, or discard this patch.
src/Validation/src/Checker/Traits/NotEmptyTrait.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      */
26 26
     public function notEmpty($value, bool $asString = true): bool
27 27
     {
28
-        if ($asString && is_string($value) && trim($value) === '') {
28
+        if ($asString && is_string($value) && trim($value) === ''){
29 29
             return false;
30 30
         }
31 31
 
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@
 block discarded – undo
25 25
      */
26 26
     public function notEmpty($value, bool $asString = true): bool
27 27
     {
28
-        if ($asString && is_string($value) && trim($value) === '') {
28
+        if ($asString && is_string($value) && trim($value) === '')
29
+        {
29 30
             return false;
30 31
         }
31 32
 
Please login to merge, or discard this patch.