Inspection of "Apply Spiral code style" - spiral/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1207)

by Aleksei

created 2025-01-24 08:09 UTC

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -34,9 +34,9 @@
 block discarded – undo
 
         self::assertSame($expected, $enum);
 
-        if ($enum === DebugMode::Enabled) {
+        if ($enum === DebugMode::Enabled){
             self::assertTrue($enum->isEnabled());
-        } else {
+        }else{
             self::assertFalse($enum->isEnabled());
         }
     }

Please login to merge, or discard this patch.

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -34,9 +34,12 @@
 block discarded – undo
 
         self::assertSame($expected, $enum);
 
-        if ($enum === DebugMode::Enabled) {
+        if ($enum === DebugMode::Enabled)
+        {
             self::assertTrue($enum->isEnabled());
-        } else {
+        }
+        else
+        {
             self::assertFalse($enum->isEnabled());
         }
     }

Please login to merge, or discard this patch.

src/Boot/tests/FunctionsTest.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
     {
         $core = TestCore::create([
             'root'   => __DIR__,
-            'config' => __DIR__ . '/config',
+            'config' => __DIR__.'/config',
         ])->run();
 
         /** @var ContainerInterface $c */
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
     {
         $core = TestCore::create([
             'root'   => __DIR__,
-            'config' => __DIR__ . '/config',
+            'config' => __DIR__.'/config',
         ])->run(new Environment([
             'key' => '(true)',
         ]));
@@ -50,14 +50,14 @@  discard block
 block discarded – undo
     {
         $core = TestCore::create([
             'root'   => __DIR__,
-            'config' => __DIR__ . '/config',
+            'config' => __DIR__.'/config',
         ])->run();
 
         /** @var ContainerInterface $c */
         $c = $core->getContainer();
 
         ContainerScope::runScope($c, function (): void {
-            $this->assertDir(__DIR__ . '/config', directory('config'));
+            $this->assertDir(__DIR__.'/config', directory('config'));
         });
     }
 
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
 
         $core = TestCore::create([
             'root'   => __DIR__,
-            'config' => __DIR__ . '/config',
+            'config' => __DIR__.'/config',
         ])->run();
 
         /** @var ContainerInterface $c */
@@ -102,6 +102,6 @@  discard block
 block discarded – undo
     private function assertDir($path, $value): void
     {
         $path = str_replace(['\\', '//'], '/', $path);
-        self::assertSame(rtrim($path, '/') . '/', $value);
+        self::assertSame(rtrim($path, '/').'/', $value);
     }
 }

Please login to merge, or discard this patch.

src/Boot/tests/DirectoriesTest.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -25,15 +25,15 @@  discard block
 block discarded – undo
 
         $this->assertDir(__DIR__, $dirs->get('root'));
 
-        $this->assertDir(__DIR__ . '/app', $dirs->get('app'));
+        $this->assertDir(__DIR__.'/app', $dirs->get('app'));
 
-        $this->assertDir(__DIR__ . '/public', $dirs->get('public'));
+        $this->assertDir(__DIR__.'/public', $dirs->get('public'));
 
-        $this->assertDir(__DIR__ . '/app/config', $dirs->get('config'));
-        $this->assertDir(__DIR__ . '/app/resources', $dirs->get('resources'));
+        $this->assertDir(__DIR__.'/app/config', $dirs->get('config'));
+        $this->assertDir(__DIR__.'/app/resources', $dirs->get('resources'));
 
-        $this->assertDir(__DIR__ . '/runtime', $dirs->get('runtime'));
-        $this->assertDir(__DIR__ . '/runtime/cache', $dirs->get('cache'));
+        $this->assertDir(__DIR__.'/runtime', $dirs->get('runtime'));
+        $this->assertDir(__DIR__.'/runtime/cache', $dirs->get('cache'));
     }
 
     public function testKernelException(): void
@@ -94,6 +94,6 @@  discard block
 block discarded – undo
     private function assertDir($path, $value): void
     {
         $path = str_replace(['\\', '//'], '/', $path);
-        self::assertSame(rtrim($path, '/') . '/', $value);
+        self::assertSame(rtrim($path, '/').'/', $value);
     }
 }

Please login to merge, or discard this patch.

src/Files/tests/InformationTest.php 2 patches

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
     public function testTime(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         $files->write($filename, 'data', FilesInterface::READONLY);
         self::assertEquals(filemtime($filename), $files->time($filename));
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
         $this->expectException(FileNotFoundException::class);
 
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         $files->time($filename);
     }
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
     public function testMD5(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         $files->write($filename, 'data');
         self::assertEquals(md5_file($filename), $files->md5($filename));
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
         $this->expectException(FileNotFoundException::class);
 
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         $files->md5($filename);
     }
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
     public function testExists(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
         self::assertSame(file_exists($filename), $files->exists($filename));
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
     public function testSize(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
         $files->write($filename, 'some-data-string');
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
         $this->expectException(FileNotFoundException::class);
 
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
         $files->size($filename);
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
     public function testLocalUri(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
         $files->write($filename, 'data');
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
     public function testIsFile(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
         $files->write($filename, 'data');
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
     public function testIsMissingFile(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
     public function testIsDirectory(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . '/directory/';
+        $directory = self::FIXTURE_DIRECTORY.'/directory/';
 
         self::assertFalse($files->exists($directory));
         $files->ensureDirectory($directory);
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
     public function testIsMissingDirectory(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . '/directory/';
+        $directory = self::FIXTURE_DIRECTORY.'/directory/';
 
         self::assertFalse($files->exists($directory));
 
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
     public function testIsDirectoryNoSlash(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . '/directory';
+        $directory = self::FIXTURE_DIRECTORY.'/directory';
 
         self::assertFalse($files->exists($directory));
         $files->ensureDirectory($directory);

Please login to merge, or discard this patch.

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@
 block discarded – undo
         $files = new Files();
         $filename = self::FIXTURE_DIRECTORY . '/test.txt';
 
-        $files->write($filename, 'data', FilesInterface::READONLY);
+        $files->write($filename, 'data', FilesInterface::readonly);
         self::assertEquals(filemtime($filename), $files->time($filename));
     }
 

Please login to merge, or discard this patch.

src/Files/tests/DirectoriesTest.php 2 patches

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
     public function testEnsureDirectory(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . 'directory/';
+        $directory = self::FIXTURE_DIRECTORY.'directory/';
 
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
     public function testEnsureExistedDirectory(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . 'directory/';
+        $directory = self::FIXTURE_DIRECTORY.'directory/';
 
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
     public function testEnsureNestedDirectory(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . 'directory/sub/other';
+        $directory = self::FIXTURE_DIRECTORY.'directory/sub/other';
 
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
     public function testEnsureNestedDirectoryNoRecursivePermissions(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . 'directory/sub/other';
+        $directory = self::FIXTURE_DIRECTORY.'directory/sub/other';
 
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
@@ -86,14 +86,14 @@  discard block
 block discarded – undo
     public function testEnsureExistedNestedDirectory(): void
     {
         $files = new Files();
-        $directory = self::FIXTURE_DIRECTORY . 'directory/sub/other';
+        $directory = self::FIXTURE_DIRECTORY.'directory/sub/other';
 
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
 
-        mkdir(self::FIXTURE_DIRECTORY . 'directory');
-        mkdir(self::FIXTURE_DIRECTORY . 'directory/sub');
-        mkdir(self::FIXTURE_DIRECTORY . 'directory/sub/other');
+        mkdir(self::FIXTURE_DIRECTORY.'directory');
+        mkdir(self::FIXTURE_DIRECTORY.'directory/sub');
+        mkdir(self::FIXTURE_DIRECTORY.'directory/sub/other');
 
         self::assertTrue($files->exists($directory));
         self::assertTrue($files->isDirectory($directory));
@@ -107,13 +107,13 @@  discard block
 block discarded – undo
     public function testDeleteDirectoryContent(): void
     {
         $files = new Files();
-        $baseDirectory = self::FIXTURE_DIRECTORY . 'directory/';
-        $directory = $baseDirectory . 'sub/other';
+        $baseDirectory = self::FIXTURE_DIRECTORY.'directory/';
+        $directory = $baseDirectory.'sub/other';
 
         $filenames = [
-            $baseDirectory . 'test.file',
-            $directory . 'other.file',
-            $directory . '.sample',
+            $baseDirectory.'test.file',
+            $directory.'other.file',
+            $directory.'.sample',
         ];
 
         self::assertFalse($files->exists($baseDirectory));
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
         self::assertTrue($files->exists($directory));
         self::assertTrue($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename){
             self::assertFalse($files->exists($filename));
             $files->write($filename, 'random-data');
             self::assertTrue($files->exists($filename));
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename){
             self::assertFalse($files->exists($filename));
         }
     }
@@ -152,13 +152,13 @@  discard block
 block discarded – undo
     public function testDeleteDirectory(): void
     {
         $files = new Files();
-        $baseDirectory = self::FIXTURE_DIRECTORY . 'directory/';
-        $directory = $baseDirectory . 'sub/other';
+        $baseDirectory = self::FIXTURE_DIRECTORY.'directory/';
+        $directory = $baseDirectory.'sub/other';
 
         $filenames = [
-            $baseDirectory . 'test.file',
-            $directory . 'other.file',
-            $directory . '.sample',
+            $baseDirectory.'test.file',
+            $directory.'other.file',
+            $directory.'.sample',
         ];
 
         self::assertFalse($files->exists($baseDirectory));
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
         self::assertTrue($files->exists($directory));
         self::assertTrue($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename){
             self::assertFalse($files->exists($filename));
             $files->write($filename, 'random-data');
             self::assertTrue($files->exists($filename));
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename){
             self::assertFalse($files->exists($filename));
         }
     }
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
 
         $files = new Files();
 
-        $files->write(self::FIXTURE_DIRECTORY . 'test', 'data');
-        $files->deleteDirectory(self::FIXTURE_DIRECTORY . 'test');
+        $files->write(self::FIXTURE_DIRECTORY.'test', 'data');
+        $files->deleteDirectory(self::FIXTURE_DIRECTORY.'test');
     }
 
     public function testGetFiles(): void

Please login to merge, or discard this patch.

Braces +8 added lines, -4 removed lines patch added patch discarded remove patch

@@ -130,7 +130,8 @@  discard block
 block discarded – undo
         self::assertTrue($files->exists($directory));
         self::assertTrue($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename)
+        {
             self::assertFalse($files->exists($filename));
             $files->write($filename, 'random-data');
             self::assertTrue($files->exists($filename));
@@ -144,7 +145,8 @@  discard block
 block discarded – undo
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename)
+        {
             self::assertFalse($files->exists($filename));
         }
     }
@@ -175,7 +177,8 @@  discard block
 block discarded – undo
         self::assertTrue($files->exists($directory));
         self::assertTrue($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename)
+        {
             self::assertFalse($files->exists($filename));
             $files->write($filename, 'random-data');
             self::assertTrue($files->exists($filename));
@@ -189,7 +192,8 @@  discard block
 block discarded – undo
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->isDirectory($directory));
 
-        foreach ($filenames as $filename) {
+        foreach ($filenames as $filename)
+        {
             self::assertFalse($files->exists($filename));
         }
     }

Please login to merge, or discard this patch.

src/Files/tests/IOTest.php 2 patches

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@  discard block
 block discarded – undo
     {
         $files = new Files();
 
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
         self::assertFalse($files->exists($filename));
 
         $files->write($filename, 'some-data');
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
     {
         $files = new Files();
 
-        $directory = self::FIXTURE_DIRECTORY . '/directory/abc/';
-        $filename = $directory . 'test.txt';
+        $directory = self::FIXTURE_DIRECTORY.'/directory/abc/';
+        $filename = $directory.'test.txt';
 
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->exists($filename));
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
     {
         $files = new Files();
 
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
         self::assertFalse($files->exists($filename));
 
         $files->write($filename, 'some-data');
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
 
         $files = new Files();
 
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
         self::assertFalse($files->exists($filename));
 
         $files->read($filename);
@@ -94,14 +94,14 @@  discard block
 block discarded – undo
         $this->expectException(FileNotFoundException::class);
 
         $files = new Files();
-        $files->getPermissions(self::FIXTURE_DIRECTORY . '/missing');
+        $files->getPermissions(self::FIXTURE_DIRECTORY.'/missing');
     }
 
     public function testAppend(): void
     {
         $files = new Files();
 
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
         self::assertFalse($files->exists($filename));
 
         $files->append($filename, 'some-data');
@@ -117,8 +117,8 @@  discard block
 block discarded – undo
     {
         $files = new Files();
 
-        $directory = self::FIXTURE_DIRECTORY . '/directory/abc/';
-        $filename = $directory . 'test.txt';
+        $directory = self::FIXTURE_DIRECTORY.'/directory/abc/';
+        $filename = $directory.'test.txt';
 
         self::assertFalse($files->exists($directory));
         self::assertFalse($files->exists($filename));
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
     {
         $files = new Files();
 
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
         $files->touch($filename);
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
     public function testDelete(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
     public function testDeleteMissingFile(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
 
         self::assertFalse($files->exists($filename));
         $files->delete($filename);
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
     public function testCopy(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
-        $destination = self::FIXTURE_DIRECTORY . '/new.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
+        $destination = self::FIXTURE_DIRECTORY.'/new.txt';
 
         self::assertFalse($files->exists($filename));
         $files->write($filename, 'some-data');
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
         $this->expectException(FileNotFoundException::class);
 
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
-        $destination = self::FIXTURE_DIRECTORY . '/new.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
+        $destination = self::FIXTURE_DIRECTORY.'/new.txt';
 
         self::assertFalse($files->exists($filename));
         $files->copy($filename, $destination);
@@ -206,8 +206,8 @@  discard block
 block discarded – undo
     public function testMove(): void
     {
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
-        $destination = self::FIXTURE_DIRECTORY . '/new.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
+        $destination = self::FIXTURE_DIRECTORY.'/new.txt';
 
         self::assertFalse($files->exists($filename));
         $files->write($filename, 'some-data');
@@ -230,8 +230,8 @@  discard block
 block discarded – undo
         $this->expectException(FileNotFoundException::class);
 
         $files = new Files();
-        $filename = self::FIXTURE_DIRECTORY . '/test.txt';
-        $destination = self::FIXTURE_DIRECTORY . '/new.txt';
+        $filename = self::FIXTURE_DIRECTORY.'/test.txt';
+        $destination = self::FIXTURE_DIRECTORY.'/new.txt';
 
         self::assertFalse($files->exists($filename));
         $files->move($filename, $destination);

Please login to merge, or discard this patch.

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -48,7 +48,7 @@
 block discarded – undo
 
         self::assertFalse($files->isDirectory($directory));
 
-        $files->write($filename, 'some-data', FilesInterface::READONLY, true);
+        $files->write($filename, 'some-data', FilesInterface::readonly, true);
 
         self::assertTrue($files->isDirectory($directory));
         self::assertTrue($files->exists($filename));

Please login to merge, or discard this patch.

src/Console/tests/SignatureTest.php 3 patches

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -119,7 +119,7 @@
 block discarded – undo
   -o, --id[=ID]         Id option description. (multiple values allowed)
   -Q, --quit            Quit option description.
       --naf[=NAF]       Naf option description. [default: "default"]
-HELP, $core->run(command: 'help', input: ['command_name' => 'foo:bar'])->getOutput()->fetch());
+help, $core->run(command: 'help', input: ['command_name' => 'foo:bar'])->getOutput()->fetch());
     }
 
     public function testDescriptionFromConstant(): void

Please login to merge, or discard this patch.

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command{
                     protected const SIGNATURE = 'foo:bar {arg?} {--o|option}';
 
                     public function perform(): int
@@ -21,12 +21,12 @@  discard block
 block discarded – undo
                         $argument = $this->argument('arg');
                         $option = $this->option('option');
 
-                        if ($argument) {
-                            $this->write('argument : ' . $argument);
+                        if ($argument){
+                            $this->write('argument : '.$argument);
                         }
 
-                        if ($option) {
-                            $this->write('option : ' . $option);
+                        if ($option){
+                            $this->write('option : '.$option);
                         }
 
                         return 1;
@@ -50,20 +50,20 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command{
                     protected const SIGNATURE = 'foo:bar {arg[]?} {--o|option[]=}';
 
                     public function perform(): int
                     {
-                        $argument = (array) $this->argument('arg');
-                        $option = (array) $this->option('option');
+                        $argument = (array)$this->argument('arg');
+                        $option = (array)$this->option('option');
 
-                        if ($argument) {
-                            $this->write('argument : ' . \implode(',', $argument));
+                        if ($argument){
+                            $this->write('argument : '.\implode(',', $argument));
                         }
 
-                        if ($option) {
-                            $this->write('option : ' . \implode(',', $option));
+                        if ($option){
+                            $this->write('option : '.\implode(',', $option));
                         }
 
                         return 1;
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command{
                     protected const SIGNATURE = 'foo:bar
                                     {foo : Foo arg description. }
                                     {bar=default : Bar arg description. }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command{
                     protected const SIGNATURE = 'foo:bar';
                     protected const DESCRIPTION = 'baz';
 

Please login to merge, or discard this patch.

Braces +16 added lines, -8 removed lines patch added patch discarded remove patch

@@ -13,7 +13,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command
+                {
                     protected const SIGNATURE = 'foo:bar {arg?} {--o|option}';
 
                     public function perform(): int
@@ -21,11 +22,13 @@  discard block
 block discarded – undo
                         $argument = $this->argument('arg');
                         $option = $this->option('option');
 
-                        if ($argument) {
+                        if ($argument)
+                        {
                             $this->write('argument : ' . $argument);
                         }
 
-                        if ($option) {
+                        if ($option)
+                        {
                             $this->write('option : ' . $option);
                         }
 
@@ -50,7 +53,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command
+                {
                     protected const SIGNATURE = 'foo:bar {arg[]?} {--o|option[]=}';
 
                     public function perform(): int
@@ -58,11 +62,13 @@  discard block
 block discarded – undo
                         $argument = (array) $this->argument('arg');
                         $option = (array) $this->option('option');
 
-                        if ($argument) {
+                        if ($argument)
+                        {
                             $this->write('argument : ' . \implode(',', $argument));
                         }
 
-                        if ($option) {
+                        if ($option)
+                        {
                             $this->write('option : ' . \implode(',', $option));
                         }
 
@@ -88,7 +94,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command
+                {
                     protected const SIGNATURE = 'foo:bar
                                     {foo : Foo arg description. }
                                     {bar=default : Bar arg description. }
@@ -126,7 +133,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore(
             $this->getStaticLocator([
-                new class extends Command {
+                new class extends Command
+                {
                     protected const SIGNATURE = 'foo:bar';
                     protected const DESCRIPTION = 'baz';
 

Please login to merge, or discard this patch.

src/Router/tests/Loader/Configurator/RoutingConfiguratorTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
         self::assertCount(0, $routes->getCollection());
 
-        $routes->import(\dirname(__DIR__, 2) . '/Fixtures/file.php');
+        $routes->import(\dirname(__DIR__, 2).'/Fixtures/file.php');
 
         self::assertCount(3, $routes->getCollection());
     }
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 
         self::assertCount(0, $routes->getCollection());
 
-        $routes->import(\dirname(__DIR__, 2) . '/Fixtures/file.php', 'php');
+        $routes->import(\dirname(__DIR__, 2).'/Fixtures/file.php', 'php');
 
         self::assertCount(3, $routes->getCollection());
     }
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
 
         self::assertCount(0, $routes->getCollection());
 
-        $routes->import(\dirname(__DIR__, 2) . '/Fixtures/file.php', 'yaml');
+        $routes->import(\dirname(__DIR__, 2).'/Fixtures/file.php', 'yaml');
 
         self::assertCount(0, $routes->getCollection());
     }

Please login to merge, or discard this patch.

src/Router/tests/Loader/PhpFileLoaderTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -29,12 +29,12 @@
 block discarded – undo
     {
         $loader = new PhpFileLoader($this->container, $this->container);
 
-        $routes = $loader->load(\dirname(__DIR__) . '/Fixtures/file.php');
+        $routes = $loader->load(\dirname(__DIR__).'/Fixtures/file.php');
         self::assertInstanceOf(RouteCollection::class, $routes);
         self::assertCount(3, $routes);
 
         $this->expectException(LoaderLoadException::class);
-        $loader->load(\dirname(__DIR__) . '/Fixtures/unknown.php');
+        $loader->load(\dirname(__DIR__).'/Fixtures/unknown.php');
     }
 
     public function testSupports(): void

Please login to merge, or discard this patch.

		@@ -34,9 +34,9 @@
		block discarded – undo
34	34
35	35	self::assertSame($expected, $enum);
36	36
37		- if ($enum === DebugMode::Enabled) {
	37	+ if ($enum === DebugMode::Enabled){
38	38	self::assertTrue($enum->isEnabled());
39		- } else {
	39	+ }else{
40	40	self::assertFalse($enum->isEnabled());
41	41	}
42	42	}

		@@ -34,9 +34,12 @@
		block discarded – undo
34	34
35	35	self::assertSame($expected, $enum);
36	36
37		- if ($enum === DebugMode::Enabled) {
	37	+ if ($enum === DebugMode::Enabled)
	38	+ {
38	39	self::assertTrue($enum->isEnabled());
39		- } else {
	40	+ }
	41	+ else
	42	+ {
40	43	self::assertFalse($enum->isEnabled());
41	44	}
42	45	}

		@@ -18,7 +18,7 @@ discard block
		block discarded – undo
18	18	{
19	19	$core = TestCore::create([
20	20	'root' => __DIR__,
21		- 'config' => __DIR__ . '/config',
	21	+ 'config' => __DIR__.'/config',
22	22	])->run();
23	23
24	24	/** @var ContainerInterface $c */
		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	{
34	34	$core = TestCore::create([
35	35	'root' => __DIR__,
36		- 'config' => __DIR__ . '/config',
	36	+ 'config' => __DIR__.'/config',
37	37	])->run(new Environment([
38	38	'key' => '(true)',
39	39	]));
		@@ -50,14 +50,14 @@ discard block
		block discarded – undo
50	50	{
51	51	$core = TestCore::create([
52	52	'root' => __DIR__,
53		- 'config' => __DIR__ . '/config',
	53	+ 'config' => __DIR__.'/config',
54	54	])->run();
55	55
56	56	/** @var ContainerInterface $c */
57	57	$c = $core->getContainer();
58	58
59	59	ContainerScope::runScope($c, function (): void {
60		- $this->assertDir(__DIR__ . '/config', directory('config'));
	60	+ $this->assertDir(__DIR__.'/config', directory('config'));
61	61	});
62	62	}
63	63
		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74
75	75	$core = TestCore::create([
76	76	'root' => __DIR__,
77		- 'config' => __DIR__ . '/config',
	77	+ 'config' => __DIR__.'/config',
78	78	])->run();
79	79
80	80	/** @var ContainerInterface $c */
		@@ -102,6 +102,6 @@ discard block
		block discarded – undo
102	102	private function assertDir($path, $value): void
103	103	{
104	104	$path = str_replace(['\\', '//'], '/', $path);
105		- self::assertSame(rtrim($path, '/') . '/', $value);
	105	+ self::assertSame(rtrim($path, '/').'/', $value);
106	106	}
107	107	}

		@@ -25,15 +25,15 @@ discard block
		block discarded – undo
25	25
26	26	$this->assertDir(__DIR__, $dirs->get('root'));
27	27
28		- $this->assertDir(__DIR__ . '/app', $dirs->get('app'));
	28	+ $this->assertDir(__DIR__.'/app', $dirs->get('app'));
29	29
30		- $this->assertDir(__DIR__ . '/public', $dirs->get('public'));
	30	+ $this->assertDir(__DIR__.'/public', $dirs->get('public'));
31	31
32		- $this->assertDir(__DIR__ . '/app/config', $dirs->get('config'));
33		- $this->assertDir(__DIR__ . '/app/resources', $dirs->get('resources'));
	32	+ $this->assertDir(__DIR__.'/app/config', $dirs->get('config'));
	33	+ $this->assertDir(__DIR__.'/app/resources', $dirs->get('resources'));
34	34
35		- $this->assertDir(__DIR__ . '/runtime', $dirs->get('runtime'));
36		- $this->assertDir(__DIR__ . '/runtime/cache', $dirs->get('cache'));
	35	+ $this->assertDir(__DIR__.'/runtime', $dirs->get('runtime'));
	36	+ $this->assertDir(__DIR__.'/runtime/cache', $dirs->get('cache'));
37	37	}
38	38
39	39	public function testKernelException(): void
		@@ -94,6 +94,6 @@ discard block
		block discarded – undo
94	94	private function assertDir($path, $value): void
95	95	{
96	96	$path = str_replace(['\\', '//'], '/', $path);
97		- self::assertSame(rtrim($path, '/') . '/', $value);
	97	+ self::assertSame(rtrim($path, '/').'/', $value);
98	98	}
99	99	}

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	public function testTime(): void
26	26	{
27	27	$files = new Files();
28		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	28	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
29	29
30	30	$files->write($filename, 'data', FilesInterface::READONLY);
31	31	self::assertEquals(filemtime($filename), $files->time($filename));
		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37	$this->expectException(FileNotFoundException::class);
38	38
39	39	$files = new Files();
40		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	40	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
41	41
42	42	$files->time($filename);
43	43	}
		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	public function testMD5(): void
46	46	{
47	47	$files = new Files();
48		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	48	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
49	49
50	50	$files->write($filename, 'data');
51	51	self::assertEquals(md5_file($filename), $files->md5($filename));
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	$this->expectException(FileNotFoundException::class);
59	59
60	60	$files = new Files();
61		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	61	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
62	62
63	63	$files->md5($filename);
64	64	}
		@@ -75,7 +75,7 @@ discard block
		block discarded – undo
75	75	public function testExists(): void
76	76	{
77	77	$files = new Files();
78		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	78	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
79	79
80	80	self::assertFalse($files->exists($filename));
81	81	self::assertSame(file_exists($filename), $files->exists($filename));
		@@ -88,7 +88,7 @@ discard block
		block discarded – undo
88	88	public function testSize(): void
89	89	{
90	90	$files = new Files();
91		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	91	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
92	92
93	93	self::assertFalse($files->exists($filename));
94	94	$files->write($filename, 'some-data-string');
		@@ -103,7 +103,7 @@ discard block
		block discarded – undo
103	103	$this->expectException(FileNotFoundException::class);
104	104
105	105	$files = new Files();
106		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	106	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
107	107
108	108	self::assertFalse($files->exists($filename));
109	109	$files->size($filename);
		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	public function testLocalUri(): void
113	113	{
114	114	$files = new Files();
115		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	115	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
116	116
117	117	self::assertFalse($files->exists($filename));
118	118	$files->write($filename, 'data');
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122	public function testIsFile(): void
123	123	{
124	124	$files = new Files();
125		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	125	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
126	126
127	127	self::assertFalse($files->exists($filename));
128	128	$files->write($filename, 'data');
		@@ -138,7 +138,7 @@ discard block
		block discarded – undo
138	138	public function testIsMissingFile(): void
139	139	{
140	140	$files = new Files();
141		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	141	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
142	142
143	143	self::assertFalse($files->exists($filename));
144	144
		@@ -152,7 +152,7 @@ discard block
		block discarded – undo
152	152	public function testIsDirectory(): void
153	153	{
154	154	$files = new Files();
155		- $directory = self::FIXTURE_DIRECTORY . '/directory/';
	155	+ $directory = self::FIXTURE_DIRECTORY.'/directory/';
156	156
157	157	self::assertFalse($files->exists($directory));
158	158	$files->ensureDirectory($directory);
		@@ -168,7 +168,7 @@ discard block
		block discarded – undo
168	168	public function testIsMissingDirectory(): void
169	169	{
170	170	$files = new Files();
171		- $directory = self::FIXTURE_DIRECTORY . '/directory/';
	171	+ $directory = self::FIXTURE_DIRECTORY.'/directory/';
172	172
173	173	self::assertFalse($files->exists($directory));
174	174
		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182	public function testIsDirectoryNoSlash(): void
183	183	{
184	184	$files = new Files();
185		- $directory = self::FIXTURE_DIRECTORY . '/directory';
	185	+ $directory = self::FIXTURE_DIRECTORY.'/directory';
186	186
187	187	self::assertFalse($files->exists($directory));
188	188	$files->ensureDirectory($directory);

		@@ -27,7 +27,7 @@
		block discarded – undo
27	27	$files = new Files();
28	28	$filename = self::FIXTURE_DIRECTORY . '/test.txt';
29	29
30		- $files->write($filename, 'data', FilesInterface::READONLY);
	30	+ $files->write($filename, 'data', FilesInterface::readonly);
31	31	self::assertEquals(filemtime($filename), $files->time($filename));
32	32	}
33	33

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	public function testEnsureDirectory(): void
26	26	{
27	27	$files = new Files();
28		- $directory = self::FIXTURE_DIRECTORY . 'directory/';
	28	+ $directory = self::FIXTURE_DIRECTORY.'directory/';
29	29
30	30	self::assertFalse($files->exists($directory));
31	31	self::assertFalse($files->isDirectory($directory));
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	public function testEnsureExistedDirectory(): void
40	40	{
41	41	$files = new Files();
42		- $directory = self::FIXTURE_DIRECTORY . 'directory/';
	42	+ $directory = self::FIXTURE_DIRECTORY.'directory/';
43	43
44	44	self::assertFalse($files->exists($directory));
45	45	self::assertFalse($files->isDirectory($directory));
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	public function testEnsureNestedDirectory(): void
59	59	{
60	60	$files = new Files();
61		- $directory = self::FIXTURE_DIRECTORY . 'directory/sub/other';
	61	+ $directory = self::FIXTURE_DIRECTORY.'directory/sub/other';
62	62
63	63	self::assertFalse($files->exists($directory));
64	64	self::assertFalse($files->isDirectory($directory));
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	public function testEnsureNestedDirectoryNoRecursivePermissions(): void
73	73	{
74	74	$files = new Files();
75		- $directory = self::FIXTURE_DIRECTORY . 'directory/sub/other';
	75	+ $directory = self::FIXTURE_DIRECTORY.'directory/sub/other';
76	76
77	77	self::assertFalse($files->exists($directory));
78	78	self::assertFalse($files->isDirectory($directory));
		@@ -86,14 +86,14 @@ discard block
		block discarded – undo
86	86	public function testEnsureExistedNestedDirectory(): void
87	87	{
88	88	$files = new Files();
89		- $directory = self::FIXTURE_DIRECTORY . 'directory/sub/other';
	89	+ $directory = self::FIXTURE_DIRECTORY.'directory/sub/other';
90	90
91	91	self::assertFalse($files->exists($directory));
92	92	self::assertFalse($files->isDirectory($directory));
93	93
94		- mkdir(self::FIXTURE_DIRECTORY . 'directory');
95		- mkdir(self::FIXTURE_DIRECTORY . 'directory/sub');
96		- mkdir(self::FIXTURE_DIRECTORY . 'directory/sub/other');
	94	+ mkdir(self::FIXTURE_DIRECTORY.'directory');
	95	+ mkdir(self::FIXTURE_DIRECTORY.'directory/sub');
	96	+ mkdir(self::FIXTURE_DIRECTORY.'directory/sub/other');
97	97
98	98	self::assertTrue($files->exists($directory));
99	99	self::assertTrue($files->isDirectory($directory));
		@@ -107,13 +107,13 @@ discard block
		block discarded – undo
107	107	public function testDeleteDirectoryContent(): void
108	108	{
109	109	$files = new Files();
110		- $baseDirectory = self::FIXTURE_DIRECTORY . 'directory/';
111		- $directory = $baseDirectory . 'sub/other';
	110	+ $baseDirectory = self::FIXTURE_DIRECTORY.'directory/';
	111	+ $directory = $baseDirectory.'sub/other';
112	112
113	113	$filenames = [
114		- $baseDirectory . 'test.file',
115		- $directory . 'other.file',
116		- $directory . '.sample',
	114	+ $baseDirectory.'test.file',
	115	+ $directory.'other.file',
	116	+ $directory.'.sample',
117	117	];
118	118
119	119	self::assertFalse($files->exists($baseDirectory));
		@@ -130,7 +130,7 @@ discard block
		block discarded – undo
130	130	self::assertTrue($files->exists($directory));
131	131	self::assertTrue($files->isDirectory($directory));
132	132
133		- foreach ($filenames as $filename) {
	133	+ foreach ($filenames as $filename){
134	134	self::assertFalse($files->exists($filename));
135	135	$files->write($filename, 'random-data');
136	136	self::assertTrue($files->exists($filename));
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	self::assertFalse($files->exists($directory));
145	145	self::assertFalse($files->isDirectory($directory));
146	146
147		- foreach ($filenames as $filename) {
	147	+ foreach ($filenames as $filename){
148	148	self::assertFalse($files->exists($filename));
149	149	}
150	150	}
		@@ -152,13 +152,13 @@ discard block
		block discarded – undo
152	152	public function testDeleteDirectory(): void
153	153	{
154	154	$files = new Files();
155		- $baseDirectory = self::FIXTURE_DIRECTORY . 'directory/';
156		- $directory = $baseDirectory . 'sub/other';
	155	+ $baseDirectory = self::FIXTURE_DIRECTORY.'directory/';
	156	+ $directory = $baseDirectory.'sub/other';
157	157
158	158	$filenames = [
159		- $baseDirectory . 'test.file',
160		- $directory . 'other.file',
161		- $directory . '.sample',
	159	+ $baseDirectory.'test.file',
	160	+ $directory.'other.file',
	161	+ $directory.'.sample',
162	162	];
163	163
164	164	self::assertFalse($files->exists($baseDirectory));
		@@ -175,7 +175,7 @@ discard block
		block discarded – undo
175	175	self::assertTrue($files->exists($directory));
176	176	self::assertTrue($files->isDirectory($directory));
177	177
178		- foreach ($filenames as $filename) {
	178	+ foreach ($filenames as $filename){
179	179	self::assertFalse($files->exists($filename));
180	180	$files->write($filename, 'random-data');
181	181	self::assertTrue($files->exists($filename));
		@@ -189,7 +189,7 @@ discard block
		block discarded – undo
189	189	self::assertFalse($files->exists($directory));
190	190	self::assertFalse($files->isDirectory($directory));
191	191
192		- foreach ($filenames as $filename) {
	192	+ foreach ($filenames as $filename){
193	193	self::assertFalse($files->exists($filename));
194	194	}
195	195	}
		@@ -200,8 +200,8 @@ discard block
		block discarded – undo
200	200
201	201	$files = new Files();
202	202
203		- $files->write(self::FIXTURE_DIRECTORY . 'test', 'data');
204		- $files->deleteDirectory(self::FIXTURE_DIRECTORY . 'test');
	203	+ $files->write(self::FIXTURE_DIRECTORY.'test', 'data');
	204	+ $files->deleteDirectory(self::FIXTURE_DIRECTORY.'test');
205	205	}
206	206
207	207	public function testGetFiles(): void

		@@ -130,7 +130,8 @@ discard block
		block discarded – undo
130	130	self::assertTrue($files->exists($directory));
131	131	self::assertTrue($files->isDirectory($directory));
132	132
133		- foreach ($filenames as $filename) {
	133	+ foreach ($filenames as $filename)
	134	+ {
134	135	self::assertFalse($files->exists($filename));
135	136	$files->write($filename, 'random-data');
136	137	self::assertTrue($files->exists($filename));
		@@ -144,7 +145,8 @@ discard block
		block discarded – undo
144	145	self::assertFalse($files->exists($directory));
145	146	self::assertFalse($files->isDirectory($directory));
146	147
147		- foreach ($filenames as $filename) {
	148	+ foreach ($filenames as $filename)
	149	+ {
148	150	self::assertFalse($files->exists($filename));
149	151	}
150	152	}
		@@ -175,7 +177,8 @@ discard block
		block discarded – undo
175	177	self::assertTrue($files->exists($directory));
176	178	self::assertTrue($files->isDirectory($directory));
177	179
178		- foreach ($filenames as $filename) {
	180	+ foreach ($filenames as $filename)
	181	+ {
179	182	self::assertFalse($files->exists($filename));
180	183	$files->write($filename, 'random-data');
181	184	self::assertTrue($files->exists($filename));
		@@ -189,7 +192,8 @@ discard block
		block discarded – undo
189	192	self::assertFalse($files->exists($directory));
190	193	self::assertFalse($files->isDirectory($directory));
191	194
192		- foreach ($filenames as $filename) {
	195	+ foreach ($filenames as $filename)
	196	+ {
193	197	self::assertFalse($files->exists($filename));
194	198	}
195	199	}

		@@ -27,7 +27,7 @@ discard block
		block discarded – undo
27	27	{
28	28	$files = new Files();
29	29
30		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	30	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
31	31	self::assertFalse($files->exists($filename));
32	32
33	33	$files->write($filename, 'some-data');
		@@ -40,8 +40,8 @@ discard block
		block discarded – undo
40	40	{
41	41	$files = new Files();
42	42
43		- $directory = self::FIXTURE_DIRECTORY . '/directory/abc/';
44		- $filename = $directory . 'test.txt';
	43	+ $directory = self::FIXTURE_DIRECTORY.'/directory/abc/';
	44	+ $filename = $directory.'test.txt';
45	45
46	46	self::assertFalse($files->exists($directory));
47	47	self::assertFalse($files->exists($filename));
		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59	{
60	60	$files = new Files();
61	61
62		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	62	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
63	63	self::assertFalse($files->exists($filename));
64	64
65	65	$files->write($filename, 'some-data');
		@@ -75,7 +75,7 @@ discard block
		block discarded – undo
75	75
76	76	$files = new Files();
77	77
78		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	78	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
79	79	self::assertFalse($files->exists($filename));
80	80
81	81	$files->read($filename);
		@@ -94,14 +94,14 @@ discard block
		block discarded – undo
94	94	$this->expectException(FileNotFoundException::class);
95	95
96	96	$files = new Files();
97		- $files->getPermissions(self::FIXTURE_DIRECTORY . '/missing');
	97	+ $files->getPermissions(self::FIXTURE_DIRECTORY.'/missing');
98	98	}
99	99
100	100	public function testAppend(): void
101	101	{
102	102	$files = new Files();
103	103
104		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	104	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
105	105	self::assertFalse($files->exists($filename));
106	106
107	107	$files->append($filename, 'some-data');
		@@ -117,8 +117,8 @@ discard block
		block discarded – undo
117	117	{
118	118	$files = new Files();
119	119
120		- $directory = self::FIXTURE_DIRECTORY . '/directory/abc/';
121		- $filename = $directory . 'test.txt';
	120	+ $directory = self::FIXTURE_DIRECTORY.'/directory/abc/';
	121	+ $filename = $directory.'test.txt';
122	122
123	123	self::assertFalse($files->exists($directory));
124	124	self::assertFalse($files->exists($filename));
		@@ -139,7 +139,7 @@ discard block
		block discarded – undo
139	139	{
140	140	$files = new Files();
141	141
142		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	142	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
143	143
144	144	self::assertFalse($files->exists($filename));
145	145	$files->touch($filename);
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	public function testDelete(): void
150	150	{
151	151	$files = new Files();
152		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	152	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
153	153
154	154	self::assertFalse($files->exists($filename));
155	155
		@@ -163,7 +163,7 @@ discard block
		block discarded – undo
163	163	public function testDeleteMissingFile(): void
164	164	{
165	165	$files = new Files();
166		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
	166	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
167	167
168	168	self::assertFalse($files->exists($filename));
169	169	$files->delete($filename);
		@@ -172,8 +172,8 @@ discard block
		block discarded – undo
172	172	public function testCopy(): void
173	173	{
174	174	$files = new Files();
175		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
176		- $destination = self::FIXTURE_DIRECTORY . '/new.txt';
	175	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
	176	+ $destination = self::FIXTURE_DIRECTORY.'/new.txt';
177	177
178	178	self::assertFalse($files->exists($filename));
179	179	$files->write($filename, 'some-data');
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	$this->expectException(FileNotFoundException::class);
197	197
198	198	$files = new Files();
199		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
200		- $destination = self::FIXTURE_DIRECTORY . '/new.txt';
	199	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
	200	+ $destination = self::FIXTURE_DIRECTORY.'/new.txt';
201	201
202	202	self::assertFalse($files->exists($filename));
203	203	$files->copy($filename, $destination);
		@@ -206,8 +206,8 @@ discard block
		block discarded – undo
206	206	public function testMove(): void
207	207	{
208	208	$files = new Files();
209		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
210		- $destination = self::FIXTURE_DIRECTORY . '/new.txt';
	209	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
	210	+ $destination = self::FIXTURE_DIRECTORY.'/new.txt';
211	211
212	212	self::assertFalse($files->exists($filename));
213	213	$files->write($filename, 'some-data');
		@@ -230,8 +230,8 @@ discard block
		block discarded – undo
230	230	$this->expectException(FileNotFoundException::class);
231	231
232	232	$files = new Files();
233		- $filename = self::FIXTURE_DIRECTORY . '/test.txt';
234		- $destination = self::FIXTURE_DIRECTORY . '/new.txt';
	233	+ $filename = self::FIXTURE_DIRECTORY.'/test.txt';
	234	+ $destination = self::FIXTURE_DIRECTORY.'/new.txt';
235	235
236	236	self::assertFalse($files->exists($filename));
237	237	$files->move($filename, $destination);

		@@ -48,7 +48,7 @@
		block discarded – undo
48	48
49	49	self::assertFalse($files->isDirectory($directory));
50	50
51		- $files->write($filename, 'some-data', FilesInterface::READONLY, true);
	51	+ $files->write($filename, 'some-data', FilesInterface::readonly, true);
52	52
53	53	self::assertTrue($files->isDirectory($directory));
54	54	self::assertTrue($files->exists($filename));

		@@ -119,7 +119,7 @@
		block discarded – undo
119	119	-o, --id[=ID] Id option description. (multiple values allowed)
120	120	-Q, --quit Quit option description.
121	121	--naf[=NAF] Naf option description. [default: "default"]
122		-HELP, $core->run(command: 'help', input: ['command_name' => 'foo:bar'])->getOutput()->fetch());
	122	+help, $core->run(command: 'help', input: ['command_name' => 'foo:bar'])->getOutput()->fetch());
123	123	}
124	124
125	125	public function testDescriptionFromConstant(): void

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13	{
14	14	$core = $this->getCore(
15	15	$this->getStaticLocator([
16		- new class extends Command {
	16	+ new class extends Command{
17	17	protected const SIGNATURE = 'foo:bar {arg?} {--o\|option}';
18	18
19	19	public function perform(): int
		@@ -21,12 +21,12 @@ discard block
		block discarded – undo
21	21	$argument = $this->argument('arg');
22	22	$option = $this->option('option');
23	23
24		- if ($argument) {
25		- $this->write('argument : ' . $argument);
	24	+ if ($argument){
	25	+ $this->write('argument : '.$argument);
26	26	}
27	27
28		- if ($option) {
29		- $this->write('option : ' . $option);
	28	+ if ($option){
	29	+ $this->write('option : '.$option);
30	30	}
31	31
32	32	return 1;
		@@ -50,20 +50,20 @@ discard block
		block discarded – undo
50	50	{
51	51	$core = $this->getCore(
52	52	$this->getStaticLocator([
53		- new class extends Command {
	53	+ new class extends Command{
54	54	protected const SIGNATURE = 'foo:bar {arg[]?} {--o\|option[]=}';
55	55
56	56	public function perform(): int
57	57	{
58		- $argument = (array) $this->argument('arg');
59		- $option = (array) $this->option('option');
	58	+ $argument = (array)$this->argument('arg');
	59	+ $option = (array)$this->option('option');
60	60
61		- if ($argument) {
62		- $this->write('argument : ' . \implode(',', $argument));
	61	+ if ($argument){
	62	+ $this->write('argument : '.\implode(',', $argument));
63	63	}
64	64
65		- if ($option) {
66		- $this->write('option : ' . \implode(',', $option));
	65	+ if ($option){
	66	+ $this->write('option : '.\implode(',', $option));
67	67	}
68	68
69	69	return 1;
		@@ -88,7 +88,7 @@ discard block
		block discarded – undo
88	88	{
89	89	$core = $this->getCore(
90	90	$this->getStaticLocator([
91		- new class extends Command {
	91	+ new class extends Command{
92	92	protected const SIGNATURE = 'foo:bar
93	93	{foo : Foo arg description. }
94	94	{bar=default : Bar arg description. }
		@@ -126,7 +126,7 @@ discard block
		block discarded – undo
126	126	{
127	127	$core = $this->getCore(
128	128	$this->getStaticLocator([
129		- new class extends Command {
	129	+ new class extends Command{
130	130	protected const SIGNATURE = 'foo:bar';
131	131	protected const DESCRIPTION = 'baz';
132	132

		@@ -13,7 +13,8 @@ discard block
		block discarded – undo
13	13	{
14	14	$core = $this->getCore(
15	15	$this->getStaticLocator([
16		- new class extends Command {
	16	+ new class extends Command
	17	+ {
17	18	protected const SIGNATURE = 'foo:bar {arg?} {--o\|option}';
18	19
19	20	public function perform(): int
		@@ -21,11 +22,13 @@ discard block
		block discarded – undo
21	22	$argument = $this->argument('arg');
22	23	$option = $this->option('option');
23	24
24		- if ($argument) {
	25	+ if ($argument)
	26	+ {
25	27	$this->write('argument : ' . $argument);
26	28	}
27	29
28		- if ($option) {
	30	+ if ($option)
	31	+ {
29	32	$this->write('option : ' . $option);
30	33	}
31	34
		@@ -50,7 +53,8 @@ discard block
		block discarded – undo
50	53	{
51	54	$core = $this->getCore(
52	55	$this->getStaticLocator([
53		- new class extends Command {
	56	+ new class extends Command
	57	+ {
54	58	protected const SIGNATURE = 'foo:bar {arg[]?} {--o\|option[]=}';
55	59
56	60	public function perform(): int
		@@ -58,11 +62,13 @@ discard block
		block discarded – undo
58	62	$argument = (array) $this->argument('arg');
59	63	$option = (array) $this->option('option');
60	64
61		- if ($argument) {
	65	+ if ($argument)
	66	+ {
62	67	$this->write('argument : ' . \implode(',', $argument));
63	68	}
64	69
65		- if ($option) {
	70	+ if ($option)
	71	+ {
66	72	$this->write('option : ' . \implode(',', $option));
67	73	}
68	74
		@@ -88,7 +94,8 @@ discard block
		block discarded – undo
88	94	{
89	95	$core = $this->getCore(
90	96	$this->getStaticLocator([
91		- new class extends Command {
	97	+ new class extends Command
	98	+ {
92	99	protected const SIGNATURE = 'foo:bar
93	100	{foo : Foo arg description. }
94	101	{bar=default : Bar arg description. }
		@@ -126,7 +133,8 @@ discard block
		block discarded – undo
126	133	{
127	134	$core = $this->getCore(
128	135	$this->getStaticLocator([
129		- new class extends Command {
	136	+ new class extends Command
	137	+ {
130	138	protected const SIGNATURE = 'foo:bar';
131	139	protected const DESCRIPTION = 'baz';
132	140

		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17
18	18	self::assertCount(0, $routes->getCollection());
19	19
20		- $routes->import(\dirname(__DIR__, 2) . '/Fixtures/file.php');
	20	+ $routes->import(\dirname(__DIR__, 2).'/Fixtures/file.php');
21	21
22	22	self::assertCount(3, $routes->getCollection());
23	23	}
		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28
29	29	self::assertCount(0, $routes->getCollection());
30	30
31		- $routes->import(\dirname(__DIR__, 2) . '/Fixtures/file.php', 'php');
	31	+ $routes->import(\dirname(__DIR__, 2).'/Fixtures/file.php', 'php');
32	32
33	33	self::assertCount(3, $routes->getCollection());
34	34	}
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39
40	40	self::assertCount(0, $routes->getCollection());
41	41
42		- $routes->import(\dirname(__DIR__, 2) . '/Fixtures/file.php', 'yaml');
	42	+ $routes->import(\dirname(__DIR__, 2).'/Fixtures/file.php', 'yaml');
43	43
44	44	self::assertCount(0, $routes->getCollection());
45	45	}

		@@ -29,12 +29,12 @@
		block discarded – undo
29	29	{
30	30	$loader = new PhpFileLoader($this->container, $this->container);
31	31
32		- $routes = $loader->load(\dirname(__DIR__) . '/Fixtures/file.php');
	32	+ $routes = $loader->load(\dirname(__DIR__).'/Fixtures/file.php');
33	33	self::assertInstanceOf(RouteCollection::class, $routes);
34	34	self::assertCount(3, $routes);
35	35
36	36	$this->expectException(LoaderLoadException::class);
37		- $loader->load(\dirname(__DIR__) . '/Fixtures/unknown.php');
	37	+ $loader->load(\dirname(__DIR__).'/Fixtures/unknown.php');
38	38	}
39	39
40	40	public function testSupports(): void

spiral / framework

Pull Request — master (#1207)

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

Braces +8 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Braces +16 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch