spiral / framework

src/Console/tests/Configurator/Attribute/OptionsTest.php

Braces +42 added lines, -21 removed lines

@@ -26,7 +26,8 @@ 
     public function testRequired(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_REQUIRED)]
                 private int $option;
             }
@@ -44,7 +45,8 @@ 
     public function testDefaultValue(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_OPTIONAL)]
                 private string $option = 'some';
             }
@@ -62,7 +64,8 @@ 
     public function testNullable(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_OPTIONAL)]
                 private ?string $option;
             }
@@ -80,7 +83,8 @@ 
     public function testWithName(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(name: 'customName', mode: InputOption::VALUE_OPTIONAL)]
                 private ?string $option;
             }
@@ -98,7 +102,8 @@ 
     public function testWithShortcut(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(shortcut: 't', mode: InputOption::VALUE_OPTIONAL)]
                 private ?string $option;
             }
@@ -116,7 +121,8 @@ 
     public function testWithDescription(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(description: 'Some description', mode: InputOption::VALUE_OPTIONAL)]
                 private ?string $option;
             }
@@ -134,7 +140,8 @@ 
     public function testModeOptionalArray(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY)]
                 private array $option = [];
             }
@@ -152,7 +159,8 @@ 
     public function testModeRequiredArray(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY)]
                 private array $option = [];
             }
@@ -170,7 +178,8 @@ 
     public function testModeValueNegatable(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_NEGATABLE)]
                 private bool $option;
             }
@@ -188,7 +197,8 @@ 
     public function testModeValueNone(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_NONE)]
                 private bool $option;
             }
@@ -206,7 +216,8 @@ 
     public function testGuessedRequiredOption(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private int $int;
 
@@ -234,7 +245,8 @@ 
     public function testGuessedOptionalOption(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private ?int $int;
 
@@ -265,7 +277,8 @@ 
     public function testGuessedOptionalOptionFromPropertiesWithDefaultValue(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private int $int = 1;
 
@@ -296,7 +309,8 @@ 
     public function testGuessedArrayOption(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private array $array;
             }
@@ -310,7 +324,8 @@ 
     public function testGuessedOptionalArrayOption(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private ?array $array;
             }
@@ -325,7 +340,8 @@ 
     public function testGuessedOptionalArrayOptionFromPropertyWithDefaultValue(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private array $array = [];
             }
@@ -340,7 +356,8 @@ 
     public function testWithSuggestedValue(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_REQUIRED, suggestedValues: [1, 0])]
                 private int $option;
             }
@@ -366,7 +383,8 @@ 
     public function testUnionTypeWithBuiltInAndNot(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option(mode: InputOption::VALUE_OPTIONAL)]
                 private int|\stdClass $option;
             }
@@ -385,7 +403,8 @@ 
     {
         $this->expectException(ConfiguratorException::class);
         $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private \stdClass $option;
             }
@@ -396,7 +415,8 @@ 
     {
         $this->expectException(ConfiguratorException::class);
         $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private \stdClass&\Traversable $option;
             }
@@ -407,7 +427,8 @@ 
     {
         $this->expectException(ConfiguratorException::class);
         $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Option]
                 private object $object;
             }

src/Console/tests/Configurator/Attribute/ArgumentsTest.php

Braces +28 added lines, -14 removed lines

@@ -25,7 +25,8 @@ 
     public function testRequired(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private int $arg;
             }
@@ -41,7 +42,8 @@ 
     public function testWithDefaultValue(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private int $arg = 1;
             }
@@ -57,7 +59,8 @@ 
     public function testNullable(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private ?int $arg;
             }
@@ -73,7 +76,8 @@ 
     public function testWithName(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument(name: 'customName')]
                 private int $arg;
             }
@@ -89,7 +93,8 @@ 
     public function testWithDescription(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument(description: 'Some description')]
                 private int $arg;
             }
@@ -105,7 +110,8 @@ 
     public function testWithSuggestedValue(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument(suggestedValues: [1, 0])]
                 private int $arg;
             }
@@ -129,7 +135,8 @@ 
     public function testArrayRequired(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private array $arg;
             }
@@ -145,7 +152,8 @@ 
     public function testArrayNotRequired(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private ?array $arg;
             }
@@ -161,7 +169,8 @@ 
     public function testArrayShouldBeLast(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private ?array $arg;
 
@@ -180,7 +189,8 @@ 
     public function testUnionTypeWithBuiltInAndNot(): void
     {
         $result = $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private int|\stdClass $arg;
             }
@@ -197,7 +207,8 @@ 
     {
         $this->expectException(ConfiguratorException::class);
         $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private \stdClass $arg;
             }
@@ -208,7 +219,8 @@ 
     {
         $this->expectException(ConfiguratorException::class);
         $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private \stdClass&\Traversable $arg;
             }
@@ -219,7 +231,8 @@ 
     {
         $this->expectException(ConfiguratorException::class);
         $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private array $arg;
 
@@ -233,7 +246,8 @@ 
     {
         $this->expectException(ConfiguratorException::class);
         $this->parser->parse(new \ReflectionClass(
-            new #[AsCommand(name: 'foo')] class {
+            new #[AsCommand(name: 'foo')] class
+            {
                 #[Argument]
                 private object $arg;
             }

src/Console/src/Configurator/Attribute/Parser.php

Braces +48 added lines, -24 removed lines

@@ -37,7 +37,8 @@ 
     {
         $attribute = $this->reader->firstClassMetadata($reflection, AsCommand::class);
 
-        if ($attribute === null) {
+        if ($attribute === null)
+        {
             $attribute = $reflection->getAttributes(SymfonyAsCommand::class)[0]->newInstance();
         }
 
@@ -54,13 +55,16 @@ 
     {
         $reflection = new \ReflectionClass($command);
 
-        foreach ($reflection->getProperties() as $property) {
+        foreach ($reflection->getProperties() as $property)
+        {
             $attribute = $this->reader->firstPropertyMetadata($property, Argument::class);
-            if ($attribute === null) {
+            if ($attribute === null)
+            {
                 continue;
             }
 
-            if ($input->hasArgument($attribute->name ?? $property->getName())) {
+            if ($input->hasArgument($attribute->name ?? $property->getName()))
+            {
                 $property->setValue(
                     $command,
                     $this->typecast($input->getArgument($attribute->name ?? $property->getName()), $property)
@@ -68,13 +72,16 @@ 
             }
         }
 
-        foreach ($reflection->getProperties() as $property) {
+        foreach ($reflection->getProperties() as $property)
+        {
             $attribute = $this->reader->firstPropertyMetadata($property, Option::class);
-            if ($attribute === null) {
+            if ($attribute === null)
+            {
                 continue;
             }
 
-            if ($input->hasOption($attribute->name ?? $property->getName())) {
+            if ($input->hasOption($attribute->name ?? $property->getName()))
+            {
                 $property->setValue(
                     $command,
                     $this->typecast($input->getOption($attribute->name ?? $property->getName()), $property)
@@ -87,9 +94,11 @@ 
     {
         $result = [];
         $arrayArgument = null;
-        foreach ($reflection->getProperties() as $property) {
+        foreach ($reflection->getProperties() as $property)
+        {
             $attribute = $this->reader->firstPropertyMetadata($property, Argument::class);
-            if ($attribute === null) {
+            if ($attribute === null)
+            {
                 continue;
             }
 
@@ -112,19 +121,22 @@ 
                 suggestedValues: $attribute->suggestedValues
             );
 
-            if ($arrayArgument !== null && $isArray) {
+            if ($arrayArgument !== null && $isArray)
+            {
                 throw new ConfiguratorException('There must be only one array argument!');
             }
 
             // It must be used at the end of the argument list.
-            if ($isArray) {
+            if ($isArray)
+            {
                 $arrayArgument = $argument;
                 continue;
             }
             $result[] = $argument;
         }
 
-        if ($arrayArgument !== null) {
+        if ($arrayArgument !== null)
+        {
             $result[] = $arrayArgument;
         }
 
@@ -134,21 +146,26 @@ 
     private function parseOptions(\ReflectionClass $reflection): array
     {
         $result = [];
-        foreach ($reflection->getProperties() as $property) {
+        foreach ($reflection->getProperties() as $property)
+        {
             $attribute = $this->reader->firstPropertyMetadata($property, Option::class);
-            if ($attribute === null) {
+            if ($attribute === null)
+            {
                 continue;
             }
 
             $type = $this->getPropertyType($property);
             $mode = $attribute->mode;
 
-            if ($mode === null) {
+            if ($mode === null)
+            {
                 $mode = $this->guessOptionMode($type, $property);
             }
 
-            if ($mode === InputOption::VALUE_NONE || $attribute->mode === InputOption::VALUE_NEGATABLE) {
-                if ($type->getName() !== 'bool') {
+            if ($mode === InputOption::VALUE_NONE || $attribute->mode === InputOption::VALUE_NEGATABLE)
+            {
+                if ($type->getName() !== 'bool')
+                {
                     throw new ConfiguratorException(
                         'Options properties with mode `VALUE_NONE` or `VALUE_NEGATABLE` must be bool!'
                     );
@@ -174,7 +191,8 @@ 
     {
         $type = $property->hasType() ? $property->getType() : null;
 
-        if (!$type instanceof \ReflectionNamedType) {
+        if (!$type instanceof \ReflectionNamedType)
+        {
             return $value;
         }
 
@@ -190,7 +208,8 @@ 
 
     private function getPropertyType(\ReflectionProperty $property): \ReflectionNamedType
     {
-        if (!$property->hasType()) {
+        if (!$property->hasType())
+        {
             throw new ConfiguratorException(
                 \sprintf('Please, specify the type for the `%s` property!', $property->getName())
             );
@@ -198,19 +217,24 @@ 
 
         $type = $property->getType();
 
-        if ($type instanceof \ReflectionIntersectionType) {
+        if ($type instanceof \ReflectionIntersectionType)
+        {
             throw new ConfiguratorException(\sprintf('Invalid type for the `%s` property.', $property->getName()));
         }
 
-        if ($type instanceof \ReflectionUnionType) {
-            foreach ($type->getTypes() as $type) {
-                if ($type->isBuiltin()) {
+        if ($type instanceof \ReflectionUnionType)
+        {
+            foreach ($type->getTypes() as $type)
+            {
+                if ($type->isBuiltin())
+                {
                     return $type;
                 }
             }
         }
 
-        if ($type instanceof \ReflectionNamedType && $type->isBuiltin() && $type->getName() !== 'object') {
+        if ($type instanceof \ReflectionNamedType && $type->isBuiltin() && $type->getName() !== 'object')
+        {
             return $type;
         }