ShortCircuit::push() - Code Metrics - Inspection of "Add full support of RR2" - spiral/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#464)

by Kirill

created 2021-10-18 08:55 UTC

ShortCircuit::push() A

↳ Parent: ShortCircuit

Complexity

Conditions	3
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	6
c	1
b	0
f	0
nc	2
nop	3
dl	0
loc	12
rs	10

<?php

/**
 * Spiral Framework.
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */

declare(strict_types=1);

namespace Spiral\Jobs;

/**
 * Runs all the jobs in the same process.
 */
final class ShortCircuit implements QueueInterface
{
    /** @var int */
    private $id = 0;

    /** @var HandlerRegistryInterface */
    private $registry;

    /** @var SerializerRegistryInterface */
    private $serializerRegistry;

    /**
     * @param HandlerRegistryInterface $registry
     */
    public function __construct(HandlerRegistryInterface $registry, SerializerRegistryInterface $serializerRegistry)
    {
        $this->registry = $registry;
        $this->serializerRegistry = $serializerRegistry;
    }

    /**
     * @inheritdoc
     */
    public function push(string $jobType, array $payload = [], Options $options = null): string
    {
        $payloadBody = $this->serialize($jobType, $payload);
        if ($options !== null && $options->getDelay()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            sleep($options->getDelay());
        }

        $id = (string)(++$this->id);

        $this->registry->getHandler($jobType)->handle($jobType, $id, $payloadBody);

        return $id;
    }

    /**
     * @param string $jobType
     * @param array  $payload
     * @return string
     */
    private function serialize(string $jobType, array $payload): string
    {
        return $this->serializerRegistry->getSerializer($jobType)->serialize($jobType, $payload);
    }
}


1			<?php
2
3			/**
4			* Spiral Framework.
5			*
6			* @license MIT
7			* @author Anton Titov (Wolfy-J)
8			*/
9
10			declare(strict_types=1);
11
12			namespace Spiral\Jobs;
13
14			/**
15			* Runs all the jobs in the same process.
16			*/
17			final class ShortCircuit implements QueueInterface
18			{
19			/** @var int */
20			private $id = 0;
21
22			/** @var HandlerRegistryInterface */
23			private $registry;
24
25			/** @var SerializerRegistryInterface */
26			private $serializerRegistry;
27
28			/**
29			* @param HandlerRegistryInterface $registry
30			*/
31			public function __construct(HandlerRegistryInterface $registry, SerializerRegistryInterface $serializerRegistry)
32			{
33			$this->registry = $registry;
34			$this->serializerRegistry = $serializerRegistry;
35			}
36
37			/**
38			* @inheritdoc
39			*/
40			public function push(string $jobType, array $payload = [], Options $options = null): string
41			{
42			$payloadBody = $this->serialize($jobType, $payload);
43			if ($options !== null && $options->getDelay()) {
			0 ignored issues – show Bug Best Practice introduced 2021-10-18 09:07 UTC by Report Bug Copy Issue Report The expression `$options->getDelay()` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
44			sleep($options->getDelay());
45			}
46
47			$id = (string)(++$this->id);
48
49			$this->registry->getHandler($jobType)->handle($jobType, $id, $payloadBody);
50
51			return $id;
52			}
53
54			/**
55			* @param string $jobType
56			* @param array $payload
57			* @return string
58			*/
59			private function serialize(string $jobType, array $payload): string
60			{
61			return $this->serializerRegistry->getSerializer($jobType)->serialize($jobType, $payload);
62			}
63			}
64

spiral / framework

Pull Request — master (#464)

ShortCircuit::push() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like