GroupRegistry::getGroup() - Code Metrics - Inspection of "Router improvements" - spiral/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#831)

by Maxim

created 2022-11-15 07:16 UTC

GroupRegistry::getGroup() A

↳ Parent: GroupRegistry

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	7
ccs	4
cts	4
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Spiral\Router;

use Spiral\Core\FactoryInterface;

/**
 * Manages the presets for various route groups.
 */
final class GroupRegistry implements \IteratorAggregate
{
    private string $defaultGroup = 'web';

    /** @var array<non-empty-string, RouteGroup> */

    private array $groups = [];

    public function __construct(
        private readonly FactoryInterface $factory
    ) {
    }

    public function getGroup(string $name): RouteGroup
    {
        if (!isset($this->groups[$name])) {
            $this->groups[$name] = $this->factory->make(RouteGroup::class, ['name' => $name]);
        }

        return $this->groups[$name];
    }

    public function setDefaultGroup(string $group): self
    {
        $this->defaultGroup = $group;

        return $this;
    }

    public function getDefaultGroup(): string
    {
        return $this->defaultGroup;
    }

    /**
     * @return \ArrayIterator<array-key, RouteGroup>
     */
    public function getIterator(): \Traversable
    {
        return new \ArrayIterator($this->groups);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Spiral\Router;
6
7		use Spiral\Core\FactoryInterface;
8
9		/**
10		* Manages the presets for various route groups.
11		*/
12		final class GroupRegistry implements \IteratorAggregate
13		{
14		private string $defaultGroup = 'web';
15
16		/** @var array<non-empty-string, RouteGroup> */
		0 ignored issues – show Documentation Bug introduced 2022-09-13 07:04 UTC by Report Bug Copy Issue Report The doc comment `array<non-empty-string, RouteGroup>` at position `2` could not be parsed: Unknown type name 'non-empty-string' at position 2 in array<non-empty-string, RouteGroup>. Loading history...
17		private array $groups = [];
18
19	276	public function __construct(
20		private readonly FactoryInterface $factory
21		) {
22		}
23
24	276	public function getGroup(string $name): RouteGroup
25		{
26	276	if (!isset($this->groups[$name])) {
27	276	$this->groups[$name] = $this->factory->make(RouteGroup::class, ['name' => $name]);
28		}
29
30	276	return $this->groups[$name];
31		}
32
33	1	public function setDefaultGroup(string $group): self
34		{
35	1	$this->defaultGroup = $group;
36
37	1	return $this;
38		}
39
40	275	public function getDefaultGroup(): string
41		{
42	275	return $this->defaultGroup;
43		}
44
45		/**
46		* @return \ArrayIterator<array-key, RouteGroup>
47		*/
48	3	public function getIterator(): \Traversable
49		{
50	3	return new \ArrayIterator($this->groups);
51		}
52		}
53

spiral / framework

Pull Request — master (#831)

GroupRegistry::getGroup() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like