Passed
Push — master ( 3c979b...72c793 )
by Kirill
03:02
created
src/Session/tests/FactoryTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     public function tearDown(): void
26 26
     {
27
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
27
+        if ((int)session_status() === PHP_SESSION_ACTIVE){
28 28
             session_abort();
29 29
         }
30 30
     }
Please login to merge, or discard this patch.
src/Session/tests/SessionTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function tearDown(): void
53 53
     {
54
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
54
+        if ((int)session_status() === PHP_SESSION_ACTIVE){
55 55
             session_abort();
56 56
         }
57 57
     }
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         $this->assertSame('default', $section->getName());
126 126
 
127 127
         $section->set('key', 'value');
128
-        foreach ($section as $key => $value) {
128
+        foreach ($section as $key => $value){
129 129
             $this->assertSame('key', $key);
130 130
             $this->assertSame('value', $value);
131 131
         }
Please login to merge, or discard this patch.
src/Session/src/SessionSection.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
      */
128 128
     public function get(string $name, $default = null)
129 129
     {
130
-        if (!$this->has($name)) {
130
+        if (!$this->has($name)){
131 131
             return $default;
132 132
         }
133 133
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     {
203 203
         $this->session->resume();
204 204
 
205
-        if (!isset($_SESSION[$this->name])) {
205
+        if (!isset($_SESSION[$this->name])){
206 206
             $_SESSION[$this->name] = [];
207 207
         }
208 208
     }
Please login to merge, or discard this patch.
src/Session/src/Handler/FileHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,8 +62,8 @@
 block discarded – undo
62 62
      */
63 63
     public function gc($maxlifetime): void
64 64
     {
65
-        foreach ($this->files->getFiles($this->directory) as $filename) {
66
-            if ($this->files->time($filename) < time() - $maxlifetime) {
65
+        foreach ($this->files->getFiles($this->directory) as $filename){
66
+            if ($this->files->time($filename) < time() - $maxlifetime){
67 67
                 $this->files->delete($filename);
68 68
             }
69 69
         }
Please login to merge, or discard this patch.
src/Session/src/SessionFactory.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -48,15 +48,15 @@
 block discarded – undo
48 48
      */
49 49
     public function initSession(string $clientSignature, string $id = null): SessionInterface
50 50
     {
51
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
51
+        if ((int)session_status() === PHP_SESSION_ACTIVE){
52 52
             throw new MultipleSessionException('Unable to initiate session, session already started');
53 53
         }
54 54
 
55 55
         //Initiating proper session handler
56
-        if ($this->config->getHandler() !== null) {
57
-            try {
56
+        if ($this->config->getHandler() !== null){
57
+            try{
58 58
                 $handler = $this->config->getHandler()->resolve($this->factory);
59
-            } catch (\Throwable | ContainerExceptionInterface $e) {
59
+            }catch (\Throwable | ContainerExceptionInterface $e){
60 60
                 throw new SessionException($e->getMessage(), $e->getCode(), $e);
61 61
             }
62 62
 
Please login to merge, or discard this patch.
src/Session/src/Session.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $this->clientSignature = $clientSignature;
73 73
         $this->lifetime = $lifetime;
74 74
 
75
-        if (!empty($id) && $this->validID($id)) {
75
+        if (!empty($id) && $this->validID($id)){
76 76
             $this->id = $id;
77 77
         }
78 78
     }
@@ -103,24 +103,24 @@  discard block
 block discarded – undo
103 103
      */
104 104
     public function resume(): void
105 105
     {
106
-        if ($this->isStarted()) {
106
+        if ($this->isStarted()){
107 107
             return;
108 108
         }
109 109
 
110
-        if (!empty($this->id)) {
110
+        if (!empty($this->id)){
111 111
             session_id($this->id);
112
-        } else {
112
+        }else{
113 113
             // always new id
114 114
             session_id(session_create_id());
115 115
         }
116 116
 
117
-        try {
117
+        try{
118 118
             session_start(['use_cookies' => false]);
119
-        } catch (\Throwable $e) {
119
+        }catch (\Throwable $e){
120 120
             throw new SessionException('Unable to start session', $e->getCode(), $e);
121 121
         }
122 122
 
123
-        if (empty($this->id)) {
123
+        if (empty($this->id)){
124 124
             //Sign newly created session
125 125
             $_SESSION[self::CLIENT_SIGNATURE] = $this->clientSignature;
126 126
             $_SESSION[self::SESSION_CREATED] = time();
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
         $this->started = true;
132 132
 
133 133
         //Ensure that session is valid
134
-        if (!$this->validSession()) {
134
+        if (!$this->validSession()){
135 135
             $this->invalidateSession();
136 136
         }
137 137
     }
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      */
171 171
     public function commit(): bool
172 172
     {
173
-        if (!$this->isStarted()) {
173
+        if (!$this->isStarted()){
174 174
             return false;
175 175
         }
176 176
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
      */
186 186
     public function abort(): bool
187 187
     {
188
-        if (!$this->isStarted()) {
188
+        if (!$this->isStarted()){
189 189
             return false;
190 190
         }
191 191
 
@@ -228,17 +228,17 @@  discard block
 block discarded – undo
228 228
         if (
229 229
             !array_key_exists(self::CLIENT_SIGNATURE, $_SESSION)
230 230
             || !array_key_exists(self::SESSION_CREATED, $_SESSION)
231
-        ) {
231
+        ){
232 232
             //Missing session signature or timestamp!
233 233
             return false;
234 234
         }
235 235
 
236
-        if ($_SESSION[self::SESSION_CREATED] < time() - $this->lifetime) {
236
+        if ($_SESSION[self::SESSION_CREATED] < time() - $this->lifetime){
237 237
             //Session expired
238 238
             return false;
239 239
         }
240 240
 
241
-        if (!hash_equals($_SESSION[self::CLIENT_SIGNATURE], $this->clientSignature)) {
241
+        if (!hash_equals($_SESSION[self::CLIENT_SIGNATURE], $this->clientSignature)){
242 242
             //Signatures do not match
243 243
             return false;
244 244
         }
Please login to merge, or discard this patch.
src/Session/src/Config/SessionConfig.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,15 +64,15 @@
 block discarded – undo
64 64
      */
65 65
     public function getHandler(): ?Autowire
66 66
     {
67
-        if (empty($this->config['handler'])) {
67
+        if (empty($this->config['handler'])){
68 68
             return null;
69 69
         }
70 70
 
71
-        if ($this->config['handler'] instanceof Autowire) {
71
+        if ($this->config['handler'] instanceof Autowire){
72 72
             return $this->config['handler'];
73 73
         }
74 74
 
75
-        if (class_exists($this->config['handler'])) {
75
+        if (class_exists($this->config['handler'])){
76 76
             return new Autowire($this->config['handler']);
77 77
         }
78 78
 
Please login to merge, or discard this patch.