Spiral\Tests\Storage\TestCase

Complexity

Total Complexity

7

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	cleanTempDirectory()	0	24	5
A	tearDown()	0	5	1
A	setUp()	0	10	1

<?php

declare(strict_types=1);

namespace Spiral\Tests\Storage;

use League\Flysystem\Local\LocalFilesystemAdapter;
use PHPUnit\Framework\TestCase as BaseTestCase;
use Spiral\Storage\Bucket;
use Spiral\Storage\BucketInterface;

class TestCase extends BaseTestCase
{
    /**
     * @var string
     */
    protected const LOCAL_STORAGE_DIRECTORY = __DIR__ . '/storage';

    /**
     * @var BucketInterface
     */
    protected $local;

    /**
     * @var BucketInterface
     */
    protected $second;

    /**
     * @return void
     */
    public function setUp(): void
    {
        parent::setUp();

        $this->local = Bucket::fromAdapter(
            new LocalFilesystemAdapter(self::LOCAL_STORAGE_DIRECTORY)
        );

        $this->second = Bucket::fromAdapter(
            new LocalFilesystemAdapter(self::LOCAL_STORAGE_DIRECTORY . '/second')
        );
    }

    /**
     * @return void
     */
    public function tearDown(): void
    {
        $this->cleanTempDirectory();

        parent::tearDown();
    }

    /**
     * @return void
     */
    protected function cleanTempDirectory(): void
    {
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator(self::LOCAL_STORAGE_DIRECTORY, \FilesystemIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::CHILD_FIRST
        );

        /** @var \SplFileInfo $file */
        foreach($iterator as $file) {
            if ($file->getFilename() === '.gitignore') {
                continue;
            }

            \error_clear_last();

            if ($file->isDir()) {
                @\rmdir($file->getPathname());

It seems like you do not handle an error condition for rmdir(). This can introduce security issues, and is generally not recommended.

            } else {
                @\unlink($file->getPathname());

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

            }

            if ($error = \error_get_last()) {
                $prefix = 'An error occurred while clear temporary local storage directory: ';
                $this->addWarning($prefix . $error['message']);
            }
        }
    }
}