View GitHub Repository framework

Schedule Inspection
Subscribe
Passed
Branch — master (ebd990)
by Anton
04:32
created
Category
Toggle Patches
src/Command/Views/CompileCommand.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -32,12 +32,12 @@  discard block
 
 block discarded – undo
32 32 
         $generator = new ContextGenerator($views->getContext());
33 33
34 34 
         $contexts = $generator->generate();
35 
-        if (empty($contexts)) {
35 
+        if (empty($contexts)){
36 36 
             $contexts[] = $views->getContext();
37 37 
         }
38 38
39 
-        foreach ($contexts as $context) {
40 
-            foreach ($views->getEngines() as $engine) {
39 
+        foreach ($contexts as $context){
40 
+            foreach ($views->getEngines() as $engine){
41 41 
                 $this->compile($engine, $context);
42 42 
             }
43 43 
         }
 
@@ -57,19 +57,19 @@  discard block
 
 block discarded – undo
57 57 
             $this->describeContext($context) ?? "default"
58 58 
         );
59 59
60 
-        foreach ($engine->getLoader()->list() as $path) {
60 
+        foreach ($engine->getLoader()->list() as $path){
61 61 
             $start = microtime(true);
62 
-            try {
62 
+            try{
63 63 
                 $engine->reset($path, $context);
64 64 
                 $engine->compile($path, $context);
65 65
66 
-                if ($this->isVerbose()) {
66 
+                if ($this->isVerbose()){
67 67 
                     $this->sprintf("<info>•</info> %s", $path);
68 68 
                 }
69 
-            } catch (\Throwable $e) {
69 
+            }catch (\Throwable $e){
70 70 
                 $this->renderError($path, $e);
71 71 
                 continue;
72 
-            } finally {
72 
+            }finally{
73 73 
                 $this->renderElapsed($start);
74 74 
             }
75 75 
         }
 
@@ -85,7 +85,7 @@  discard block
 
 block discarded – undo
85 85 
     {
86 86 
         $values = [];
87 87
88 
-        foreach ($context->getDependencies() as $dependency) {
88 
+        foreach ($context->getDependencies() as $dependency){
89 89 
             $values[] = sprintf(
90 90 
                 "%s%s%s:%s%s%s",
91 91 
                 Color::LIGHT_WHITE,
 
@@ -117,7 +117,7 @@  discard block
 
 block discarded – undo
117 117 
      */
118 118 
     protected function renderError(string $path, \Throwable $e): void
119 119 
     {
120 
-        if (!$this->isVerbose()) {
120 
+        if (!$this->isVerbose()){
121 121 
             return;
122 122 
         }
123 123 
 
@@ -134,11 +134,11 @@  discard block
 
 block discarded – undo
134 134 
      */
135 135 
     private function renderSuccess(string $lastPath = null): void
136 136 
     {
137 
-        if (!$this->isVerbose()) {
137 
+        if (!$this->isVerbose()){
138 138 
             return;
139 139 
         }
140 140
141 
-        if ($lastPath === null) {
141 
+        if ($lastPath === null){
142 142 
             $this->writeln("• no views found");
143 143 
         }
144 144 
 
@@ -150,7 +150,7 @@  discard block
 
 block discarded – undo
150 150 
      */
151 151 
     private function renderElapsed(float $start): void
152 152 
     {
153 
-        if (!$this->isVerbose()) {
153 
+        if (!$this->isVerbose()){
154 154 
             return;
155 155 
         }
156 156
Please login to merge, or discard this patch.
Braces   +28 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -32,12 +32,15 @@  discard block
 
 block discarded – undo
32 32 
         $generator = new ContextGenerator($views->getContext());
33 33
34 34 
         $contexts = $generator->generate();
35 
-        if (empty($contexts)) {
35 
+        if (empty($contexts))
36 
+        {
36 37 
             $contexts[] = $views->getContext();
37 38 
         }
38 39
39 
-        foreach ($contexts as $context) {
40 
-            foreach ($views->getEngines() as $engine) {
40 
+        foreach ($contexts as $context)
41 
+        {
42 
+            foreach ($views->getEngines() as $engine)
43 
+            {
41 44 
                 $this->compile($engine, $context);
42 45 
             }
43 46 
         }
 
@@ -57,19 +60,26 @@  discard block
 
 block discarded – undo
57 60 
             $this->describeContext($context) ?? "default"
58 61 
         );
59 62
60 
-        foreach ($engine->getLoader()->list() as $path) {
63 
+        foreach ($engine->getLoader()->list() as $path)
64 
+        {
61 65 
             $start = microtime(true);
62 
-            try {
66 
+            try
67 
+            {
63 68 
                 $engine->reset($path, $context);
64 69 
                 $engine->compile($path, $context);
65 70
66 
-                if ($this->isVerbose()) {
71 
+                if ($this->isVerbose())
72 
+                {
67 73 
                     $this->sprintf("<info>•</info> %s", $path);
68 74 
                 }
69 
-            } catch (\Throwable $e) {
75 
+            }
76 
+            catch (\Throwable $e)
77 
+            {
70 78 
                 $this->renderError($path, $e);
71 79 
                 continue;
72 
-            } finally {
80 
+            }
81 
+            finally
82 
+            {
73 83 
                 $this->renderElapsed($start);
74 84 
             }
75 85 
         }
 
@@ -85,7 +95,8 @@  discard block
 
 block discarded – undo
85 95 
     {
86 96 
         $values = [];
87 97
88 
-        foreach ($context->getDependencies() as $dependency) {
98 
+        foreach ($context->getDependencies() as $dependency)
99 
+        {
89 100 
             $values[] = sprintf(
90 101 
                 "%s%s%s:%s%s%s",
91 102 
                 Color::LIGHT_WHITE,
 
@@ -117,7 +128,8 @@  discard block
 
 block discarded – undo
117 128 
      */
118 129 
     protected function renderError(string $path, \Throwable $e): void
119 130 
     {
120 
-        if (!$this->isVerbose()) {
131 
+        if (!$this->isVerbose())
132 
+        {
121 133 
             return;
122 134 
         }
123 135 
 
@@ -134,11 +146,13 @@  discard block
 
 block discarded – undo
134 146 
      */
135 147 
     private function renderSuccess(string $lastPath = null): void
136 148 
     {
137 
-        if (!$this->isVerbose()) {
149 
+        if (!$this->isVerbose())
150 
+        {
138 151 
             return;
139 152 
         }
140 153
141 
-        if ($lastPath === null) {
154 
+        if ($lastPath === null)
155 
+        {
142 156 
             $this->writeln("• no views found");
143 157 
         }
144 158 
 
@@ -150,7 +164,8 @@  discard block
 
 block discarded – undo
150 164 
      */
151 165 
     private function renderElapsed(float $start): void
152 166 
     {
153 
-        if (!$this->isVerbose()) {
167 
+        if (!$this->isVerbose())
168 
+        {
154 169 
             return;
155 170 
         }
156 171
Please login to merge, or discard this patch.
tests/Framework/Http/SapiTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -39,7 +39,7 @@  discard block
 
 block discarded – undo
39 39 
         $e = new BufferEmitter();
40 40
41 41 
         $files = $this->app->get(FilesInterface::class)->getFiles(
42 
-            $this->app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
42 
+            $this->app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
43 43 
         );
44 44
45 45 
         $this->assertCount(0, $files);
 
@@ -48,7 +48,7 @@  discard block
 
 block discarded – undo
48 48 
         $this->app->get(SapiDispatcher::class)->serve($e);
49 49
50 50 
         $files = $this->app->get(FilesInterface::class)->getFiles(
51 
-            $this->app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
51 
+            $this->app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
52 52 
         );
53 53
54 54 
         $this->assertCount(1, $files);
 
@@ -65,7 +65,7 @@  discard block
 
 block discarded – undo
65 65 
         ]);
66 66
67 67 
         $files = $app->get(FilesInterface::class)->getFiles(
68 
-            $app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
68 
+            $app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
69 69 
         );
70 70
71 71 
         $this->assertCount(0, $files);
 
@@ -74,7 +74,7 @@  discard block
 
 block discarded – undo
74 74 
         $app->get(SapiDispatcher::class)->serve($e);
75 75
76 76 
         $files = $app->get(FilesInterface::class)->getFiles(
77 
-            $app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
77 
+            $app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
78 78 
         );
79 79
80 80 
         $this->assertCount(1, $files);
Please login to merge, or discard this patch.
tests/Framework/Http/RrTest.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -21,7 +21,7 @@  discard block
 
 block discarded – undo
21 21 
     public function setUp()
22 22 
     {
23 23 
         parent::setUp();
24 
-        ini_set('error_log', __DIR__ . '/err.log');
24 
+        ini_set('error_log', __DIR__.'/err.log');
25 25 
     }
26 26
27 27 
     public function tearDown()
 
@@ -29,8 +29,8 @@  discard block
 
 block discarded – undo
29 29 
         parent::tearDown();
30 30 
         ini_set('error_log', 'stderr');
31 31
32 
-        if (file_exists(__DIR__ . '/err.log')) {
33 
-            unlink(__DIR__ . '/err.log');
32 
+        if (file_exists(__DIR__.'/err.log')){
33 
+            unlink(__DIR__.'/err.log');
34 34 
         }
35 35 
     }
36 36 
 
@@ -56,7 +56,7 @@  discard block
 
 block discarded – undo
56 56 
         );
57 57
58 58 
         $psr->shouldReceive('respond')->once()->with(
59 
-            \Mockery::on(function ($r) {
59 
+            \Mockery::on(function ($r){
60 60 
                 $this->assertSame('Hello, dave.', (string)$r->getBody());
61 61 
                 return true;
62 62 
             })
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
         );
79 79
80 80 
         $psr->shouldReceive('respond')->once()->with(
81 
-            \Mockery::on(function ($r) {
81 
+            \Mockery::on(function ($r){
82 82 
                 $this->assertContains('500', (string)$r->getBody());
83 83 
                 return true;
84 84 
             })
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
         $psr->shouldReceive('acceptRequest')->once()->andReturn(null);
88 88
89 89 
         $files = $this->app->get(FilesInterface::class)->getFiles(
90 
-            $this->app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
90 
+            $this->app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
91 91 
         );
92 92
93 93 
         $this->assertCount(0, $files);
 
@@ -95,7 +95,7 @@  discard block
 
 block discarded – undo
95 95 
         $this->app->get(RrDispacher::class)->serve($psr);
96 96
97 97 
         $files = $this->app->get(FilesInterface::class)->getFiles(
98 
-            $this->app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
98 
+            $this->app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
99 99 
         );
100 100
101 101 
         $this->assertCount(1, $files);
 
@@ -116,7 +116,7 @@  discard block
 
 block discarded – undo
116 116 
         );
117 117
118 118 
         $psr->shouldReceive('respond')->once()->with(
119 
-            \Mockery::on(function ($r) {
119 
+            \Mockery::on(function ($r){
120 120 
                 $this->assertContains('undefined', (string)$r->getBody());
121 121 
                 return true;
122 122 
             })
 
@@ -125,7 +125,7 @@  discard block
 
 block discarded – undo
125 125 
         $psr->shouldReceive('acceptRequest')->once()->andReturn(null);
126 126
127 127 
         $files = $this->app->get(FilesInterface::class)->getFiles(
128 
-            $this->app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
128 
+            $this->app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
129 129 
         );
130 130
131 131 
         $this->assertCount(0, $files);
 
@@ -133,11 +133,11 @@  discard block
 
 block discarded – undo
133 133 
         $this->app->get(RrDispacher::class)->serve($psr);
134 134
135 135 
         $files = $this->app->get(FilesInterface::class)->getFiles(
136 
-            $this->app->get(DirectoriesInterface::class)->get('runtime') . '/snapshots/'
136 
+            $this->app->get(DirectoriesInterface::class)->get('runtime').'/snapshots/'
137 137 
         );
138 138
139 139 
         $this->assertCount(1, $files);
140 140
141 
-        $this->assertContains('undefined', file_get_contents(__DIR__ . '/err.log'));
141 
+        $this->assertContains('undefined', file_get_contents(__DIR__.'/err.log'));
142 142 
     }
143 143 
 }
144 144 
\ No newline at end of file
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -29,7 +29,8 @@  discard block
 
 block discarded – undo
29 29 
         parent::tearDown();
30 30 
         ini_set('error_log', 'stderr');
31 31
32 
-        if (file_exists(__DIR__ . '/err.log')) {
32 
+        if (file_exists(__DIR__ . '/err.log'))
33 
+        {
33 34 
             unlink(__DIR__ . '/err.log');
34 35 
         }
35 36 
     }
 
@@ -56,7 +57,8 @@  discard block
 
 block discarded – undo
56 57 
         );
57 58
58 59 
         $psr->shouldReceive('respond')->once()->with(
59 
-            \Mockery::on(function ($r) {
60 
+            \Mockery::on(function ($r)
61 
+            {
60 62 
                 $this->assertSame('Hello, dave.', (string)$r->getBody());
61 63 
                 return true;
62 64 
             })
 
@@ -78,7 +80,8 @@  discard block
 
 block discarded – undo
78 80 
         );
79 81
80 82 
         $psr->shouldReceive('respond')->once()->with(
81 
-            \Mockery::on(function ($r) {
83 
+            \Mockery::on(function ($r)
84 
+            {
82 85 
                 $this->assertContains('500', (string)$r->getBody());
83 86 
                 return true;
84 87 
             })
 
@@ -116,7 +119,8 @@  discard block
 
 block discarded – undo
116 119 
         );
117 120
118 121 
         $psr->shouldReceive('respond')->once()->with(
119 
-            \Mockery::on(function ($r) {
122 
+            \Mockery::on(function ($r)
123 
+            {
120 124 
                 $this->assertContains('undefined', (string)$r->getBody());
121 125 
                 return true;
122 126 
             })
Please login to merge, or discard this patch.