Passed
Pull Request — master (#737)
by Vadim
08:14
created
src/Prototype/src/NodeVisitors/LocateProperties.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -50,13 +50,13 @@
 block discarded – undo
50 50
             $node instanceof Node\Expr\PropertyFetch &&
51 51
             $node->var instanceof Node\Expr\Variable &&
52 52
             $node->var->name === 'this'
53
-        ) {
53
+        ){
54 54
             $this->requested[$node->name->name] = $node->name->name;
55 55
         }
56 56
 
57
-        if ($node instanceof Node\Stmt\Property) {
58
-            foreach ($node->props as $prop) {
59
-                if ($prop instanceof Node\Stmt\PropertyProperty) {
57
+        if ($node instanceof Node\Stmt\Property){
58
+            foreach ($node->props as $prop){
59
+                if ($prop instanceof Node\Stmt\PropertyProperty){
60 60
                     $this->properties[$prop->name->name] = $prop->name->name;
61 61
                 }
62 62
             }
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -54,9 +54,12 @@
 block discarded – undo
54 54
             $this->requested[$node->name->name] = $node->name->name;
55 55
         }
56 56
 
57
-        if ($node instanceof Node\Stmt\Property) {
58
-            foreach ($node->props as $prop) {
59
-                if ($prop instanceof Node\Stmt\PropertyProperty) {
57
+        if ($node instanceof Node\Stmt\Property)
58
+        {
59
+            foreach ($node->props as $prop)
60
+            {
61
+                if ($prop instanceof Node\Stmt\PropertyProperty)
62
+                {
60 63
                     $this->properties[$prop->name->name] = $prop->name->name;
61 64
                 }
62 65
             }
Please login to merge, or discard this patch.
src/Prototype/src/NodeVisitors/RemoveUse.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,17 +27,17 @@
 block discarded – undo
27 27
      */
28 28
     public function leaveNode(Node $node)
29 29
     {
30
-        if (!$node instanceof Node\Stmt\Use_) {
30
+        if (!$node instanceof Node\Stmt\Use_){
31 31
             return null;
32 32
         }
33 33
 
34
-        foreach ($node->uses as $index => $use) {
35
-            if ($use->name->toString() === PrototypeTrait::class) {
34
+        foreach ($node->uses as $index => $use){
35
+            if ($use->name->toString() === PrototypeTrait::class){
36 36
                 unset($node->uses[$index]);
37 37
             }
38 38
         }
39 39
 
40
-        if (empty($node->uses)) {
40
+        if (empty($node->uses)){
41 41
             return NodeTraverser::REMOVE_NODE;
42 42
         }
43 43
 
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,17 +27,21 @@
 block discarded – undo
27 27
      */
28 28
     public function leaveNode(Node $node)
29 29
     {
30
-        if (!$node instanceof Node\Stmt\Use_) {
30
+        if (!$node instanceof Node\Stmt\Use_)
31
+        {
31 32
             return null;
32 33
         }
33 34
 
34
-        foreach ($node->uses as $index => $use) {
35
-            if ($use->name->toString() === PrototypeTrait::class) {
35
+        foreach ($node->uses as $index => $use)
36
+        {
37
+            if ($use->name->toString() === PrototypeTrait::class)
38
+            {
36 39
                 unset($node->uses[$index]);
37 40
             }
38 41
         }
39 42
 
40
-        if (empty($node->uses)) {
43
+        if (empty($node->uses))
44
+        {
41 45
             return NodeTraverser::REMOVE_NODE;
42 46
         }
43 47
 
Please login to merge, or discard this patch.
src/Prototype/src/NodeVisitors/DefineConstructor.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,15 +27,15 @@
 block discarded – undo
27 27
      */
28 28
     public function leaveNode(Node $node)
29 29
     {
30
-        if (!$node instanceof Node\Stmt\Class_) {
30
+        if (!$node instanceof Node\Stmt\Class_){
31 31
             return null;
32 32
         }
33 33
 
34 34
         $placementID = 0;
35
-        foreach ($node->stmts as $index => $child) {
35
+        foreach ($node->stmts as $index => $child){
36 36
             $placementID = $index;
37
-            if ($child instanceof Node\Stmt\ClassMethod) {
38
-                if ($child->name->name === '__construct') {
37
+            if ($child instanceof Node\Stmt\ClassMethod){
38
+                if ($child->name->name === '__construct'){
39 39
                     $node->setAttribute('constructor', $child);
40 40
 
41 41
                     return null;
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,15 +27,19 @@
 block discarded – undo
27 27
      */
28 28
     public function leaveNode(Node $node)
29 29
     {
30
-        if (!$node instanceof Node\Stmt\Class_) {
30
+        if (!$node instanceof Node\Stmt\Class_)
31
+        {
31 32
             return null;
32 33
         }
33 34
 
34 35
         $placementID = 0;
35
-        foreach ($node->stmts as $index => $child) {
36
+        foreach ($node->stmts as $index => $child)
37
+        {
36 38
             $placementID = $index;
37
-            if ($child instanceof Node\Stmt\ClassMethod) {
38
-                if ($child->name->name === '__construct') {
39
+            if ($child instanceof Node\Stmt\ClassMethod)
40
+            {
41
+                if ($child->name->name === '__construct')
42
+                {
39 43
                     $node->setAttribute('constructor', $child);
40 44
 
41 45
                     return null;
Please login to merge, or discard this patch.
src/Prototype/src/Traits/PrototypeTrait.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     public function __get(string $name)
34 34
     {
35 35
         $container = ContainerScope::getContainer();
36
-        if ($container === null || !$container->has(PrototypeRegistry::class)) {
36
+        if ($container === null || !$container->has(PrototypeRegistry::class)){
37 37
             throw new ScopeException(
38 38
                 "Unable to resolve prototyped dependency `{$name}`, invalid container scope"
39 39
             );
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
             $target === null ||
48 48
             $target instanceof \Throwable ||
49 49
             $target->type->fullName === null
50
-        ) {
50
+        ){
51 51
             throw new PrototypeException(
52 52
                 "Undefined prototype property `{$name}`",
53 53
                 0,
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,8 @@
 block discarded – undo
33 33
     public function __get(string $name)
34 34
     {
35 35
         $container = ContainerScope::getContainer();
36
-        if ($container === null || !$container->has(PrototypeRegistry::class)) {
36
+        if ($container === null || !$container->has(PrototypeRegistry::class))
37
+        {
37 38
             throw new ScopeException(
38 39
                 "Unable to resolve prototyped dependency `{$name}`, invalid container scope"
39 40
             );
Please login to merge, or discard this patch.
src/Prototype/src/PrototypeRegistry.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,15 +64,15 @@
 block discarded – undo
64 64
     public function resolveProperty(string $name)
65 65
     {
66 66
         $dependency = $this->dependencies[$name] ?? null;
67
-        if ($dependency === null) {
67
+        if ($dependency === null){
68 68
             return null;
69 69
         }
70 70
 
71
-        try {
71
+        try{
72 72
             $this->container->get($dependency->type->name());
73 73
 
74 74
             return $dependency;
75
-        } catch (ContainerExceptionInterface $e) {
75
+        }catch (ContainerExceptionInterface $e){
76 76
             return $e;
77 77
         }
78 78
     }
Please login to merge, or discard this patch.
Braces   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,15 +64,19 @@
 block discarded – undo
64 64
     public function resolveProperty(string $name)
65 65
     {
66 66
         $dependency = $this->dependencies[$name] ?? null;
67
-        if ($dependency === null) {
67
+        if ($dependency === null)
68
+        {
68 69
             return null;
69 70
         }
70 71
 
71
-        try {
72
+        try
73
+        {
72 74
             $this->container->get($dependency->type->name());
73 75
 
74 76
             return $dependency;
75
-        } catch (ContainerExceptionInterface $e) {
77
+        }
78
+        catch (ContainerExceptionInterface $e)
79
+        {
76 80
             return $e;
77 81
         }
78 82
     }
Please login to merge, or discard this patch.
src/Prototype/src/Utils.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
     public static function shortName(string $name): string
26 26
     {
27 27
         $pos = mb_strrpos($name, '\\');
28
-        if ($pos === false) {
28
+        if ($pos === false){
29 29
             return $name;
30 30
         }
31 31
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     public static function trimTrailingDigits(string $name, int $number): string
59 59
     {
60 60
         $pos = mb_strripos($name, (string)$number);
61
-        if ($pos === false) {
61
+        if ($pos === false){
62 62
             return $name;
63 63
         }
64 64
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@  discard block
 block discarded – undo
25 25
     public static function shortName(string $name): string
26 26
     {
27 27
         $pos = mb_strrpos($name, '\\');
28
-        if ($pos === false) {
28
+        if ($pos === false)
29
+        {
29 30
             return $name;
30 31
         }
31 32
 
@@ -58,7 +59,8 @@  discard block
 block discarded – undo
58 59
     public static function trimTrailingDigits(string $name, int $number): string
59 60
     {
60 61
         $pos = mb_strripos($name, (string)$number);
61
-        if ($pos === false) {
62
+        if ($pos === false)
63
+        {
62 64
             return $name;
63 65
         }
64 66
 
Please login to merge, or discard this patch.
src/Prototype/tests/Traverse/Extractor.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
     private function traverse(string $code, NodeVisitor ...$visitors): void
58 58
     {
59 59
         $tr = new NodeTraverser();
60
-        foreach ($visitors as $visitor) {
60
+        foreach ($visitors as $visitor){
61 61
             $tr->addVisitor($visitor);
62 62
         }
63 63
 
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,8 @@
 block discarded – undo
57 57
     private function traverse(string $code, NodeVisitor ...$visitors): void
58 58
     {
59 59
         $tr = new NodeTraverser();
60
-        foreach ($visitors as $visitor) {
60
+        foreach ($visitors as $visitor)
61
+        {
61 62
             $tr->addVisitor($visitor);
62 63
         }
63 64
 
Please login to merge, or discard this patch.
src/Prototype/tests/ExtractorTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
         $e = new PropertyExtractor();
22 22
 
23 23
         $expected = ['test', 'test2', 'test3', 'testClass'];
24
-        $prototypes = $e->getPrototypeProperties(file_get_contents(__DIR__ . '/Fixtures/TestClass.php'));
24
+        $prototypes = $e->getPrototypeProperties(file_get_contents(__DIR__.'/Fixtures/TestClass.php'));
25 25
         sort($prototypes);
26 26
         $this->assertSame($expected, $prototypes);
27 27
     }
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
         $e = new PropertyExtractor();
32 32
         $this->assertSame(
33 33
             [],
34
-            $e->getPrototypeProperties(file_get_contents(__DIR__ . '/Fixtures/HydratedClass.php'))
34
+            $e->getPrototypeProperties(file_get_contents(__DIR__.'/Fixtures/HydratedClass.php'))
35 35
         );
36 36
     }
37 37
 }
Please login to merge, or discard this patch.
src/Prototype/tests/ClassNode/ExtractorTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     public function testNoClass(): void
19 19
     {
20 20
         $this->expectException(ClassNotDeclaredException::class);
21
-        $this->getExtractor()->extract(dirname(__DIR__) . '/Fixtures/noClass.php', []);
21
+        $this->getExtractor()->extract(dirname(__DIR__).'/Fixtures/noClass.php', []);
22 22
     }
23 23
 
24 24
     private function getExtractor(): NodeExtractor
Please login to merge, or discard this patch.