Test Failed
Pull Request — master (#928)
by butschster
08:19
created
src/Hmvc/tests/DemoInterceptor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,6 +11,6 @@
 block discarded – undo
11 11
 {
12 12
     public function process(string $controller, string $action, array $parameters, CoreInterface $core): string
13 13
     {
14
-        return '?' . $core->callAction($controller, $action, $parameters) . '!';
14
+        return '?'.$core->callAction($controller, $action, $parameters).'!';
15 15
     }
16 16
 }
Please login to merge, or discard this patch.
src/Hmvc/tests/InterceptorPipelineTest.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function testInterceptorCallingEventShouldBeDispatched(): void
17 17
     {
18
-        $interceptor = new class implements CoreInterceptorInterface {
18
+        $interceptor = new class implements CoreInterceptorInterface{
19 19
             public function process(string $controller, string $action, array $parameters, CoreInterface $core): mixed
20 20
             {
21 21
                 return null;
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
         $pipeline = new InterceptorPipeline($dispatcher);
32 32
         $pipeline->addInterceptor($interceptor);
33 33
 
34
-        $pipeline->withCore(new class implements CoreInterface {
34
+        $pipeline->withCore(new class implements CoreInterface{
35 35
             public function callAction(string $controller, string $action, array $parameters = []): mixed
36 36
             {
37 37
                 return null;
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,8 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function testInterceptorCallingEventShouldBeDispatched(): void
17 17
     {
18
-        $interceptor = new class implements CoreInterceptorInterface {
18
+        $interceptor = new class implements CoreInterceptorInterface
19
+        {
19 20
             public function process(string $controller, string $action, array $parameters, CoreInterface $core): mixed
20 21
             {
21 22
                 return null;
@@ -31,7 +32,8 @@  discard block
 block discarded – undo
31 32
         $pipeline = new InterceptorPipeline($dispatcher);
32 33
         $pipeline->addInterceptor($interceptor);
33 34
 
34
-        $pipeline->withCore(new class implements CoreInterface {
35
+        $pipeline->withCore(new class implements CoreInterface
36
+        {
35 37
             public function callAction(string $controller, string $action, array $parameters = []): mixed
36 38
             {
37 39
                 return null;
Please login to merge, or discard this patch.
src/Hmvc/src/InterceptorPipeline.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 
23 23
     public function __construct(
24 24
         private readonly ?EventDispatcherInterface $dispatcher = null
25
-    ) {
25
+    ){
26 26
     }
27 27
 
28 28
     public function addInterceptor(CoreInterceptorInterface $interceptor): void
@@ -43,12 +43,12 @@  discard block
 block discarded – undo
43 43
      */
44 44
     public function callAction(string $controller, string $action, array $parameters = []): mixed
45 45
     {
46
-        if ($this->core === null) {
46
+        if ($this->core === null){
47 47
             throw new InterceptorException('Unable to invoke pipeline without assigned core');
48 48
         }
49 49
 
50 50
         $position = $this->position++;
51
-        if (isset($this->interceptors[$position])) {
51
+        if (isset($this->interceptors[$position])){
52 52
             $interceptor = $this->interceptors[$position];
53 53
             $this->dispatcher?->dispatch(new InterceptorCalling(
54 54
                 controller: $controller,
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,12 +43,14 @@
 block discarded – undo
43 43
      */
44 44
     public function callAction(string $controller, string $action, array $parameters = []): mixed
45 45
     {
46
-        if ($this->core === null) {
46
+        if ($this->core === null)
47
+        {
47 48
             throw new InterceptorException('Unable to invoke pipeline without assigned core');
48 49
         }
49 50
 
50 51
         $position = $this->position++;
51
-        if (isset($this->interceptors[$position])) {
52
+        if (isset($this->interceptors[$position]))
53
+        {
52 54
             $interceptor = $this->interceptors[$position];
53 55
             $this->dispatcher?->dispatch(new InterceptorCalling(
54 56
                 controller: $controller,
Please login to merge, or discard this patch.
src/Hmvc/src/InterceptableCore.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     public function __construct(
17 17
         private readonly CoreInterface $core,
18 18
         ?EventDispatcherInterface $dispatcher = null
19
-    ) {
19
+    ){
20 20
         $this->pipeline = new InterceptorPipeline($dispatcher);
21 21
     }
22 22
 
Please login to merge, or discard this patch.
src/Hmvc/src/Event/InterceptorCalling.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,6 +13,6 @@
 block discarded – undo
13 13
         public readonly string $action,
14 14
         public readonly array $parameters,
15 15
         public readonly CoreInterceptorInterface $interceptor
16
-    ) {
16
+    ){
17 17
     }
18 18
 }
Please login to merge, or discard this patch.
src/Hmvc/src/AbstractCore.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -24,16 +24,16 @@  discard block
 block discarded – undo
24 24
     public function __construct(
25 25
         /** @internal */
26 26
         protected ContainerInterface $container
27
-    ) {
27
+    ){
28 28
         // resolver is usually the container itself
29 29
         $this->resolver = $container->get(ResolverInterface::class);
30 30
     }
31 31
 
32 32
     public function callAction(string $controller, string $action, array $parameters = []): mixed
33 33
     {
34
-        try {
34
+        try{
35 35
             $method = new \ReflectionMethod($controller, $action);
36
-        } catch (\ReflectionException $e) {
36
+        }catch (\ReflectionException $e){
37 37
             throw new ControllerException(
38 38
                 \sprintf('Invalid action `%s`->`%s`', $controller, $action),
39 39
                 ControllerException::BAD_ACTION,
@@ -41,23 +41,23 @@  discard block
 block discarded – undo
41 41
             );
42 42
         }
43 43
 
44
-        if ($method->isStatic() || !$method->isPublic()) {
44
+        if ($method->isStatic() || !$method->isPublic()){
45 45
             throw new ControllerException(
46 46
                 \sprintf('Invalid action `%s`->`%s`', $controller, $action),
47 47
                 ControllerException::BAD_ACTION
48 48
             );
49 49
         }
50 50
 
51
-        try {
51
+        try{
52 52
             // getting the set of arguments should be sent to requested method
53 53
             $args = $this->resolver->resolveArguments($method, $parameters, validate: true);
54
-        } catch (ArgumentResolvingException|InvalidArgumentException $e) {
54
+        }catch (ArgumentResolvingException | InvalidArgumentException $e){
55 55
             throw new ControllerException(
56 56
                 \sprintf('Missing/invalid parameter %s of `%s`->`%s`', $e->getParameter(), $controller, $action),
57 57
                 ControllerException::BAD_ARGUMENT,
58 58
                 $e
59 59
             );
60
-        } catch (ContainerExceptionInterface $e) {
60
+        }catch (ContainerExceptionInterface $e){
61 61
             throw new ControllerException(
62 62
                 $e->getMessage(),
63 63
                 ControllerException::ERROR,
Please login to merge, or discard this patch.
Braces   +15 added lines, -6 removed lines patch added patch discarded remove patch
@@ -31,9 +31,12 @@  discard block
 block discarded – undo
31 31
 
32 32
     public function callAction(string $controller, string $action, array $parameters = []): mixed
33 33
     {
34
-        try {
34
+        try
35
+        {
35 36
             $method = new \ReflectionMethod($controller, $action);
36
-        } catch (\ReflectionException $e) {
37
+        }
38
+        catch (\ReflectionException $e)
39
+        {
37 40
             throw new ControllerException(
38 41
                 \sprintf('Invalid action `%s`->`%s`', $controller, $action),
39 42
                 ControllerException::BAD_ACTION,
@@ -41,23 +44,29 @@  discard block
 block discarded – undo
41 44
             );
42 45
         }
43 46
 
44
-        if ($method->isStatic() || !$method->isPublic()) {
47
+        if ($method->isStatic() || !$method->isPublic())
48
+        {
45 49
             throw new ControllerException(
46 50
                 \sprintf('Invalid action `%s`->`%s`', $controller, $action),
47 51
                 ControllerException::BAD_ACTION
48 52
             );
49 53
         }
50 54
 
51
-        try {
55
+        try
56
+        {
52 57
             // getting the set of arguments should be sent to requested method
53 58
             $args = $this->resolver->resolveArguments($method, $parameters, validate: true);
54
-        } catch (ArgumentResolvingException|InvalidArgumentException $e) {
59
+        }
60
+        catch (ArgumentResolvingException|InvalidArgumentException $e)
61
+        {
55 62
             throw new ControllerException(
56 63
                 \sprintf('Missing/invalid parameter %s of `%s`->`%s`', $e->getParameter(), $controller, $action),
57 64
                 ControllerException::BAD_ARGUMENT,
58 65
                 $e
59 66
             );
60
-        } catch (ContainerExceptionInterface $e) {
67
+        }
68
+        catch (ContainerExceptionInterface $e)
69
+        {
61 70
             throw new ControllerException(
62 71
                 $e->getMessage(),
63 72
                 ControllerException::ERROR,
Please login to merge, or discard this patch.
src/Pagination/src/Paginator.php 2 patches
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,8 @@  discard block
 block discarded – undo
71 71
     public function paginate(PaginableInterface $target): PaginatorInterface
72 72
     {
73 73
         $paginator = clone $this;
74
-        if ($target instanceof \Countable && $paginator->count === 0) {
74
+        if ($target instanceof \Countable && $paginator->count === 0)
75
+        {
75 76
             $paginator->setCount($target->count());
76 77
         }
77 78
 
@@ -93,7 +94,8 @@  discard block
 block discarded – undo
93 94
 
94 95
     public function countDisplayed(): int
95 96
     {
96
-        if ($this->getPage() === $this->countPages) {
97
+        if ($this->getPage() === $this->countPages)
98
+        {
97 99
             return $this->count - $this->getOffset();
98 100
         }
99 101
 
@@ -107,7 +109,8 @@  discard block
 block discarded – undo
107 109
 
108 110
     public function nextPage(): ?int
109 111
     {
110
-        if ($this->getPage() !== $this->countPages) {
112
+        if ($this->getPage() !== $this->countPages)
113
+        {
111 114
             return $this->getPage() + 1;
112 115
         }
113 116
 
@@ -116,7 +119,8 @@  discard block
 block discarded – undo
116 119
 
117 120
     public function previousPage(): ?int
118 121
     {
119
-        if ($this->getPage() > 1) {
122
+        if ($this->getPage() > 1)
123
+        {
120 124
             return $this->getPage() - 1;
121 125
         }
122 126
 
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
         private int $limit = 25,
18 18
         int $count = 0,
19 19
         private readonly ?string $parameter = null,
20
-    ) {
20
+    ){
21 21
         $this->setCount($count);
22 22
     }
23 23
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     public function paginate(PaginableInterface $target): PaginatorInterface
74 74
     {
75 75
         $paginator = clone $this;
76
-        if ($target instanceof \Countable && $paginator->count === 0) {
76
+        if ($target instanceof \Countable && $paginator->count === 0){
77 77
             $paginator->setCount($target->count());
78 78
         }
79 79
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
     public function countDisplayed(): int
97 97
     {
98
-        if ($this->getPage() === $this->countPages) {
98
+        if ($this->getPage() === $this->countPages){
99 99
             return $this->count - $this->getOffset();
100 100
         }
101 101
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
     public function nextPage(): ?int
111 111
     {
112
-        if ($this->getPage() !== $this->countPages) {
112
+        if ($this->getPage() !== $this->countPages){
113 113
             return $this->getPage() + 1;
114 114
         }
115 115
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
     public function previousPage(): ?int
120 120
     {
121
-        if ($this->getPage() > 1) {
121
+        if ($this->getPage() > 1){
122 122
             return $this->getPage() - 1;
123 123
         }
124 124
 
Please login to merge, or discard this patch.
src/Boot/tests/MemoryTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -14,17 +14,17 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $core = TestCore::create([
16 16
             'root'  => __DIR__,
17
-            'cache' => __DIR__ . '/cache'
17
+            'cache' => __DIR__.'/cache'
18 18
         ])->run();
19 19
 
20 20
         /** @var MemoryInterface $memory */
21 21
         $memory = $core->getContainer()->get(MemoryInterface::class);
22 22
 
23 23
         $memory->saveData('test', 'data');
24
-        $this->assertFileExists(__DIR__ . '/cache/test.php');
24
+        $this->assertFileExists(__DIR__.'/cache/test.php');
25 25
         $this->assertSame('data', $memory->loadData('test'));
26 26
 
27
-        unlink(__DIR__ . '/cache/test.php');
27
+        unlink(__DIR__.'/cache/test.php');
28 28
         $this->assertNull($memory->loadData('test'));
29 29
     }
30 30
 
@@ -32,16 +32,16 @@  discard block
 block discarded – undo
32 32
     {
33 33
         $core = TestCore::create([
34 34
             'root'  => __DIR__,
35
-            'cache' => __DIR__ . '/cache'
35
+            'cache' => __DIR__.'/cache'
36 36
         ])->run();
37 37
 
38 38
         /** @var MemoryInterface $memory */
39 39
         $memory = $core->getContainer()->get(MemoryInterface::class);
40 40
 
41
-        file_put_contents(__DIR__ . '/cache/test.php', '<?php broken');
41
+        file_put_contents(__DIR__.'/cache/test.php', '<?php broken');
42 42
         $this->assertNull($memory->loadData('test'));
43 43
 
44
-        unlink(__DIR__ . '/cache/test.php');
44
+        unlink(__DIR__.'/cache/test.php');
45 45
         $this->assertNull($memory->loadData('test'));
46 46
     }
47 47
 }
Please login to merge, or discard this patch.
src/Boot/tests/Environment/DebugModeTest.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@
 block discarded – undo
33 33
 
34 34
         $this->assertSame($expected, $enum);
35 35
 
36
-        if ($enum === DebugMode::Enabled) {
36
+        if ($enum === DebugMode::Enabled){
37 37
             $this->assertTrue($enum->isEnabled());
38
-        } else {
38
+        }else{
39 39
             $this->assertFalse($enum->isEnabled());
40 40
         }
41 41
     }
Please login to merge, or discard this patch.
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,9 +33,12 @@
 block discarded – undo
33 33
 
34 34
         $this->assertSame($expected, $enum);
35 35
 
36
-        if ($enum === DebugMode::Enabled) {
36
+        if ($enum === DebugMode::Enabled)
37
+        {
37 38
             $this->assertTrue($enum->isEnabled());
38
-        } else {
39
+        }
40
+        else
41
+        {
39 42
             $this->assertFalse($enum->isEnabled());
40 43
         }
41 44
     }
Please login to merge, or discard this patch.