Completed
Push — master ( 6366df...fbe022 )
by Kirill
23s queued 19s
created
src/Router/src/Traits/PipelineTrait.php 2 patches
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -46,15 +46,15 @@  discard block
 block discarded – undo
46 46
         $route = clone $this;
47 47
 
48 48
         // array fallback
49
-        if (count($middleware) === 1 && is_array($middleware[0])) {
49
+        if (count($middleware) === 1 && is_array($middleware[0])){
50 50
             $middleware = $middleware[0];
51 51
         }
52 52
 
53
-        foreach ($middleware as $item) {
54
-            if (!is_string($item) && !$item instanceof MiddlewareInterface) {
55
-                if (is_object($item)) {
53
+        foreach ($middleware as $item){
54
+            if (!is_string($item) && !$item instanceof MiddlewareInterface){
55
+                if (is_object($item)){
56 56
                     $name = get_class($item);
57
-                } else {
57
+                }else{
58 58
                     $name = gettype($item);
59 59
                 }
60 60
 
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
             $route->middleware[] = $item;
65 65
         }
66 66
 
67
-        if ($route->pipeline !== null) {
67
+        if ($route->pipeline !== null){
68 68
             $route->pipeline = $route->makePipeline();
69 69
         }
70 70
 
@@ -81,22 +81,22 @@  discard block
 block discarded – undo
81 81
     protected function makePipeline(): Pipeline
82 82
     {
83 83
         // pre-aggregated
84
-        if (count($this->middleware) === 1 && $this->middleware[0] instanceof Pipeline) {
84
+        if (count($this->middleware) === 1 && $this->middleware[0] instanceof Pipeline){
85 85
             return $this->middleware[0];
86 86
         }
87 87
 
88
-        try {
88
+        try{
89 89
             $pipeline = $this->container->get(Pipeline::class);
90 90
 
91
-            foreach ($this->middleware as $middleware) {
92
-                if ($middleware instanceof MiddlewareInterface) {
91
+            foreach ($this->middleware as $middleware){
92
+                if ($middleware instanceof MiddlewareInterface){
93 93
                     $pipeline->pushMiddleware($middleware);
94
-                } else {
94
+                }else{
95 95
                     // dynamically resolved
96 96
                     $pipeline->pushMiddleware($this->container->get($middleware));
97 97
                 }
98 98
             }
99
-        } catch (ContainerExceptionInterface $e) {
99
+        }catch (ContainerExceptionInterface $e){
100 100
             throw new RouteException($e->getMessage(), $e->getCode(), $e);
101 101
         }
102 102
 
Please login to merge, or discard this patch.
Braces   +27 added lines, -12 removed lines patch added patch discarded remove patch
@@ -46,15 +46,21 @@  discard block
 block discarded – undo
46 46
         $route = clone $this;
47 47
 
48 48
         // array fallback
49
-        if (count($middleware) === 1 && is_array($middleware[0])) {
49
+        if (count($middleware) === 1 && is_array($middleware[0]))
50
+        {
50 51
             $middleware = $middleware[0];
51 52
         }
52 53
 
53
-        foreach ($middleware as $item) {
54
-            if (!is_string($item) && !$item instanceof MiddlewareInterface) {
55
-                if (is_object($item)) {
54
+        foreach ($middleware as $item)
55
+        {
56
+            if (!is_string($item) && !$item instanceof MiddlewareInterface)
57
+            {
58
+                if (is_object($item))
59
+                {
56 60
                     $name = get_class($item);
57
-                } else {
61
+                }
62
+                else
63
+                {
58 64
                     $name = gettype($item);
59 65
                 }
60 66
 
@@ -64,7 +70,8 @@  discard block
 block discarded – undo
64 70
             $route->middleware[] = $item;
65 71
         }
66 72
 
67
-        if ($route->pipeline !== null) {
73
+        if ($route->pipeline !== null)
74
+        {
68 75
             $route->pipeline = $route->makePipeline();
69 76
         }
70 77
 
@@ -81,22 +88,30 @@  discard block
 block discarded – undo
81 88
     protected function makePipeline(): Pipeline
82 89
     {
83 90
         // pre-aggregated
84
-        if (count($this->middleware) === 1 && $this->middleware[0] instanceof Pipeline) {
91
+        if (count($this->middleware) === 1 && $this->middleware[0] instanceof Pipeline)
92
+        {
85 93
             return $this->middleware[0];
86 94
         }
87 95
 
88
-        try {
96
+        try
97
+        {
89 98
             $pipeline = $this->container->get(Pipeline::class);
90 99
 
91
-            foreach ($this->middleware as $middleware) {
92
-                if ($middleware instanceof MiddlewareInterface) {
100
+            foreach ($this->middleware as $middleware)
101
+            {
102
+                if ($middleware instanceof MiddlewareInterface)
103
+                {
93 104
                     $pipeline->pushMiddleware($middleware);
94
-                } else {
105
+                }
106
+                else
107
+                {
95 108
                     // dynamically resolved
96 109
                     $pipeline->pushMiddleware($this->container->get($middleware));
97 110
                 }
98 111
             }
99
-        } catch (ContainerExceptionInterface $e) {
112
+        }
113
+        catch (ContainerExceptionInterface $e)
114
+        {
100 115
             throw new RouteException($e->getMessage(), $e->getCode(), $e);
101 116
         }
102 117
 
Please login to merge, or discard this patch.
src/Router/src/Traits/VerbsTrait.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@
 block discarded – undo
30 30
      */
31 31
     public function withVerbs(string ...$verbs): RouteInterface
32 32
     {
33
-        foreach ($verbs as &$verb) {
33
+        foreach ($verbs as &$verb){
34 34
             $verb = strtoupper($verb);
35
-            if (!in_array($verb, RouteInterface::VERBS, true)) {
35
+            if (!in_array($verb, RouteInterface::VERBS, true)){
36 36
                 throw new RouteException("Invalid HTTP verb `{$verb}`");
37 37
             }
38 38
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,9 +30,11 @@
 block discarded – undo
30 30
      */
31 31
     public function withVerbs(string ...$verbs): RouteInterface
32 32
     {
33
-        foreach ($verbs as &$verb) {
33
+        foreach ($verbs as &$verb)
34
+        {
34 35
             $verb = strtoupper($verb);
35
-            if (!in_array($verb, RouteInterface::VERBS, true)) {
36
+            if (!in_array($verb, RouteInterface::VERBS, true))
37
+            {
36 38
                 throw new RouteException("Invalid HTTP verb `{$verb}`");
37 39
             }
38 40
 
Please login to merge, or discard this patch.
src/Router/src/AbstractRoute.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,12 +65,12 @@
 block discarded – undo
65 65
      */
66 66
     public function match(Request $request): ?RouteInterface
67 67
     {
68
-        if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true)) {
68
+        if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true)){
69 69
             return null;
70 70
         }
71 71
 
72 72
         $matches = $this->uriHandler->match($request->getUri(), $this->defaults);
73
-        if ($matches === null) {
73
+        if ($matches === null){
74 74
             return null;
75 75
         }
76 76
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,12 +65,14 @@
 block discarded – undo
65 65
      */
66 66
     public function match(Request $request): ?RouteInterface
67 67
     {
68
-        if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true)) {
68
+        if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true))
69
+        {
69 70
             return null;
70 71
         }
71 72
 
72 73
         $matches = $this->uriHandler->match($request->getUri(), $this->defaults);
73
-        if ($matches === null) {
74
+        if ($matches === null)
75
+        {
74 76
             return null;
75 77
         }
76 78
 
Please login to merge, or discard this patch.
src/Router/src/CoreHandler.php 2 patches
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         CoreInterface $core,
61 61
         ScopeInterface $scope,
62 62
         ResponseFactoryInterface $responseFactory
63
-    ) {
63
+    ){
64 64
         $this->core = $core;
65 65
         $this->scope = $scope;
66 66
         $this->responseFactory = $responseFactory;
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     public function handle(Request $request): Response
105 105
     {
106
-        if ($this->controller === null) {
106
+        if ($this->controller === null){
107 107
             throw new HandlerException('Controller and action pair is not set');
108 108
         }
109 109
 
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         $output = $result = null;
114 114
 
115 115
         $response = $this->responseFactory->createResponse(200);
116
-        try {
116
+        try{
117 117
             // run the core withing PSR-7 Request/Response scope
118 118
             $result = $this->scope->runScope(
119 119
                 [
@@ -128,22 +128,22 @@  discard block
 block discarded – undo
128 128
                     );
129 129
                 }
130 130
             );
131
-        } catch (ControllerException $e) {
131
+        }catch (ControllerException $e){
132 132
             ob_get_clean();
133 133
             throw $this->mapException($e);
134
-        } catch (\Throwable $e) {
134
+        }catch (\Throwable $e){
135 135
             ob_get_clean();
136 136
             throw $e;
137
-        } finally {
138
-            while (ob_get_level() > $outputLevel + 1) {
139
-                $output = ob_get_clean() . $output;
137
+        }finally{
138
+            while (ob_get_level() > $outputLevel + 1){
139
+                $output = ob_get_clean().$output;
140 140
             }
141 141
         }
142 142
 
143 143
         return $this->wrapResponse(
144 144
             $response,
145 145
             $result,
146
-            ob_get_clean() . $output
146
+            ob_get_clean().$output
147 147
         );
148 148
     }
149 149
 
@@ -153,8 +153,8 @@  discard block
 block discarded – undo
153 153
      */
154 154
     private function getAction(Request $request): string
155 155
     {
156
-        if ($this->verbActions) {
157
-            return strtolower($request->getMethod()) . ucfirst($this->action);
156
+        if ($this->verbActions){
157
+            return strtolower($request->getMethod()).ucfirst($this->action);
158 158
         }
159 159
 
160 160
         return $this->action;
@@ -170,17 +170,17 @@  discard block
 block discarded – undo
170 170
      */
171 171
     private function wrapResponse(Response $response, $result = null, string $output = ''): Response
172 172
     {
173
-        if ($result instanceof Response) {
174
-            if ($output !== '' && $result->getBody()->isWritable()) {
173
+        if ($result instanceof Response){
174
+            if ($output !== '' && $result->getBody()->isWritable()){
175 175
                 $result->getBody()->write($output);
176 176
             }
177 177
 
178 178
             return $result;
179 179
         }
180 180
 
181
-        if (is_array($result) || $result instanceof \JsonSerializable) {
181
+        if (is_array($result) || $result instanceof \JsonSerializable){
182 182
             $response = $this->writeJson($response, $result);
183
-        } else {
183
+        }else{
184 184
             $response->getBody()->write((string)$result);
185 185
         }
186 186
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
      */
199 199
     private function mapException(ControllerException $exception): ClientException
200 200
     {
201
-        switch ($exception->getCode()) {
201
+        switch ($exception->getCode()){
202 202
             case ControllerException::BAD_ACTION:
203 203
             case ControllerException::NOT_FOUND:
204 204
                 return new NotFoundException($exception->getMessage());
Please login to merge, or discard this patch.
Braces   +30 added lines, -13 removed lines patch added patch discarded remove patch
@@ -103,7 +103,8 @@  discard block
 block discarded – undo
103 103
      */
104 104
     public function handle(Request $request): Response
105 105
     {
106
-        if ($this->controller === null) {
106
+        if ($this->controller === null)
107
+        {
107 108
             throw new HandlerException('Controller and action pair is not set');
108 109
         }
109 110
 
@@ -113,14 +114,16 @@  discard block
 block discarded – undo
113 114
         $output = $result = null;
114 115
 
115 116
         $response = $this->responseFactory->createResponse(200);
116
-        try {
117
+        try
118
+        {
117 119
             // run the core withing PSR-7 Request/Response scope
118 120
             $result = $this->scope->runScope(
119 121
                 [
120 122
                     Request::class  => $request,
121 123
                     Response::class => $response,
122 124
                 ],
123
-                function () use ($request) {
125
+                function () use ($request)
126
+                {
124 127
                     return $this->core->callAction(
125 128
                         $this->controller,
126 129
                         $this->getAction($request),
@@ -128,14 +131,21 @@  discard block
 block discarded – undo
128 131
                     );
129 132
                 }
130 133
             );
131
-        } catch (ControllerException $e) {
134
+        }
135
+        catch (ControllerException $e)
136
+        {
132 137
             ob_get_clean();
133 138
             throw $this->mapException($e);
134
-        } catch (\Throwable $e) {
139
+        }
140
+        catch (\Throwable $e)
141
+        {
135 142
             ob_get_clean();
136 143
             throw $e;
137
-        } finally {
138
-            while (ob_get_level() > $outputLevel + 1) {
144
+        }
145
+        finally
146
+        {
147
+            while (ob_get_level() > $outputLevel + 1)
148
+            {
139 149
                 $output = ob_get_clean() . $output;
140 150
             }
141 151
         }
@@ -153,7 +163,8 @@  discard block
 block discarded – undo
153 163
      */
154 164
     private function getAction(Request $request): string
155 165
     {
156
-        if ($this->verbActions) {
166
+        if ($this->verbActions)
167
+        {
157 168
             return strtolower($request->getMethod()) . ucfirst($this->action);
158 169
         }
159 170
 
@@ -170,17 +181,22 @@  discard block
 block discarded – undo
170 181
      */
171 182
     private function wrapResponse(Response $response, $result = null, string $output = ''): Response
172 183
     {
173
-        if ($result instanceof Response) {
174
-            if ($output !== '' && $result->getBody()->isWritable()) {
184
+        if ($result instanceof Response)
185
+        {
186
+            if ($output !== '' && $result->getBody()->isWritable())
187
+            {
175 188
                 $result->getBody()->write($output);
176 189
             }
177 190
 
178 191
             return $result;
179 192
         }
180 193
 
181
-        if (is_array($result) || $result instanceof \JsonSerializable) {
194
+        if (is_array($result) || $result instanceof \JsonSerializable)
195
+        {
182 196
             $response = $this->writeJson($response, $result);
183
-        } else {
197
+        }
198
+        else
199
+        {
184 200
             $response->getBody()->write((string)$result);
185 201
         }
186 202
 
@@ -198,7 +214,8 @@  discard block
 block discarded – undo
198 214
      */
199 215
     private function mapException(ControllerException $exception): ClientException
200 216
     {
201
-        switch ($exception->getCode()) {
217
+        switch ($exception->getCode())
218
+        {
202 219
             case ControllerException::BAD_ACTION:
203 220
             case ControllerException::NOT_FOUND:
204 221
                 return new NotFoundException($exception->getMessage());
Please login to merge, or discard this patch.
src/Session/tests/FactoryTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     public function tearDown(): void
26 26
     {
27
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
27
+        if ((int)session_status() === PHP_SESSION_ACTIVE){
28 28
             session_abort();
29 29
         }
30 30
     }
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,8 @@
 block discarded – undo
24 24
 {
25 25
     public function tearDown(): void
26 26
     {
27
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
27
+        if ((int)session_status() === PHP_SESSION_ACTIVE)
28
+        {
28 29
             session_abort();
29 30
         }
30 31
     }
Please login to merge, or discard this patch.
src/Session/tests/SessionTest.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function tearDown(): void
53 53
     {
54
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
54
+        if ((int)session_status() === PHP_SESSION_ACTIVE){
55 55
             session_abort();
56 56
         }
57 57
     }
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         $this->assertSame('default', $section->getName());
126 126
 
127 127
         $section->set('key', 'value');
128
-        foreach ($section as $key => $value) {
128
+        foreach ($section as $key => $value){
129 129
             $this->assertSame('key', $key);
130 130
             $this->assertSame('value', $value);
131 131
         }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,8 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function tearDown(): void
53 53
     {
54
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
54
+        if ((int)session_status() === PHP_SESSION_ACTIVE)
55
+        {
55 56
             session_abort();
56 57
         }
57 58
     }
@@ -125,7 +126,8 @@  discard block
 block discarded – undo
125 126
         $this->assertSame('default', $section->getName());
126 127
 
127 128
         $section->set('key', 'value');
128
-        foreach ($section as $key => $value) {
129
+        foreach ($section as $key => $value)
130
+        {
129 131
             $this->assertSame('key', $key);
130 132
             $this->assertSame('value', $value);
131 133
         }
Please login to merge, or discard this patch.
src/Session/src/SessionSection.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
      */
128 128
     public function get(string $name, $default = null)
129 129
     {
130
-        if (!$this->has($name)) {
130
+        if (!$this->has($name)){
131 131
             return $default;
132 132
         }
133 133
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     {
203 203
         $this->session->resume();
204 204
 
205
-        if (!isset($_SESSION[$this->name])) {
205
+        if (!isset($_SESSION[$this->name])){
206 206
             $_SESSION[$this->name] = [];
207 207
         }
208 208
     }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -127,7 +127,8 @@  discard block
 block discarded – undo
127 127
      */
128 128
     public function get(string $name, $default = null)
129 129
     {
130
-        if (!$this->has($name)) {
130
+        if (!$this->has($name))
131
+        {
131 132
             return $default;
132 133
         }
133 134
 
@@ -202,7 +203,8 @@  discard block
 block discarded – undo
202 203
     {
203 204
         $this->session->resume();
204 205
 
205
-        if (!isset($_SESSION[$this->name])) {
206
+        if (!isset($_SESSION[$this->name]))
207
+        {
206 208
             $_SESSION[$this->name] = [];
207 209
         }
208 210
     }
Please login to merge, or discard this patch.
src/Session/src/Handler/FileHandler.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,8 +62,8 @@
 block discarded – undo
62 62
      */
63 63
     public function gc($maxlifetime): void
64 64
     {
65
-        foreach ($this->files->getFiles($this->directory) as $filename) {
66
-            if ($this->files->time($filename) < time() - $maxlifetime) {
65
+        foreach ($this->files->getFiles($this->directory) as $filename){
66
+            if ($this->files->time($filename) < time() - $maxlifetime){
67 67
                 $this->files->delete($filename);
68 68
             }
69 69
         }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,8 +62,10 @@
 block discarded – undo
62 62
      */
63 63
     public function gc($maxlifetime): void
64 64
     {
65
-        foreach ($this->files->getFiles($this->directory) as $filename) {
66
-            if ($this->files->time($filename) < time() - $maxlifetime) {
65
+        foreach ($this->files->getFiles($this->directory) as $filename)
66
+        {
67
+            if ($this->files->time($filename) < time() - $maxlifetime)
68
+            {
67 69
                 $this->files->delete($filename);
68 70
             }
69 71
         }
Please login to merge, or discard this patch.
src/Session/src/SessionFactory.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -48,15 +48,15 @@
 block discarded – undo
48 48
      */
49 49
     public function initSession(string $clientSignature, string $id = null): SessionInterface
50 50
     {
51
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
51
+        if ((int)session_status() === PHP_SESSION_ACTIVE){
52 52
             throw new MultipleSessionException('Unable to initiate session, session already started');
53 53
         }
54 54
 
55 55
         //Initiating proper session handler
56
-        if ($this->config->getHandler() !== null) {
57
-            try {
56
+        if ($this->config->getHandler() !== null){
57
+            try{
58 58
                 $handler = $this->config->getHandler()->resolve($this->factory);
59
-            } catch (\Throwable | ContainerExceptionInterface $e) {
59
+            }catch (\Throwable | ContainerExceptionInterface $e){
60 60
                 throw new SessionException($e->getMessage(), $e->getCode(), $e);
61 61
             }
62 62
 
Please login to merge, or discard this patch.
Braces   +9 added lines, -4 removed lines patch added patch discarded remove patch
@@ -48,15 +48,20 @@
 block discarded – undo
48 48
      */
49 49
     public function initSession(string $clientSignature, string $id = null): SessionInterface
50 50
     {
51
-        if ((int)session_status() === PHP_SESSION_ACTIVE) {
51
+        if ((int)session_status() === PHP_SESSION_ACTIVE)
52
+        {
52 53
             throw new MultipleSessionException('Unable to initiate session, session already started');
53 54
         }
54 55
 
55 56
         //Initiating proper session handler
56
-        if ($this->config->getHandler() !== null) {
57
-            try {
57
+        if ($this->config->getHandler() !== null)
58
+        {
59
+            try
60
+            {
58 61
                 $handler = $this->config->getHandler()->resolve($this->factory);
59
-            } catch (\Throwable | ContainerExceptionInterface $e) {
62
+            }
63
+            catch (\Throwable | ContainerExceptionInterface $e)
64
+            {
60 65
                 throw new SessionException($e->getMessage(), $e->getCode(), $e);
61 66
             }
62 67
 
Please login to merge, or discard this patch.