Spiral\Storage\Builder\Adapter\LocalBuilder

Complexity

Total Complexity

5

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	buildSimple()	0	6	1
A	buildAdvanced()	0	15	4

<?php

/**
 * This file is part of Spiral Framework package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Spiral\Storage\Builder\Adapter;

use League\Flysystem\FilesystemAdapter;
use League\Flysystem\UnixVisibility\PortableVisibilityConverter;
use Spiral\Storage\Config\DTO\FileSystemInfo\LocalInfo;
use Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface;

/**
 * @property FileSystemInfoInterface|LocalInfo $fsInfo
 */
class LocalBuilder extends AbstractBuilder
{
    protected const FILE_SYSTEM_INFO_CLASS = LocalInfo::class;

    /**
     * @inheritDoc
     */
    public function buildSimple(): FilesystemAdapter
    {
        $adapterClass = $this->fsInfo->getAdapterClass();

        return new $adapterClass(
            $this->fsInfo->getOption(LocalInfo::ROOT_DIR_KEY)

The method getOption() does not exist on Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface.

        );
    }

    /**
     * @inheritDoc
     */
    public function buildAdvanced(): FilesystemAdapter
    {
        $adapterClass = $this->fsInfo->getAdapterClass();

        return new $adapterClass(
            $this->fsInfo->getOption(LocalInfo::ROOT_DIR_KEY),
            $this->fsInfo->hasOption(LocalInfo::VISIBILITY_KEY)

The method hasOption() does not exist on Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface.

                ? PortableVisibilityConverter::fromArray($this->fsInfo->getOption(LocalInfo::VISIBILITY_KEY))

It seems like $this->fsInfo->getOption(Spiral\Storage\Config\DTO\FileSystemInfo\LocalInfo::VISIBILITY_KEY) can also be of type null; however, parameter $permissionMap of League\Flysystem\UnixVisibility\PortableVisibilityConverter::fromArray() does only seem to accept array, maybe add an additional type check?

                : null,
            $this->fsInfo->hasOption(LocalInfo::WRITE_FLAGS_KEY)
                ? $this->fsInfo->getOption(LocalInfo::WRITE_FLAGS_KEY)
                : \LOCK_EX,
            $this->fsInfo->hasOption(LocalInfo::LINK_HANDLING_KEY)
                ? $this->fsInfo->getOption(LocalInfo::LINK_HANDLING_KEY)
                : $adapterClass::DISALLOW_LINKS
        );
    }
}