Test Failed
Pull Request — master (#1170)
by Aleksei
19:12 queued 08:18
created
src/Streams/src/StreamWrapper.php 2 patches
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      */
44 44
     public function stream_eof(): bool
45 45
     {
46
-        if ($this->stream === null) {
46
+        if ($this->stream === null){
47 47
             throw new WrapperException('Stream is not opened.');
48 48
         }
49 49
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      */
56 56
     public function stream_open(string $path, string $mode, int $options, ?string &$opened_path): bool
57 57
     {
58
-        if (!isset(self::$uris[$path])) {
58
+        if (!isset(self::$uris[$path])){
59 59
             return false;
60 60
         }
61 61
 
@@ -70,9 +70,9 @@  discard block
 block discarded – undo
70 70
     /**
71 71
      * Read data from StreamInterface.
72 72
      */
73
-    public function stream_read(int $length): string|false
73
+    public function stream_read(int $length): string | false
74 74
     {
75
-        if ($this->stream === null) {
75
+        if ($this->stream === null){
76 76
             throw new WrapperException('Stream is not opened.');
77 77
         }
78 78
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function stream_seek(int $offset, int $whence = SEEK_SET): bool
86 86
     {
87
-        if ($this->stream === null) {
87
+        if ($this->stream === null){
88 88
             throw new WrapperException('Stream is not opened.');
89 89
         }
90 90
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      */
103 103
     public function stream_stat(): array
104 104
     {
105
-        if ($this->stream === null) {
105
+        if ($this->stream === null){
106 106
             throw new WrapperException('Stream is not opened.');
107 107
         }
108 108
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function stream_tell(): int
116 116
     {
117
-        if ($this->stream === null) {
117
+        if ($this->stream === null){
118 118
             throw new WrapperException('Stream is not opened.');
119 119
         }
120 120
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
      */
129 129
     public function stream_write(string $data): int
130 130
     {
131
-        if ($this->stream === null) {
131
+        if ($this->stream === null){
132 132
             throw new WrapperException('Stream is not opened.');
133 133
         }
134 134
 
@@ -140,14 +140,14 @@  discard block
 block discarded – undo
140 140
      *
141 141
      * @see stat()
142 142
      */
143
-    public function url_stat(string $path, int $flag): array|false
143
+    public function url_stat(string $path, int $flag): array | false
144 144
     {
145
-        try {
146
-            if (isset(self::$uris[$path])) {
145
+        try{
146
+            if (isset(self::$uris[$path])){
147 147
                 return $this->getStreamStats(self::$uris[$path]);
148 148
             }
149
-        } catch (\Throwable $e) {
150
-            if (($flag & \STREAM_URL_STAT_QUIET) === \STREAM_URL_STAT_QUIET) {
149
+        }catch (\Throwable $e){
150
+            if (($flag & \STREAM_URL_STAT_QUIET) === \STREAM_URL_STAT_QUIET){
151 151
                 return false;
152 152
             }
153 153
             \trigger_error($e->getMessage(), \E_USER_ERROR);
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
      */
162 162
     public static function register(): void
163 163
     {
164
-        if (self::$registered) {
164
+        if (self::$registered){
165 165
             return;
166 166
         }
167 167
 
@@ -173,10 +173,10 @@  discard block
 block discarded – undo
173 173
     /**
174 174
      * Check if given uri or stream has been allocated.
175 175
      */
176
-    public static function has(StreamInterface|string $file): bool
176
+    public static function has(StreamInterface | string $file): bool
177 177
     {
178
-        if ($file instanceof StreamInterface) {
179
-            $file = 'spiral://' . \spl_object_hash($file);
178
+        if ($file instanceof StreamInterface){
179
+            $file = 'spiral://'.\spl_object_hash($file);
180 180
         }
181 181
 
182 182
         return isset(self::$uris[$file]);
@@ -191,15 +191,15 @@  discard block
 block discarded – undo
191 191
     public static function getResource(StreamInterface $stream)
192 192
     {
193 193
         $mode = null;
194
-        if ($stream->isReadable()) {
194
+        if ($stream->isReadable()){
195 195
             $mode = 'r';
196 196
         }
197 197
 
198
-        if ($stream->isWritable()) {
198
+        if ($stream->isWritable()){
199 199
             $mode = !empty($mode) ? 'r+' : 'w';
200 200
         }
201 201
 
202
-        if (empty($mode)) {
202
+        if (empty($mode)){
203 203
             throw new WrapperException('Stream is not available in read or write modes');
204 204
         }
205 205
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
     {
214 214
         self::register();
215 215
 
216
-        $uri = 'spiral://' . \spl_object_hash($stream);
216
+        $uri = 'spiral://'.\spl_object_hash($stream);
217 217
         self::$uris[$uri] = $stream;
218 218
 
219 219
         return $uri;
@@ -225,10 +225,10 @@  discard block
 block discarded – undo
225 225
      *
226 226
      * @param string|StreamInterface $file String uri or StreamInterface.
227 227
      */
228
-    public static function release(StreamInterface|string $file): void
228
+    public static function release(StreamInterface | string $file): void
229 229
     {
230
-        if ($file instanceof StreamInterface) {
231
-            $file = 'spiral://' . \spl_object_hash($file);
230
+        if ($file instanceof StreamInterface){
231
+            $file = 'spiral://'.\spl_object_hash($file);
232 232
         }
233 233
 
234 234
         unset(self::$uris[$file]);
@@ -240,12 +240,12 @@  discard block
 block discarded – undo
240 240
     private function getStreamStats(StreamInterface $stream): array
241 241
     {
242 242
         $mode = $this->mode;
243
-        if (empty($mode)) {
244
-            if ($stream->isReadable()) {
243
+        if (empty($mode)){
244
+            if ($stream->isReadable()){
245 245
                 $mode = 'r';
246 246
             }
247 247
 
248
-            if ($stream->isWritable()) {
248
+            if ($stream->isWritable()){
249 249
                 $mode = !empty($mode) ? 'r+' : 'w';
250 250
             }
251 251
         }
Please login to merge, or discard this patch.
Braces   +41 added lines, -20 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@  discard block
 block discarded – undo
43 43
      */
44 44
     public function stream_eof(): bool
45 45
     {
46
-        if ($this->stream === null) {
46
+        if ($this->stream === null)
47
+        {
47 48
             throw new WrapperException('Stream is not opened.');
48 49
         }
49 50
 
@@ -55,7 +56,8 @@  discard block
 block discarded – undo
55 56
      */
56 57
     public function stream_open(string $path, string $mode, int $options, ?string &$opened_path): bool
57 58
     {
58
-        if (!isset(self::$uris[$path])) {
59
+        if (!isset(self::$uris[$path]))
60
+        {
59 61
             return false;
60 62
         }
61 63
 
@@ -72,7 +74,8 @@  discard block
 block discarded – undo
72 74
      */
73 75
     public function stream_read(int $length): string|false
74 76
     {
75
-        if ($this->stream === null) {
77
+        if ($this->stream === null)
78
+        {
76 79
             throw new WrapperException('Stream is not opened.');
77 80
         }
78 81
 
@@ -84,7 +87,8 @@  discard block
 block discarded – undo
84 87
      */
85 88
     public function stream_seek(int $offset, int $whence = SEEK_SET): bool
86 89
     {
87
-        if ($this->stream === null) {
90
+        if ($this->stream === null)
91
+        {
88 92
             throw new WrapperException('Stream is not opened.');
89 93
         }
90 94
 
@@ -102,7 +106,8 @@  discard block
 block discarded – undo
102 106
      */
103 107
     public function stream_stat(): array
104 108
     {
105
-        if ($this->stream === null) {
109
+        if ($this->stream === null)
110
+        {
106 111
             throw new WrapperException('Stream is not opened.');
107 112
         }
108 113
 
@@ -114,7 +119,8 @@  discard block
 block discarded – undo
114 119
      */
115 120
     public function stream_tell(): int
116 121
     {
117
-        if ($this->stream === null) {
122
+        if ($this->stream === null)
123
+        {
118 124
             throw new WrapperException('Stream is not opened.');
119 125
         }
120 126
 
@@ -128,7 +134,8 @@  discard block
 block discarded – undo
128 134
      */
129 135
     public function stream_write(string $data): int
130 136
     {
131
-        if ($this->stream === null) {
137
+        if ($this->stream === null)
138
+        {
132 139
             throw new WrapperException('Stream is not opened.');
133 140
         }
134 141
 
@@ -142,12 +149,17 @@  discard block
 block discarded – undo
142 149
      */
143 150
     public function url_stat(string $path, int $flag): array|false
144 151
     {
145
-        try {
146
-            if (isset(self::$uris[$path])) {
152
+        try
153
+        {
154
+            if (isset(self::$uris[$path]))
155
+            {
147 156
                 return $this->getStreamStats(self::$uris[$path]);
148 157
             }
149
-        } catch (\Throwable $e) {
150
-            if (($flag & \STREAM_URL_STAT_QUIET) === \STREAM_URL_STAT_QUIET) {
158
+        }
159
+        catch (\Throwable $e)
160
+        {
161
+            if (($flag & \STREAM_URL_STAT_QUIET) === \STREAM_URL_STAT_QUIET)
162
+            {
151 163
                 return false;
152 164
             }
153 165
             \trigger_error($e->getMessage(), \E_USER_ERROR);
@@ -161,7 +173,8 @@  discard block
 block discarded – undo
161 173
      */
162 174
     public static function register(): void
163 175
     {
164
-        if (self::$registered) {
176
+        if (self::$registered)
177
+        {
165 178
             return;
166 179
         }
167 180
 
@@ -175,7 +188,8 @@  discard block
 block discarded – undo
175 188
      */
176 189
     public static function has(StreamInterface|string $file): bool
177 190
     {
178
-        if ($file instanceof StreamInterface) {
191
+        if ($file instanceof StreamInterface)
192
+        {
179 193
             $file = 'spiral://' . \spl_object_hash($file);
180 194
         }
181 195
 
@@ -191,15 +205,18 @@  discard block
 block discarded – undo
191 205
     public static function getResource(StreamInterface $stream)
192 206
     {
193 207
         $mode = null;
194
-        if ($stream->isReadable()) {
208
+        if ($stream->isReadable())
209
+        {
195 210
             $mode = 'r';
196 211
         }
197 212
 
198
-        if ($stream->isWritable()) {
213
+        if ($stream->isWritable())
214
+        {
199 215
             $mode = !empty($mode) ? 'r+' : 'w';
200 216
         }
201 217
 
202
-        if (empty($mode)) {
218
+        if (empty($mode))
219
+        {
203 220
             throw new WrapperException('Stream is not available in read or write modes');
204 221
         }
205 222
 
@@ -227,7 +244,8 @@  discard block
 block discarded – undo
227 244
      */
228 245
     public static function release(StreamInterface|string $file): void
229 246
     {
230
-        if ($file instanceof StreamInterface) {
247
+        if ($file instanceof StreamInterface)
248
+        {
231 249
             $file = 'spiral://' . \spl_object_hash($file);
232 250
         }
233 251
 
@@ -240,12 +258,15 @@  discard block
 block discarded – undo
240 258
     private function getStreamStats(StreamInterface $stream): array
241 259
     {
242 260
         $mode = $this->mode;
243
-        if (empty($mode)) {
244
-            if ($stream->isReadable()) {
261
+        if (empty($mode))
262
+        {
263
+            if ($stream->isReadable())
264
+            {
245 265
                 $mode = 'r';
246 266
             }
247 267
 
248
-            if ($stream->isWritable()) {
268
+            if ($stream->isWritable())
269
+            {
249 270
                 $mode = !empty($mode) ? 'r+' : 'w';
250 271
             }
251 272
         }
Please login to merge, or discard this patch.
src/Security/src/Rule/CompositeRule.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -32,22 +32,22 @@
 block discarded – undo
32 32
 
33 33
     public function __construct(
34 34
         private readonly RulesInterface $repository
35
-    ) {
35
+    ){
36 36
     }
37 37
 
38 38
     public function allows(ActorInterface $actor, string $permission, array $context): bool
39 39
     {
40 40
         $allowed = 0;
41
-        foreach (static::RULES as $rule) {
41
+        foreach (static::RULES as $rule){
42 42
             $rule = $this->repository->get($rule);
43 43
 
44
-            if ($rule->allows($actor, $permission, $context)) {
45
-                if (static::BEHAVIOUR === self::AT_LEAST_ONE) {
44
+            if ($rule->allows($actor, $permission, $context)){
45
+                if (static::BEHAVIOUR === self::AT_LEAST_ONE){
46 46
                     return true;
47 47
                 }
48 48
 
49 49
                 $allowed++;
50
-            } elseif (static::BEHAVIOUR === self::ALL) {
50
+            } elseif (static::BEHAVIOUR === self::ALL){
51 51
                 return false;
52 52
             }
53 53
         }
Please login to merge, or discard this patch.
Braces   +9 added lines, -4 removed lines patch added patch discarded remove patch
@@ -38,16 +38,21 @@
 block discarded – undo
38 38
     public function allows(ActorInterface $actor, string $permission, array $context): bool
39 39
     {
40 40
         $allowed = 0;
41
-        foreach (static::RULES as $rule) {
41
+        foreach (static::RULES as $rule)
42
+        {
42 43
             $rule = $this->repository->get($rule);
43 44
 
44
-            if ($rule->allows($actor, $permission, $context)) {
45
-                if (static::BEHAVIOUR === self::AT_LEAST_ONE) {
45
+            if ($rule->allows($actor, $permission, $context))
46
+            {
47
+                if (static::BEHAVIOUR === self::AT_LEAST_ONE)
48
+                {
46 49
                     return true;
47 50
                 }
48 51
 
49 52
                 $allowed++;
50
-            } elseif (static::BEHAVIOUR === self::ALL) {
53
+            }
54
+            elseif (static::BEHAVIOUR === self::ALL)
55
+            {
51 56
                 return false;
52 57
             }
53 58
         }
Please login to merge, or discard this patch.
src/Security/src/Rule/CallableRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,6 +21,6 @@
 block discarded – undo
21 21
 
22 22
     public function allows(ActorInterface $actor, string $permission, array $context): bool
23 23
     {
24
-        return (bool) ($this->callable)($actor, $permission, $context);
24
+        return (bool)($this->callable)($actor, $permission, $context);
25 25
     }
26 26
 }
Please login to merge, or discard this patch.
src/Security/src/PermissionManager.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     public function __construct(
33 33
         private readonly RulesInterface $rules,
34 34
         private readonly string $defaultRule = ForbidRule::class
35
-    ) {
35
+    ){
36 36
         $this->matcher = new Matcher();
37 37
     }
38 38
 
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
     public function addRole(string $role): PermissionManager
45 45
     {
46
-        if ($this->hasRole($role)) {
46
+        if ($this->hasRole($role)){
47 47
             throw new RoleException(\sprintf("Role '%s' already exists", $role));
48 48
         }
49 49
 
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
     public function removeRole(string $role): PermissionManager
58 58
     {
59
-        if (!$this->hasRole($role)) {
59
+        if (!$this->hasRole($role)){
60 60
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
61 61
         }
62 62
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
     public function getPermissions(string $role): array
74 74
     {
75
-        if (!$this->hasRole($role)) {
75
+        if (!$this->hasRole($role)){
76 76
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
77 77
         }
78 78
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
     public function getRule(string $role, string $permission): RuleInterface
83 83
     {
84
-        if (!$this->hasRole($role)) {
84
+        if (!$this->hasRole($role)){
85 85
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
86 86
         }
87 87
 
@@ -91,11 +91,11 @@  discard block
 block discarded – undo
91 91
 
92 92
     public function associate(string $role, string $permission, string $rule = AllowRule::class): PermissionManager
93 93
     {
94
-        if (!$this->hasRole($role)) {
94
+        if (!$this->hasRole($role)){
95 95
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
96 96
         }
97 97
 
98
-        if (!$this->rules->has($rule)) {
98
+        if (!$this->rules->has($rule)){
99 99
             throw new PermissionException(\sprintf("Undefined rule '%s'", $rule));
100 100
         }
101 101
 
@@ -121,14 +121,14 @@  discard block
 block discarded – undo
121 121
      */
122 122
     private function findRule(string $role, string $permission): string
123 123
     {
124
-        if (isset($this->permissions[$role][$permission])) {
124
+        if (isset($this->permissions[$role][$permission])){
125 125
             //O(1) check
126 126
             return $this->permissions[$role][$permission];
127 127
         }
128 128
 
129 129
         //Matching using star syntax
130
-        foreach ($this->permissions[$role] as $pattern => $rule) {
131
-            if ($this->matcher->matches($permission, $pattern)) {
130
+        foreach ($this->permissions[$role] as $pattern => $rule){
131
+            if ($this->matcher->matches($permission, $pattern)){
132 132
                 return $rule;
133 133
             }
134 134
         }
Please login to merge, or discard this patch.
Braces   +18 added lines, -9 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@  discard block
 block discarded – undo
43 43
 
44 44
     public function addRole(string $role): PermissionManager
45 45
     {
46
-        if ($this->hasRole($role)) {
46
+        if ($this->hasRole($role))
47
+        {
47 48
             throw new RoleException(\sprintf("Role '%s' already exists", $role));
48 49
         }
49 50
 
@@ -56,7 +57,8 @@  discard block
 block discarded – undo
56 57
 
57 58
     public function removeRole(string $role): PermissionManager
58 59
     {
59
-        if (!$this->hasRole($role)) {
60
+        if (!$this->hasRole($role))
61
+        {
60 62
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
61 63
         }
62 64
 
@@ -72,7 +74,8 @@  discard block
 block discarded – undo
72 74
 
73 75
     public function getPermissions(string $role): array
74 76
     {
75
-        if (!$this->hasRole($role)) {
77
+        if (!$this->hasRole($role))
78
+        {
76 79
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
77 80
         }
78 81
 
@@ -81,7 +84,8 @@  discard block
 block discarded – undo
81 84
 
82 85
     public function getRule(string $role, string $permission): RuleInterface
83 86
     {
84
-        if (!$this->hasRole($role)) {
87
+        if (!$this->hasRole($role))
88
+        {
85 89
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
86 90
         }
87 91
 
@@ -91,11 +95,13 @@  discard block
 block discarded – undo
91 95
 
92 96
     public function associate(string $role, string $permission, string $rule = AllowRule::class): PermissionManager
93 97
     {
94
-        if (!$this->hasRole($role)) {
98
+        if (!$this->hasRole($role))
99
+        {
95 100
             throw new RoleException(\sprintf("Undefined role '%s'", $role));
96 101
         }
97 102
 
98
-        if (!$this->rules->has($rule)) {
103
+        if (!$this->rules->has($rule))
104
+        {
99 105
             throw new PermissionException(\sprintf("Undefined rule '%s'", $rule));
100 106
         }
101 107
 
@@ -121,14 +127,17 @@  discard block
 block discarded – undo
121 127
      */
122 128
     private function findRule(string $role, string $permission): string
123 129
     {
124
-        if (isset($this->permissions[$role][$permission])) {
130
+        if (isset($this->permissions[$role][$permission]))
131
+        {
125 132
             //O(1) check
126 133
             return $this->permissions[$role][$permission];
127 134
         }
128 135
 
129 136
         //Matching using star syntax
130
-        foreach ($this->permissions[$role] as $pattern => $rule) {
131
-            if ($this->matcher->matches($permission, $pattern)) {
137
+        foreach ($this->permissions[$role] as $pattern => $rule)
138
+        {
139
+            if ($this->matcher->matches($permission, $pattern))
140
+            {
132 141
                 return $rule;
133 142
             }
134 143
         }
Please login to merge, or discard this patch.
src/Security/src/Actor/Actor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 {
14 14
     public function __construct(
15 15
         private readonly array $roles
16
-    ) {
16
+    ){
17 17
     }
18 18
 
19 19
     public function getRoles(): array
Please login to merge, or discard this patch.
src/Security/src/Traits/GuardedTrait.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     public function getGuard(): GuardInterface
21 21
     {
22 22
         $container = ContainerScope::getContainer();
23
-        if (empty($container) || !$container->has(GuardInterface::class)) {
23
+        if (empty($container) || !$container->has(GuardInterface::class)){
24 24
             throw new ScopeException(
25 25
                 'Unable to get `GuardInterface`, binding is missing or container scope is not set'
26 26
             );
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
44 44
      */
45 45
     protected function resolvePermission(string $permission): string
46 46
     {
47
-        if (\defined('static::GUARD_NAMESPACE')) {
47
+        if (\defined('static::GUARD_NAMESPACE')){
48 48
             // Yay! Isolation
49
-            $permission = \constant(static::class . '::' . 'GUARD_NAMESPACE') . '.' . $permission;
49
+            $permission = \constant(static::class.'::'.'GUARD_NAMESPACE').'.'.$permission;
50 50
         }
51 51
 
52 52
         return $permission;
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,7 +20,8 @@  discard block
 block discarded – undo
20 20
     public function getGuard(): GuardInterface
21 21
     {
22 22
         $container = ContainerScope::getContainer();
23
-        if (empty($container) || !$container->has(GuardInterface::class)) {
23
+        if (empty($container) || !$container->has(GuardInterface::class))
24
+        {
24 25
             throw new ScopeException(
25 26
                 'Unable to get `GuardInterface`, binding is missing or container scope is not set'
26 27
             );
@@ -44,7 +45,8 @@  discard block
 block discarded – undo
44 45
      */
45 46
     protected function resolvePermission(string $permission): string
46 47
     {
47
-        if (\defined('static::GUARD_NAMESPACE')) {
48
+        if (\defined('static::GUARD_NAMESPACE'))
49
+        {
48 50
             // Yay! Isolation
49 51
             $permission = \constant(static::class . '::' . 'GUARD_NAMESPACE') . '.' . $permission;
50 52
         }
Please login to merge, or discard this patch.
src/Security/src/Command/RolePermissionsCommand.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -28,16 +28,16 @@  discard block
 block discarded – undo
28 28
     {
29 29
         $role = $this->argument('role');
30 30
 
31
-        if ($role !== null && !$rbac->hasRole($role)) {
31
+        if ($role !== null && !$rbac->hasRole($role)){
32 32
             throw new CommandException('Unknown role provided');
33 33
         }
34 34
 
35
-        if ($role !== null) {
35
+        if ($role !== null){
36 36
             $rows = $this->getRolePermissions($role, $rbac);
37
-        } else {
37
+        }else{
38 38
             $rows = [];
39 39
 
40
-            foreach ($rbac->getRoles() as $role) {
40
+            foreach ($rbac->getRoles() as $role){
41 41
                 /** @noinspection SlowArrayOperationsInLoopInspection */
42 42
                 $rows = \array_merge(
43 43
                     $this->getRolePermissions($role, $rbac),
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     {
64 64
         $permissions = [];
65 65
 
66
-        foreach ($rbac->getPermissions($role) as $permission => $rule) {
66
+        foreach ($rbac->getPermissions($role) as $permission => $rule){
67 67
             $permissions[] = [
68 68
                 'role' => $role,
69 69
                 'permission' => $permission,
Please login to merge, or discard this patch.
Braces   +11 added lines, -5 removed lines patch added patch discarded remove patch
@@ -28,16 +28,21 @@  discard block
 block discarded – undo
28 28
     {
29 29
         $role = $this->argument('role');
30 30
 
31
-        if ($role !== null && !$rbac->hasRole($role)) {
31
+        if ($role !== null && !$rbac->hasRole($role))
32
+        {
32 33
             throw new CommandException('Unknown role provided');
33 34
         }
34 35
 
35
-        if ($role !== null) {
36
+        if ($role !== null)
37
+        {
36 38
             $rows = $this->getRolePermissions($role, $rbac);
37
-        } else {
39
+        }
40
+        else
41
+        {
38 42
             $rows = [];
39 43
 
40
-            foreach ($rbac->getRoles() as $role) {
44
+            foreach ($rbac->getRoles() as $role)
45
+            {
41 46
                 /** @noinspection SlowArrayOperationsInLoopInspection */
42 47
                 $rows = \array_merge(
43 48
                     $this->getRolePermissions($role, $rbac),
@@ -63,7 +68,8 @@  discard block
 block discarded – undo
63 68
     {
64 69
         $permissions = [];
65 70
 
66
-        foreach ($rbac->getPermissions($role) as $permission => $rule) {
71
+        foreach ($rbac->getPermissions($role) as $permission => $rule)
72
+        {
67 73
             $permissions[] = [
68 74
                 'role' => $role,
69 75
                 'permission' => $permission,
Please login to merge, or discard this patch.
src/Security/src/RuleManager.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -18,16 +18,16 @@  discard block
 block discarded – undo
18 18
 
19 19
     public function __construct(
20 20
         private readonly ContainerInterface $container
21
-    ) {
21
+    ){
22 22
     }
23 23
 
24 24
     public function set(string $name, mixed $rule = null): RuleManager
25 25
     {
26
-        if (empty($rule)) {
26
+        if (empty($rule)){
27 27
             $rule = $name;
28 28
         }
29 29
 
30
-        if (!$this->validateRule($rule)) {
30
+        if (!$this->validateRule($rule)){
31 31
             throw new RuleException("Unable to set rule '{$name}', invalid rule body");
32 32
         }
33 33
 
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 
39 39
     public function remove(string $name): RuleManager
40 40
     {
41
-        if (!$this->has($name)) {
41
+        if (!$this->has($name)){
42 42
             throw new RuleException("Undefined rule '{$name}'");
43 43
         }
44 44
 
@@ -60,26 +60,26 @@  discard block
 block discarded – undo
60 60
 
61 61
     public function get(string $name): RuleInterface
62 62
     {
63
-        if (!$this->has($name)) {
63
+        if (!$this->has($name)){
64 64
             throw new RuleException(\sprintf("Undefined rule '%s'", $name));
65 65
         }
66 66
 
67
-        if (!isset($this->rules[$name])) {
67
+        if (!isset($this->rules[$name])){
68 68
             //Rule represented as class name
69 69
             $rule = $name;
70
-        } else {
70
+        }else{
71 71
             $rule = $this->rules[$name];
72 72
         }
73 73
 
74
-        if ($rule instanceof RuleInterface) {
74
+        if ($rule instanceof RuleInterface){
75 75
             return $rule;
76 76
         }
77 77
 
78
-        if (\is_string($rule)) {
78
+        if (\is_string($rule)){
79 79
             //We are expecting that rule points to
80 80
             $rule = $this->container->get($rule);
81 81
 
82
-            if (!$rule instanceof RuleInterface) {
82
+            if (!$rule instanceof RuleInterface){
83 83
                 throw new RuleException(\sprintf(
84 84
                     "Rule '%s' must point to RuleInterface, '%s' given",
85 85
                     $name,
@@ -99,18 +99,18 @@  discard block
 block discarded – undo
99 99
      */
100 100
     private function validateRule(mixed $rule): bool
101 101
     {
102
-        if ($rule instanceof \Closure || $rule instanceof RuleInterface) {
102
+        if ($rule instanceof \Closure || $rule instanceof RuleInterface){
103 103
             return true;
104 104
         }
105 105
 
106
-        if (\is_array($rule)) {
106
+        if (\is_array($rule)){
107 107
             return \is_callable($rule, true);
108 108
         }
109 109
 
110
-        if (\is_string($rule) && \class_exists($rule)) {
111
-            try {
110
+        if (\is_string($rule) && \class_exists($rule)){
111
+            try{
112 112
                 $reflection = new \ReflectionClass($rule);
113
-            } catch (\ReflectionException) {
113
+            }catch (\ReflectionException){
114 114
                 return false;
115 115
             }
116 116
 
Please login to merge, or discard this patch.
Braces   +30 added lines, -14 removed lines patch added patch discarded remove patch
@@ -23,11 +23,13 @@  discard block
 block discarded – undo
23 23
 
24 24
     public function set(string $name, mixed $rule = null): RuleManager
25 25
     {
26
-        if (empty($rule)) {
26
+        if (empty($rule))
27
+        {
27 28
             $rule = $name;
28 29
         }
29 30
 
30
-        if (!$this->validateRule($rule)) {
31
+        if (!$this->validateRule($rule))
32
+        {
31 33
             throw new RuleException("Unable to set rule '{$name}', invalid rule body");
32 34
         }
33 35
 
@@ -38,7 +40,8 @@  discard block
 block discarded – undo
38 40
 
39 41
     public function remove(string $name): RuleManager
40 42
     {
41
-        if (!$this->has($name)) {
43
+        if (!$this->has($name))
44
+        {
42 45
             throw new RuleException("Undefined rule '{$name}'");
43 46
         }
44 47
 
@@ -60,26 +63,33 @@  discard block
 block discarded – undo
60 63
 
61 64
     public function get(string $name): RuleInterface
62 65
     {
63
-        if (!$this->has($name)) {
66
+        if (!$this->has($name))
67
+        {
64 68
             throw new RuleException(\sprintf("Undefined rule '%s'", $name));
65 69
         }
66 70
 
67
-        if (!isset($this->rules[$name])) {
71
+        if (!isset($this->rules[$name]))
72
+        {
68 73
             //Rule represented as class name
69 74
             $rule = $name;
70
-        } else {
75
+        }
76
+        else
77
+        {
71 78
             $rule = $this->rules[$name];
72 79
         }
73 80
 
74
-        if ($rule instanceof RuleInterface) {
81
+        if ($rule instanceof RuleInterface)
82
+        {
75 83
             return $rule;
76 84
         }
77 85
 
78
-        if (\is_string($rule)) {
86
+        if (\is_string($rule))
87
+        {
79 88
             //We are expecting that rule points to
80 89
             $rule = $this->container->get($rule);
81 90
 
82
-            if (!$rule instanceof RuleInterface) {
91
+            if (!$rule instanceof RuleInterface)
92
+            {
83 93
                 throw new RuleException(\sprintf(
84 94
                     "Rule '%s' must point to RuleInterface, '%s' given",
85 95
                     $name,
@@ -99,18 +109,24 @@  discard block
 block discarded – undo
99 109
      */
100 110
     private function validateRule(mixed $rule): bool
101 111
     {
102
-        if ($rule instanceof \Closure || $rule instanceof RuleInterface) {
112
+        if ($rule instanceof \Closure || $rule instanceof RuleInterface)
113
+        {
103 114
             return true;
104 115
         }
105 116
 
106
-        if (\is_array($rule)) {
117
+        if (\is_array($rule))
118
+        {
107 119
             return \is_callable($rule, true);
108 120
         }
109 121
 
110
-        if (\is_string($rule) && \class_exists($rule)) {
111
-            try {
122
+        if (\is_string($rule) && \class_exists($rule))
123
+        {
124
+            try
125
+            {
112 126
                 $reflection = new \ReflectionClass($rule);
113
-            } catch (\ReflectionException) {
127
+            }
128
+            catch (\ReflectionException)
129
+            {
114 130
                 return false;
115 131
             }
116 132
 
Please login to merge, or discard this patch.
src/Queue/tests/Config/QueueConfigTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -281,7 +281,7 @@
 block discarded – undo
281 281
         yield [['defaultSerializer' => null], null];
282 282
         yield [['defaultSerializer' => 'json'], 'json'];
283 283
         yield [['defaultSerializer' => JsonSerializer::class], JsonSerializer::class];
284
-        yield [['defaultSerializer' => new JsonSerializer ()], new JsonSerializer()];
284
+        yield [['defaultSerializer' => new JsonSerializer()], new JsonSerializer()];
285 285
         yield [['defaultSerializer' => new Autowire(JsonSerializer::class)], new Autowire(JsonSerializer::class)];
286 286
     }
287 287
 }
Please login to merge, or discard this patch.