Passed
Pull Request — master (#450)
by Kirill
07:27
created
src/Filters/src/SchemaBuilder.php 1 patch
Braces   +21 added lines, -10 removed lines patch added patch discarded remove patch
@@ -70,18 +70,22 @@  discard block
 block discarded – undo
70 70
     protected function buildMap(ReflectionEntity $filter): array
71 71
     {
72 72
         $schema = $filter->getProperty('schema', true);
73
-        if (empty($schema)) {
73
+        if (empty($schema))
74
+        {
74 75
             throw new SchemaException("Filter `{$filter->getName()}` does not define any schema");
75 76
         }
76 77
 
77 78
         $result = [];
78
-        foreach ($schema as $field => $definition) {
79
+        foreach ($schema as $field => $definition)
80
+        {
79 81
             $optional = false;
80 82
 
81 83
             // short definition
82
-            if (is_string($definition)) {
84
+            if (is_string($definition))
85
+            {
83 86
                 // simple scalar field definition
84
-                if (!class_exists($definition)) {
87
+                if (!class_exists($definition))
88
+                {
85 89
                     [$source, $origin] = $this->parseDefinition($field, $definition);
86 90
                     $result[$field] = [
87 91
                         FilterProvider::SOURCE => $source,
@@ -102,25 +106,30 @@  discard block
 block discarded – undo
102 106
                 continue;
103 107
             }
104 108
 
105
-            if (!is_array($definition) || count($definition) === 0) {
109
+            if (!is_array($definition) || count($definition) === 0)
110
+            {
106 111
                 throw new SchemaException(
107 112
                     "Invalid schema definition at `{$filter->getName()}`->`{$field}`"
108 113
                 );
109 114
             }
110 115
 
111 116
             // complex definition
112
-            if (!empty($definition[self::ORIGIN])) {
117
+            if (!empty($definition[self::ORIGIN]))
118
+            {
113 119
                 $origin = $definition[self::ORIGIN];
114 120
 
115 121
                 // [class, 'data:something.*'] vs [class, 'data:something']
116 122
                 $iterate = strpos($origin, '.*') !== false || !empty($definition[self::ITERATE]);
117 123
                 $origin = rtrim($origin, '.*');
118
-            } else {
124
+            }
125
+            else
126
+            {
119 127
                 $origin = $field;
120 128
                 $iterate = true;
121 129
             }
122 130
 
123
-            if (!empty($definition[self::OPTIONAL]) && $definition[self::OPTIONAL]) {
131
+            if (!empty($definition[self::OPTIONAL]) && $definition[self::OPTIONAL])
132
+            {
124 133
                 $optional = true;
125 134
             }
126 135
 
@@ -133,7 +142,8 @@  discard block
 block discarded – undo
133 142
                 FilterProvider::OPTIONAL => $optional,
134 143
             ];
135 144
 
136
-            if ($iterate) {
145
+            if ($iterate)
146
+            {
137 147
                 [$source, $origin] = $this->parseDefinition($field, $definition[self::ITERATE] ?? $origin);
138 148
 
139 149
                 $map[FilterProvider::ITERATE_SOURCE] = $source;
@@ -159,7 +169,8 @@  discard block
 block discarded – undo
159 169
      */
160 170
     private function parseDefinition(string $field, string $definition): array
161 171
     {
162
-        if (strpos($definition, ':') === false) {
172
+        if (strpos($definition, ':') === false)
173
+        {
163 174
             return ['data', $definition ?? $field];
164 175
         }
165 176
 
Please login to merge, or discard this patch.
src/Filters/src/Filter.php 1 patch
Braces   +26 added lines, -13 removed lines patch added patch discarded remove patch
@@ -160,10 +160,13 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function getErrors(): array
162 162
     {
163
-        if ($this->errors === null) {
163
+        if ($this->errors === null)
164
+        {
164 165
             $this->errors = [];
165
-            foreach ($this->validator->withData($this)->getErrors() as $field => $error) {
166
-                if (is_string($error) && Translator::isMessage($error)) {
166
+            foreach ($this->validator->withData($this)->getErrors() as $field => $error)
167
+            {
168
+                if (is_string($error) && Translator::isMessage($error))
169
+                {
167 170
                     // translate error message
168 171
                     $error = $this->say($error);
169 172
                 }
@@ -195,36 +198,46 @@  discard block
 block discarded – undo
195 198
      */
196 199
     protected function validateNested(array $errors): array
197 200
     {
198
-        foreach ($this->getFields(false) as $index => $value) {
199
-            if (isset($errors[$index])) {
201
+        foreach ($this->getFields(false) as $index => $value)
202
+        {
203
+            if (isset($errors[$index]))
204
+            {
200 205
                 //Invalid on parent level
201 206
                 continue;
202 207
             }
203 208
 
204
-            if ($value instanceof FilterInterface) {
209
+            if ($value instanceof FilterInterface)
210
+            {
205 211
                 $isOptional = $this->mappings[$index][FilterProvider::OPTIONAL] ?? false;
206 212
 
207
-                if ($isOptional && $this->getField($index) !== []) {
213
+                if ($isOptional && $this->getField($index) !== [])
214
+                {
208 215
                     continue;
209 216
                 }
210 217
 
211
-                if (!$value->isValid()) {
218
+                if (!$value->isValid())
219
+                {
212 220
                     $errors[$index] = $value->getErrors();
213 221
                     continue;
214 222
                 }
215 223
             }
216 224
 
217 225
             //Array of nested entities for validation
218
-            if (is_iterable($value)) {
219
-                foreach ($value as $nIndex => $nValue) {
220
-                    if ($nValue instanceof FilterInterface) {
226
+            if (is_iterable($value))
227
+            {
228
+                foreach ($value as $nIndex => $nValue)
229
+                {
230
+                    if ($nValue instanceof FilterInterface)
231
+                    {
221 232
                         $isOptional = $this->mappings[$index][FilterProvider::OPTIONAL] ?? false;
222 233
 
223
-                        if ($isOptional && $this->getField($nIndex) !== []) {
234
+                        if ($isOptional && $this->getField($nIndex) !== [])
235
+                        {
224 236
                             continue;
225 237
                         }
226 238
 
227
-                        if (!$nValue->isValid()) {
239
+                        if (!$nValue->isValid())
240
+                        {
228 241
                             $errors[$index][$nIndex] = $nValue->getErrors();
229 242
                         }
230 243
                     }
Please login to merge, or discard this patch.