@@ -30,9 +30,9 @@ |
||
| 30 | 30 | */ |
| 31 | 31 | public function withVerbs(string ...$verbs): RouteInterface |
| 32 | 32 | { |
| 33 | - foreach ($verbs as &$verb) { |
|
| 33 | + foreach ($verbs as &$verb){ |
|
| 34 | 34 | $verb = strtoupper($verb); |
| 35 | - if (!in_array($verb, RouteInterface::VERBS, true)) { |
|
| 35 | + if (!in_array($verb, RouteInterface::VERBS, true)){ |
|
| 36 | 36 | throw new RouteException("Invalid HTTP verb `{$verb}`"); |
| 37 | 37 | } |
| 38 | 38 | |
@@ -30,9 +30,11 @@ |
||
| 30 | 30 | */ |
| 31 | 31 | public function withVerbs(string ...$verbs): RouteInterface |
| 32 | 32 | { |
| 33 | - foreach ($verbs as &$verb) { |
|
| 33 | + foreach ($verbs as &$verb) |
|
| 34 | + { |
|
| 34 | 35 | $verb = strtoupper($verb); |
| 35 | - if (!in_array($verb, RouteInterface::VERBS, true)) { |
|
| 36 | + if (!in_array($verb, RouteInterface::VERBS, true)) |
|
| 37 | + { |
|
| 36 | 38 | throw new RouteException("Invalid HTTP verb `{$verb}`"); |
| 37 | 39 | } |
| 38 | 40 | |
@@ -65,12 +65,12 @@ |
||
| 65 | 65 | */ |
| 66 | 66 | public function match(Request $request): ?RouteInterface |
| 67 | 67 | { |
| 68 | - if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true)) { |
|
| 68 | + if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true)){ |
|
| 69 | 69 | return null; |
| 70 | 70 | } |
| 71 | 71 | |
| 72 | 72 | $matches = $this->uriHandler->match($request->getUri(), $this->defaults); |
| 73 | - if ($matches === null) { |
|
| 73 | + if ($matches === null){ |
|
| 74 | 74 | return null; |
| 75 | 75 | } |
| 76 | 76 | |
@@ -65,12 +65,14 @@ |
||
| 65 | 65 | */ |
| 66 | 66 | public function match(Request $request): ?RouteInterface |
| 67 | 67 | { |
| 68 | - if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true)) { |
|
| 68 | + if (!in_array(strtoupper($request->getMethod()), $this->getVerbs(), true)) |
|
| 69 | + { |
|
| 69 | 70 | return null; |
| 70 | 71 | } |
| 71 | 72 | |
| 72 | 73 | $matches = $this->uriHandler->match($request->getUri(), $this->defaults); |
| 73 | - if ($matches === null) { |
|
| 74 | + if ($matches === null) |
|
| 75 | + { |
|
| 74 | 76 | return null; |
| 75 | 77 | } |
| 76 | 78 | |
@@ -60,7 +60,7 @@ discard block |
||
| 60 | 60 | CoreInterface $core, |
| 61 | 61 | ScopeInterface $scope, |
| 62 | 62 | ResponseFactoryInterface $responseFactory |
| 63 | - ) { |
|
| 63 | + ){ |
|
| 64 | 64 | $this->core = $core; |
| 65 | 65 | $this->scope = $scope; |
| 66 | 66 | $this->responseFactory = $responseFactory; |
@@ -103,7 +103,7 @@ discard block |
||
| 103 | 103 | */ |
| 104 | 104 | public function handle(Request $request): Response |
| 105 | 105 | { |
| 106 | - if ($this->controller === null) { |
|
| 106 | + if ($this->controller === null){ |
|
| 107 | 107 | throw new HandlerException('Controller and action pair is not set'); |
| 108 | 108 | } |
| 109 | 109 | |
@@ -113,7 +113,7 @@ discard block |
||
| 113 | 113 | $output = $result = null; |
| 114 | 114 | |
| 115 | 115 | $response = $this->responseFactory->createResponse(200); |
| 116 | - try { |
|
| 116 | + try{ |
|
| 117 | 117 | // run the core withing PSR-7 Request/Response scope |
| 118 | 118 | $result = $this->scope->runScope( |
| 119 | 119 | [ |
@@ -128,22 +128,22 @@ discard block |
||
| 128 | 128 | ); |
| 129 | 129 | } |
| 130 | 130 | ); |
| 131 | - } catch (ControllerException $e) { |
|
| 131 | + }catch (ControllerException $e){ |
|
| 132 | 132 | ob_get_clean(); |
| 133 | 133 | throw $this->mapException($e); |
| 134 | - } catch (\Throwable $e) { |
|
| 134 | + }catch (\Throwable $e){ |
|
| 135 | 135 | ob_get_clean(); |
| 136 | 136 | throw $e; |
| 137 | - } finally { |
|
| 138 | - while (ob_get_level() > $outputLevel + 1) { |
|
| 139 | - $output = ob_get_clean() . $output; |
|
| 137 | + }finally{ |
|
| 138 | + while (ob_get_level() > $outputLevel + 1){ |
|
| 139 | + $output = ob_get_clean().$output; |
|
| 140 | 140 | } |
| 141 | 141 | } |
| 142 | 142 | |
| 143 | 143 | return $this->wrapResponse( |
| 144 | 144 | $response, |
| 145 | 145 | $result, |
| 146 | - ob_get_clean() . $output |
|
| 146 | + ob_get_clean().$output |
|
| 147 | 147 | ); |
| 148 | 148 | } |
| 149 | 149 | |
@@ -153,8 +153,8 @@ discard block |
||
| 153 | 153 | */ |
| 154 | 154 | private function getAction(Request $request): string |
| 155 | 155 | { |
| 156 | - if ($this->verbActions) { |
|
| 157 | - return strtolower($request->getMethod()) . ucfirst($this->action); |
|
| 156 | + if ($this->verbActions){ |
|
| 157 | + return strtolower($request->getMethod()).ucfirst($this->action); |
|
| 158 | 158 | } |
| 159 | 159 | |
| 160 | 160 | return $this->action; |
@@ -170,17 +170,17 @@ discard block |
||
| 170 | 170 | */ |
| 171 | 171 | private function wrapResponse(Response $response, $result = null, string $output = ''): Response |
| 172 | 172 | { |
| 173 | - if ($result instanceof Response) { |
|
| 174 | - if ($output !== '' && $result->getBody()->isWritable()) { |
|
| 173 | + if ($result instanceof Response){ |
|
| 174 | + if ($output !== '' && $result->getBody()->isWritable()){ |
|
| 175 | 175 | $result->getBody()->write($output); |
| 176 | 176 | } |
| 177 | 177 | |
| 178 | 178 | return $result; |
| 179 | 179 | } |
| 180 | 180 | |
| 181 | - if (is_array($result) || $result instanceof \JsonSerializable) { |
|
| 181 | + if (is_array($result) || $result instanceof \JsonSerializable){ |
|
| 182 | 182 | $response = $this->writeJson($response, $result); |
| 183 | - } else { |
|
| 183 | + }else{ |
|
| 184 | 184 | $response->getBody()->write((string)$result); |
| 185 | 185 | } |
| 186 | 186 | |
@@ -198,7 +198,7 @@ discard block |
||
| 198 | 198 | */ |
| 199 | 199 | private function mapException(ControllerException $exception): ClientException |
| 200 | 200 | { |
| 201 | - switch ($exception->getCode()) { |
|
| 201 | + switch ($exception->getCode()){ |
|
| 202 | 202 | case ControllerException::BAD_ACTION: |
| 203 | 203 | case ControllerException::NOT_FOUND: |
| 204 | 204 | return new NotFoundException($exception->getMessage()); |
@@ -103,7 +103,8 @@ discard block |
||
| 103 | 103 | */ |
| 104 | 104 | public function handle(Request $request): Response |
| 105 | 105 | { |
| 106 | - if ($this->controller === null) { |
|
| 106 | + if ($this->controller === null) |
|
| 107 | + { |
|
| 107 | 108 | throw new HandlerException('Controller and action pair is not set'); |
| 108 | 109 | } |
| 109 | 110 | |
@@ -113,14 +114,16 @@ discard block |
||
| 113 | 114 | $output = $result = null; |
| 114 | 115 | |
| 115 | 116 | $response = $this->responseFactory->createResponse(200); |
| 116 | - try { |
|
| 117 | + try |
|
| 118 | + { |
|
| 117 | 119 | // run the core withing PSR-7 Request/Response scope |
| 118 | 120 | $result = $this->scope->runScope( |
| 119 | 121 | [ |
| 120 | 122 | Request::class => $request, |
| 121 | 123 | Response::class => $response, |
| 122 | 124 | ], |
| 123 | - function () use ($request) { |
|
| 125 | + function () use ($request) |
|
| 126 | + { |
|
| 124 | 127 | return $this->core->callAction( |
| 125 | 128 | $this->controller, |
| 126 | 129 | $this->getAction($request), |
@@ -128,14 +131,21 @@ discard block |
||
| 128 | 131 | ); |
| 129 | 132 | } |
| 130 | 133 | ); |
| 131 | - } catch (ControllerException $e) { |
|
| 134 | + } |
|
| 135 | + catch (ControllerException $e) |
|
| 136 | + { |
|
| 132 | 137 | ob_get_clean(); |
| 133 | 138 | throw $this->mapException($e); |
| 134 | - } catch (\Throwable $e) { |
|
| 139 | + } |
|
| 140 | + catch (\Throwable $e) |
|
| 141 | + { |
|
| 135 | 142 | ob_get_clean(); |
| 136 | 143 | throw $e; |
| 137 | - } finally { |
|
| 138 | - while (ob_get_level() > $outputLevel + 1) { |
|
| 144 | + } |
|
| 145 | + finally |
|
| 146 | + { |
|
| 147 | + while (ob_get_level() > $outputLevel + 1) |
|
| 148 | + { |
|
| 139 | 149 | $output = ob_get_clean() . $output; |
| 140 | 150 | } |
| 141 | 151 | } |
@@ -153,7 +163,8 @@ discard block |
||
| 153 | 163 | */ |
| 154 | 164 | private function getAction(Request $request): string |
| 155 | 165 | { |
| 156 | - if ($this->verbActions) { |
|
| 166 | + if ($this->verbActions) |
|
| 167 | + { |
|
| 157 | 168 | return strtolower($request->getMethod()) . ucfirst($this->action); |
| 158 | 169 | } |
| 159 | 170 | |
@@ -170,17 +181,22 @@ discard block |
||
| 170 | 181 | */ |
| 171 | 182 | private function wrapResponse(Response $response, $result = null, string $output = ''): Response |
| 172 | 183 | { |
| 173 | - if ($result instanceof Response) { |
|
| 174 | - if ($output !== '' && $result->getBody()->isWritable()) { |
|
| 184 | + if ($result instanceof Response) |
|
| 185 | + { |
|
| 186 | + if ($output !== '' && $result->getBody()->isWritable()) |
|
| 187 | + { |
|
| 175 | 188 | $result->getBody()->write($output); |
| 176 | 189 | } |
| 177 | 190 | |
| 178 | 191 | return $result; |
| 179 | 192 | } |
| 180 | 193 | |
| 181 | - if (is_array($result) || $result instanceof \JsonSerializable) { |
|
| 194 | + if (is_array($result) || $result instanceof \JsonSerializable) |
|
| 195 | + { |
|
| 182 | 196 | $response = $this->writeJson($response, $result); |
| 183 | - } else { |
|
| 197 | + } |
|
| 198 | + else |
|
| 199 | + { |
|
| 184 | 200 | $response->getBody()->write((string)$result); |
| 185 | 201 | } |
| 186 | 202 | |
@@ -198,7 +214,8 @@ discard block |
||
| 198 | 214 | */ |
| 199 | 215 | private function mapException(ControllerException $exception): ClientException |
| 200 | 216 | { |
| 201 | - switch ($exception->getCode()) { |
|
| 217 | + switch ($exception->getCode()) |
|
| 218 | + { |
|
| 202 | 219 | case ControllerException::BAD_ACTION: |
| 203 | 220 | case ControllerException::NOT_FOUND: |
| 204 | 221 | return new NotFoundException($exception->getMessage()); |
@@ -24,7 +24,7 @@ |
||
| 24 | 24 | { |
| 25 | 25 | public function tearDown(): void |
| 26 | 26 | { |
| 27 | - if ((int)session_status() === PHP_SESSION_ACTIVE) { |
|
| 27 | + if ((int)session_status() === PHP_SESSION_ACTIVE){ |
|
| 28 | 28 | session_abort(); |
| 29 | 29 | } |
| 30 | 30 | } |
@@ -24,7 +24,8 @@ |
||
| 24 | 24 | { |
| 25 | 25 | public function tearDown(): void |
| 26 | 26 | { |
| 27 | - if ((int)session_status() === PHP_SESSION_ACTIVE) { |
|
| 27 | + if ((int)session_status() === PHP_SESSION_ACTIVE) |
|
| 28 | + { |
|
| 28 | 29 | session_abort(); |
| 29 | 30 | } |
| 30 | 31 | } |
@@ -51,7 +51,7 @@ discard block |
||
| 51 | 51 | |
| 52 | 52 | public function tearDown(): void |
| 53 | 53 | { |
| 54 | - if ((int)session_status() === PHP_SESSION_ACTIVE) { |
|
| 54 | + if ((int)session_status() === PHP_SESSION_ACTIVE){ |
|
| 55 | 55 | session_abort(); |
| 56 | 56 | } |
| 57 | 57 | } |
@@ -125,7 +125,7 @@ discard block |
||
| 125 | 125 | $this->assertSame('default', $section->getName()); |
| 126 | 126 | |
| 127 | 127 | $section->set('key', 'value'); |
| 128 | - foreach ($section as $key => $value) { |
|
| 128 | + foreach ($section as $key => $value){ |
|
| 129 | 129 | $this->assertSame('key', $key); |
| 130 | 130 | $this->assertSame('value', $value); |
| 131 | 131 | } |
@@ -51,7 +51,8 @@ discard block |
||
| 51 | 51 | |
| 52 | 52 | public function tearDown(): void |
| 53 | 53 | { |
| 54 | - if ((int)session_status() === PHP_SESSION_ACTIVE) { |
|
| 54 | + if ((int)session_status() === PHP_SESSION_ACTIVE) |
|
| 55 | + { |
|
| 55 | 56 | session_abort(); |
| 56 | 57 | } |
| 57 | 58 | } |
@@ -125,7 +126,8 @@ discard block |
||
| 125 | 126 | $this->assertSame('default', $section->getName()); |
| 126 | 127 | |
| 127 | 128 | $section->set('key', 'value'); |
| 128 | - foreach ($section as $key => $value) { |
|
| 129 | + foreach ($section as $key => $value) |
|
| 130 | + { |
|
| 129 | 131 | $this->assertSame('key', $key); |
| 130 | 132 | $this->assertSame('value', $value); |
| 131 | 133 | } |
@@ -127,7 +127,7 @@ discard block |
||
| 127 | 127 | */ |
| 128 | 128 | public function get(string $name, $default = null) |
| 129 | 129 | { |
| 130 | - if (!$this->has($name)) { |
|
| 130 | + if (!$this->has($name)){ |
|
| 131 | 131 | return $default; |
| 132 | 132 | } |
| 133 | 133 | |
@@ -202,7 +202,7 @@ discard block |
||
| 202 | 202 | { |
| 203 | 203 | $this->session->resume(); |
| 204 | 204 | |
| 205 | - if (!isset($_SESSION[$this->name])) { |
|
| 205 | + if (!isset($_SESSION[$this->name])){ |
|
| 206 | 206 | $_SESSION[$this->name] = []; |
| 207 | 207 | } |
| 208 | 208 | } |
@@ -127,7 +127,8 @@ discard block |
||
| 127 | 127 | */ |
| 128 | 128 | public function get(string $name, $default = null) |
| 129 | 129 | { |
| 130 | - if (!$this->has($name)) { |
|
| 130 | + if (!$this->has($name)) |
|
| 131 | + { |
|
| 131 | 132 | return $default; |
| 132 | 133 | } |
| 133 | 134 | |
@@ -202,7 +203,8 @@ discard block |
||
| 202 | 203 | { |
| 203 | 204 | $this->session->resume(); |
| 204 | 205 | |
| 205 | - if (!isset($_SESSION[$this->name])) { |
|
| 206 | + if (!isset($_SESSION[$this->name])) |
|
| 207 | + { |
|
| 206 | 208 | $_SESSION[$this->name] = []; |
| 207 | 209 | } |
| 208 | 210 | } |
@@ -62,8 +62,8 @@ |
||
| 62 | 62 | */ |
| 63 | 63 | public function gc($maxlifetime): void |
| 64 | 64 | { |
| 65 | - foreach ($this->files->getFiles($this->directory) as $filename) { |
|
| 66 | - if ($this->files->time($filename) < time() - $maxlifetime) { |
|
| 65 | + foreach ($this->files->getFiles($this->directory) as $filename){ |
|
| 66 | + if ($this->files->time($filename) < time() - $maxlifetime){ |
|
| 67 | 67 | $this->files->delete($filename); |
| 68 | 68 | } |
| 69 | 69 | } |
@@ -62,8 +62,10 @@ |
||
| 62 | 62 | */ |
| 63 | 63 | public function gc($maxlifetime): void |
| 64 | 64 | { |
| 65 | - foreach ($this->files->getFiles($this->directory) as $filename) { |
|
| 66 | - if ($this->files->time($filename) < time() - $maxlifetime) { |
|
| 65 | + foreach ($this->files->getFiles($this->directory) as $filename) |
|
| 66 | + { |
|
| 67 | + if ($this->files->time($filename) < time() - $maxlifetime) |
|
| 68 | + { |
|
| 67 | 69 | $this->files->delete($filename); |
| 68 | 70 | } |
| 69 | 71 | } |
@@ -48,15 +48,15 @@ |
||
| 48 | 48 | */ |
| 49 | 49 | public function initSession(string $clientSignature, string $id = null): SessionInterface |
| 50 | 50 | { |
| 51 | - if ((int)session_status() === PHP_SESSION_ACTIVE) { |
|
| 51 | + if ((int)session_status() === PHP_SESSION_ACTIVE){ |
|
| 52 | 52 | throw new MultipleSessionException('Unable to initiate session, session already started'); |
| 53 | 53 | } |
| 54 | 54 | |
| 55 | 55 | //Initiating proper session handler |
| 56 | - if ($this->config->getHandler() !== null) { |
|
| 57 | - try { |
|
| 56 | + if ($this->config->getHandler() !== null){ |
|
| 57 | + try{ |
|
| 58 | 58 | $handler = $this->config->getHandler()->resolve($this->factory); |
| 59 | - } catch (\Throwable | ContainerExceptionInterface $e) { |
|
| 59 | + }catch (\Throwable | ContainerExceptionInterface $e){ |
|
| 60 | 60 | throw new SessionException($e->getMessage(), $e->getCode(), $e); |
| 61 | 61 | } |
| 62 | 62 | |
@@ -48,15 +48,20 @@ |
||
| 48 | 48 | */ |
| 49 | 49 | public function initSession(string $clientSignature, string $id = null): SessionInterface |
| 50 | 50 | { |
| 51 | - if ((int)session_status() === PHP_SESSION_ACTIVE) { |
|
| 51 | + if ((int)session_status() === PHP_SESSION_ACTIVE) |
|
| 52 | + { |
|
| 52 | 53 | throw new MultipleSessionException('Unable to initiate session, session already started'); |
| 53 | 54 | } |
| 54 | 55 | |
| 55 | 56 | //Initiating proper session handler |
| 56 | - if ($this->config->getHandler() !== null) { |
|
| 57 | - try { |
|
| 57 | + if ($this->config->getHandler() !== null) |
|
| 58 | + { |
|
| 59 | + try |
|
| 60 | + { |
|
| 58 | 61 | $handler = $this->config->getHandler()->resolve($this->factory); |
| 59 | - } catch (\Throwable | ContainerExceptionInterface $e) { |
|
| 62 | + } |
|
| 63 | + catch (\Throwable | ContainerExceptionInterface $e) |
|
| 64 | + { |
|
| 60 | 65 | throw new SessionException($e->getMessage(), $e->getCode(), $e); |
| 61 | 66 | } |
| 62 | 67 | |
@@ -72,7 +72,7 @@ discard block |
||
| 72 | 72 | $this->clientSignature = $clientSignature; |
| 73 | 73 | $this->lifetime = $lifetime; |
| 74 | 74 | |
| 75 | - if (!empty($id) && $this->validID($id)) { |
|
| 75 | + if (!empty($id) && $this->validID($id)){ |
|
| 76 | 76 | $this->id = $id; |
| 77 | 77 | } |
| 78 | 78 | } |
@@ -103,24 +103,24 @@ discard block |
||
| 103 | 103 | */ |
| 104 | 104 | public function resume(): void |
| 105 | 105 | { |
| 106 | - if ($this->isStarted()) { |
|
| 106 | + if ($this->isStarted()){ |
|
| 107 | 107 | return; |
| 108 | 108 | } |
| 109 | 109 | |
| 110 | - if (!empty($this->id)) { |
|
| 110 | + if (!empty($this->id)){ |
|
| 111 | 111 | session_id($this->id); |
| 112 | - } else { |
|
| 112 | + }else{ |
|
| 113 | 113 | // always new id |
| 114 | 114 | session_id(session_create_id()); |
| 115 | 115 | } |
| 116 | 116 | |
| 117 | - try { |
|
| 117 | + try{ |
|
| 118 | 118 | session_start(['use_cookies' => false]); |
| 119 | - } catch (\Throwable $e) { |
|
| 119 | + }catch (\Throwable $e){ |
|
| 120 | 120 | throw new SessionException('Unable to start session', $e->getCode(), $e); |
| 121 | 121 | } |
| 122 | 122 | |
| 123 | - if (empty($this->id)) { |
|
| 123 | + if (empty($this->id)){ |
|
| 124 | 124 | //Sign newly created session |
| 125 | 125 | $_SESSION[self::CLIENT_SIGNATURE] = $this->clientSignature; |
| 126 | 126 | $_SESSION[self::SESSION_CREATED] = time(); |
@@ -131,7 +131,7 @@ discard block |
||
| 131 | 131 | $this->started = true; |
| 132 | 132 | |
| 133 | 133 | //Ensure that session is valid |
| 134 | - if (!$this->validSession()) { |
|
| 134 | + if (!$this->validSession()){ |
|
| 135 | 135 | $this->invalidateSession(); |
| 136 | 136 | } |
| 137 | 137 | } |
@@ -170,7 +170,7 @@ discard block |
||
| 170 | 170 | */ |
| 171 | 171 | public function commit(): bool |
| 172 | 172 | { |
| 173 | - if (!$this->isStarted()) { |
|
| 173 | + if (!$this->isStarted()){ |
|
| 174 | 174 | return false; |
| 175 | 175 | } |
| 176 | 176 | |
@@ -185,7 +185,7 @@ discard block |
||
| 185 | 185 | */ |
| 186 | 186 | public function abort(): bool |
| 187 | 187 | { |
| 188 | - if (!$this->isStarted()) { |
|
| 188 | + if (!$this->isStarted()){ |
|
| 189 | 189 | return false; |
| 190 | 190 | } |
| 191 | 191 | |
@@ -228,17 +228,17 @@ discard block |
||
| 228 | 228 | if ( |
| 229 | 229 | !array_key_exists(self::CLIENT_SIGNATURE, $_SESSION) |
| 230 | 230 | || !array_key_exists(self::SESSION_CREATED, $_SESSION) |
| 231 | - ) { |
|
| 231 | + ){ |
|
| 232 | 232 | //Missing session signature or timestamp! |
| 233 | 233 | return false; |
| 234 | 234 | } |
| 235 | 235 | |
| 236 | - if ($_SESSION[self::SESSION_CREATED] < time() - $this->lifetime) { |
|
| 236 | + if ($_SESSION[self::SESSION_CREATED] < time() - $this->lifetime){ |
|
| 237 | 237 | //Session expired |
| 238 | 238 | return false; |
| 239 | 239 | } |
| 240 | 240 | |
| 241 | - if (!hash_equals($_SESSION[self::CLIENT_SIGNATURE], $this->clientSignature)) { |
|
| 241 | + if (!hash_equals($_SESSION[self::CLIENT_SIGNATURE], $this->clientSignature)){ |
|
| 242 | 242 | //Signatures do not match |
| 243 | 243 | return false; |
| 244 | 244 | } |
@@ -72,7 +72,8 @@ discard block |
||
| 72 | 72 | $this->clientSignature = $clientSignature; |
| 73 | 73 | $this->lifetime = $lifetime; |
| 74 | 74 | |
| 75 | - if (!empty($id) && $this->validID($id)) { |
|
| 75 | + if (!empty($id) && $this->validID($id)) |
|
| 76 | + { |
|
| 76 | 77 | $this->id = $id; |
| 77 | 78 | } |
| 78 | 79 | } |
@@ -103,24 +104,32 @@ discard block |
||
| 103 | 104 | */ |
| 104 | 105 | public function resume(): void |
| 105 | 106 | { |
| 106 | - if ($this->isStarted()) { |
|
| 107 | + if ($this->isStarted()) |
|
| 108 | + { |
|
| 107 | 109 | return; |
| 108 | 110 | } |
| 109 | 111 | |
| 110 | - if (!empty($this->id)) { |
|
| 112 | + if (!empty($this->id)) |
|
| 113 | + { |
|
| 111 | 114 | session_id($this->id); |
| 112 | - } else { |
|
| 115 | + } |
|
| 116 | + else |
|
| 117 | + { |
|
| 113 | 118 | // always new id |
| 114 | 119 | session_id(session_create_id()); |
| 115 | 120 | } |
| 116 | 121 | |
| 117 | - try { |
|
| 122 | + try |
|
| 123 | + { |
|
| 118 | 124 | session_start(['use_cookies' => false]); |
| 119 | - } catch (\Throwable $e) { |
|
| 125 | + } |
|
| 126 | + catch (\Throwable $e) |
|
| 127 | + { |
|
| 120 | 128 | throw new SessionException('Unable to start session', $e->getCode(), $e); |
| 121 | 129 | } |
| 122 | 130 | |
| 123 | - if (empty($this->id)) { |
|
| 131 | + if (empty($this->id)) |
|
| 132 | + { |
|
| 124 | 133 | //Sign newly created session |
| 125 | 134 | $_SESSION[self::CLIENT_SIGNATURE] = $this->clientSignature; |
| 126 | 135 | $_SESSION[self::SESSION_CREATED] = time(); |
@@ -131,7 +140,8 @@ discard block |
||
| 131 | 140 | $this->started = true; |
| 132 | 141 | |
| 133 | 142 | //Ensure that session is valid |
| 134 | - if (!$this->validSession()) { |
|
| 143 | + if (!$this->validSession()) |
|
| 144 | + { |
|
| 135 | 145 | $this->invalidateSession(); |
| 136 | 146 | } |
| 137 | 147 | } |
@@ -170,7 +180,8 @@ discard block |
||
| 170 | 180 | */ |
| 171 | 181 | public function commit(): bool |
| 172 | 182 | { |
| 173 | - if (!$this->isStarted()) { |
|
| 183 | + if (!$this->isStarted()) |
|
| 184 | + { |
|
| 174 | 185 | return false; |
| 175 | 186 | } |
| 176 | 187 | |
@@ -185,7 +196,8 @@ discard block |
||
| 185 | 196 | */ |
| 186 | 197 | public function abort(): bool |
| 187 | 198 | { |
| 188 | - if (!$this->isStarted()) { |
|
| 199 | + if (!$this->isStarted()) |
|
| 200 | + { |
|
| 189 | 201 | return false; |
| 190 | 202 | } |
| 191 | 203 | |
@@ -233,12 +245,14 @@ discard block |
||
| 233 | 245 | return false; |
| 234 | 246 | } |
| 235 | 247 | |
| 236 | - if ($_SESSION[self::SESSION_CREATED] < time() - $this->lifetime) { |
|
| 248 | + if ($_SESSION[self::SESSION_CREATED] < time() - $this->lifetime) |
|
| 249 | + { |
|
| 237 | 250 | //Session expired |
| 238 | 251 | return false; |
| 239 | 252 | } |
| 240 | 253 | |
| 241 | - if (!hash_equals($_SESSION[self::CLIENT_SIGNATURE], $this->clientSignature)) { |
|
| 254 | + if (!hash_equals($_SESSION[self::CLIENT_SIGNATURE], $this->clientSignature)) |
|
| 255 | + { |
|
| 242 | 256 | //Signatures do not match |
| 243 | 257 | return false; |
| 244 | 258 | } |