Spiral\Database\Drivers\Postgres\PostgresDriver

Complexity

Total Complexity

14

Size/Duplication

Total Lines	150
Duplicated Lines	12.67 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes	8
Bugs	0	Features	2

6 Methods

Rating	Name	Duplication	Size	Complexity
A	hasTable()	0	7	1
A	tableNames()	12	12	2
C	getPrimary()	0	31	8
A	insertBuilder()	7	7	1
A	createPDO()	0	8	1
A	__construct()	0	10	1

<?php
/**
 * Spiral Framework.
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */
namespace Spiral\Database\Drivers\Postgres;

use Spiral\Core\FactoryInterface;
use Spiral\Core\HippocampusInterface;
use Spiral\Database\DatabaseInterface;
use Spiral\Database\Drivers\Postgres\Schemas\Commander;
use Spiral\Database\Drivers\Postgres\Schemas\TableSchema;
use Spiral\Database\Entities\Database;
use Spiral\Database\Entities\Driver;
use Spiral\Database\Exceptions\DriverException;

/**
 * Talks to postgres databases.
 */
class PostgresDriver extends Driver
{
    /**
     * Driver type.
     */
    const TYPE = DatabaseInterface::POSTGRES;

    /**
     * Driver schemas.
     */
    const SCHEMA_TABLE = TableSchema::class;

    /**
     * Commander used to execute commands. :)
     */
    const COMMANDER = Commander::class;

    /**
     * Query compiler class.
     */
    const QUERY_COMPILER = QueryCompiler::class;

    /**
     * Default timestamp expression.
     */
    const TIMESTAMP_NOW = 'now()';

    /**
     * Cached list of primary keys associated with their table names. Used by InsertBuilder to
     * emulate last insert id.
     *
     * @var array
     */
    private $primaryKeys = [];

    /**
     * Needed to remember table primary keys.
     *
     * @invisible
     * @var HippocampusInterface
     */
    protected $memory = null;

    /**
     * {@inheritdoc}
     * @param string               $name
     * @param array                $config
     * @param FactoryInterface     $factory
     * @param HippocampusInterface $memory
     */
    public function __construct(
        $name,
        array $config,
        FactoryInterface $factory = null,
        HippocampusInterface $memory = null
    ) {
        parent::__construct($name, $config, $factory);

        $this->memory = $memory;
    }

    /**
     * {@inheritdoc}
     */
    public function hasTable($name)
    {
        $query = 'SELECT "table_name" FROM "information_schema"."tables" '
            . 'WHERE "table_schema" = \'public\' AND "table_type" = \'BASE TABLE\' AND "table_name" = ?';

        return (bool)$this->query($query, [$name])->fetchColumn();
    }

    /**
     * {@inheritdoc}
     */
    public function tableNames()

This method seems to be duplicated in your project.

    {
        $query = 'SELECT "table_name" FROM "information_schema"."tables" '
            . 'WHERE "table_schema" = \'public\' AND "table_type" = \'BASE TABLE\'';

        $tables = [];
        foreach ($this->query($query) as $row) {
            $tables[] = $row['table_name'];
        }

        return $tables;
    }

    /**
     * Get singular primary key associated with desired table. Used to emulate last insert id.
     *
     * @param string $table Fully specified table name, including postfix.
     * @return string
     * @throws DriverException
     */
    public function getPrimary($table)
    {
        if (!empty($this->memory) && empty($this->primaryKeys)) {
            $this->primaryKeys = $this->memory->loadData($this->getSource() . '-primary');

It seems like $this->memory->loadData($this->getSource() . '-primary') can also be of type string or null. However, the property $primaryKeys is declared as type array. Maybe add an additional type check?

        }

        if (!empty($this->primaryKeys) && array_key_exists($table, $this->primaryKeys)) {
            return $this->primaryKeys[$table];
        }

        if (!$this->hasTable($table)) {
            throw new DriverException(
                "Unable to fetch table primary key, no such table '{$table}' exists."
            );
        }

        $this->primaryKeys[$table] = $this->tableSchema($table)->getPrimaryKeys();
        if (count($this->primaryKeys[$table]) === 1) {
            //We do support only single primary key
            $this->primaryKeys[$table] = $this->primaryKeys[$table][0];
        } else {
            $this->primaryKeys[$table] = null;
        }

        //Caching
        if (!empty($this->memory)) {
            $this->memory->saveData($this->getSource() . '-primary', $this->primaryKeys);
        }

        return $this->primaryKeys[$table];
    }

    /**
     * {@inheritdoc}
     */
    public function insertBuilder(Database $database, array $parameters = [])

This method seems to be duplicated in your project.

    {
        return $this->factory->make(InsertQuery::class, [
                'database' => $database,
                'compiler' => $this->queryCompiler($database->getPrefix())
            ] + $parameters);
    }

    /**
     * {@inheritdoc}
     */
    protected function createPDO()
    {
        //Spiral is purely UTF-8
        $pdo = parent::createPDO();
        $pdo->exec("SET NAMES 'UTF-8'");

        return $pdo;
    }
}