Spiral\ORM\Record

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	save()	0	25	4
A	delete()	0	7	1

<?php
/**
 * components
 *
 * @author    Wolfy-J
 */
namespace Spiral\ORM;

use Spiral\Models\ActiveEntityInterface;
use Spiral\ORM\Commands\InsertCommand;
use Spiral\ORM\Commands\UpdateCommand;

/**
 * Adds ActiveRecord abilities to RecordEntity.
 */
abstract class Record extends RecordEntity implements ActiveEntityInterface
{
    public function save(TransactionInterface $transaction = null, bool $queueRelations = true): int
    {
        //Initial reacord command
        $command = $this->queueSave(false);

        if ($command instanceof InsertCommand) {
            $state = self::CREATED;
        } elseif ($command instanceof UpdateCommand) {
            $state = self::UPDATED;
        } else {
            $state = self::UNCHANGED;
        }

        if ($queueRelations) {
            //Mounting relation related updates
            $command = $this->relations->queueRelations($command);
        }

        //todo: saturate command

        //Registering command
        $transaction->addCommand($command);

It seems like $transaction is not always an object, but can also be of type null. Maybe add an additional type check?

        return $state;
    }

    public function delete(TransactionInterface $transaction = null)
    {
        //todo: saturate command

        //saturate transaction
        $transaction->addCommand($this->queueDelete());

It seems like $transaction is not always an object, but can also be of type null. Maybe add an additional type check?

    }
}