MySQLTable::fetchColumns() - Code Metrics - Inspection of "mysq world man!" - spiral/components - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — feature/pre-split (b5c37f)

by Anton

created 2016-12-13 13:45 UTC

MySQLTable::fetchColumns() A

↳ Parent: MySQLTable

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	0
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * components
 *
 * @author    Wolfy-J
 */
namespace Spiral\Database\Drivers\MySQL\Schemas;

use Spiral\Database\Exceptions\SchemaException;
use Spiral\Database\Schemas\Prototypes\AbstractColumn;
use Spiral\Database\Schemas\Prototypes\AbstractIndex;
use Spiral\Database\Schemas\Prototypes\AbstractReference;
use Spiral\Database\Schemas\Prototypes\AbstractTable;
use Spiral\Database\Schemas\TableState;

class MySQLTable extends AbstractTable
{
    /**
     * List of most common MySQL table engines.
     */
    const ENGINE_INNODB = 'InnoDB';
    const ENGINE_MYISAM = 'MyISAM';
    const ENGINE_MEMORY = 'Memory';

    /**
     * MySQL table engine.
     *
     * @var string
     */
    private $engine = self::ENGINE_INNODB;

    /**
     * Populate table schema with values from database.
     *
     * @param TableState $state
     */
    protected function initSchema(TableState $state)
    {
        parent::initSchema($state);

        //Reading table schema
        $this->engine = $this->driver->query('SHOW TABLE STATUS WHERE `Name` = ?', [
            $state->getName()
        ])->fetch()['Engine'];
    }

    /**
     * Change table engine. Such operation will be applied only at moment of table creation.
     *
     * @param string $engine
     *
     * @return $this
     *
     * @throws SchemaException
     */
    public function setEngine($engine)
    {
        if ($this->exists()) {
            throw new SchemaException('Table engine can be set only at moment of creation');
        }

        $this->engine = $engine;

        return $this;
    }

    /**
     * @return string
     */
    public function getEngine()
    {
        return $this->engine;
    }

    /**
     * {@inheritdoc}
     */
    protected function fetchColumns(): array
    {
        $query = "SHOW FULL COLUMNS FROM {$this->driver->identifier($this->getName())}";

        $result = [];
        foreach ($this->driver->query($query) as $schema) {
            $result[] = MySQLColumn::createInstance($this->getName(), $schema);
        }

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    protected function fetchIndexes(): array
    {
        $query = "SHOW INDEXES FROM {$this->driver->identifier($this->getName())}";

        //Gluing all index definitions together
        $schemas = [];
        foreach ($this->driver->query($query) as $index) {
            if ($index['Key_name'] == 'PRIMARY') {
                //Skipping PRIMARY index
                continue;
            }

            $schemas[$index['Key_name']][] = $index;
        }

        $result = [];
        foreach ($schemas as $name => $index) {
            $result[] = MySQLIndex::createInstance($this->getName(), $name, $index);
        }

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    protected function fetchReferences(): array
    {
        $references = $this->driver->query(
            'SELECT * FROM `information_schema`.`referential_constraints` WHERE `constraint_schema` = ? AND `table_name` = ?',
            [$this->driver->getSource(), $this->getName()]
        );

        $result = [];
        foreach ($references as $schema) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $references = 'SELECT * FROM `information_schema`.`key_column_usage` WHERE `constraint_name` = ? AND `table_schema` = ? AND `table_name` = ?';

            $column = $this->driver->query(
                $references,
                [$schema['CONSTRAINT_NAME'], $this->driver->getSource(), $this->getName()]
            )->fetch();

            $result[] = MySQLReference::createInstance(
                $this->getName(),
                $this->getPrefix(),
                $schema + $column
            );
        }

        return $result;
    }

    /**
     * Fetching primary keys from table.
     *
     * @return array
     */
    protected function fetchPrimaryKeys(): array
    {
        $query = "SHOW INDEXES FROM {$this->driver->identifier($this->getName())}";

        $primaryKeys = [];
        foreach ($this->driver->query($query) as $index) {
            if ($index['Key_name'] == 'PRIMARY') {
                $primaryKeys[] = $index['Column_name'];
            }
        }

        return $primaryKeys;
    }

    /**
     * {@inheritdoc}
     */
    protected function createColumn(string $name): AbstractColumn
    {
        return new MySQLColumn($this->getName(), $name);
    }

    /**
     * {@inheritdoc}
     */
    protected function createIndex(string $name): AbstractIndex
    {
        return new MySQLIndex($this->getName(), $name);
    }

    /**
     * {@inheritdoc}
     */
    protected function createForeign(string $column): AbstractReference
    {
        return new MySQLReference($this->getName(), $this->getPrefix(), $column);
    }
}

1			<?php
2			/**
3			* components
4			*
5			* @author Wolfy-J
6			*/
7			namespace Spiral\Database\Drivers\MySQL\Schemas;
8
9			use Spiral\Database\Exceptions\SchemaException;
10			use Spiral\Database\Schemas\Prototypes\AbstractColumn;
11			use Spiral\Database\Schemas\Prototypes\AbstractIndex;
12			use Spiral\Database\Schemas\Prototypes\AbstractReference;
13			use Spiral\Database\Schemas\Prototypes\AbstractTable;
14			use Spiral\Database\Schemas\TableState;
15
16			class MySQLTable extends AbstractTable
17			{
18			/**
19			* List of most common MySQL table engines.
20			*/
21			const ENGINE_INNODB = 'InnoDB';
22			const ENGINE_MYISAM = 'MyISAM';
23			const ENGINE_MEMORY = 'Memory';
24
25			/**
26			* MySQL table engine.
27			*
28			* @var string
29			*/
30			private $engine = self::ENGINE_INNODB;
31
32			/**
33			* Populate table schema with values from database.
34			*
35			* @param TableState $state
36			*/
37			protected function initSchema(TableState $state)
38			{
39			parent::initSchema($state);
40
41			//Reading table schema
42			$this->engine = $this->driver->query('SHOW TABLE STATUS WHERE `Name` = ?', [
43			$state->getName()
44			])->fetch()['Engine'];
45			}
46
47			/**
48			* Change table engine. Such operation will be applied only at moment of table creation.
49			*
50			* @param string $engine
51			*
52			* @return $this
53			*
54			* @throws SchemaException
55			*/
56			public function setEngine($engine)
57			{
58			if ($this->exists()) {
59			throw new SchemaException('Table engine can be set only at moment of creation');
60			}
61
62			$this->engine = $engine;
63
64			return $this;
65			}
66
67			/**
68			* @return string
69			*/
70			public function getEngine()
71			{
72			return $this->engine;
73			}
74
75			/**
76			* {@inheritdoc}
77			*/
78			protected function fetchColumns(): array
79			{
80			$query = "SHOW FULL COLUMNS FROM {$this->driver->identifier($this->getName())}";
81
82			$result = [];
83			foreach ($this->driver->query($query) as $schema) {
84			$result[] = MySQLColumn::createInstance($this->getName(), $schema);
85			}
86
87			return $result;
88			}
89
90			/**
91			* {@inheritdoc}
92			*/
93			protected function fetchIndexes(): array
94			{
95			$query = "SHOW INDEXES FROM {$this->driver->identifier($this->getName())}";
96
97			//Gluing all index definitions together
98			$schemas = [];
99			foreach ($this->driver->query($query) as $index) {
100			if ($index['Key_name'] == 'PRIMARY') {
101			//Skipping PRIMARY index
102			continue;
103			}
104
105			$schemas[$index['Key_name']][] = $index;
106			}
107
108			$result = [];
109			foreach ($schemas as $name => $index) {
110			$result[] = MySQLIndex::createInstance($this->getName(), $name, $index);
111			}
112
113			return $result;
114			}
115
116			/**
117			* {@inheritdoc}
118			*/
119			protected function fetchReferences(): array
120			{
121			$references = $this->driver->query(
122			'SELECT * FROM `information_schema`.`referential_constraints` WHERE `constraint_schema` = ? AND `table_name` = ?',
123			[$this->driver->getSource(), $this->getName()]
124			);
125
126			$result = [];
127			foreach ($references as $schema) {
			0 ignored issues – show Bug introduced 2016-12-08 15:15 UTC by Report Bug Copy Issue Report The expression `$references` of type `object<Spiral\Database\E...Query\PDOResult>\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
128			$references = 'SELECT * FROM `information_schema`.`key_column_usage` WHERE `constraint_name` = ? AND `table_schema` = ? AND `table_name` = ?';
129
130			$column = $this->driver->query(
131			$references,
132			[$schema['CONSTRAINT_NAME'], $this->driver->getSource(), $this->getName()]
133			)->fetch();
134
135			$result[] = MySQLReference::createInstance(
136			$this->getName(),
137			$this->getPrefix(),
138			$schema + $column
139			);
140			}
141
142			return $result;
143			}
144
145			/**
146			* Fetching primary keys from table.
147			*
148			* @return array
149			*/
150			protected function fetchPrimaryKeys(): array
151			{
152			$query = "SHOW INDEXES FROM {$this->driver->identifier($this->getName())}";
153
154			$primaryKeys = [];
155			foreach ($this->driver->query($query) as $index) {
156			if ($index['Key_name'] == 'PRIMARY') {
157			$primaryKeys[] = $index['Column_name'];
158			}
159			}
160
161			return $primaryKeys;
162			}
163
164			/**
165			* {@inheritdoc}
166			*/
167			protected function createColumn(string $name): AbstractColumn
168			{
169			return new MySQLColumn($this->getName(), $name);
170			}
171
172			/**
173			* {@inheritdoc}
174			*/
175			protected function createIndex(string $name): AbstractIndex
176			{
177			return new MySQLIndex($this->getName(), $name);
178			}
179
180			/**
181			* {@inheritdoc}
182			*/
183			protected function createForeign(string $column): AbstractReference
184			{
185			return new MySQLReference($this->getName(), $this->getPrefix(), $column);
186			}
187			}

spiral / components

Branch — feature/pre-split (b5c37f)

MySQLTable::fetchColumns() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like