Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
24 | class LogViewerController extends Controller |
||
25 | { |
||
26 | use AuthorizesTrait, TranslatorTrait; |
||
27 | |||
28 | const GUARD_NAMESPACE = 'vault.logs'; |
||
29 | |||
30 | /** |
||
31 | * @param LogService $source |
||
32 | * @param Timestamps $timestamps |
||
33 | * @return string |
||
34 | */ |
||
35 | public function indexAction(LogService $source, Timestamps $timestamps) |
||
43 | |||
44 | /** |
||
45 | * @param LogService $source |
||
46 | * @param Timestamps $timestamps |
||
47 | * @return string |
||
48 | */ |
||
49 | public function viewAction(LogService $source, Timestamps $timestamps) |
||
62 | |||
63 | /** |
||
64 | * @param LogService $source |
||
65 | * @return array|\Psr\Http\Message\ResponseInterface |
||
66 | */ |
||
67 | public function removeAllAction(LogService $source) |
||
84 | |||
85 | /** |
||
86 | * @param LogService $source |
||
87 | * @param ServerRequestInterface $request |
||
88 | * @return array|\Psr\Http\Message\ResponseInterface |
||
89 | */ |
||
90 | public function removeAction(LogService $source, ServerRequestInterface $request) |
||
115 | |||
116 | /** |
||
117 | * Build redirect URI for removal operation. |
||
118 | * |
||
119 | * @param ServerRequestInterface $request |
||
120 | * @return \Psr\Http\Message\UriInterface |
||
121 | */ |
||
122 | protected function removeBackURI(ServerRequestInterface $request) |
||
133 | } |