UnarySorter::apply() - Code Metrics - Inspection of "Remove dead code" - spiral-modules/listing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c88373...f3b15c )

by Dmitry

created 2017-03-16 14:29 UTC

UnarySorter::apply() A

↳ Parent: UnarySorter

Complexity

Conditions	4
Paths	3

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.2
c	0
b	0
f	0
cc	4
eloc	10
nc	3
nop	1

<?php
/**
 * Spiral Framework.
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */
namespace Spiral\Listing\Sorters;

use Spiral\Database\Builders\SelectQuery;
use Spiral\Listing\Dependency;
use Spiral\Listing\Prototypes\DependedModificator;
use Spiral\Listing\SorterInterface;
use Spiral\Listing\Traits\SelectorValidationTrait;
use Spiral\ORM\Entities\RecordSelector;

/**
 * Simple sorter with ability to specify sorting fields/columns in array form. Compatible with
 * both ORM and ODM selectors.
 */
class UnarySorter extends DependedModificator implements SorterInterface
{
    use SelectorValidationTrait;

    /**
     * Expression in a form or [column => direction, ...]
     *
     * @var array
     */
    private $sortBy = [];

    /**
     * @param array            $sortBy
     * @param array|Dependency $dependencies
     */
    public function __construct(array $sortBy, $dependencies = [])
    {
        parent::__construct($dependencies);

        $this->sortBy = $sortBy;
    }

    /**
     * {@inheritdoc}
     */
    public function apply($selector)
    {
        $this->validateSelector($selector);

        if ($selector instanceof RecordSelector) {
            $selector = $this->loadDependencies($selector);

            foreach ($this->sortBy as $expression => $direction) {
                $selector = $selector->orderBy(
                    $expression,
                    $direction == self::ASC ? SelectQuery::SORT_ASC : SelectQuery::SORT_DESC
                );
            }

            return $selector;
        }

        return $selector->sortBy($this->sortBy);
    }
}


1			<?php
2			/**
3			* Spiral Framework.
4			*
5			* @license MIT
6			* @author Anton Titov (Wolfy-J)
7			*/
8			namespace Spiral\Listing\Sorters;
9
10			use Spiral\Database\Builders\SelectQuery;
11			use Spiral\Listing\Dependency;
12			use Spiral\Listing\Prototypes\DependedModificator;
13			use Spiral\Listing\SorterInterface;
14			use Spiral\Listing\Traits\SelectorValidationTrait;
15			use Spiral\ORM\Entities\RecordSelector;
16
17			/**
18			* Simple sorter with ability to specify sorting fields/columns in array form. Compatible with
19			* both ORM and ODM selectors.
20			*/
21			class UnarySorter extends DependedModificator implements SorterInterface
22			{
23			use SelectorValidationTrait;
24
25			/**
26			* Expression in a form or [column => direction, ...]
27			*
28			* @var array
29			*/
30			private $sortBy = [];
31
32			/**
33			* @param array $sortBy
34			* @param array\|Dependency $dependencies
35			*/
36			public function __construct(array $sortBy, $dependencies = [])
37			{
38			parent::__construct($dependencies);
			0 ignored issues – show Bug introduced 2017-03-14 16:58 UTC by Report Bug Copy Issue Report It seems like `$dependencies` defined by parameter `$dependencies` on line 36 can also be of type `array`; however, `Spiral\Listing\Prototype...ificator::__construct()` does only seem to accept `array<integer,object<Spi...ral\Listing\Dependency>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
39			$this->sortBy = $sortBy;
40			}
41
42			/**
43			* {@inheritdoc}
44			*/
45			public function apply($selector)
46			{
47			$this->validateSelector($selector);
48
49			if ($selector instanceof RecordSelector) {
50			$selector = $this->loadDependencies($selector);
51
52			foreach ($this->sortBy as $expression => $direction) {
53			$selector = $selector->orderBy(
54			$expression,
55			$direction == self::ASC ? SelectQuery::SORT_ASC : SelectQuery::SORT_DESC
56			);
57			}
58
59			return $selector;
60			}
61
62			return $selector->sortBy($this->sortBy);
63			}
64			}
65

spiral-modules / listing

Push — master ( c88373...f3b15c )

UnarySorter::apply() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like