Inspection of "[Salvatore] [source:ecrire/lang/ ecrire] Export de..." - spip/SPIP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c76770...babdec )

by cam

created 2023-02-28 00:27 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -57,8 +57,8 @@  discard block
 block discarded – undo
 			$namespace[null] = null;
 		}
 
-		$name = strtolower((string)$obj->getName());
-		$text = trim((string)$obj);
+		$name = strtolower((string) $obj->getName());
+		$text = trim((string) $obj);
 		if (strlen($text) <= 0) {
 			$text = null;
 		}
@@ -71,10 +71,10 @@  discard block
 block discarded – undo
 			// attributes
 			$objAttributes = $obj->attributes($ns, true);
 			foreach ($objAttributes as $attributeName => $attributeValue) {
-				$attribName = strtolower(trim((string)$attributeName));
-				$attribVal = trim((string)$attributeValue);
+				$attribName = strtolower(trim((string) $attributeName));
+				$attribVal = trim((string) $attributeValue);
 				if (!empty($ns)) {
-					$attribName = $ns . ':' . $attribName;
+					$attribName = $ns.':'.$attribName;
 				}
 				$attributes[$attribName] = $attribVal;
 			}
@@ -82,9 +82,9 @@  discard block
 block discarded – undo
 			// children
 			$objChildren = $obj->children($ns, true);
 			foreach ($objChildren as $childName => $child) {
-				$childName = strtolower((string)$childName);
+				$childName = strtolower((string) $childName);
 				if (!empty($ns)) {
-					$childName = $ns . ':' . $childName;
+					$childName = $ns.':'.$childName;
 				}
 				$children[$childName][] = xmlObjToArr($child, $namespace);
 			}

Please login to merge, or discard this patch.

ecrire/inc/actions.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -78,7 +78,7 @@  discard block
 block discarded – undo
  *     Code HTML du formulaire
  */
 function redirige_action_auteur($action, $arg, $ret, $gra = '', $mode = false, $atts = '', $public = false) {
-	$r = ($public ? _DIR_RESTREINT_ABS : _DIR_RESTREINT) . generer_url_ecrire($ret, $gra, true, true);
+	$r = ($public ? _DIR_RESTREINT_ABS : _DIR_RESTREINT).generer_url_ecrire($ret, $gra, true, true);
 
 	return generer_action_auteur($action, $arg, $r, $mode, $atts, $public);
 }
@@ -105,9 +105,9 @@  discard block
 block discarded – undo
  *     URL, code HTML du formulaire ou tableau (action, arg, hash)
  */
 function redirige_action_post($action, $arg, $ret, $gra, $corps, $att = '') {
-	$r = _DIR_RESTREINT . generer_url_ecrire($ret, $gra, false, true);
+	$r = _DIR_RESTREINT.generer_url_ecrire($ret, $gra, false, true);
 
-	return generer_action_auteur($action, $arg, $r, $corps, $att . " method='post'");
+	return generer_action_auteur($action, $arg, $r, $corps, $att." method='post'");
 }
 
 
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
 	}
 
 	$c = $GLOBALS['meta']['charset'];
-	header('Content-Type: ' . $content_type . '; charset=' . $c);
-	$debut = (($xml and strlen(trim($corps))) ? '<' . "?xml version='1.0' encoding='" . $c . "'?" . ">\n" : '');
+	header('Content-Type: '.$content_type.'; charset='.$c);
+	$debut = (($xml and strlen(trim($corps))) ? '<'."?xml version='1.0' encoding='".$c."'?".">\n" : '');
 	$fin = '';
 
 	echo $debut, $corps, $fin, $e;

Please login to merge, or discard this patch.

ecrire/prive.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -26,7 +26,7 @@
 block discarded – undo
 		// On reexecute pour deboucher sur le include public.
 		// autrement on insiste
 		if (is_array($var_auth)) {
-			$var_auth = '../?' . $_SERVER['QUERY_STRING'];
+			$var_auth = '../?'.$_SERVER['QUERY_STRING'];
 			spip_setcookie('spip_session', $_COOKIE['spip_session'], [
 				'expires' => time() + 3600 * 24 * 14
 			]);

Please login to merge, or discard this patch.

prive/formulaires/configurer_preferences.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@
 block discarded – undo
 	$les_couleurs = $couleurs();
 	foreach ($les_couleurs as $k => $c) {
 		$valeurs['_couleurs_url'][$k] = generer_url_public('style_prive.css', 'ltr='
-			. $GLOBALS['spip_lang_left'] . '&'
+			. $GLOBALS['spip_lang_left'].'&'
 			. $couleurs($k));
 		$valeurs['couleurs'][$k] = $c;
 	}

Please login to merge, or discard this patch.

ecrire/inc/filtres_boites.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -135,7 +135,7 @@
		block discarded – undo
135	135	$titre = "<h3>$titre</h3>";
136	136	}
137	137
138		- return '<div class="' . $class . ($id ? "\" id=\"$id" : '') . '">'
	138	+ return '<div class="'.$class.($id ? "\" id=\"$id" : '').'">'
139	139	. ($titre ? "<div class=\"$head_class\">$titre<!--/hd--></div>" : '')
140	140	. '<div class="box__body clearfix">';
141	141	}

Please login to merge, or discard this patch.

prive/themes/spip/vars.css_fonctions.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -49,8 +49,8 @@ discard block
		block discarded – undo
49	49
50	50	// Espacements pour le rythme vertical et les gouttières
51	51	// Basés sur la hauteur d'une ligne de texte à la racine du document
52		- $vars->add('--spip-spacing-y', round(strmult($Pile[0]['font-size'], $Pile[0]['line-height']), 4) . 'rem');
53		- $vars->add('--spip-spacing-x', round(strmult($Pile[0]['font-size'], $Pile[0]['line-height']), 4) . 'rem');
	52	+ $vars->add('--spip-spacing-y', round(strmult($Pile[0]['font-size'], $Pile[0]['line-height']), 4).'rem');
	53	+ $vars->add('--spip-spacing-x', round(strmult($Pile[0]['font-size'], $Pile[0]['line-height']), 4).'rem');
54	54	$vars->add('--spip-margin-bottom', $Pile[0]['margin-bottom']); // À déprécier
55	55
56	56	// Bordures
		@@ -60,20 +60,20 @@ discard block
		block discarded – undo
60	60
61	61	// Ombres portées
62	62	$shadow_mini =
63		- '0 0.05em 0.1em hsla(0, 0%, 0%, 0.33),' .
64		- '0 0.1em 0.15em hsla(0, 0%, 0%, 0.05),' .
	63	+ '0 0.05em 0.1em hsla(0, 0%, 0%, 0.33),'.
	64	+ '0 0.1em 0.15em hsla(0, 0%, 0%, 0.05),'.
65	65	'0 0.1em 0.25em hsla(0, 0%, 0%, 0.05)';
66	66	$shadow =
67		- '0 0.05em 0.15em hsla(0, 0%, 0%, 0.33),' .
68		- '0 0.1em 0.25em hsla(0, 0%, 0%, 0.05),' .
	67	+ '0 0.05em 0.15em hsla(0, 0%, 0%, 0.33),'.
	68	+ '0 0.1em 0.25em hsla(0, 0%, 0%, 0.05),'.
69	69	'0 0.1em 0.5em hsla(0, 0%, 0%, 0.05)';
70	70	$shadow_large =
71		- '0 0.05em 0.15em hsla(0, 0%, 0%, 0.1),' .
72		- '0 0.2em 0.5em hsla(0, 0%, 0%, 0.1),' .
	71	+ '0 0.05em 0.15em hsla(0, 0%, 0%, 0.1),'.
	72	+ '0 0.2em 0.5em hsla(0, 0%, 0%, 0.1),'.
73	73	'0 0.2em 1em hsla(0, 0%, 0%, 0.075)';
74	74	$shadow_huge =
75		- '0 0.1em 0.25em hsla(0, 0%, 0%, 0.1),' .
76		- '0 0.25em 1em hsla(0, 0%, 0%, 0.1),' .
	75	+ '0 0.1em 0.25em hsla(0, 0%, 0%, 0.1),'.
	76	+ '0 0.25em 1em hsla(0, 0%, 0%, 0.1),'.
77	77	'0 0.5em 2em hsla(0, 0%, 0%, 0.075)';
78	78	$vars->add('--spip-box-shadow-mini', $shadow_mini);
79	79	$vars->add('--spip-box-shadow-mini-hover', $shadow);

Please login to merge, or discard this patch.

prive/objets/liste/objets-trad_fonctions.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -19,12 +19,12 @@
 block discarded – undo
 	$primary = id_table_objet($objet);
 
 	$select = "$primary as id,lang";
-	$where = 'id_trad=' . intval($id_trad);
+	$where = 'id_trad='.intval($id_trad);
 	$trouver_table = charger_fonction('trouver_table', 'base');
 	$desc = $trouver_table($table_objet_sql);
 	if (isset($desc['field']['statut'])) {
 		$select .= ',statut';
-		$where .= ' AND statut!=' . sql_quote('poubelle');
+		$where .= ' AND statut!='.sql_quote('poubelle');
 	}
 
 	$rows = sql_allfetsel($select, $table_objet_sql, $where);

Please login to merge, or discard this patch.

prive/formulaires/configurer_ecran_connexion.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@
 block discarded – undo
 function formulaires_configurer_ecran_connexion_data(): array {
 	return [
 		'couleur_defaut' => '#db1762',
-		'img_fond' => _DIR_IMG . 'spip_fond_login.jpg',
+		'img_fond' => _DIR_IMG.'spip_fond_login.jpg',
 	];
 }
 

Please login to merge, or discard this patch.

prive/formulaires/configurer_langue.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@
 block discarded – undo
 	foreach ($langues as $l) {
 		$res .= "<option value='$l'"
 			. ($l == $l_site ? " selected='selected'" : '')
-			. '>' . traduire_nom_langue($l) . "</option>\n";
+			. '>'.traduire_nom_langue($l)."</option>\n";
 	}
 
 	$valeurs = [

Please login to merge, or discard this patch.

		@@ -57,8 +57,8 @@ discard block
		block discarded – undo
57	57	$namespace[null] = null;
58	58	}
59	59
60		- $name = strtolower((string)$obj->getName());
61		- $text = trim((string)$obj);
	60	+ $name = strtolower((string) $obj->getName());
	61	+ $text = trim((string) $obj);
62	62	if (strlen($text) <= 0) {
63	63	$text = null;
64	64	}
		@@ -71,10 +71,10 @@ discard block
		block discarded – undo
71	71	// attributes
72	72	$objAttributes = $obj->attributes($ns, true);
73	73	foreach ($objAttributes as $attributeName => $attributeValue) {
74		- $attribName = strtolower(trim((string)$attributeName));
75		- $attribVal = trim((string)$attributeValue);
	74	+ $attribName = strtolower(trim((string) $attributeName));
	75	+ $attribVal = trim((string) $attributeValue);
76	76	if (!empty($ns)) {
77		- $attribName = $ns . ':' . $attribName;
	77	+ $attribName = $ns.':'.$attribName;
78	78	}
79	79	$attributes[$attribName] = $attribVal;
80	80	}
		@@ -82,9 +82,9 @@ discard block
		block discarded – undo
82	82	// children
83	83	$objChildren = $obj->children($ns, true);
84	84	foreach ($objChildren as $childName => $child) {
85		- $childName = strtolower((string)$childName);
	85	+ $childName = strtolower((string) $childName);
86	86	if (!empty($ns)) {
87		- $childName = $ns . ':' . $childName;
	87	+ $childName = $ns.':'.$childName;
88	88	}
89	89	$children[$childName][] = xmlObjToArr($child, $namespace);
90	90	}

		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78	* Code HTML du formulaire
79	79	*/
80	80	function redirige_action_auteur($action, $arg, $ret, $gra = '', $mode = false, $atts = '', $public = false) {
81		- $r = ($public ? _DIR_RESTREINT_ABS : _DIR_RESTREINT) . generer_url_ecrire($ret, $gra, true, true);
	81	+ $r = ($public ? _DIR_RESTREINT_ABS : _DIR_RESTREINT).generer_url_ecrire($ret, $gra, true, true);
82	82
83	83	return generer_action_auteur($action, $arg, $r, $mode, $atts, $public);
84	84	}
		@@ -105,9 +105,9 @@ discard block
		block discarded – undo
105	105	* URL, code HTML du formulaire ou tableau (action, arg, hash)
106	106	*/
107	107	function redirige_action_post($action, $arg, $ret, $gra, $corps, $att = '') {
108		- $r = _DIR_RESTREINT . generer_url_ecrire($ret, $gra, false, true);
	108	+ $r = _DIR_RESTREINT.generer_url_ecrire($ret, $gra, false, true);
109	109
110		- return generer_action_auteur($action, $arg, $r, $corps, $att . " method='post'");
	110	+ return generer_action_auteur($action, $arg, $r, $corps, $att." method='post'");
111	111	}
112	112
113	113
		@@ -138,8 +138,8 @@ discard block
		block discarded – undo
138	138	}
139	139
140	140	$c = $GLOBALS['meta']['charset'];
141		- header('Content-Type: ' . $content_type . '; charset=' . $c);
142		- $debut = (($xml and strlen(trim($corps))) ? '<' . "?xml version='1.0' encoding='" . $c . "'?" . ">\n" : '');
	141	+ header('Content-Type: '.$content_type.'; charset='.$c);
	142	+ $debut = (($xml and strlen(trim($corps))) ? '<'."?xml version='1.0' encoding='".$c."'?".">\n" : '');
143	143	$fin = '';
144	144
145	145	echo $debut, $corps, $fin, $e;

		@@ -26,7 +26,7 @@
		block discarded – undo
26	26	// On reexecute pour deboucher sur le include public.
27	27	// autrement on insiste
28	28	if (is_array($var_auth)) {
29		- $var_auth = '../?' . $_SERVER['QUERY_STRING'];
	29	+ $var_auth = '../?'.$_SERVER['QUERY_STRING'];
30	30	spip_setcookie('spip_session', $_COOKIE['spip_session'], [
31	31	'expires' => time() + 3600 * 24 * 14
32	32	]);

		@@ -45,7 +45,7 @@
		block discarded – undo
45	45	$les_couleurs = $couleurs();
46	46	foreach ($les_couleurs as $k => $c) {
47	47	$valeurs['_couleurs_url'][$k] = generer_url_public('style_prive.css', 'ltr='
48		- . $GLOBALS['spip_lang_left'] . '&'
	48	+ . $GLOBALS['spip_lang_left'].'&'
49	49	. $couleurs($k));
50	50	$valeurs['couleurs'][$k] = $c;
51	51	}

		@@ -19,12 +19,12 @@
		block discarded – undo
19	19	$primary = id_table_objet($objet);
20	20
21	21	$select = "$primary as id,lang";
22		- $where = 'id_trad=' . intval($id_trad);
	22	+ $where = 'id_trad='.intval($id_trad);
23	23	$trouver_table = charger_fonction('trouver_table', 'base');
24	24	$desc = $trouver_table($table_objet_sql);
25	25	if (isset($desc['field']['statut'])) {
26	26	$select .= ',statut';
27		- $where .= ' AND statut!=' . sql_quote('poubelle');
	27	+ $where .= ' AND statut!='.sql_quote('poubelle');
28	28	}
29	29
30	30	$rows = sql_allfetsel($select, $table_objet_sql, $where);

		@@ -3,7 +3,7 @@
		block discarded – undo
3	3	function formulaires_configurer_ecran_connexion_data(): array {
4	4	return [
5	5	'couleur_defaut' => '#db1762',
6		- 'img_fond' => _DIR_IMG . 'spip_fond_login.jpg',
	6	+ 'img_fond' => _DIR_IMG.'spip_fond_login.jpg',
7	7	];
8	8	}
9	9

		@@ -31,7 +31,7 @@
		block discarded – undo
31	31	foreach ($langues as $l) {
32	32	$res .= "<option value='$l'"
33	33	. ($l == $l_site ? " selected='selected'" : '')
34		- . '>' . traduire_nom_langue($l) . "</option>\n";
	34	+ . '>'.traduire_nom_langue($l)."</option>\n";
35	35	}
36	36
37	37	$valeurs = [

spip / SPIP

Push — master ( c76770...babdec )

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch