afficher_plugin.php ➔ plugin_resume() - Code Metrics - Inspection of "Icone 'plugin' en svg + variantes + petits fix css..." - spip/SPIP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6f1482...4c57e4 )

by cam

created 2020-11-09 15:33 UTC

afficher_plugin.php ➔ plugin_resume() B

↳ Parent: Project

Complexity

Conditions	6
Paths	12

Size

Total Lines

Duplication

Lines	2
Ratio	4.65 %

Importance

Changes

Metric	Value
cc	6
nc	12
nop	4
dl	2
loc	43
rs	8.6097
c	0
b	0
f	0

<?php

/***************************************************************************\
 *  SPIP, Système de publication pour l'internet                           *
 *                                                                         *
 *  Copyright © avec tendresse depuis 2001                                 *
 *  Arnaud Martin, Antoine Pitrou, Philippe Rivière, Emmanuel Saint-James  *
 *                                                                         *
 *  Ce programme est un logiciel libre distribué sous licence GNU/GPL.     *
 *  Pour plus de détails voir le fichier COPYING.txt ou l'aide en ligne.   *
\***************************************************************************/

/**
 * Fonctions pour l'affichage des informations de plugins
 *
 * @package SPIP\Core\Plugins
 **/

if (!defined('_ECRIRE_INC_VERSION')) {
	return;
}
include_spip('inc/charsets');
include_spip('inc/texte');
include_spip('inc/plugin'); // pour plugin_est_installe

// https://code.spip.net/@ligne_plug
function plugins_afficher_plugin_dist(
	$url_page,
	$plug_file,
	$checked,
	$actif,
	$expose = false,
	$class_li = "item",
	$dir_plugins = _DIR_PLUGINS
) {

	static $id_input = 0;
	static $versions = array();

	$force_reload = (_request('var_mode') == 'recalcul');
	$get_infos = charger_fonction('get_infos', 'plugins');
	$info = $get_infos($plug_file, $force_reload, $dir_plugins);
	$prefix = $info['prefix'];
	$cfg = "";
	$checkable = ($dir_plugins !== _DIR_PLUGINS_DIST);
	$nom = plugin_nom($info, $dir_plugins, $plug_file);
	$erreur = "";

	if (!plugin_version_compatible($info['compatibilite'], $GLOBALS['spip_version_branche'], 'spip')) {
		$info['slogan'] = _T('plugin_info_non_compatible_spip');
		$erreur = http_img_pack("plugin-dis-32.png", _T('plugin_info_non_compatible_spip'), " class='picto_err'",
			_T('plugin_info_non_compatible_spip'));
		$class_li .= " disabled";
		$checkable = false;
	} elseif (isset($info['erreur'])) {
		$class_li .= " error";
		$erreur = http_img_pack("plugin-err-32.png", _T('plugin_info_erreur_xml'), " class='picto_err'",
				_T('plugin_info_erreur_xml'))
			. "<div class='erreur'>" . join('<br >', $info['erreur']) . "</div>";
		$checkable = false;
	} elseif (isset($GLOBALS['erreurs_activation_raw'][$dir_plugins . $plug_file])) {
		$class_li .= " error";
		$erreur = http_img_pack("plugin-err-32.png", _T('plugin_impossible_activer', array('plugin' => $nom)),
				" class='picto_err'", _T('plugin_impossible_activer', array('plugin' => $nom)))
			. "<div class='erreur'>" . implode("<br />",
				$GLOBALS['erreurs_activation_raw'][$dir_plugins . $plug_file]) . "</div>";
	} else {
		$cfg = $actif ? plugin_bouton_config($plug_file, $info, $dir_plugins) : "";
	}

	// numerotons les occurrences d'un meme prefix
	$versions[$prefix] = $id = isset($versions[$prefix]) ? intval($versions[$prefix]) + 1 : '';

	$class_li .= ($actif ? " actif" : "") . ($expose ? " on" : "");

	return "<li id='$prefix$id' class='$class_li'>"
	. ((!$checkable and !$checked)
		? '' : plugin_checkbox(++$id_input, $dir_plugins . $plug_file, $checked))
	. plugin_resume($info, $dir_plugins, $plug_file, $url_page)
	. $cfg
	. $erreur
	. (($dir_plugins !== _DIR_PLUGINS_DIST and plugin_est_installe($plug_file))
		? plugin_desintalle($plug_file, $nom, $dir_plugins) : '')
	. "<div class='details'>" // pour l'ajax de exec/info_plugin
	. (!$expose ? '' : affiche_bloc_plugin($plug_file, $info, $dir_plugins))
	. "</div>"
	. "</li>";
}

function plugin_bouton_config($nom, $infos, $dir) {
	// la verification se base sur le filesystem
	// il faut donc n'utiliser que des minuscules, par convention
	$prefix = strtolower($infos['prefix']);
	// si paquet.xml fournit un squelette, le prendre
	if (isset($infos['config']) and $infos['config']) {
		return recuperer_fond("$dir$nom/" . $infos['config'],
			array(
				'script' => 'configurer_' . $prefix,
				'nom' => $nom
			));
	}

	// si le plugin CFG est la, l'essayer
	if (defined('_DIR_PLUGIN_CFG')) {
		if (include_spip('inc/cfg')) // test CFG version >= 1.0.5
		{
			if ($cfg = icone_lien_cfg("$dir$nom", "cfg")) {
				return "<div class='cfg_link'>$cfg</div>";
			}
		}
	}

	// sinon prendre le squelette std sur le nom std
	return recuperer_fond("prive/squelettes/inclure/cfg",
		array(
			'script' => 'configurer_' . $prefix,
			'nom' => $nom
		));
}

// checkbox pour activer ou desactiver
// si ce n'est pas une extension

function plugin_checkbox($id_input, $file, $actif) {
	$name = substr(md5($file), 0, 16);

	return "<div class='check'>\n"
	. "<input type='checkbox' name='s$name' id='label_$id_input'"
	. ($actif ? " checked='checked'" : "")
	. " class='checkbox'  value='O' />"
	. "\n<label for='label_$id_input'>" . _T('activer_plugin') . "</label>"
	. "</div>";
}

function plugin_nom($info, $dir_plugins, $plug_file) {
	$prefix = $info['prefix'];
	$dir = "$dir_plugins$plug_file";
	// Si dtd paquet, on traite le nom soit par son item de langue soit par sa valeur immediate a l'index "nom"
	if ($info['dtd'] == "paquet") {
		$nom = plugin_typo("{$prefix}_nom", "$dir/lang/paquet-$prefix");
		if (!$nom) {
			$nom = typo($info['nom']);
		}
	} else {
		$nom = typo(attribut_html($info['nom']));
	}

	return trim($nom);
}

// Cartouche Resume
function plugin_resume($info, $dir_plugins, $plug_file, $url_page) {
	$prefix = $info['prefix'];
	$dir = "$dir_plugins$plug_file";
	$slogan = PtoBR(plugin_propre($info['slogan'], "$dir/lang/paquet-$prefix"));
	// une seule ligne dans le slogan : couper si besoin
	if (($p = strpos($slogan, "<br />")) !== false) {

		$slogan = substr($slogan, 0, $p);
	}
	// couper par securite
	$slogan = couper($slogan, 80);

	$nom = plugin_nom($info, $dir_plugins, $plug_file);

	$url = parametre_url($url_page, "plugin", substr($dir, strlen(_DIR_RACINE)));

	$icon_class = 'icon';
	$img = '';
	if (isset($info['logo']) and $i = trim($info['logo'])) {
		if ($img = chemin_image("$dir/$i")) {
			$img = http_img_pack($img, '', " width='32' height='32'", '', ['variante_svg_si_possible' => true, 'chemin_image' => false]);
		}
	}
	if (!$img) {
		$img = http_img_pack("plugin-xx.svg", '', " width='32' height='32'");
		$icon_class .= ' no-logo';
	}
	else {
#		$img = "<img src='$img' width='32' height='32' alt='' />";
	}
	$i = "<div class='$icon_class'><a href='$url' rel='info'>$img</a></div>";

	return "<div class='resume'>"
	. "<h3><a href='$url' rel='info'>"
	. $nom
	. "</a></h3>"
	. " <span class='version'>" . $info['version'] . "</span>"
	. " <span class='etat'> - "
	. plugin_etat_en_clair($info['etat'])
	. "</span>"
	. "<div class='short'>" . $slogan . "</div>"
	. $i
	. "</div>";
}

function plugin_desintalle($plug_file, $nom, $dir_plugins = null) {
	if (!$dir_plugins) {
		$dir_plugins = _DIR_PLUGINS;
	}

	$action = redirige_action_auteur('desinstaller_plugin', "$dir_plugins::$plug_file", 'admin_plugin');
	$text = _T('bouton_desinstaller');
	$text2 = _T('info_desinstaller_plugin');
	$file = basename($plug_file);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

	return "<div class='actions'>[" .
	"<a href='$action'
		onclick='return confirm(\"$text $nom ?\\n$text2\")'>"
	. $text
	. "</a>]</div>";
}

/**
 * Traduit un type d'état de plugin
 *
 * Si l'état n'existe pas, prendra par défaut 'developpement'
 *
 * @param string $etat
 *     Le type d'état (stable, test, ...)
 * @return string
 *     Traduction de l'état dans la langue en cours
 **/
function plugin_etat_en_clair($etat) {
	if (!in_array($etat, array('stable', 'test', 'experimental'))) {
		$etat = 'developpement';
	}

	return _T('plugin_etat_' . $etat);
}

// https://code.spip.net/@plugin_propre
function plugin_propre($texte, $module = '',$propre='propre') {
	// retirer le retour a la racine du module, car le find_in_path se fait depuis la racine
	if (_DIR_RACINE and strncmp($module, _DIR_RACINE, strlen(_DIR_RACINE)) == 0) {

		$module = substr($module, strlen(_DIR_RACINE));
	}
	if (preg_match("|^\w+_[\w_]+$|", $texte)) {
		$texte = _T(($module ? "$module:" : '') . $texte, array(), array('force' => false));
	}

	return $propre($texte);
}

function plugin_typo($texte, $module = '') {
	return plugin_propre($texte, $module, 'typo');
}


// https://code.spip.net/@affiche_bloc_plugin
function affiche_bloc_plugin($plug_file, $info, $dir_plugins = null) {
	if (!$dir_plugins) {
		$dir_plugins = _DIR_PLUGINS;
	}

	$prefix = $info['prefix'];
	$dir = "$dir_plugins$plug_file/lang/paquet-$prefix";

	$s = "";
	// TODO: le traiter_multi ici n'est pas beau
	// cf. description du plugin/_stable_/ortho/plugin.xml
	// concerne les anciens plugin.xml donc on devrait plus en avoir besoin
	$description = "";
	if (isset($info['description'])) {
		$description = plugin_propre($info['description'], $dir);
	}

	if (isset($info['documentation'])
		and $lien = $info['documentation']
	) {
		$description .= "<p><em class='site'><a href='$lien' class='spip_out'>" . _T('en_savoir_plus') . '</a></em></p>';
	}
	$s .= "<dd class='desc'>" . $description . "</dd>\n";

	if (isset($info['auteur'])) {

		if (is_array($info['auteur'])) {
			$a = formater_credits($info['auteur'], ', ');
		} // pour compat mais ne doit plus arriver
		else {
			$a = trim($info['auteur']);
		}
		if ($a) {
			$s .= "<dt class='auteurs'>" . _T('public:par_auteur') . "</dt><dd class='auteurs'>" . PtoBR(propre($a,
					$dir)) . "</dd>\n";
		}
	}

	if (isset($info['credit'])) {
		if ($a = formater_credits($info['credit'], ', ')) {
			$s .= "<dt class='credits'>" . _T('plugin_info_credit') . "</dt><dd class='credits'>" . PtoBR(propre($a,
					$dir)) . "</dd>\n";
		}
	}

	if (isset($info['licence'])) {

		if (is_array($info['licence'])) {
			$a = formater_credits($info['licence'], ', ');
		} // pour compat mais ne doit plus arriver
		else {
			$a = trim($info['licence']);
		}
		if ($a) {
			$s .= "<dt class='licence'>" . _T('intitule_licence') . "</dt><dd class='licence'>" . PtoBR(propre($a,
					$dir)) . "</dd>\n";
		}
	}

	$s = "<dl class='description'>$s</dl>";

	//
	// Ajouter les infos techniques
	//
	$infotech = array();

	$version = "<dt>" . _T('version') . "</dt><dd>" . $info['version'];
	// Version VCS
	if ($vcs = version_vcs_courante($dir_plugins . $plug_file)) {
		$version .= ' ' . $vcs;
	}
	$version .= "</dd>";
	$infotech[] = $version;
	$infotech[] = "<dt>" . _T('repertoire_plugins') . "</dt><dd>" . joli_repertoire("$dir_plugins$plug_file") . "</dd>";
	// source zip le cas echeant
	$infotech[] = (lire_fichier($dir_plugins . $plug_file . '/install.log', $log)
		and preg_match(',^source:(.*)$,m', $log, $r))
		? '<dt>' . _T('plugin_source') . '</dt><dd>' . trim($r[1]) . "</dd>"
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		: '';

	$infotech[] = !$info['necessite'] ? '' :
		('<dt>' . _T('plugin_info_necessite') . '</dt><dd>' . join(' ',
				array_map('array_shift', $info['necessite'])) . '</dd>');

	$s .= "<dl class='tech'>"
		. join('', $infotech)
		. "</dl>";


	return $s;
}

function formater_credits($infos, $sep = ', ') {
	$texte = '';

	foreach ($infos as $_credit) {
		if ($texte) {
			$texte .= $sep;
		}
		// Si le credit en cours n'est pas un array c'est donc un copyright
		$texte .=
			(!is_array($_credit))
				? PtoBR(propre($_credit))
				: ($_credit['url'] ? '<a href="' . $_credit['url'] . '">' : '') .
				$_credit['nom'] .
				($_credit['url'] ? '</a>' : '');
	}

	return $texte;
}


1		<?php
2
3		/***************************************************************************\
4		* SPIP, Système de publication pour l'internet *
5		* *
6		* Copyright © avec tendresse depuis 2001 *
7		* Arnaud Martin, Antoine Pitrou, Philippe Rivière, Emmanuel Saint-James *
8		* *
9		* Ce programme est un logiciel libre distribué sous licence GNU/GPL. *
10		* Pour plus de détails voir le fichier COPYING.txt ou l'aide en ligne. *
11		\***************************************************************************/
12
13		/**
14		* Fonctions pour l'affichage des informations de plugins
15		*
16		* @package SPIP\Core\Plugins
17		**/
18
19		if (!defined('_ECRIRE_INC_VERSION')) {
20		return;
21		}
22		include_spip('inc/charsets');
23		include_spip('inc/texte');
24		include_spip('inc/plugin'); // pour plugin_est_installe
25
26		// https://code.spip.net/@ligne_plug
27		function plugins_afficher_plugin_dist(
28		$url_page,
29		$plug_file,
30		$checked,
31		$actif,
32		$expose = false,
33		$class_li = "item",
34		$dir_plugins = _DIR_PLUGINS
35		) {
36
37		static $id_input = 0;
38		static $versions = array();
39
40		$force_reload = (_request('var_mode') == 'recalcul');
41		$get_infos = charger_fonction('get_infos', 'plugins');
42		$info = $get_infos($plug_file, $force_reload, $dir_plugins);
43		$prefix = $info['prefix'];
44		$cfg = "";
45		$checkable = ($dir_plugins !== _DIR_PLUGINS_DIST);
46		$nom = plugin_nom($info, $dir_plugins, $plug_file);
47		$erreur = "";
48
49		if (!plugin_version_compatible($info['compatibilite'], $GLOBALS['spip_version_branche'], 'spip')) {
50		$info['slogan'] = _T('plugin_info_non_compatible_spip');
51		$erreur = http_img_pack("plugin-dis-32.png", _T('plugin_info_non_compatible_spip'), " class='picto_err'",
52		_T('plugin_info_non_compatible_spip'));
53		$class_li .= " disabled";
54		$checkable = false;
55		} elseif (isset($info['erreur'])) {
56		$class_li .= " error";
57		$erreur = http_img_pack("plugin-err-32.png", _T('plugin_info_erreur_xml'), " class='picto_err'",
58		_T('plugin_info_erreur_xml'))
59		. "<div class='erreur'>" . join('<br >', $info['erreur']) . "</div>";
60		$checkable = false;
61		} elseif (isset($GLOBALS['erreurs_activation_raw'][$dir_plugins . $plug_file])) {
62		$class_li .= " error";
63		$erreur = http_img_pack("plugin-err-32.png", _T('plugin_impossible_activer', array('plugin' => $nom)),
64		" class='picto_err'", _T('plugin_impossible_activer', array('plugin' => $nom)))
65		. "<div class='erreur'>" . implode("<br />",
66		$GLOBALS['erreurs_activation_raw'][$dir_plugins . $plug_file]) . "</div>";
67		} else {
68		$cfg = $actif ? plugin_bouton_config($plug_file, $info, $dir_plugins) : "";
69		}
70
71		// numerotons les occurrences d'un meme prefix
72		$versions[$prefix] = $id = isset($versions[$prefix]) ? intval($versions[$prefix]) + 1 : '';
73
74		$class_li .= ($actif ? " actif" : "") . ($expose ? " on" : "");
75
76		return "<li id='$prefix$id' class='$class_li'>"
77		. ((!$checkable and !$checked)
78		? '' : plugin_checkbox(++$id_input, $dir_plugins . $plug_file, $checked))
79		. plugin_resume($info, $dir_plugins, $plug_file, $url_page)
80		. $cfg
81		. $erreur
82		. (($dir_plugins !== _DIR_PLUGINS_DIST and plugin_est_installe($plug_file))
83		? plugin_desintalle($plug_file, $nom, $dir_plugins) : '')
84		. "<div class='details'>" // pour l'ajax de exec/info_plugin
85		. (!$expose ? '' : affiche_bloc_plugin($plug_file, $info, $dir_plugins))
86		. "</div>"
87		. "</li>";
88		}
89
90		function plugin_bouton_config($nom, $infos, $dir) {
91		// la verification se base sur le filesystem
92		// il faut donc n'utiliser que des minuscules, par convention
93		$prefix = strtolower($infos['prefix']);
94		// si paquet.xml fournit un squelette, le prendre
95		if (isset($infos['config']) and $infos['config']) {
96		return recuperer_fond("$dir$nom/" . $infos['config'],
97		array(
98		'script' => 'configurer_' . $prefix,
99		'nom' => $nom
100		));
101		}
102
103		// si le plugin CFG est la, l'essayer
104		if (defined('_DIR_PLUGIN_CFG')) {
105		if (include_spip('inc/cfg')) // test CFG version >= 1.0.5
106		{
107		if ($cfg = icone_lien_cfg("$dir$nom", "cfg")) {
108		return "<div class='cfg_link'>$cfg</div>";
109		}
110		}
111		}
112
113		// sinon prendre le squelette std sur le nom std
114		return recuperer_fond("prive/squelettes/inclure/cfg",
115		array(
116		'script' => 'configurer_' . $prefix,
117		'nom' => $nom
118		));
119		}
120
121		// checkbox pour activer ou desactiver
122		// si ce n'est pas une extension
123
124		function plugin_checkbox($id_input, $file, $actif) {
125		$name = substr(md5($file), 0, 16);
126
127		return "<div class='check'>\n"
128		. "<input type='checkbox' name='s$name' id='label_$id_input'"
129		. ($actif ? " checked='checked'" : "")
130		. " class='checkbox' value='O' />"
131		. "\n<label for='label_$id_input'>" . _T('activer_plugin') . "</label>"
132		. "</div>";
133		}
134
135		function plugin_nom($info, $dir_plugins, $plug_file) {
136		$prefix = $info['prefix'];
137		$dir = "$dir_plugins$plug_file";
138		// Si dtd paquet, on traite le nom soit par son item de langue soit par sa valeur immediate a l'index "nom"
139		if ($info['dtd'] == "paquet") {
140		$nom = plugin_typo("{$prefix}_nom", "$dir/lang/paquet-$prefix");
141		if (!$nom) {
142		$nom = typo($info['nom']);
143		}
144		} else {
145		$nom = typo(attribut_html($info['nom']));
146		}
147
148		return trim($nom);
149		}
150
151		// Cartouche Resume
152		function plugin_resume($info, $dir_plugins, $plug_file, $url_page) {
153		$prefix = $info['prefix'];
154		$dir = "$dir_plugins$plug_file";
155		$slogan = PtoBR(plugin_propre($info['slogan'], "$dir/lang/paquet-$prefix"));
156		// une seule ligne dans le slogan : couper si besoin
157	View Code Duplication	if (($p = strpos($slogan, "<br />")) !== false) {
		0 ignored issues – show Duplication introduced 2016-04-05 13:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
158		$slogan = substr($slogan, 0, $p);
159		}
160		// couper par securite
161		$slogan = couper($slogan, 80);
162
163		$nom = plugin_nom($info, $dir_plugins, $plug_file);
164
165		$url = parametre_url($url_page, "plugin", substr($dir, strlen(_DIR_RACINE)));
166
167		$icon_class = 'icon';
168		$img = '';
169		if (isset($info['logo']) and $i = trim($info['logo'])) {
170		if ($img = chemin_image("$dir/$i")) {
171		$img = http_img_pack($img, '', " width='32' height='32'", '', ['variante_svg_si_possible' => true, 'chemin_image' => false]);
172		}
173		}
174		if (!$img) {
175		$img = http_img_pack("plugin-xx.svg", '', " width='32' height='32'");
176		$icon_class .= ' no-logo';
177		}
178		else {
179		# $img = "<img src='$img' width='32' height='32' alt='' />";
180		}
181		$i = "<div class='$icon_class'><a href='$url' rel='info'>$img</a></div>";
182
183		return "<div class='resume'>"
184		. "<h3><a href='$url' rel='info'>"
185		. $nom
186		. "</a></h3>"
187		. " <span class='version'>" . $info['version'] . "</span>"
188		. " <span class='etat'> - "
189		. plugin_etat_en_clair($info['etat'])
190		. "</span>"
191		. "<div class='short'>" . $slogan . "</div>"
192		. $i
193		. "</div>";
194		}
195
196		function plugin_desintalle($plug_file, $nom, $dir_plugins = null) {
197		if (!$dir_plugins) {
198		$dir_plugins = _DIR_PLUGINS;
199		}
200
201		$action = redirige_action_auteur('desinstaller_plugin', "$dir_plugins::$plug_file", 'admin_plugin');
202		$text = _T('bouton_desinstaller');
203		$text2 = _T('info_desinstaller_plugin');
204		$file = basename($plug_file);
		0 ignored issues – show Unused Code introduced 2016-04-05 12:13 UTC by Report Bug Copy Issue Report `$file` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
205
206		return "<div class='actions'>[" .
207		"<a href='$action'
208		onclick='return confirm(\"$text $nom ?\\n$text2\")'>"
209		. $text
210		. "</a>]</div>";
211		}
212
213		/**
214		* Traduit un type d'état de plugin
215		*
216		* Si l'état n'existe pas, prendra par défaut 'developpement'
217		*
218		* @param string $etat
219		* Le type d'état (stable, test, ...)
220		* @return string
221		* Traduction de l'état dans la langue en cours
222		**/
223		function plugin_etat_en_clair($etat) {
224		if (!in_array($etat, array('stable', 'test', 'experimental'))) {
225		$etat = 'developpement';
226		}
227
228		return _T('plugin_etat_' . $etat);
229		}
230
231		// https://code.spip.net/@plugin_propre
232		function plugin_propre($texte, $module = '',$propre='propre') {
233		// retirer le retour a la racine du module, car le find_in_path se fait depuis la racine
234	View Code Duplication	if (_DIR_RACINE and strncmp($module, _DIR_RACINE, strlen(_DIR_RACINE)) == 0) {
		0 ignored issues – show Duplication introduced 2016-04-05 13:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
235		$module = substr($module, strlen(_DIR_RACINE));
236		}
237		if (preg_match("\|^\w+_[\w_]+$\|", $texte)) {
238		$texte = _T(($module ? "$module:" : '') . $texte, array(), array('force' => false));
239		}
240
241		return $propre($texte);
242		}
243
244		function plugin_typo($texte, $module = '') {
245		return plugin_propre($texte, $module, 'typo');
246		}
247
248
249		// https://code.spip.net/@affiche_bloc_plugin
250		function affiche_bloc_plugin($plug_file, $info, $dir_plugins = null) {
251		if (!$dir_plugins) {
252		$dir_plugins = _DIR_PLUGINS;
253		}
254
255		$prefix = $info['prefix'];
256		$dir = "$dir_plugins$plug_file/lang/paquet-$prefix";
257
258		$s = "";
259		// TODO: le traiter_multi ici n'est pas beau
260		// cf. description du plugin/_stable_/ortho/plugin.xml
261		// concerne les anciens plugin.xml donc on devrait plus en avoir besoin
262		$description = "";
263		if (isset($info['description'])) {
264		$description = plugin_propre($info['description'], $dir);
265		}
266
267		if (isset($info['documentation'])
268		and $lien = $info['documentation']
269		) {
270		$description .= "<p><em class='site'><a href='$lien' class='spip_out'>" . _T('en_savoir_plus') . '</a></em></p>';
271		}
272		$s .= "<dd class='desc'>" . $description . "</dd>\n";
273
274	View Code Duplication	if (isset($info['auteur'])) {
		0 ignored issues – show Duplication introduced 2016-04-05 12:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
275		if (is_array($info['auteur'])) {
276		$a = formater_credits($info['auteur'], ', ');
277		} // pour compat mais ne doit plus arriver
278		else {
279		$a = trim($info['auteur']);
280		}
281		if ($a) {
282		$s .= "<dt class='auteurs'>" . _T('public:par_auteur') . "</dt><dd class='auteurs'>" . PtoBR(propre($a,
283		$dir)) . "</dd>\n";
284		}
285		}
286
287		if (isset($info['credit'])) {
288		if ($a = formater_credits($info['credit'], ', ')) {
289		$s .= "<dt class='credits'>" . _T('plugin_info_credit') . "</dt><dd class='credits'>" . PtoBR(propre($a,
290		$dir)) . "</dd>\n";
291		}
292		}
293
294	View Code Duplication	if (isset($info['licence'])) {
		0 ignored issues – show Duplication introduced 2016-04-05 12:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
295		if (is_array($info['licence'])) {
296		$a = formater_credits($info['licence'], ', ');
297		} // pour compat mais ne doit plus arriver
298		else {
299		$a = trim($info['licence']);
300		}
301		if ($a) {
302		$s .= "<dt class='licence'>" . _T('intitule_licence') . "</dt><dd class='licence'>" . PtoBR(propre($a,
303		$dir)) . "</dd>\n";
304		}
305		}
306
307		$s = "<dl class='description'>$s</dl>";
308
309		//
310		// Ajouter les infos techniques
311		//
312		$infotech = array();
313
314		$version = "<dt>" . _T('version') . "</dt><dd>" . $info['version'];
315		// Version VCS
316		if ($vcs = version_vcs_courante($dir_plugins . $plug_file)) {
317		$version .= ' ' . $vcs;
318		}
319		$version .= "</dd>";
320		$infotech[] = $version;
321		$infotech[] = "<dt>" . _T('repertoire_plugins') . "</dt><dd>" . joli_repertoire("$dir_plugins$plug_file") . "</dd>";
322		// source zip le cas echeant
323		$infotech[] = (lire_fichier($dir_plugins . $plug_file . '/install.log', $log)
324		and preg_match(',^source:(.*)$,m', $log, $r))
325		? '<dt>' . _T('plugin_source') . '</dt><dd>' . trim($r[1]) . "</dd>"
		0 ignored issues – show Bug introduced 2016-04-05 12:13 UTC by Report Bug Copy Issue Report The variable `$r` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
326		: '';
327
328		$infotech[] = !$info['necessite'] ? '' :
329		('<dt>' . _T('plugin_info_necessite') . '</dt><dd>' . join(' ',
330		array_map('array_shift', $info['necessite'])) . '</dd>');
331
332		$s .= "<dl class='tech'>"
333		. join('', $infotech)
334		. "</dl>";
335
336
337		return $s;
338		}
339
340		function formater_credits($infos, $sep = ', ') {
341		$texte = '';
342
343		foreach ($infos as $_credit) {
344		if ($texte) {
345		$texte .= $sep;
346		}
347		// Si le credit en cours n'est pas un array c'est donc un copyright
348		$texte .=
349		(!is_array($_credit))
350		? PtoBR(propre($_credit))
351		: ($_credit['url'] ? '<a href="' . $_credit['url'] . '">' : '') .
352		$_credit['nom'] .
353		($_credit['url'] ? '</a>' : '');
354		}
355
356		return $texte;
357		}
358

spip / SPIP

Push — master ( 6f1482...4c57e4 )

afficher_plugin.php ➔ plugin_resume() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like