Code Duplication - spip/SPIP - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 7-9 lines in 8 locations

ecrire/exec/brouteur_frame.php 6 locations


	if ($special == "redac") {
		$result=sql_select("articles.id_article, articles.id_rubrique, articles.titre, articles.statut", "spip_articles AS articles LEFT JOIN spip_auteurs_articles AS lien ON articles.id_article=lien.id_article", "articles.statut = 'prepa' AND lien.id_auteur = $connect_id_auteur ", " id_article ", " articles.date DESC");
		$res = '';
		while($row=sql_fetch($result)){
			$id_article=$row['id_article'];
			if (autoriser('voir','article',$id_article)){
				$titre = typo($row['titre']);
				$statut = $row['statut'];
				$h = generer_url_ecrire('articles',"id_article=$id_article");
				$res .= "<a class='$statut'\nhref='javascript:window.parent.location=\"$h\"'>$titre</a>";
				}
			}
		if ($res) {
			echo "\n<div style='padding-top: 6px; padding-bottom: 3px;'><b class='verdana2'>"._T("info_cours_edition")."</b></div>";
			echo "\n<div class='plan-articles'>", $res, "</div>";

	} else if ($special == "valider") {
		$result=sql_select("id_article, id_rubrique, titre, statut", "spip_articles", "statut = 'prop'", "", "date DESC");
		$res = '';
		while($row=sql_fetch($result)){
			$id_article=$row['id_article'];
			if (autoriser('voir','article',$id_article)){
				$titre = typo($row['titre']);
				$statut = $row['statut'];
				$h = generer_url_ecrire('articles',"id_article=$id_article");
				$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
				}
		}

		if ($res) {
			echo "\n<div style='padding-top: 6px; padding-bottom: 3px;'><b class='verdana2'>"._T("info_articles_proposes")."</b></div>";

	
		$result=sql_select("*", "spip_breves", "statut = 'prop'", "", "date_heure DESC", "20");
		$res = '';
		while($row=sql_fetch($result)){
			$id_breve=$row['id_breve'];
			if (autoriser('voir','breve',$id_breve)){
				$titre = typo($row['titre']);
				$statut = $row['statut'];
				$h = generer_url_ecrire('breves_voir',"id_breve=$id_breve");
				$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
				}
		}
		if ($res) {
			echo "\n<div style='padding-top: 6px;'><b class='verdana2'>"._T("info_breves_valider")."</b></div>";
			echo "\n<div class='plan-articles'>", $res, "</div>";

			else 
				$result = sql_select("articles.id_article, articles.id_rubrique, articles.titre, articles.statut", "spip_articles AS articles, spip_auteurs_articles AS lien", "articles.id_rubrique=$id_rubrique AND (articles.statut = 'publie' OR articles.statut = 'prop' OR (articles.statut = 'prepa' AND articles.id_article = lien.id_article AND lien.id_auteur = $connect_id_auteur)) ", " id_article ", " articles.date DESC");
			$res = '';
			while($row=sql_fetch($result)){
					$id_article=$row['id_article'];
					if (autoriser('voir','article',$id_article)){
						$titre = typo($row['titre']);
						$statut = $row['statut'];
						$h = generer_url_ecrire('articles',"id_article=$id_article");
						$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
					}
			}
			if ($res) {
				echo "\n<div style='padding-top: 6px; padding-bottom: 3px;'><b class='verdana2'>"._T('info_articles')."</b></div>";
				echo "\n<div class='plan-articles'>", $res, "</div>";

	
			$result=sql_select("*", "spip_breves", "id_rubrique=$id_rubrique", "", "date_heure DESC", "20");
			$res = '';
			while($row=sql_fetch($result)){
				$id_breve=$row['id_breve'];
				if (autoriser('voir','breve',$id_breve)){
					$titre = typo($row['titre']);
					$statut = $row['statut'];
					$h = generer_url_ecrire('breves_voir',"id_breve=$id_breve");
					$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
				}
			}
			if ($res) {
				echo "\n<div style='padding-top: 6px;'><b class='verdana2'>"._T('info_breves_02')."</b></div>";
				echo "\n<div class='plan-articles'>", $res, "</div>";

	
			$result=sql_select("*", "spip_syndic", "id_rubrique=$id_rubrique AND statut!='refuse'", "", "nom_site");
			$res = '';
			while($row=sql_fetch($result)){
				$id_syndic=$row['id_syndic'];
				if (autoriser('voir','site',$id_syndic)){
					$titre = typo($row['nom_site']);
					$statut = $row['statut'];
					$h = generer_url_ecrire('sites',"id_syndic=$id_syndic");
					$res .= "\n<div class='brouteur_icone_site'><b><a href='javascript:window.parent.location=\"$h\"'>$titre</a></b></div>";
				}
			}
			if ($res)
				echo "\n<div style='padding-top: 6px;'><b class='verdana2'>"._T('icone_sites_references')."</b></div>", $res;
		}

ecrire/exec/menu_navigation.php 2 locations



	$vos_articles = sql_select("articles.id_article, articles.id_rubrique, articles.titre, articles.statut", "spip_articles AS articles, spip_auteurs_articles AS lien", "articles.id_article=lien.id_article AND lien.id_auteur=$connect_id_auteur AND articles.statut='prepa'", "articles.date", "articles.date DESC", "5");
	$vos = '';
	while($row = sql_fetch($vos_articles)) {
		$id_article = $row['id_article'];
		$titre = typo(sinon($row['titre'], _T('ecrire:info_sans_titre')));
		$statut = $row['statut'];
		$h = generer_url_ecrire("articles","id_article=$id_article");
		$vos .= "<a class='$statut spip_xx-small' href='$h'>$titre</a>\n";
	}
	if ($vos) {
		$t = _T('info_en_cours_validation');
		$gadget .= debut_cadre('bandeau-rubriques',"article-24.gif",'',afficher_plus(generer_url_ecrire("articles_page")).$t)

	
	$vos_articles = sql_select("id_article, id_rubrique, titre, statut", "spip_articles", "statut='prop'", "date", "date DESC", "5");
	$vos = '';
	while($row = sql_fetch($vos_articles)) {
		$id_article = $row['id_article'];
		$titre = sinon($row['titre'], _T('ecrire:info_sans_titre'));
		$statut = $row['statut'];
		$h = generer_url_ecrire("articles","id_article=$id_article");
		$vos .= "<a class='$statut' href='$h'>$titre</a>";
	}
	if ($vos) {
		$gadget .= debut_cadre('bandeau-rubriques',"article-24.gif",'',afficher_plus(generer_url_ecrire())._T('info_articles_proposes'))
		. "<div class='plan-articles'>"

		@@ 68-76 (lines=9) @@
65		if ($special == "redac") {
66		$result=sql_select("articles.id_article, articles.id_rubrique, articles.titre, articles.statut", "spip_articles AS articles LEFT JOIN spip_auteurs_articles AS lien ON articles.id_article=lien.id_article", "articles.statut = 'prepa' AND lien.id_auteur = $connect_id_auteur ", " id_article ", " articles.date DESC");
67		$res = '';
68		while($row=sql_fetch($result)){
69		$id_article=$row['id_article'];
70		if (autoriser('voir','article',$id_article)){
71		$titre = typo($row['titre']);
72		$statut = $row['statut'];
73		$h = generer_url_ecrire('articles',"id_article=$id_article");
74		$res .= "<a class='$statut'\nhref='javascript:window.parent.location=\"$h\"'>$titre</a>";
75		}
76		}
77		if ($res) {
78		echo "\n<div style='padding-top: 6px; padding-bottom: 3px;'><b class='verdana2'>"._T("info_cours_edition")."</b></div>";
79		echo "\n<div class='plan-articles'>", $res, "</div>";
		@@ 85-93 (lines=9) @@
82		} else if ($special == "valider") {
83		$result=sql_select("id_article, id_rubrique, titre, statut", "spip_articles", "statut = 'prop'", "", "date DESC");
84		$res = '';
85		while($row=sql_fetch($result)){
86		$id_article=$row['id_article'];
87		if (autoriser('voir','article',$id_article)){
88		$titre = typo($row['titre']);
89		$statut = $row['statut'];
90		$h = generer_url_ecrire('articles',"id_article=$id_article");
91		$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
92		}
93		}
94
95		if ($res) {
96		echo "\n<div style='padding-top: 6px; padding-bottom: 3px;'><b class='verdana2'>"._T("info_articles_proposes")."</b></div>";
		@@ 102-110 (lines=9) @@
99
100		$result=sql_select("*", "spip_breves", "statut = 'prop'", "", "date_heure DESC", "20");
101		$res = '';
102		while($row=sql_fetch($result)){
103		$id_breve=$row['id_breve'];
104		if (autoriser('voir','breve',$id_breve)){
105		$titre = typo($row['titre']);
106		$statut = $row['statut'];
107		$h = generer_url_ecrire('breves_voir',"id_breve=$id_breve");
108		$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
109		}
110		}
111		if ($res) {
112		echo "\n<div style='padding-top: 6px;'><b class='verdana2'>"._T("info_breves_valider")."</b></div>";
113		echo "\n<div class='plan-articles'>", $res, "</div>";
		@@ 175-183 (lines=9) @@
172		else
173		$result = sql_select("articles.id_article, articles.id_rubrique, articles.titre, articles.statut", "spip_articles AS articles, spip_auteurs_articles AS lien", "articles.id_rubrique=$id_rubrique AND (articles.statut = 'publie' OR articles.statut = 'prop' OR (articles.statut = 'prepa' AND articles.id_article = lien.id_article AND lien.id_auteur = $connect_id_auteur)) ", " id_article ", " articles.date DESC");
174		$res = '';
175		while($row=sql_fetch($result)){
176		$id_article=$row['id_article'];
177		if (autoriser('voir','article',$id_article)){
178		$titre = typo($row['titre']);
179		$statut = $row['statut'];
180		$h = generer_url_ecrire('articles',"id_article=$id_article");
181		$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
182		}
183		}
184		if ($res) {
185		echo "\n<div style='padding-top: 6px; padding-bottom: 3px;'><b class='verdana2'>"._T('info_articles')."</b></div>";
186		echo "\n<div class='plan-articles'>", $res, "</div>";
		@@ 191-199 (lines=9) @@
188
189		$result=sql_select("*", "spip_breves", "id_rubrique=$id_rubrique", "", "date_heure DESC", "20");
190		$res = '';
191		while($row=sql_fetch($result)){
192		$id_breve=$row['id_breve'];
193		if (autoriser('voir','breve',$id_breve)){
194		$titre = typo($row['titre']);
195		$statut = $row['statut'];
196		$h = generer_url_ecrire('breves_voir',"id_breve=$id_breve");
197		$res .= "<a class='$statut' href='javascript:window.parent.location=\"$h\"'>$titre</a>";
198		}
199		}
200		if ($res) {
201		echo "\n<div style='padding-top: 6px;'><b class='verdana2'>"._T('info_breves_02')."</b></div>";
202		echo "\n<div class='plan-articles'>", $res, "</div>";
		@@ 208-216 (lines=9) @@
205
206		$result=sql_select("*", "spip_syndic", "id_rubrique=$id_rubrique AND statut!='refuse'", "", "nom_site");
207		$res = '';
208		while($row=sql_fetch($result)){
209		$id_syndic=$row['id_syndic'];
210		if (autoriser('voir','site',$id_syndic)){
211		$titre = typo($row['nom_site']);
212		$statut = $row['statut'];
213		$h = generer_url_ecrire('sites',"id_syndic=$id_syndic");
214		$res .= "\n<div class='brouteur_icone_site'><b><a href='javascript:window.parent.location=\"$h\"'>$titre</a></b></div>";
215		}
216		}
217		if ($res)
218		echo "\n<div style='padding-top: 6px;'><b class='verdana2'>"._T('icone_sites_references')."</b></div>", $res;
219		}

		@@ 27-33 (lines=7) @@
24
25		$vos_articles = sql_select("articles.id_article, articles.id_rubrique, articles.titre, articles.statut", "spip_articles AS articles, spip_auteurs_articles AS lien", "articles.id_article=lien.id_article AND lien.id_auteur=$connect_id_auteur AND articles.statut='prepa'", "articles.date", "articles.date DESC", "5");
26		$vos = '';
27		while($row = sql_fetch($vos_articles)) {
28		$id_article = $row['id_article'];
29		$titre = typo(sinon($row['titre'], _T('ecrire:info_sans_titre')));
30		$statut = $row['statut'];
31		$h = generer_url_ecrire("articles","id_article=$id_article");
32		$vos .= "<a class='$statut spip_xx-small' href='$h'>$titre</a>\n";
33		}
34		if ($vos) {
35		$t = _T('info_en_cours_validation');
36		$gadget .= debut_cadre('bandeau-rubriques',"article-24.gif",'',afficher_plus(generer_url_ecrire("articles_page")).$t)
		@@ 45-51 (lines=7) @@
42
43		$vos_articles = sql_select("id_article, id_rubrique, titre, statut", "spip_articles", "statut='prop'", "date", "date DESC", "5");
44		$vos = '';
45		while($row = sql_fetch($vos_articles)) {
46		$id_article = $row['id_article'];
47		$titre = sinon($row['titre'], _T('ecrire:info_sans_titre'));
48		$statut = $row['statut'];
49		$h = generer_url_ecrire("articles","id_article=$id_article");
50		$vos .= "<a class='$statut' href='$h'>$titre</a>";
51		}
52		if ($vos) {
53		$gadget .= debut_cadre('bandeau-rubriques',"article-24.gif",'',afficher_plus(generer_url_ecrire())._T('info_articles_proposes'))
54		. "<div class='plan-articles'>"

spip / SPIP

Code Duplication Length = 7-9 lines in 8 locations

ecrire/exec/brouteur_frame.php 6 locations

ecrire/exec/menu_navigation.php 2 locations