Conditions | 1 |
Paths | 1 |
Total Lines | 90 |
Code Lines | 88 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
12 | public static function getCollection() : \Phpro\SoapClient\Soap\ClassMap\ClassMapCollection |
||
13 | { |
||
14 | return new ClassMapCollection([ |
||
15 | new ClassMap('stringArray', Type\StringArray::class), |
||
16 | new ClassMap('activeIssuesList', Type\ActiveIssuesList::class), |
||
17 | new ClassMap('eiKeyValue', Type\EiKeyValue::class), |
||
18 | new ClassMap('eiTuple', Type\EiTuple::class), |
||
19 | new ClassMap('activeIssuesListResponse', Type\ActiveIssuesListResponse::class), |
||
20 | new ClassMap('eiKeyValueList', Type\EiKeyValueList::class), |
||
21 | new ClassMap('customerAdd', Type\CustomerAdd::class), |
||
22 | new ClassMap('customerAddResponse', Type\CustomerAddResponse::class), |
||
23 | new ClassMap('organizationPropertyList', Type\OrganizationPropertyList::class), |
||
24 | new ClassMap('organizationPropertyListResponse', Type\OrganizationPropertyListResponse::class), |
||
25 | new ClassMap('organizationProperties', Type\OrganizationProperties::class), |
||
26 | new ClassMap('organizationProperty', Type\OrganizationProperty::class), |
||
27 | new ClassMap('accessGroupAdd', Type\AccessGroupAdd::class), |
||
28 | new ClassMap('accessGroupAddResponse', Type\AccessGroupAddResponse::class), |
||
29 | new ClassMap('lastExportReset', Type\LastExportReset::class), |
||
30 | new ClassMap('lastExportResetResponse', Type\LastExportResetResponse::class), |
||
31 | new ClassMap('userRoleList', Type\UserRoleList::class), |
||
32 | new ClassMap('userRoleListResponse', Type\UserRoleListResponse::class), |
||
33 | new ClassMap('eiKeyValuesList', Type\EiKeyValuesList::class), |
||
34 | new ClassMap('eiKeyValues', Type\EiKeyValues::class), |
||
35 | new ClassMap('arrayList', Type\ArrayList::class), |
||
36 | new ClassMap('abstractList', Type\AbstractList::class), |
||
37 | new ClassMap('abstractCollection', Type\AbstractCollection::class), |
||
38 | new ClassMap('deviceGetStatus', Type\DeviceGetStatus::class), |
||
39 | new ClassMap('deviceGetStatusResponse', Type\DeviceGetStatusResponse::class), |
||
40 | new ClassMap('psaCreateCustomTicket', Type\PsaCreateCustomTicket::class), |
||
41 | new ClassMap('psaCreateCustomTicketResponse', Type\PsaCreateCustomTicketResponse::class), |
||
42 | new ClassMap('eiCustomPsaTicketResponse', Type\EiCustomPsaTicketResponse::class), |
||
43 | new ClassMap('accessGroupList', Type\AccessGroupList::class), |
||
44 | new ClassMap('accessGroupListResponse', Type\AccessGroupListResponse::class), |
||
45 | new ClassMap('SOAdd', Type\SOAdd::class), |
||
46 | new ClassMap('SOAddResponse', Type\SOAddResponse::class), |
||
47 | new ClassMap('userRoleAdd', Type\UserRoleAdd::class), |
||
48 | new ClassMap('userRoleAddResponse', Type\UserRoleAddResponse::class), |
||
49 | new ClassMap('customerDelete', Type\CustomerDelete::class), |
||
50 | new ClassMap('customerDeleteResponse', Type\CustomerDeleteResponse::class), |
||
51 | new ClassMap('organizationPropertyModify', Type\OrganizationPropertyModify::class), |
||
52 | new ClassMap('organizationPropertyModifyResponse', Type\OrganizationPropertyModifyResponse::class), |
||
53 | new ClassMap('deviceList', Type\DeviceList::class), |
||
54 | new ClassMap('deviceListResponse', Type\DeviceListResponse::class), |
||
55 | new ClassMap('jobStatusList', Type\JobStatusList::class), |
||
56 | new ClassMap('jobStatusListResponse', Type\JobStatusListResponse::class), |
||
57 | new ClassMap('customerModify', Type\CustomerModify::class), |
||
58 | new ClassMap('customerModifyResponse', Type\CustomerModifyResponse::class), |
||
59 | new ClassMap('deviceAssetInfoExportDevice', Type\DeviceAssetInfoExportDevice::class), |
||
60 | new ClassMap('deviceAssetInfoExportDeviceResponse', Type\DeviceAssetInfoExportDeviceResponse::class), |
||
61 | new ClassMap('userRoleGet', Type\UserRoleGet::class), |
||
62 | new ClassMap('userRoleGetResponse', Type\UserRoleGetResponse::class), |
||
63 | new ClassMap('taskPauseMonitoring', Type\TaskPauseMonitoring::class), |
||
64 | new ClassMap('taskPauseMonitoringResponse', Type\TaskPauseMonitoringResponse::class), |
||
65 | new ClassMap('wrapperTaskMonitoring', Type\WrapperTaskMonitoring::class), |
||
66 | new ClassMap('tEITaskFailed', Type\TEITaskFailed::class), |
||
67 | new ClassMap('psaCredentialsValidate', Type\PsaCredentialsValidate::class), |
||
68 | new ClassMap('psaCredentialsValidateResponse', Type\PsaCredentialsValidateResponse::class), |
||
69 | new ClassMap('deviceGet', Type\DeviceGet::class), |
||
70 | new ClassMap('deviceGetResponse', Type\DeviceGetResponse::class), |
||
71 | new ClassMap('psaGetCustomTicket', Type\PsaGetCustomTicket::class), |
||
72 | new ClassMap('psaGetCustomTicketResponse', Type\PsaGetCustomTicketResponse::class), |
||
73 | new ClassMap('eiCustomPsaTicketDetails', Type\EiCustomPsaTicketDetails::class), |
||
74 | new ClassMap('versionInfoGet', Type\VersionInfoGet::class), |
||
75 | new ClassMap('eiCredentials', Type\EiCredentials::class), |
||
76 | new ClassMap('versionInfoGetResponse', Type\VersionInfoGetResponse::class), |
||
77 | new ClassMap('configValue', Type\ConfigValue::class), |
||
78 | new ClassMap('acknowledgeNotification', Type\AcknowledgeNotification::class), |
||
79 | new ClassMap('acknowledgeNotificationResponse', Type\AcknowledgeNotificationResponse::class), |
||
80 | new ClassMap('userAdd', Type\UserAdd::class), |
||
81 | new ClassMap('userAddResponse', Type\UserAddResponse::class), |
||
82 | new ClassMap('devicePropertyModify', Type\DevicePropertyModify::class), |
||
83 | new ClassMap('deviceProperties', Type\DeviceProperties::class), |
||
84 | new ClassMap('deviceProperty', Type\DeviceProperty::class), |
||
85 | new ClassMap('devicePropertyModifyResponse', Type\DevicePropertyModifyResponse::class), |
||
86 | new ClassMap('psaReopenCustomTicket', Type\PsaReopenCustomTicket::class), |
||
87 | new ClassMap('psaReopenCustomTicketResponse', Type\PsaReopenCustomTicketResponse::class), |
||
88 | new ClassMap('taskResumeMonitoring', Type\TaskResumeMonitoring::class), |
||
89 | new ClassMap('taskResumeMonitoringResponse', Type\TaskResumeMonitoringResponse::class), |
||
90 | new ClassMap('customerListChildren', Type\CustomerListChildren::class), |
||
91 | new ClassMap('customerListChildrenResponse', Type\CustomerListChildrenResponse::class), |
||
92 | new ClassMap('accessGroupGet', Type\AccessGroupGet::class), |
||
93 | new ClassMap('accessGroupGetResponse', Type\AccessGroupGetResponse::class), |
||
94 | new ClassMap('deviceAssetInfoExportDeviceWithSettings', Type\DeviceAssetInfoExportDeviceWithSettings::class), |
||
95 | new ClassMap('deviceAssetInfoExportDeviceWithSettingsResponse', Type\DeviceAssetInfoExportDeviceWithSettingsResponse::class), |
||
96 | new ClassMap('devicePropertyList', Type\DevicePropertyList::class), |
||
97 | new ClassMap('devicePropertyListResponse', Type\DevicePropertyListResponse::class), |
||
98 | new ClassMap('customerList', Type\CustomerList::class), |
||
99 | new ClassMap('customerListResponse', Type\CustomerListResponse::class), |
||
100 | new ClassMap('psaResolveCustomTicket', Type\PsaResolveCustomTicket::class), |
||
101 | new ClassMap('psaResolveCustomTicketResponse', Type\PsaResolveCustomTicketResponse::class), |
||
102 | ]); |
||
108 |