Spinen\Discourse\Controllers\SsoController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	nullProperty()	0	4	1
A	__construct()	0	6	1
A	buildExtraParameters()	0	8	1
A	login()	0	17	2
A	parseUserValue()	0	8	2

<?php

namespace Spinen\Discourse\Controllers;

use Cviebrock\DiscoursePHP\SSOHelper;
use Illuminate\Contracts\Auth\Authenticatable as User;
use Illuminate\Contracts\Config\Repository as Config;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Illuminate\Support\Collection;

/**
 * Class SsoController
 *
 * Controller to process the Discourse SSO request.  There is a good bit of logic in here that almost feels like too
 * much for a controller, but given that this is the only thing that this controller is doing, I am not going to break
 * it out into some service class.
 *
 * @package Spinen\Discourse
 */
class SsoController extends Controller
{
    /**
     * Package configuration
     *
     * @var Collection
     */
    protected $config;

    /**
     * SSOHelper Instance
     *
     * @var SSOHelper
     */
    protected $sso;

    /**
     * Authenticated user
     *
     * @var User
     */
    protected $user;

    /**
     * SsoController constructor.
     *
     * @param Config $config
     * @param SSOHelper $sso
     */
    public function __construct(Config $config, SSOHelper $sso)
    {
        $this->config = $config->get('services.discourse');

        $this->sso = $sso->setSecret($this->config['secret']);
    }

    /**
     * Build out the extra parameters to send to Discourse
     *
     * @return array
     */
    protected function buildExtraParameters()
    {
        return collect($this->config['user'])
            ->except(['external_id', 'email'])
            ->reject([$this, 'nullProperty'])
            ->map([$this, 'parseUserValue'])
            ->toArray();
    }

    /**
     * Process the SSO login request from Discourse
     *
     * @param Request $request
     *
     * @return mixed
     */
    public function login(Request $request)
    {
        if (! ($this->sso->validatePayload($payload = $request->get('sso'), $request->get('sig')))) {
            abort(403); //Forbidden
        }

        $this->user = $request->user();

        $query = $this->sso->getSignInString(
            $this->sso->getNonce($payload),
            $this->user->{$this->config['user']['external_id']},
            $this->user->{$this->config['user']['email']},
            $this->buildExtraParameters($this->user)

The call to SsoController::buildExtraParameters() has too many arguments starting with $this->user.

        );

        return redirect(str_finish($this->config['url'], '/').'session/sso_login?'.$query);
    }

    /**
     * Check to see if property is null
     *
     * @param string $property
     * @return bool
     */
    public function nullProperty($property)
    {
        return is_null($property);
    }

    /**
     * Get the property from the user
     *
     * If a string is passed in, then get it from the user object, otherwise, return what was given
     *
     * @param string $property
     * @return mixed
     */
    public function parseUserValue($property)
    {
        if (! is_string($property)) {
            return $property;
        }

        return $this->user->{$property};
    }
}