Spinen\Discourse\Listeners\LogoutDiscourseUser::handle()

Complexity

Conditions	3
Paths	3

Size

Total Lines	26
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handle(Logout $event)
    {
        if (!$event->user) {
            return;
        }

        $configs = [
            'base_uri' => config('services.discourse.url'),

The function config was not found. Maybe you did not declare it correctly or list all dependencies?

            'headers'  => [
                'Api-Key'      => config('services.discourse.api.key'),
                'Api-Username' => config('services.discourse.api.user'),
            ],
        ];

        // Get Discourse user to match this one, and send a Logout request to Discourse and get the response
        $user = json_decode(
            $this->client->get("users/by-external/{$event->user->id}.json", $configs)

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                         ->getBody()
        )->user;

        $response = $this->client->post("admin/users/{$user->id}/log_out");

        if ($response->getStatusCode() !== 200) {
            Log::notice(
                "When logging out user {$event->user->id} Discourse returned status code {$response->getStatusCode()}:",
                ['reason' => $response->getReasonPhrase()]
            );