Spinen\ConnectWise\Laravel\ServiceProvider

Complexity

Total Complexity

8

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Importance

Changes	6
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	7	1
A	boot()	0	2	1
A	registerToken()	0	7	1
A	determineMemberId()	0	11	3
A	provides()	0	5	1
A	registerClient()	0	14	1

<?php

namespace Spinen\ConnectWise\Laravel;

use GuzzleHttp\Client as Guzzle;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Support\ServiceProvider as LaravelServiceProvider;
use Spinen\ConnectWise\Api\Client;
use Spinen\ConnectWise\Api\Token;
use Spinen\ConnectWise\Exceptions\NoLoggedInUser;
use Spinen\ConnectWise\Support\ModelResolver;

/**
 * Class ConnectWiseProvider
 *
 * @package Spinen\ConnectWise\Laravel
 */
class ServiceProvider extends LaravelServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = true;

    /**
     * Bootstrap the application services.
     *
     * @return void
     */
    public function boot()
    {
        //
    }

    /**
     * Determine the member Id to use for API call
     *
     * Allow a default member id to use for the API calls if there is no logged in user.
     *
     * @return mixed
     * @throws NoLoggedInUser
     */
    protected function determineMemberId()
    {
        if ($this->app->auth->check()) {

Accessing auth on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $this->app->auth->user()->connect_wise_member_id;
        }

        if (!empty($this->app->config->get('services.connectwise.default_member_id'))) {

Accessing config on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $this->app->config->get('services.connectwise.default_member_id');
        }

        throw new NoLoggedInUser("There is not a currently logged in user.");
    }

    /**
     * Register the application services.
     *
     * @return void
     */
    public function register()
    {
        $this->registerToken();

        $this->registerClient();

        $this->app->alias(Client::class, 'connectwise');
    }

    /**
     * Register the client object
     *
     * A Client needs to have some properties set, so in Laravel, we are going to pull them from the configs.
     */
    protected function registerClient()
    {
        $this->app->singleton(
            Client::class,
            function (Application $app) {
                return (new Client(
                    $app->make(Token::class),
                    $app->make(Guzzle::class),
                    $app->make(ModelResolver::class)
                ))->setClientId($app->config->get('services.connectwise.client_id'))

Accessing config on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

                  ->setIntegrator($app->config->get('services.connectwise.integrator'))
                  ->setPassword($app->config->get('services.connectwise.password'))
                  ->setUrl($app->config->get('services.connectwise.url'))
                  ->setVersion($app->config->get('services.connectwise.version', '2019.4'));
            }
        );
    }

    /**
     * Get the services provided by the provider.
     *
     * @return array
     */
    public function provides()
    {
        return [
            Client::class,
            Token::class,
        ];
    }

    /**
     * Register the token object
     *
     * For our setup, everyone's ConnectWise username (member id) is the front part of their email less the dot
     * between the first & last name.
     */
    protected function registerToken()
    {
        $this->app->singleton(
            Token::class,
            function (Application $app) {
                return (new Token())->setCompanyId($app->config->get('services.connectwise.company_id'))

Accessing config on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

                                    ->setMemberId($this->determineMemberId());
            }
        );
    }
}