spindle / spindle-httpclient

src/Multi.php

<?php
/**
 * spindle/httpclient
 * @license CC0-1.0 (Public Domain) https://creativecommons.org/publicdomain/zero/1.0/
 * @see https://github.com/spindle/spindle-httpclient
 */
namespace Spindle\HttpClient;

class Multi implements \IteratorAggregate, \Countable
{
    protected
        $mh
      , $timeout = 10
      , $pool = array()
    ;

    function __construct() {

It is generally recommended to explicitly declare the visibility for methods.

        $this->mh = curl_multi_init();
        foreach (func_get_args() as $req) {
            $this->attach($req);
        }
    }

    function __destruct()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->detachAll();
        curl_multi_close($this->mh);
    }

    function setTimeout($num)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->timeout = $num;
        return $this;
    }

    function attach(Request $req)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $handle = $req->getHandle();
        $this->pool[(int)$handle] = $req;

        curl_multi_add_handle($this->mh, $handle);
    }

    function detach(Request $req)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $handle = $req->getHandle();
        unset($this->pool[(int)$handle]);

        curl_multi_remove_handle($this->mh, $handle);
    }

    function start()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $mh = $this->mh;

        do $stat = curl_multi_exec($mh, $running);
        while ($stat === \CURLM_CALL_MULTI_PERFORM);
        return curl_multi_select($mh, 0);
    }

    /**
     * イベントが発生するのを待って、何かレスポンスが得られればその配列を返す。
     * これを実行すると、不要になったrequestオブジェクトはdetachします
     *
     * @return Request[]
     */
    function getFinishedResponses()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $mh = $this->mh;
        $requests = array();

        switch (curl_multi_select($mh, $this->timeout)) {
            case 0:
                throw new \RuntimeException('timeout?');

            case -1:
            default:
                do $stat = curl_multi_exec($mh, $running);
                while ($stat === \CURLM_CALL_MULTI_PERFORM);

                do if ($raised = curl_multi_info_read($mh, $remains)) {
                    $info = curl_getinfo($raised['handle']);
                    $body = curl_multi_getcontent($raised['handle']);

                    $response = new Response($body, $info);
                    $request = $this->pool[(int)$raised['handle']];

                    $request->setResponse($response);
                    $this->detach($request);

                    if (CURLE_OK !== $raised['result']) {

This code seems to be duplicated across your project.

                        $error = new CurlException(curl_error($raised['handle']), $raised['result']);
                        $request->setError($error);
                    }

                    $requests[] = $request;

                } while ($remains);

The expression $remains of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

        }

        return $requests;
    }

    function waitResponse()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $mh = $this->mh;

        do switch (curl_multi_select($mh, $this->timeout)) {
            case 0:
                throw new \RuntimeException('timeout.');

            case -1:
            default:
                do $stat = curl_multi_exec($mh, $running);
                while ($stat === \CURLM_CALL_MULTI_PERFORM);

                do if ($raised = curl_multi_info_read($mh, $remains)) {
                    $info = curl_getinfo($raised['handle']);
                    $body = curl_multi_getcontent($raised['handle']);

                    $response = new Response($body, $info);
                    $request = $this->pool[(int)$raised['handle']];

                    $request->setResponse($response);
                    if (CURLE_OK !== $raised['result']) {

This code seems to be duplicated across your project.

                        $error = new CurlException(curl_error($raised['handle']), $raised['result']);
                        $request->setError($error);
                    }

                } while ($remains);

The expression $remains of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

        } while ($running);
    }

    function send()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->start();
        $this->waitResponse();
    }

    function detachAll()

It is generally recommended to explicitly declare the visibility for methods.

    {
        foreach ($this->pool as $request) {
            curl_multi_remove_handle($this->mh, $request->getHandle());
        }

        $this->pool = array();
    }

    /**
     * @override IteratorAggregate::getIterator
     */
    function getIterator()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return new \ArrayIterator($this->pool);
    }

    /**
     * @override Countable::count
     */
    function count()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return count($this->pool);
    }
}