SortTrait::rsort() - Code Metrics - Inspection of "refactoring with trait (BC break change)" - spindle/spindle-collection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 63f743...cd2958 )

by Hiraku

created 2017-06-25 03:49 UTC

SortTrait::rsort() A

↳ Parent: SortTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
crap	1

<?php
namespace Spindle\Collection\Traits;

trait SortTrait
{
    /**
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function usort(callable $cmp)
    {
        $array = $this->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        usort($array, $cmp);
        return new $this($array, $this->debug);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param int $sort_flags \SORT_REGULAR|\SORT_NUMERIC|\SORT_STRING
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function rsort($sort_flags = \SORT_REGULAR)
    {
        $array = $this->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        rsort($array, $sort_flags);
        return new $this($array, $this->debug);
    }

    /**
     * @param int $sort_flags \SORT_REGULAR|\SORT_NUMERIC|\SORT_STRING
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function sort($sort_flags = \SORT_REGULAR)
    {
        $array = $this->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        sort($array, $sort_flags);
        return new $this($array, $this->debug);
    }

    /**
     * stable sort
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function usortStable(callable $cmp)
    {
        $array = $this->map('[$_, $_i]')->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        usort($array, static function ($a, $b) use ($cmp) {
            return $cmp($a[0], $b[0]) ?: ($a[1] - $b[1]);
        });
        $sorted = new $this($array, $this->debug);
        $sorted->column(0)->toArray();
        return $sorted;
    }

    /**
     * sort with Schwartzian Transform
     * @param string|callable $fn map function
     * @param SORT_ASC|SORT_DESC $sort_order
     * @param SORT_REGULAR|SORT_NUMERIC|SORT_STRING $sort_flags
     * @return \Spindle\Collection (new instance)
     */
    public function mapSort($fn, $sort_order = \SORT_ASC, $sort_flags = \SORT_REGULAR)
    {
        $array = $this->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $mapped = (new static($array))->map($fn)->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        array_multisort($mapped, $sort_order, $sort_flags, $array);
        return new $this($array, $this->debug);
    }
}


1		<?php
2		namespace Spindle\Collection\Traits;
3
4		trait SortTrait
5		{
6		/**
7		* @return \Spindle\Collection\Collection (new instance)
8		*/
9	1	public function usort(callable $cmp)
10		{
11	1	$array = $this->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
12	1	usort($array, $cmp);
13	1	return new $this($array, $this->debug);
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report The property `debug` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14		}
15
16		/**
17		* @param int $sort_flags \SORT_REGULAR\|\SORT_NUMERIC\|\SORT_STRING
18		* @return \Spindle\Collection\Collection (new instance)
19		*/
20	1	public function rsort($sort_flags = \SORT_REGULAR)
21		{
22	1	$array = $this->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23	1	rsort($array, $sort_flags);
24	1	return new $this($array, $this->debug);
25		}
26
27		/**
28		* @param int $sort_flags \SORT_REGULAR\|\SORT_NUMERIC\|\SORT_STRING
29		* @return \Spindle\Collection\Collection (new instance)
30		*/
31	1	public function sort($sort_flags = \SORT_REGULAR)
32		{
33	1	$array = $this->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34	1	sort($array, $sort_flags);
35	1	return new $this($array, $this->debug);
36		}
37
38		/**
39		* stable sort
40		* @return \Spindle\Collection\Collection (new instance)
41		*/
42		public function usortStable(callable $cmp)
43		{
44		$array = $this->map('[$_, $_i]')->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `map()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45		usort($array, static function ($a, $b) use ($cmp) {
46		return $cmp($a[0], $b[0]) ?: ($a[1] - $b[1]);
47		});
48		$sorted = new $this($array, $this->debug);
49		$sorted->column(0)->toArray();
50		return $sorted;
51		}
52
53		/**
54		* sort with Schwartzian Transform
55		* @param string\|callable $fn map function
56		* @param SORT_ASC\|SORT_DESC $sort_order
57		* @param SORT_REGULAR\|SORT_NUMERIC\|SORT_STRING $sort_flags
58		* @return \Spindle\Collection (new instance)
59		*/
60		public function mapSort($fn, $sort_order = \SORT_ASC, $sort_flags = \SORT_REGULAR)
61		{
62		$array = $this->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
63		$mapped = (new static($array))->map($fn)->toArray();
		0 ignored issues – show Unused Code introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report The call to `SortTrait::__construct()` has too many arguments starting with `$array`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `map()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64		array_multisort($mapped, $sort_order, $sort_flags, $array);
65		return new $this($array, $this->debug);
66		}
67		}
68

spindle / spindle-collection

Push — master ( 63f743...cd2958 )

SortTrait::rsort() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like