SetsTrait::groupBy() - Code Metrics - Inspection of "refactoring with trait (BC break change)" - spindle/spindle-collection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 63f743...cd2958 )

by Hiraku

created 2017-06-25 03:49 UTC

SetsTrait::groupBy() A

↳ Parent: SetsTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	0
cts	8
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	6

<?php
namespace Spindle\Collection\Traits;

trait SetsTrait
{
    /**
     * @param int $size
     * @return \Spindle\Collection\Collection
     */
    public function chunk($size)
    {
        return new $this(array_chunk($this->toArray(), $size), $this->debug);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return \Spindle\Collection\Collection
     */
    public function unique()
    {
        return new $this(array_unique($this->toArray()), $this->debug);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return \Spindle\Collection\Collection
     */
    public function groupBy($fn)
    {
        $array = $this->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $mapped = (new $this($array))->map($fn)->toArray();
        $grouped = [];
        foreach ($mapped as $key => $val) {
            $grouped[$val][$key] = $array[$key];
        }

        return new $this($grouped, $this->debug);
    }

    /**
     * SQL's LEFT JOIN
     * - in order to avoid N+1 problem
     */
    public function leftJoin($map, callable $fetch, callable $combine)
    {
        $array = $this->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($map) {
            $mapped = (new $this($array))->groupBy($map)->toArray();
        } else {
            $mapped = [];
            foreach ($array as $key => $val) {
                $mapped[$key] = [$key];
            }
        }
        $keys = array_keys($mapped);
        $fetched = $fetch($keys);
        if (!is_array($fetched)) {
            throw new \UnexpectedValueException(
                'leftJoin($map, $fetch, $combine) $fetch must be function-type [key1, key2, ...] => [key1 => val1, ...]'
            );
        }

        foreach ($fetched as $key => $val) {
            if (!isset($mapped[$key])) {
                throw new \UnexpectedValueException(
                    'leftJoin($map, $fetch, $combine) $fetch returned an array having unexpected key: ' . $key
                );
            }
            foreach ($mapped[$key] as $originKey) {
                $array[$originKey] = $combine($array[$originKey], $val);
            }
        }

        return new $this($array, $this->debug);
    }
}


1		<?php
2		namespace Spindle\Collection\Traits;
3
4		trait SetsTrait
5		{
6		/**
7		* @param int $size
8		* @return \Spindle\Collection\Collection
9		*/
10	1	public function chunk($size)
11		{
12	1	return new $this(array_chunk($this->toArray(), $size), $this->debug);
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report The property `debug` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13		}
14
15		/**
16		* @return \Spindle\Collection\Collection
17		*/
18	1	public function unique()
19		{
20	1	return new $this(array_unique($this->toArray()), $this->debug);
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		}
22
23		/**
24		* @return \Spindle\Collection\Collection
25		*/
26		public function groupBy($fn)
27		{
28		$array = $this->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29		$mapped = (new $this($array))->map($fn)->toArray();
30		$grouped = [];
31		foreach ($mapped as $key => $val) {
32		$grouped[$val][$key] = $array[$key];
33		}
34
35		return new $this($grouped, $this->debug);
36		}
37
38		/**
39		* SQL's LEFT JOIN
40		* - in order to avoid N+1 problem
41		*/
42		public function leftJoin($map, callable $fetch, callable $combine)
43		{
44		$array = $this->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45
46		if ($map) {
47		$mapped = (new $this($array))->groupBy($map)->toArray();
48		} else {
49		$mapped = [];
50		foreach ($array as $key => $val) {
51		$mapped[$key] = [$key];
52		}
53		}
54		$keys = array_keys($mapped);
55		$fetched = $fetch($keys);
56		if (!is_array($fetched)) {
57		throw new \UnexpectedValueException(
58		'leftJoin($map, $fetch, $combine) $fetch must be function-type [key1, key2, ...] => [key1 => val1, ...]'
59		);
60		}
61
62		foreach ($fetched as $key => $val) {
63		if (!isset($mapped[$key])) {
64		throw new \UnexpectedValueException(
65		'leftJoin($map, $fetch, $combine) $fetch returned an array having unexpected key: ' . $key
66		);
67		}
68		foreach ($mapped[$key] as $originKey) {
69		$array[$originKey] = $combine($array[$originKey], $val);
70		}
71		}
72
73		return new $this($array, $this->debug);
74		}
75		}
76

spindle / spindle-collection

Push — master ( 63f743...cd2958 )

SetsTrait::groupBy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like